Skip to contentSkip to conversation

dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

PATCH In review Delphine CC Chiu 2 participants 6 messages Jul 27, 2023 – Aug 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index e0eff4c05879..2ef6821e3648 100644
@@ -79,6 +79,7 @@ properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,yosemitev4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC

Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC.

---
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed/aspeed-bmc-facebook-yosemitev4.dts | 640 ++++++++++++++++++
 2 files changed, 641 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemitev4.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index c68984322a86..023fb428611f 100644
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-wedge400.dtb \
 	aspeed-bmc-facebook-yamp.dtb \
 	aspeed-bmc-facebook-yosemitev2.dtb \
+	aspeed-bmc-facebook-yosemitev4.dtb \
 	aspeed-bmc-ibm-bonnell.dtb \
 	aspeed-bmc-ibm-everest.dtb \
 	aspeed-bmc-ibm-rainier.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemitev4.dts new file +640 -0

640 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw
Quoted 18 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, July 27, 2023 2:49 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>; patrick at stwcx.xyz; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Security Reminder: Please be aware that this email is sent by an external
sender.

On 27/07/2023 05:39, Delphine CC Chiu wrote:

Quoted 8 lines
Quoted 6 lines

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

I got the same patch four times...

It was my oversight to send the same patch multiple times.
Would you please to tell that should I resend a new version, or these patches has been already under reviewed. Thank you.

Quoted 3 lines

Best regards,
Krzysztof

#4 lore raw
Quoted 25 lines · Delphine_CC_Chiu/WYHQ/Wiwynn
Quoted 25 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, July 27, 2023 2:49 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>; patrick at stwcx.xyz; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Security Reminder: Please be aware that this email is sent by an external
sender.

Quoted 6 lines · Delphine CC Chiu

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 4 lines
Quoted 1 line

I got the same patch four times...

It was my oversight to send the same patch multiple times.
Would you please to tell that should I resend a new version, or these patches has been already under reviewed. Thank you.

I don't see versioning, no changelog. Thus if you send the same patches all the time, then answer is - please version your patches, implement the feedback and explain in changelog what changed.

Otherwise it will not get reviewed, so I assume this was not reviewed and it is waiting for proper submission.

Best regards,
Krzysztof

#5 lore raw
Quoted 46 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 3, 2023 7:14 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>; patrick at stwcx.xyz; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Security Reminder: Please be aware that this email is sent by an external
sender.

Quoted 6 lines · Delphine_CC_Chiu/WYHQ/Wiwynn
Quoted 6 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, July 27, 2023 2:49 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn

<[email protected]>;

Quoted 21 lines
Quoted 21 lines

patrick at stwcx.xyz; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Security Reminder: Please be aware that this email is sent by an
external sender.

Quoted 6 lines · Delphine CC Chiu

Document the new compatibles used on Facebook Yosemite V4.

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

I got the same patch four times...

Quoted 8 lines
Quoted 2 lines

It was my oversight to send the same patch multiple times. Would you please to tell that should I resend a new version, or these

patches has been already under reviewed.

Quoted 1 line

Thank you.

I don't see versioning, no changelog. Thus if you send the same patches all the time, then answer is - please version your patches, implement the feedback and explain in changelog what changed.

It seems that versioning didn't added successfully in duplicated patches.

I will update v5 patches for versioning, changelogs and all feedback's implementation, without duplicating sending. Please help to tell if there's any feedback I lost, thank you.

Quoted 6 lines

Otherwise it will not get reviewed, so I assume this was not reviewed and it is waiting for proper submission.

Best regards,
Krzysztof