Skip to contentSkip to conversation

Update remove method for DSS driver

PATCH In review Nikhil M Jain 3 participants 7 messages Jul 27, 2023 – Aug 1, 2023 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

cover Update remove method for DSS driver

This patch series aims at updating the remove method for DSS video driver.

Nikhil M Jain (2):
drivers: video: tidss: tidss_drv: Change remove method
drivers: video: tidss: tidss_drv: Use kconfig VIDEO_REMOVE to remove
video

 drivers/video/tidss/tidss_drv.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 drivers: video: tidss: tidss_drv: Change remove method

Change remove method of DSS video driver to disable video port instead of performing a soft reset, as soft reset takes longer duration. Video port is disabled by setting enable bit of video port to 0.

---
 drivers/video/tidss/tidss_drv.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/video/tidss/tidss_drv.c +1 -11
index 078e3e82e3..623bf4cf31 100644
@@ -901,19 +901,9 @@ static int tidss_drv_probe(struct udevice *dev)
 
 static int tidss_drv_remove(struct udevice *dev)
 {
-	u32 val;
-	int ret;
 	struct tidss_drv_priv *priv = dev_get_priv(dev);
 
-	priv->base_common = dev_remap_addr_index(dev, 0);
-	REG_FLD_MOD(priv, DSS_SYSCONFIG, 1, 1, 1);
-	/* Wait for reset to complete */
-	ret = readl_poll_timeout(priv->base_common + DSS_SYSSTATUS,
-				 val, val & 1, 5000);
-	if (ret) {
-		dev_warn(priv->dev, "failed to reset priv\n");
-		return ret;
-	}
+	VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
 	return 0;
 }
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] drivers: video: tidss: tidss_drv: Change remove method

Quoted 5 lines · Nikhil

Change remove method of DSS video driver to disable video port instead of performing a soft reset, as soft reset takes longer duration. Video port is disabled by setting enable bit of video port to 0.

Quoted 29 lines
---
 drivers/video/tidss/tidss_drv.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/video/tidss/tidss_drv.c +1 -11
index 078e3e82e3..623bf4cf31 100644
@@ -901,19 +901,9 @@ static int tidss_drv_probe(struct udevice *dev)
 
 static int tidss_drv_remove(struct udevice *dev)
 {
-	u32 val;
-	int ret;
 	struct tidss_drv_priv *priv = dev_get_priv(dev);
 
-	priv->base_common = dev_remap_addr_index(dev, 0);
-	REG_FLD_MOD(priv, DSS_SYSCONFIG, 1, 1, 1);
-	/* Wait for reset to complete */
-	ret = readl_poll_timeout(priv->base_common + DSS_SYSSTATUS,
-				 val, val & 1, 5000);
-	if (ret) {
-		dev_warn(priv->dev, "failed to reset priv\n");
-		return ret;
-	}
+	VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
 	return 0;
 }
 
#3 lore raw

Re: [PATCH 1/2] drivers: video: tidss: tidss_drv: Change remove method

In reply to Nikhil M Jain
Quoted 8 lines · On Thu, 27 Jul 2023 12:01:25 +0530 Nikhil M Jain [email protected] wrote:

Change remove method of DSS video driver to disable video port instead of performing a soft reset, as soft reset takes longer duration. Video port is disabled by setting enable bit of video port to 0.

---
 drivers/video/tidss/tidss_drv.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

applied to u-boot-video/master, thanks!

--
Anatolij

#4 lore raw

PATCH 2/2 drivers: video: tidss: tidss_drv: Use kconfig VIDEO_REMOVE to remove video

In reply to Nikhil M Jain

Perform removal of DSS if kconfigs VIDEO_REMOVE or SPL_VIDEO_REMOVE is set by user. Otherwise if above Kconfigs are not selected, it is assumed that user wants splash screen to be displayed until linux kernel boots up. In such scenario, leave the power domain of DSS as "on" so that splash screen stays intact until kernel boots up.

---
 drivers/video/tidss/tidss_drv.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/video/tidss/tidss_drv.c +8 -2
index 623bf4cf31..e285f255d7 100644
@@ -901,9 +901,11 @@ static int tidss_drv_probe(struct udevice *dev)
 
 static int tidss_drv_remove(struct udevice *dev)
 {
-	struct tidss_drv_priv *priv = dev_get_priv(dev);
+	if (CONFIG_IS_ENABLED(VIDEO_REMOVE)) {
+		struct tidss_drv_priv *priv = dev_get_priv(dev);
 
-	VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
+		VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
+	}
 	return 0;
 }
 
@@ -929,5 +931,9 @@ U_BOOT_DRIVER(tidss_drv) = {
 	.probe = tidss_drv_probe,
 	.remove = tidss_drv_remove,
 	.priv_auto = sizeof(struct tidss_drv_priv),
+#if CONFIG_IS_ENABLED(VIDEO_REMOVE)
 	.flags = DM_FLAG_OS_PREPARE,
+#else
+	.flags = DM_FLAG_OS_PREPARE | DM_FLAG_LEAVE_PD_ON,
+#endif
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] drivers: video: tidss: tidss_drv: Use kconfig VIDEO_REMOVE to remove video

Quoted 7 lines · Nikhil

Perform removal of DSS if kconfigs VIDEO_REMOVE or SPL_VIDEO_REMOVE is set by user. Otherwise if above Kconfigs are not selected, it is assumed that user wants splash screen to be displayed until linux kernel boots up. In such scenario, leave the power domain of DSS as "on" so that splash screen stays intact until kernel boots up.

Quoted 32 lines
---
 drivers/video/tidss/tidss_drv.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/video/tidss/tidss_drv.c +8 -2
index 623bf4cf31..e285f255d7 100644
@@ -901,9 +901,11 @@ static int tidss_drv_probe(struct udevice *dev)
 
 static int tidss_drv_remove(struct udevice *dev)
 {
-	struct tidss_drv_priv *priv = dev_get_priv(dev);
+	if (CONFIG_IS_ENABLED(VIDEO_REMOVE)) {
+		struct tidss_drv_priv *priv = dev_get_priv(dev);
 
-	VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
+		VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
+	}
 	return 0;
 }
 
@@ -929,5 +931,9 @@ U_BOOT_DRIVER(tidss_drv) = {
 	.probe = tidss_drv_probe,
 	.remove = tidss_drv_remove,
 	.priv_auto = sizeof(struct tidss_drv_priv),
+#if CONFIG_IS_ENABLED(VIDEO_REMOVE)
 	.flags = DM_FLAG_OS_PREPARE,
+#else
+	.flags = DM_FLAG_OS_PREPARE | DM_FLAG_LEAVE_PD_ON,
+#endif
 };
#6 lore raw

Re: [PATCH 2/2] drivers: video: tidss: tidss_drv: Use kconfig VIDEO_REMOVE to remove video

In reply to Nikhil M Jain
Quoted 10 lines · On Thu, 27 Jul 2023 12:01:26 +0530 Nikhil M Jain [email protected] wrote:

Perform removal of DSS if kconfigs VIDEO_REMOVE or SPL_VIDEO_REMOVE is set by user. Otherwise if above Kconfigs are not selected, it is assumed that user wants splash screen to be displayed until linux kernel boots up. In such scenario, leave the power domain of DSS as "on" so that splash screen stays intact until kernel boots up.

---
 drivers/video/tidss/tidss_drv.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

applied to u-boot-video/master, thanks!

--
Anatolij