dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
Subsystems (6)
PATCH 1/3 dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
From: Thierry Reding <[email protected]>
The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct bindings file.
--- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ .../devicetree/bindings/display/panel/panel-simple.yaml | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml +2 -0
@@ -40,6 +40,8 @@ properties: items: - enum: - auo,b101ew05 + # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel + - hannstar,hsd101pww2 - tbs,a711-panel - const: panel-lvds
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +0 -2
@@ -168,8 +168,6 @@ properties: - hannstar,hsd070pww1 # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel - hannstar,hsd100pxn1 - # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel - - hannstar,hsd101pww2 # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel - hit,tx23d38vm0caa # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
Signature · 1 line
2.41.0
PATCH 2/3 drm/panel: Relax porches for HannStar HSD101PWW2
From: Thierry Reding <[email protected]>
The porch maximum values for the HannStar HSD101PWW2 are unusually small. Make them a bit larger to allow a more flexibility when overriding the timings in device tree. Unfortunately the datasheet doesn't list porch limits in detail, so this is a bit of guesswork.
--- drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +6 -6
@@ -2104,13 +2104,13 @@ static const struct panel_desc hannstar_hsd100pxn1 = {static const struct display_timing hannstar_hsd101pww2_timing = { .pixelclock = {64300000 ,71100000 ,82000000 }, .hactive = {1280 ,1280 ,1280 }, - .hfront_porch = {1 ,1 ,10 }, - .hback_porch = {1 ,1 ,10 }, - .hsync_len = {58 ,158 ,661 }, + .hfront_porch = {1 ,1 ,64 }, + .hback_porch = {1 ,1 ,64 }, + .hsync_len = {58 ,158 ,553 }, .vactive = {800 ,800 ,800 }, - .vfront_porch = {1 ,1 ,10 }, - .vback_porch = {1 ,1 ,10 }, - .vsync_len = {1 ,21 ,203 }, + .vfront_porch = {1 ,1 ,32 }, + .vback_porch = {1 ,1 ,32 }, + .vsync_len = {1 ,21 ,159 }, .flags =DISPLAY_FLAGS_DE_HIGH , };
Signature · 1 line
2.41.0
PATCH 3/3 ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The LVDS bindings require a specific compatible string in addition to the generic "panel-lvds". Add the HannStar HSD101PWW2 which is used on a similar device (ASUS TF201) and seems to work fine with slightly modified timings in DT.
--- arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts +1 -1
@@ -2628,7 +2628,7 @@ cpu3: cpu@3 { }; display-panel { - compatible = "panel-lvds"; + compatible = "hannstar,hsd101pww2", "panel-lvds"; width-mm = <217>; height-mm = <136>;
Signature · 1 line
2.41.0
Quoted 7 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct bindings file.
Signed-off-by Thierry Reding <[email protected]>---
Best regards,
Krzysztof
Hi Thierry,
Thank you for the patch.
Quoted 29 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct bindings file.
Signed-off-by Thierry Reding <[email protected]>--- Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++ .../devicetree/bindings/display/panel/panel-simple.yaml | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/panel/panel-lvds.yaml +2
-0@@ -40,6 +40,8 @@ properties: items: - enum: - auo,b101ew05 + # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel + - hannstar,hsd101pww2 - tbs,a711-panel - const: panel-lvdsDocumentation/devicetree/bindings/display/panel/panel-simple.yaml +0
-0
Documentation/devicetree/bindings/display/panel/panel-simple.yaml properties: · line 170
Quoted 3 lines
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +0
-0@@ -168,8 +168,6 @@ properties: - hannstar,hsd070pww1 # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel - hannstar,hsd100pxn1
I'm wondering if it would make sense to move them all in one go ? Regardless, this patch is OK, so
Quoted 5 lines
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +0
-2- # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel - - hannstar,hsd101pww2 # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel - hit,tx23d38vm0caa # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
Signature · 3 lines
Regards, Laurent Pinchart
Thierry Reding
AppliedRe: (subset) [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
Quoted 6 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct bindings file.
Applied, thanks!
[3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall
commit: b28d3af99ac4885f136f6330fec6499b15ad5b25
Best regards,
Signature · 1 line
Thierry Reding <[email protected]>