GenieZone hypervisor drivers
Subsystems (5)
v5 cover GenieZone hypervisor drivers
This series is based on linux-next, tag: next-20230726.
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports various virtual machine types and provides security features such as TEE-like scenarios and secure boot. It can create guest VMs for security use cases and has virtualization capabilities for both platform and interrupt. Although the hypervisor can be booted independently, it requires the assistance of GenieZone hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux kernel for vCPU scheduling, memory management, inter-VM communication and virtio backend support.
Changes in v5:
- Add dt solution back for device initialization
- Add GZVM_EXIT_GZ reason for gzvm_vcpu_run()
- Add patch for guest page fault handler
- Add patch for supporitng pin/unpin memory
- Remove unused enum members, namely GZVM_FUNC_GET_REGS and GZVM_FUNC_SET_REGS
- Use dev_debug() for debugging when platform device is available, and use pr_debug() otherwise
- Response to reviewers and fix bugs accordingly
Changes in v4:
https://lore.kernel.org/lkml/[email protected]/
- Add macro to set VM as protected without triggering pvmfw in AVF.
- Add support to pass dtb config to hypervisor.
- Add support for virtual timer.
- Add UAPI to pass memory region metadata to hypervisor.
- Define our own macros for ARM's interrupt number
- Elaborate more on GenieZone hyperivsor in documentation
- Fix coding style.
- Implement our own module for coverting ipa to pa
- Modify the way of initializing device from dt to a more discoverable way
- Move refactoring changes into indepedent patches.
Changes in v3:
https://lore.kernel.org/all/[email protected]/
- Refactor: separate arch/arm64/geniezone/gzvm_arch.c into vm.c/vcpu.c/vgic.c
- Remove redundant functions
- Fix reviewer's comments
Changes in v2:
https://lore.kernel.org/all/[email protected]/
- Refactor: move to drivers/virt/geniezone
- Refactor: decouple arch-dependent and arch-independent
- Check pending signal before entering guest context
- Fix reviewer's comments
Initial Commit in v1:
https://lore.kernel.org/all/[email protected]/
Yi-De Wu (12):
docs: geniezone: Introduce GenieZone hypervisor
dt-bindings: hypervisor: Add MediaTek GenieZone hypervisor
virt: geniezone: Add GenieZone hypervisor support
virt: geniezone: Add vcpu support
virt: geniezone: Add irqchip support for virtual interrupt injection
virt: geniezone: Add irqfd support
virt: geniezone: Add ioeventfd support
virt: geniezone: Add memory region support
virt: geniezone: Add dtb config support
virt: geniezone: Add virtual timer support
virt: geniezone: Add guest page fault handler
virt: geniezone: Add memory pin/unpin support
.../hypervisor/mediatek,geniezone-hyp.yaml | 31 + Documentation/virt/geniezone/introduction.rst | 86 +++ Documentation/virt/index.rst | 1 + MAINTAINERS | 13 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/driver.c | 26 + arch/arm64/geniezone/gzvm_arch_common.h | 130 ++++ arch/arm64/geniezone/vcpu.c | 155 +++++ arch/arm64/geniezone/vgic.c | 124 ++++ arch/arm64/geniezone/vm.c | 251 ++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 58 ++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 12 + drivers/virt/geniezone/gzvm_common.h | 12 + drivers/virt/geniezone/gzvm_exception.c | 34 ++ drivers/virt/geniezone/gzvm_hvc.c | 34 ++ drivers/virt/geniezone/gzvm_ioeventfd.c | 273 +++++++++ drivers/virt/geniezone/gzvm_irqfd.c | 566 ++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 154 +++++ drivers/virt/geniezone/gzvm_mmu.c | 210 +++++++ drivers/virt/geniezone/gzvm_vcpu.c | 280 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 488 +++++++++++++++ include/linux/gzvm_drv.h | 185 ++++++ include/uapi/asm-generic/Kbuild | 1 + include/uapi/asm-generic/gzvm_arch.h | 13 + include/uapi/linux/gzvm.h | 362 +++++++++++ 28 files changed, 3527 insertions(+) create mode 100644 Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml create mode 100644 Documentation/virt/geniezone/introduction.rst create mode 100644 arch/arm64/geniezone/Makefile create mode 100644 arch/arm64/geniezone/driver.c create mode 100644 arch/arm64/geniezone/gzvm_arch_common.h create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 arch/arm64/geniezone/vgic.c create mode 100644 arch/arm64/geniezone/vm.c create mode 100644 arch/arm64/include/uapi/asm/gzvm_arch.h create mode 100644 drivers/virt/geniezone/Kconfig create mode 100644 drivers/virt/geniezone/Makefile create mode 100644 drivers/virt/geniezone/gzvm_common.h create mode 100644 drivers/virt/geniezone/gzvm_exception.c create mode 100644 drivers/virt/geniezone/gzvm_hvc.c create mode 100644 drivers/virt/geniezone/gzvm_ioeventfd.c create mode 100644 drivers/virt/geniezone/gzvm_irqfd.c create mode 100644 drivers/virt/geniezone/gzvm_main.c create mode 100644 drivers/virt/geniezone/gzvm_mmu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vm.c create mode 100644 include/linux/gzvm_drv.h create mode 100644 include/uapi/asm-generic/gzvm_arch.h create mode 100644 include/uapi/linux/gzvm.h
Signature · 1 line
2.18.0
PATCH v5 1/12 docs: geniezone: Introduce GenieZone hypervisor
From: "Yi-De Wu" <[email protected]>
GenieZone is MediaTek proprietary hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. It is a pure EL2 implementation which implies it does not rely any specific host VM, and this behavior improves GenieZone's security as it limits its interface.
--- Documentation/virt/geniezone/introduction.rst | 86 +++++++++++++++++++ Documentation/virt/index.rst | 1 + MAINTAINERS | 6 ++ 3 files changed, 93 insertions(+) create mode 100644 Documentation/virt/geniezone/introduction.rst
Documentation/virt/geniezone/introduction.rst new file +86 -0
@@ -0,0 +1,86 @@ +.. SPDX-License-Identifier: GPL-2.0 + +====================== +GenieZone Introduction +====================== + +Overview +======== +GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports various virtual +machine types and provides security features such as TEE-like scenarios and +secure boot. It can create guest VMs for security use cases and has +virtualization capabilities for both platform and interrupt. Although the +hypervisor can be booted independently, it requires the assistance of GenieZone +hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux kernel for +vCPU scheduling, memory management, inter-VM communication and virtio backend +support. + +Supported Architecture +====================== +GenieZone now only supports MediaTek ARM64 SoC. + +Features +======== + +- vCPU Management + +VM manager aims to provide vCPUs on the basis of time sharing on physical CPUs. +It requires Linux kernel in host VM for vCPU scheduling and VM power management. + +- Memory Management + +Direct use of physical memory from VMs is forbidden and designed to be dictated +to the privilege models managed by GenieZone hypervisor for security reason. +With the help of gzvm-ko, the hypervisor would be able to manipulate memory as +objects. + +- Virtual Platform + +We manage to emulate a virtual mobile platform for guest OS running on guest +VM. The platform supports various architecture-defined devices, such as +virtual arch timer, GIC, MMIO, PSCI, and exception watching...etc. + +- Inter-VM Communication + +Communication among guest VMs was provided mainly on RPC. More communication +mechanisms were to be provided in the future based on VirtIO-vsock. + +- Device Virtualization + +The solution is provided using the well-known VirtIO. The gzvm-ko would +redirect MMIO traps back to VMM where the virtual devices are mostly emulated. +Ioeventfd is implemented using eventfd for signaling host VM that some IO +events in guest VMs need to be processed. + +- Interrupt virtualization + +All Interrupts during some guest VMs running would be handled by GenieZone +hypervisor with the help of gzvm-ko, both virtual and physical ones. In case +there's no guest VM running out there, physical interrupts would be handled by +host VM directly for performance reason. Irqfd is also implemented using +eventfd for accepting vIRQ requests in gzvm-ko. + +Platform architecture component +=============================== + +- vm + +The vm component is responsible for setting up the capability and memory +management for the protected VMs. The capability is mainly about the lifecycle +control and boot context initialization. And the memory management is highly +integrated with ARM 2-stage translation tables to convert VA to IPA to PA under +proper security measures required by protected VMs. + +- vcpu + +The vcpu component is the core of virtualizing aarch64 physical CPU runnable, +and it controls the vCPU lifecycle including creating, running and destroying. +With self-defined exit handler, the vm component would be able to act +accordingly before terminated. + +- vgic + +The vgic component exposes control interfaces to Linux kernel via irqchip, and +we intend to support all SPI, PPI, and SGI. When it comes to virtual +interrupts, the GenieZone hypervisor would write to list registers and trigger +vIRQ injection in guest VMs via GIC.
Documentation/virt/index.rst +1 -0
@@ -16,6 +16,7 @@ Virtualization Support coco/sev-guest coco/tdx-guest hyperv/index + geniezone/introduction .. only:: html and subproject
MAINTAINERS +6 -0
@@ -8741,6 +8741,12 @@ F: include/vdso/ F: kernel/time/vsyscall.c F: lib/vdso/ +GENIEZONE HYPERVISOR DRIVER +M: Yingshiuan Pan <[email protected]> +M: Ze-Yu Wang <[email protected]> +M: Yi-De Wu <[email protected]> +F: Documentation/virt/geniezone/ + GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]> S: Supported
Signature · 1 line
2.18.0
PATCH v5 2/12 dt-bindings: hypervisor: Add MediaTek GenieZone hypervisor
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Add documentation for GenieZone(gzvm) node. This node informs gzvm driver to start probing if geniezone hypervisor is available and able to do virtual machine operations.
--- .../hypervisor/mediatek,geniezone-hyp.yaml | 31 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml
Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml new file +31 -0
@@ -0,0 +1,31 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hypervisor/mediatek,geniezone-hyp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek GenieZone hypervisor + +maintainers: + - Yingshiuan Pan <[email protected]> + +description: + This interface is designed for integrating GenieZone hypervisor into Android + Virtualization Framework(AVF) along with Crosvm as a VMM. + It acts like a wrapper for every hypercall to GenieZone hypervisor in + order to control guest VM lifecycles and virtual interrupt injections. + +properties: + compatible: + const: mediatek,geniezone-hyp + +required: + - compatible + +additionalProperties: false + +examples: + - | + hypervisor { + compatible = "mediatek,geniezone-hyp"; + };
MAINTAINERS +1 -0
@@ -8745,6 +8745,7 @@ GENIEZONE HYPERVISOR DRIVER M: Yingshiuan Pan <[email protected]> M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> +F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ GENWQE (IBM Generic Workqueue Card)
Signature · 1 line
2.18.0
PATCH v5 3/12 virt: geniezone: Add GenieZone hypervisor support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
GenieZone is MediaTek hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. This patch exports a set of ioctl interfaces for userspace VMM (e.g., crosvm) to operate guest VMs lifecycle (creation and destroy) on GenieZone.
--- MAINTAINERS | 6 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/gzvm_arch_common.h | 68 ++++ arch/arm64/geniezone/vm.c | 212 +++++++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 20 ++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 10 + drivers/virt/geniezone/gzvm_main.c | 143 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 400 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 90 ++++++ include/uapi/asm-generic/Kbuild | 1 + include/uapi/asm-generic/gzvm_arch.h | 10 + include/uapi/linux/gzvm.h | 76 +++++ 15 files changed, 1064 insertions(+) create mode 100644 arch/arm64/geniezone/Makefile create mode 100644 arch/arm64/geniezone/gzvm_arch_common.h create mode 100644 arch/arm64/geniezone/vm.c create mode 100644 arch/arm64/include/uapi/asm/gzvm_arch.h create mode 100644 drivers/virt/geniezone/Kconfig create mode 100644 drivers/virt/geniezone/Makefile create mode 100644 drivers/virt/geniezone/gzvm_main.c create mode 100644 drivers/virt/geniezone/gzvm_vm.c create mode 100644 include/linux/gzvm_drv.h create mode 100644 include/uapi/asm-generic/gzvm_arch.h create mode 100644 include/uapi/linux/gzvm.h
MAINTAINERS +6 -0
@@ -8747,6 +8747,12 @@ M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ +F: arch/arm64/geniezone/ +F: arch/arm64/include/uapi/asm/gzvm_arch.h +F: drivers/virt/geniezone/ +F: include/linux/gzvm_drv.h +F include/uapi/asm-generic/gzvm_arch.h +F: include/uapi/linux/gzvm.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>
arch/arm64/Kbuild +1 -0
@@ -4,6 +4,7 @@ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(subst m,y,$(CONFIG_HYPERV)) += hyperv/ obj-$(CONFIG_CRYPTO) += crypto/ +obj-$(CONFIG_MTK_GZVM) += geniezone/ # for cleaning subdir- += boot
arch/arm64/geniezone/Makefile new file +9 -0
@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Main Makefile for gzvm, this one includes drivers/virt/geniezone/Makefile +# +include $(srctree)/drivers/virt/geniezone/Makefile + +gzvm-y += vm.o + +obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h new file +68 -0
68 lines not on this page · raw message
arch/arm64/geniezone/vm.c new file +212 -0
212 lines not on this page · raw message
arch/arm64/include/uapi/asm/gzvm_arch.h new file +20 -0
@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_H__ +#define __GZVM_ARCH_H__ + +#include <linux/types.h> + +#define GZVM_CAP_ARM_VM_IPA_SIZE 165 +#define GZVM_CAP_ARM_PROTECTED_VM 0xffbadab1 + +/* sub-commands put in args[0] for GZVM_CAP_ARM_PROTECTED_VM */ +#define GZVM_CAP_ARM_PVM_SET_PVMFW_IPA 0 +#define GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE 1 +/* GZVM_CAP_ARM_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */ +#define GZVM_CAP_ARM_PVM_SET_PROTECTED_VM 2 + +#endif /* __GZVM_ARCH_H__ */
drivers/virt/Kconfig +2 -0
@@ -54,4 +54,6 @@ source "drivers/virt/coco/sev-guest/Kconfig" source "drivers/virt/coco/tdx-guest/Kconfig" +source "drivers/virt/geniezone/Kconfig" + endif
drivers/virt/geniezone/Kconfig new file +16 -0
@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config MTK_GZVM + tristate "GenieZone Hypervisor driver for guest VM operation" + depends on ARM64 + help + This driver, gzvm, enables to run guest VMs on MTK GenieZone + hypervisor. It exports kvm-like interfaces for VMM (e.g., crosvm) in + order to operate guest VMs on GenieZone hypervisor. + + GenieZone hypervisor now only supports MediaTek SoC and arm64 + architecture. + + Select M if you want it be built as a module (gzvm.ko). + + If unsure, say N.
drivers/virt/geniezone/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Makefile for GenieZone driver, this file should be include in arch's +# to avoid two ko being generated. +# + +GZVM_DIR ?= ../../../drivers/virt/geniezone + +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o +
drivers/virt/geniezone/gzvm_main.c new file +143 -0
143 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vm.c new file +400 -0
400 lines not on this page · raw message
include/linux/gzvm_drv.h new file +90 -0
90 lines not on this page · raw message
include/uapi/asm-generic/Kbuild +1 -0
@@ -34,3 +34,4 @@ mandatory-y += termbits.h mandatory-y += termios.h mandatory-y += types.h mandatory-y += unistd.h +mandatory-y += gzvm_arch.h
include/uapi/asm-generic/gzvm_arch.h new file +10 -0
@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __ASM_GENERIC_GZVM_ARCH_H +#define __ASM_GENERIC_GZVM_ARCH_H +/* geniezone only supports aarch64 platform for now */ + +#endif /* __ASM_GENERIC_GZVM_ARCH_H */
include/uapi/linux/gzvm.h new file +76 -0
76 lines not on this page · raw message
Signature · 1 line
2.18.0
Re: [PATCH v5 03/12] virt: geniezone: Add GenieZone hypervisor support
Hi Yi-De,
Quoted 28 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
GenieZone is MediaTek hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. This patch exports a set of ioctl interfaces for userspace VMM (e.g., crosvm) to operate guest VMs lifecycle (creation and destroy) on GenieZone.
Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>--- MAINTAINERS | 6 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/gzvm_arch_common.h | 68 ++++ arch/arm64/geniezone/vm.c | 212 +++++++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 20 ++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 10 + drivers/virt/geniezone/gzvm_main.c | 143 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 400 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 90 ++++++ include/uapi/asm-generic/Kbuild | 1 + include/uapi/asm-generic/gzvm_arch.h | 10 + include/uapi/linux/gzvm.h | 76 +++++ 15 files changed, 1064 insertions(+)
Quoted 12 lines
create mode 100644
arch/arm64/geniezone/Makefilecreate mode 100644arch/arm64/geniezone/gzvm_arch_common.hcreate mode 100644arch/arm64/geniezone/vm.ccreate mode 100644arch/arm64/include/uapi/asm/gzvm_arch.hcreate mode 100644drivers/virt/geniezone/Kconfigcreate mode 100644drivers/virt/geniezone/Makefilecreate mode 100644drivers/virt/geniezone/gzvm_main.ccreate mode 100644drivers/virt/geniezone/gzvm_vm.ccreate mode 100644include/linux/gzvm_drv.hcreate mode 100644include/uapi/asm-generic/gzvm_arch.hcreate mode 100644include/uapi/linux/gzvm.h
I have a feeling this patch is a bit big, and could help review if it's split into chunks of smaller size.
Quoted 137 lines
MAINTAINERS +6
-0@@ -8747,6 +8747,12 @@ M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ +F: arch/arm64/geniezone/ +F: arch/arm64/include/uapi/asm/gzvm_arch.h +F: drivers/virt/geniezone/ +F: include/linux/gzvm_drv.h +F include/uapi/asm-generic/gzvm_arch.h +F: include/uapi/linux/gzvm.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>arch/arm64/Kbuild +1
-0@@ -4,6 +4,7 @@ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(subst m,y,$(CONFIG_HYPERV)) += hyperv/ obj-$(CONFIG_CRYPTO) += crypto/ +obj-$(CONFIG_MTK_GZVM) += geniezone/ # for cleaning subdir- += bootarch/arm64/geniezone/Makefile new file +9
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Main Makefile for gzvm, this one includes drivers/virt/geniezone/Makefile +# +include $(srctree)/drivers/virt/geniezone/Makefile + +gzvm-y += vm.o + +obj-$(CONFIG_MTK_GZVM) += gzvm.oarch/arm64/geniezone/gzvm_arch_common.h new file +68
-0@@ -0,0 +1,68 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_COMMON_H__ +#define __GZVM_ARCH_COMMON_H__ + +#include <linux/arm-smccc.h> + +enum { +GZVM_FUNC_CREATE_VM =0 , +GZVM_FUNC_DESTROY_VM =1 , +GZVM_FUNC_CREATE_VCPU =2 , +GZVM_FUNC_DESTROY_VCPU =3 , +GZVM_FUNC_SET_MEMREGION =4 , +GZVM_FUNC_RUN =5 , +GZVM_FUNC_GET_ONE_REG =8 , +GZVM_FUNC_SET_ONE_REG =9 , +GZVM_FUNC_IRQ_LINE =10 , +GZVM_FUNC_CREATE_DEVICE =11 , +GZVM_FUNC_PROBE =12 , +GZVM_FUNC_ENABLE_CAP =13 , +NR_GZVM_FUNC , +}; + +#define SMC_ENTITY_MTK 59 +#define GZVM_FUNCID_START (0x1000) +#define GZVM_HCALL_ID (func) \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_32, \ + SMC_ENTITY_MTK, (GZVM_FUNCID_START + (func))) + +#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC_CREATE_VM) +#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM) +#define MT_HVC_GZVM_CREATE_VCPU GZVM_HCALL_ID(GZVM_FUNC_CREATE_VCPU) +#define MT_HVC_GZVM_DESTROY_VCPU GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VCPU) +#define MT_HVC_GZVM_SET_MEMREGION GZVM_HCALL_ID(GZVM_FUNC_SET_MEMREGION) +#define MT_HVC_GZVM_RUN GZVM_HCALL_ID(GZVM_FUNC_RUN) +#define MT_HVC_GZVM_GET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_GET_ONE_REG) +#define MT_HVC_GZVM_SET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_SET_ONE_REG) +#define MT_HVC_GZVM_IRQ_LINE GZVM_HCALL_ID(GZVM_FUNC_IRQ_LINE) +#define MT_HVC_GZVM_CREATE_DEVICE GZVM_HCALL_ID(GZVM_FUNC_CREATE_DEVICE) +#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE) +#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP) + +/** +* gzvm_hypcall_wrapper() - the wrapper for hvc calls +* @a0-a7: arguments passed in registers 0 to 7 +* @res: result values from registers 0 to 3 +* +* Return: The wrapper helps caller to convert geniezone errno to Linux errno. +*/ +static inline int gzvm_hypcall_wrapper (unsigned long a0,unsigned long a1, +unsigned long a2,unsigned long a3, +unsigned long a4,unsigned long a5, +unsigned long a6,unsigned long a7, +struct arm_smccc_res *res) +{ +arm_smccc_hvc (a0, a1, a2, a3, a4, a5, a6, a7, res); +return gzvm_err_to_errno (res->a0); +} + +static inline u16 get_vmid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple >>16 ); +} + +#endif /* __GZVM_ARCH_COMMON_H__ */ arch/arm64/geniezone/vm.c new file +13
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <asm/sysreg.h> +#include <linux/arm-smccc.h> +#include <linux/err.h> +#include <linux/uaccess.h> + +#include <linux/gzvm.h> +#include <linux/gzvm_drv.h> +#include "gzvm_arch_common.h"
arch/arm64/geniezone/vm.c line 23
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ +#define PAR_PA47_MASK ((((1UL << 48) - 1) >> 12) << 12) + +int gzvm_arch_probe (void ) +{ +struct arm_smccc_res res; + +arm_smccc_hvc (MT_HVC_GZVM_PROBE ,0 ,0 ,0 ,0 ,0 ,0 ,0 , &res); +if (res.a0 ==0 ) +return 0 ;
I would see the error path as a particular case here, e.g.
if (res.a0)
return -ENXIO;
and on the usual path return success.
(as you already do below in some functions)...
Quoted 9 lines
arch/arm64/geniezone/vm.c new file +9
-0+ +return -ENXIO ; +} + +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region) +{ +struct arm_smccc_res res; +
arch/arm64/geniezone/vm.c line 42
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+return gzvm_hypcall_wrapper (MT_HVC_GZVM_SET_MEMREGION , vm_id, + buf_size, region,0 ,0 ,0 ,0 , &res); +} + +static int gzvm_cap_arm_vm_ipa_size (void __user *argp) +{ +__u64 value =CONFIG_ARM64_PA_BITS ; + +if (copy_to_user (argp, &value,sizeof (__u64))) +return -EFAULT ;
... e.g. here.
Quoted 13 lines
arch/arm64/geniezone/vm.c new file +13
-0+ +return 0 ; +} + +int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp) +{ +int ret = -EOPNOTSUPP ; + +switch (cap) { +case GZVM_CAP_ARM_PROTECTED_VM : { +__u64 success =1 ; + +if (copy_to_user (argp, &success,sizeof (__u64)))
arch/arm64/geniezone/vm.c line 65
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+return -EFAULT ; + ret =0 ; +break ; + } +case GZVM_CAP_ARM_VM_IPA_SIZE : { + ret =gzvm_cap_arm_vm_ipa_size (argp); +break ; + } +default : + ret = -EOPNOTSUPP ;
you already initialized ret to -EOPNOTSUPP, why don't you initialize it with 0, and just set it as error code here, and avoid setting it to 0 on the success case above.
Quoted 78 lines
arch/arm64/geniezone/vm.c new file +78
-0+ } + +return ret; +} + +/** +* gzvm_arch_create_vm() - create vm +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: +* * positive value - VM ID +* * -ENOMEM - Memory not enough for storing VM data +*/ +int gzvm_arch_create_vm (unsigned long vm_type) +{ +struct arm_smccc_res res; +int ret; + + ret =gzvm_hypcall_wrapper (MT_HVC_GZVM_CREATE_VM , vm_type,0 ,0 ,0 ,0 , +0 ,0 , &res); + +if (ret ==0 ) +return res.a1; +else +return ret; +} + +int gzvm_arch_destroy_vm (u16 vm_id) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_DESTROY_VM , vm_id,0 ,0 ,0 ,0 , +0 ,0 , &res); +} + +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +struct arm_smccc_res *res) +{ +return gzvm_hypcall_wrapper (MT_HVC_GZVM_ENABLE_CAP , gzvm->vm_id, + cap->cap, cap->args[0 ], cap->args[1 ], + cap->args[2 ], cap->args[3 ], cap->args[4 ], + res); +} + +/** +* gzvm_vm_ioctl_get_pvmfw_size() - Get pvmfw size from hypervisor, return +* in x1, and return to userspace in args +* @gzvm: Pointer to struct gzvm. +* @cap: Pointer to struct gzvm_enable_cap. +* @argp: Pointer to struct gzvm_enable_cap in user space. +* +* Return: +* * 0 - Succeed +* * -EINVAL - Hypervisor return invalid results +* * -EFAULT - Fail to copy back to userspace buffer +*/ +static int gzvm_vm_ioctl_get_pvmfw_size (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +struct arm_smccc_res res = {0 }; + +if (gzvm_vm_arch_enable_cap (gzvm, cap, &res) !=0 ) +return -EINVAL ; + + cap->args[1 ] = res.a1; +if (copy_to_user (argp, cap,sizeof (*cap))) +return -EFAULT ; + +return 0 ; +} + +/** +* gzvm_vm_ioctl_cap_pvm() - Proceed GZVM_CAP_ARM_PROTECTED_VM's subcommands +* @gzvm: Pointer to struct gzvm. +* @cap: Pointer to struct gzvm_enable_cap. +* @argp: Pointer to struct gzvm_enable_cap in user space.
arch/arm64/geniezone/vm.c line 153
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+* +* Return: +* * 0 - Succeed +* * -EINVAL - Invalid subcommand or arguments +*/ +static int gzvm_vm_ioctl_cap_pvm (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ;
This initialization appears redundant as you always rewrite ret to a new value below
Quoted 14 lines
arch/arm64/geniezone/vm.c new file +14
-0+struct arm_smccc_res res = {0 }; + +switch (cap->args[0 ]) { +case GZVM_CAP_ARM_PVM_SET_PVMFW_IPA : + fallthrough; +case GZVM_CAP_ARM_PVM_SET_PROTECTED_VM : + ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res); +break ; +case GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE : + ret =gzvm_vm_ioctl_get_pvmfw_size (gzvm, cap, argp); +break ; +default : + ret = -EINVAL ; +break ;
arch/arm64/geniezone/vm.c line 177
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ } + +return ret; +} + +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ;
same here
Quoted 8 lines
arch/arm64/geniezone/vm.c new file +8
-0+ +switch (cap->cap) { +case GZVM_CAP_ARM_PROTECTED_VM : + ret =gzvm_vm_ioctl_cap_pvm (gzvm, cap, argp); +break ; +default : + ret = -EINVAL ; +break ;
arch/arm64/geniezone/vm.c line 195
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ } + +return ret; +} + +/** +* gzvm_hva_to_pa_arch() - converts hva to pa with arch-specific way +* @hva: Host virtual address. +* +* Return: 0 if translation error
This is a bit misleading, if you look at the code, you return 0 if the bit SYS_PAR_EL1_F is present, but also return 0 if bit PAR_PA47_MASK is not present. Are those situations identical ?
Also, it's a bit strange to return 0 for an error case.
Quoted 60 lines
arch/arm64/geniezone/vm.c new file +17
-0+*/ +u64 gzvm_hva_to_pa_arch (u64 hva) +{ +u64 par; +unsigned long flags; + +local_irq_save (flags); + asmvolatile ("at s1e1r, %0" ::"r" (hva)); +isb (); + par =read_sysreg_par (); +local_irq_restore (flags); + +if (par &SYS_PAR_EL1_F ) +return 0 ; + +return par &PAR_PA47_MASK ; +}arch/arm64/include/uapi/asm/gzvm_arch.h new file +20
-0@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_H__ +#define __GZVM_ARCH_H__ + +#include <linux/types.h> + +#define GZVM_CAP_ARM_VM_IPA_SIZE 165 +#define GZVM_CAP_ARM_PROTECTED_VM 0xffbadab1 + +/* sub-commands put in args[0] for GZVM_CAP_ARM_PROTECTED_VM */ +#define GZVM_CAP_ARM_PVM_SET_PVMFW_IPA 0 +#define GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE 1 +/* GZVM_CAP_ARM_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */ +#define GZVM_CAP_ARM_PVM_SET_PROTECTED_VM 2 + +#endif /* __GZVM_ARCH_H__ */ drivers/virt/Kconfig +2
-0@@ -54,4 +54,6 @@ source "drivers/virt/coco/sev-guest/Kconfig" source "drivers/virt/coco/tdx-guest/Kconfig" +source "drivers/virt/geniezone/Kconfig" + endifdrivers/virt/geniezone/Kconfig new file +0
-0
drivers/virt/geniezone/Kconfig line 5
Quoted 5 lines
drivers/virt/geniezone/Kconfig new file +5
-0@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config MTK_GZVM + tristate "GenieZone Hypervisor driver for guest VM operation" + depends on ARM64
if only mediatek SoC is supported, should it depend on it here ?
Quoted 77 lines
drivers/virt/geniezone/Kconfig new file +11
-0+ help + This driver, gzvm, enables to run guest VMs on MTK GenieZone + hypervisor. It exports kvm-like interfaces for VMM (e.g., crosvm) in + order to operate guest VMs on GenieZone hypervisor. + + GenieZone hypervisor now only supports MediaTek SoC and arm64 + architecture. + + Select M if you want it be built as a module (gzvm.ko). + + If unsure, say N.drivers/virt/geniezone/Makefile new file +10
-0@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Makefile for GenieZone driver, this file should be include in arch's +# to avoid two ko being generated. +# + +GZVM_DIR ?= ../../../drivers/virt/geniezone + +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o +drivers/virt/geniezone/gzvm_main.c new file +44
-0@@ -0,0 +1,143 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/device.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/miscdevice.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> + +/** +* gzvm_err_to_errno() - Convert geniezone return value to standard errno +* +* @err: Return value from geniezone function return +* +* Return: Standard errno +*/ +int gzvm_err_to_errno (unsigned long err) +{ +int gz_err = (int )err; + +switch (gz_err) { +case 0 : +return 0 ; +case ERR_NO_MEMORY : +return -ENOMEM ; +case ERR_NOT_SUPPORTED : +return -EOPNOTSUPP ; +case ERR_NOT_IMPLEMENTED : +return -EOPNOTSUPP ; +case ERR_FAULT : +return -EFAULT ; +default : +break ; + } + +return -EINVAL ; +}
drivers/virt/geniezone/gzvm_main.c line 54
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+ +/** +* gzvm_dev_ioctl_check_extension() - Check if given capability is support +* or not +* +* @gzvm: Pointer to struct gzvm +* @args: Pointer in u64 from userspace +* +* Return: +* * 0 - Support, no error
Supported ?
Quoted 7 lines
drivers/virt/geniezone/gzvm_main.c new file +7
-0+* * -EOPNOTSUPP - Not support +* * -EFAULT - Failed to get data from userspace +*/ +long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args) +{ +__u64 cap; +void __user *argp = (void __user *)args;
drivers/virt/geniezone/gzvm_main.c line 71
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+ +if (copy_from_user (&cap, argp,sizeof (uint64_t ))) +return -EFAULT ; +return gzvm_arch_check_extension (gzvm, cap, argp); +} + +static long gzvm_dev_ioctl (struct file *filp,unsigned int cmd, +unsigned long user_args) +{ +long ret = -ENOTTY ;
again redundant initializations
Quoted 28 lines
drivers/virt/geniezone/gzvm_main.c new file +28
-0+ +switch (cmd) { +case GZVM_CREATE_VM : + ret =gzvm_dev_ioctl_create_vm (user_args); +break ; +case GZVM_CHECK_EXTENSION : +if (!user_args) +return -EINVAL ; + ret =gzvm_dev_ioctl_check_extension (NULL , user_args); +break ; +default : + ret = -ENOTTY ; + } + +return ret; +} + +static const struct file_operations gzvm_chardev_ops = { + .unlocked_ioctl = gzvm_dev_ioctl, + .llseek = noop_llseek, +}; + +static struct miscdevice gzvm_dev = { + .minor =MISC_DYNAMIC_MINOR , + .name =KBUILD_MODNAME , + .fops = &gzvm_chardev_ops, +}; +
drivers/virt/geniezone/gzvm_main.c line 109
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+static int gzvm_drv_probe (struct platform_device *pdev) +{ +int ret; + +if (gzvm_arch_probe () !=0 ) { +dev_err (&pdev->dev,"Not found available conduit\n" ); +return -ENODEV ; + } + + ret =misc_register (&gzvm_dev);
return misc_register(...) ?
Quoted 64 lines
drivers/virt/geniezone/gzvm_main.c new file +34
-0+if (ret) +return ret; + +return 0 ; +} + +static int gzvm_drv_remove (struct platform_device *pdev) +{ +gzvm_destroy_all_vms (); +misc_deregister (&gzvm_dev); +return 0 ; +} + +static const struct of_device_id gzvm_of_match[] = { + { .compatible ="mediatek,geniezone-hyp" , }, + {/* sentinel */ }, +}; + +static struct platform_driver gzvm_driver = { + .probe = gzvm_drv_probe, + .remove = gzvm_drv_remove, + .driver = { + .name =KBUILD_MODNAME , + .owner =THIS_MODULE , + .of_match_table = gzvm_of_match, + }, +}; + +module_platform_driver (gzvm_driver); + +MODULE_DEVICE_TABLE (of, gzvm_of_match); +MODULE_AUTHOR ("MediaTek" ); +MODULE_DESCRIPTION ("GenieZone interface for VMM" ); +MODULE_LICENSE ("GPL" );drivers/virt/geniezone/gzvm_vm.c new file +24
-0@@ -0,0 +1,400 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/mm.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> + +static DEFINE_MUTEX (gzvm_list_lock); +static LIST_HEAD (gzvm_list); + +/** +* hva_to_pa_fast() - converts hva to pa in generic fast way +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_fast (u64 hva)
drivers/virt/geniezone/gzvm_vm.c line 34
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+{ +struct page *page[1 ]; + +u64 pfn; + +if (get_user_page_fast_only (hva,0 , page)) { + pfn =page_to_phys (page[0 ]); +put_page ((struct page *)page); +return pfn; + }else {
you can remove the 'else' and just return 0 here as you return pfn in the if(true) case.
Quoted 186 lines
drivers/virt/geniezone/gzvm_vm.c new file +186
-0+return 0 ; + } +} + +/** +* hva_to_pa_slow() - note that this function may sleep +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_slow (u64 hva) +{ +struct page *page; +int npages; +u64 pfn; + + npages =get_user_pages_unlocked (hva,1 , &page,0 ); +if (npages !=1 ) +return 0 ; + + pfn =page_to_phys (page); +put_page (page); + +return pfn; +} + +static u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn) +{ +u64 offset = gfn - memslot->base_gfn; + +return memslot->userspace_addr + offset *PAGE_SIZE ; +} + +static u64 __gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn) +{ +u64 hva, pa; + + hva =gzvm_gfn_to_hva_memslot (memslot, gfn); + + pa =gzvm_hva_to_pa_arch (hva); +if (pa !=0 ) +return PHYS_PFN (pa); + + pa =hva_to_pa_fast (hva); +if (pa) +return PHYS_PFN (pa); + + pa =hva_to_pa_slow (hva); +if (pa) +return PHYS_PFN (pa); + +return 0 ; +} + +/** +* gzvm_gfn_to_pfn_memslot() - Translate gfn (guest ipa) to pfn (host pa), +* result is in @pfn +* @memslot: Pointer to struct gzvm_memslot. +* @gfn: Guest frame number. +* @pfn: Host page frame number. +* +* Return: +* * 0 - Succeed +* * -EFAULT - Failed to convert +*/ +static int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn, +u64 *pfn) +{ +u64 __pfn; + +if (!memslot) +return -EFAULT ; + + __pfn =__gzvm_gfn_to_pfn_memslot (memslot, gfn); +if (__pfn ==0 ) { + *pfn =0 ; +return -EFAULT ; + } + + *pfn = __pfn; + +return 0 ; +} + +/** +* fill_constituents() - Populate pa to buffer until full +* @consti: Pointer to struct mem_region_addr_range. +* @consti_cnt: Constituent count. +* @max_nr_consti: Maximum number of constituent count. +* @gfn: Guest frame number. +* @total_pages: Total page numbers. +* @slot: Pointer to struct gzvm_memslot. +* +* Return: how many pages we've fill in, negative if error +*/ +static int fill_constituents (struct mem_region_addr_range *consti, +int *consti_cnt,int max_nr_consti,u64 gfn, +u32 total_pages,struct gzvm_memslot *slot) +{ +u64 pfn, prev_pfn, gfn_end; +int nr_pages =1 ; +int i =0 ; + +if (unlikely (total_pages ==0 )) +return -EINVAL ; + gfn_end = gfn + total_pages; + +/* entry 0 */ +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; + consti[0 ].address =PFN_PHYS (pfn); + consti[0 ].pg_cnt =1 ; + gfn++; + prev_pfn = pfn; + +while (i < max_nr_consti && gfn < gfn_end) { +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; +if (pfn == (prev_pfn +1 )) { + consti[i].pg_cnt++; + }else { + i++; +if (i >= max_nr_consti) +break ; + consti[i].address =PFN_PHYS (pfn); + consti[i].pg_cnt =1 ; + } + prev_pfn = pfn; + gfn++; + nr_pages++; + } +if (i != max_nr_consti) + i++; + *consti_cnt = i; + +return nr_pages; +} + +/* register_memslot_addr_range() - Register memory region to GZ */ +static int +register_memslot_addr_range (struct gzvm *gzvm,struct gzvm_memslot *memslot) +{ +struct gzvm_memory_region_ranges *region; +u32 buf_size; +int max_nr_consti, remain_pages; +u64 gfn, gfn_end; + + buf_size =PAGE_SIZE *2 ; + region =alloc_pages_exact (buf_size,GFP_KERNEL ); +if (!region) +return -ENOMEM ; + max_nr_consti = (buf_size -sizeof (*region)) / +sizeof (struct mem_region_addr_range ); + + region->slot = memslot->slot_id; + remain_pages = memslot->npages; + gfn = memslot->base_gfn; + gfn_end = gfn + remain_pages; +while (gfn < gfn_end) { +int nr_pages; + + nr_pages =fill_constituents (region->constituents, + ®ion->constituent_cnt, + max_nr_consti, gfn, + remain_pages, memslot); +if (nr_pages <0 ) { +pr_err ("Failed to fill constituents\n" ); +free_pages_exact (region, buf_size); +return nr_pages; + } + region->gpa =PFN_PHYS (gfn); + region->total_pages = nr_pages; + + remain_pages -= nr_pages; + gfn += nr_pages; + +if (gzvm_arch_set_memregion (gzvm->vm_id, buf_size, +virt_to_phys (region))) { +pr_err ("Failed to register memregion to hypervisor\n" ); +free_pages_exact (region, buf_size); +return -EFAULT ; + } + } +free_pages_exact (region, buf_size); +return 0 ; +}
drivers/virt/geniezone/gzvm_vm.c line 230
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+ +/** +* gzvm_vm_ioctl_set_memory_region() - Set memory region of guest +* @gzvm: Pointer to struct gzvm. +* @mem: Input memory region from user. +* +* Return: +* * -EXIO - memslot is out-of-range +* * -EFAULT - Cannot find corresponding vma +* * -EINVAL - region size and vma size does not match
I assume 0 for success ?
Quoted 34 lines
drivers/virt/geniezone/gzvm_vm.c new file +34
-0+*/ +static int +gzvm_vm_ioctl_set_memory_region (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem) +{ +struct vm_area_struct *vma; +struct gzvm_memslot *memslot; +unsigned long size; +__u32 slot; + + slot = mem->slot; +if (slot >=GZVM_MAX_MEM_REGION ) +return -ENXIO ; + memslot = &gzvm->memslot[slot]; + + vma =vma_lookup (gzvm->mm, mem->userspace_addr); +if (!vma) +return -EFAULT ; + + size = vma->vm_end - vma->vm_start; +if (size != mem->memory_size) +return -EINVAL ; + + memslot->base_gfn =__phys_to_pfn (mem->guest_phys_addr); + memslot->npages = size >>PAGE_SHIFT ; + memslot->userspace_addr = mem->userspace_addr; + memslot->vma = vma; + memslot->flags = mem->flags; + memslot->slot_id = mem->slot; +return register_memslot_addr_range (gzvm, memslot); +} + +static int gzvm_vm_ioctl_enable_cap(struct gzvm *gzvm, + struct gzvm_enable_cap *cap,
drivers/virt/geniezone/gzvm_vm.c line 274
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+ void __user *argp) +{ +return gzvm_vm_ioctl_arch_enable_cap (gzvm, cap, argp); +} + +/* gzvm_vm_ioctl() - Ioctl handler of VM FD */ +static long gzvm_vm_ioctl (struct file *filp,unsigned int ioctl, +unsigned long arg) +{ +long ret = -ENOTTY ;
appears to be redundant
Quoted 139 lines
drivers/virt/geniezone/gzvm_vm.c new file +126
-0+void __user *argp = (void __user *)arg; +struct gzvm *gzvm = filp->private_data; + +switch (ioctl) { +case GZVM_CHECK_EXTENSION : { + ret =gzvm_dev_ioctl_check_extension (gzvm, arg); +break ; + } +case GZVM_SET_USER_MEMORY_REGION : { +struct gzvm_userspace_memory_region userspace_mem; + +if (copy_from_user (&userspace_mem, argp,sizeof (userspace_mem))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_vm_ioctl_set_memory_region (gzvm, &userspace_mem); +break ; + } +case GZVM_ENABLE_CAP : { +struct gzvm_enable_cap cap; + +if (copy_from_user (&cap, argp,sizeof (cap))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_vm_ioctl_enable_cap (gzvm, &cap, argp); +break ; + } +default : + ret = -ENOTTY ; + } +out: +return ret; +} + +static void gzvm_destroy_vm (struct gzvm *gzvm) +{ +pr_debug ("VM-%u is going to be destroyed\n" , gzvm->vm_id); + +mutex_lock (&gzvm->lock); + +gzvm_arch_destroy_vm (gzvm->vm_id); + +mutex_lock (&gzvm_list_lock); +list_del (&gzvm->vm_list); +mutex_unlock (&gzvm_list_lock); + +mutex_unlock (&gzvm->lock); + +kfree (gzvm); +} + +static int gzvm_vm_release (struct inode *inode,struct file *filp) +{ +struct gzvm *gzvm = filp->private_data; + +gzvm_destroy_vm (gzvm); +return 0 ; +} + +static const struct file_operations gzvm_vm_fops = { + .release = gzvm_vm_release, + .unlocked_ioctl = gzvm_vm_ioctl, + .llseek = noop_llseek, +}; + +static struct gzvm *gzvm_create_vm (unsigned long vm_type) +{ +int ret; +struct gzvm *gzvm; + + gzvm =kzalloc (sizeof (*gzvm),GFP_KERNEL ); +if (!gzvm) +return ERR_PTR (-ENOMEM ); + + ret =gzvm_arch_create_vm (vm_type); +if (ret <0 ) { +kfree (gzvm); +return ERR_PTR (ret); + } + + gzvm->vm_id = ret; + gzvm->mm = current->mm; +mutex_init (&gzvm->lock); + +mutex_lock (&gzvm_list_lock); +list_add (&gzvm->vm_list, &gzvm_list); +mutex_unlock (&gzvm_list_lock); + +pr_debug ("VM-%u is created\n" , gzvm->vm_id); + +return gzvm; +} + +/** +* gzvm_dev_ioctl_create_vm - Create vm fd +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: fd of vm, negative if error +*/ +int gzvm_dev_ioctl_create_vm (unsigned long vm_type) +{ +struct gzvm *gzvm; + + gzvm =gzvm_create_vm (vm_type); +if (IS_ERR (gzvm)) +return PTR_ERR (gzvm); + +return anon_inode_getfd ("gzvm-vm" , &gzvm_vm_fops, gzvm, +O_RDWR |O_CLOEXEC ); +} + +void gzvm_destroy_all_vms (void ) +{ +struct gzvm *gzvm, *tmp; + +mutex_lock (&gzvm_list_lock); +if (list_empty (&gzvm_list)) + goto out; + +list_for_each_entry_safe (gzvm, tmp, &gzvm_list, vm_list) +gzvm_destroy_vm (gzvm); + +out: +mutex_unlock (&gzvm_list_lock); +}include/linux/gzvm_drv.h new file +7
-0@@ -0,0 +1,90 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_DRV_H__ +#define __GZVM_DRV_H__
include/linux/gzvm_drv.h line 17
Quoted 10 lines
include/linux/gzvm_drv.h new file +10
-0+ +#include <linux/list.h> +#include <linux/mutex.h> +#include <linux/gzvm.h> + +#define GZVM_VCPU_MMAP_SIZE PAGE_SIZE +#define INVALID_VM_ID 0xffff + +/* +* These are the efinitions of APIs between GenieZone hypervisor and driver,
typo: definitions
include/linux/gzvm_drv.h line 18
Quoted 1 line
include/linux/gzvm_drv.h new file +1
-0+* there's no need to be visible to uapi. Furthermore, We need GenieZone
We doesn't have to be capital
Quoted 160 lines
include/linux/gzvm_drv.h new file +72
-0+* specific error code in order to map to Linux errno +*/ +#define NO_ERROR (0) +#define ERR_NO_MEMORY (-5) +#define ERR_NOT_SUPPORTED (-24) +#define ERR_NOT_IMPLEMENTED (-27) +#define ERR_FAULT (-40) + +/* +* The following data structures are for data transferring between driver and +* hypervisor, and they're aligned with hypervisor definitions +*/ +#define GZVM_MAX_VCPUS 8 +#define GZVM_MAX_MEM_REGION 10 + +/* struct mem_region_addr_range - Identical to ffa memory constituent */ +struct mem_region_addr_range { +/* the base IPA of the constituent memory region, aligned to 4 kiB */ +__u64 address; +/* the number of 4 kiB pages in the constituent memory region. */ +__u32 pg_cnt; +__u32 reserved; +}; + +struct gzvm_memory_region_ranges { +__u32 slot; +__u32 constituent_cnt; +__u64 total_pages; +__u64 gpa; +struct mem_region_addr_range constituents[]; +}; + +/* struct gzvm_memslot - VM's memory slot descriptor */ +struct gzvm_memslot { +u64 base_gfn;/* begin of guest page frame */ +unsigned long npages;/* number of pages this slot covers */ +unsigned long userspace_addr;/* corresponding userspace va */ +struct vm_area_struct *vma;/* vma related to this userspace addr */ +u32 flags; +u32 slot_id; +}; + +struct gzvm { +/* userspace tied to this vm */ +struct mm_struct *mm; +struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ]; +/* lock for list_add*/ +struct mutex lock; +struct list_head vm_list; +u16 vm_id; +}; + +long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args); +int gzvm_dev_ioctl_create_vm (unsigned long vm_type); + +int gzvm_err_to_errno (unsigned long err); + +void gzvm_destroy_all_vms (void ); + +/* arch-dependant functions */ +int gzvm_arch_probe (void ); +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region); +int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp); +int gzvm_arch_create_vm (unsigned long vm_type); +int gzvm_arch_destroy_vm (u16 vm_id); +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp); +u64 gzvm_hva_to_pa_arch (u64 hva); + +#endif /* __GZVM_DRV_H__ */ include/uapi/asm-generic/Kbuild +1
-0@@ -34,3 +34,4 @@ mandatory-y += termbits.h mandatory-y += termios.h mandatory-y += types.h mandatory-y += unistd.h +mandatory-y += gzvm_arch.hinclude/uapi/asm-generic/gzvm_arch.h new file +10
-0@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __ASM_GENERIC_GZVM_ARCH_H +#define __ASM_GENERIC_GZVM_ARCH_H +/* geniezone only supports aarch64 platform for now */ + +#endif /* __ASM_GENERIC_GZVM_ARCH_H */ include/uapi/linux/gzvm.h new file +57
-0@@ -0,0 +1,76 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +/** +* DOC: UAPI of GenieZone Hypervisor +* +* This file declares common data structure shared among user space, +* kernel space, and GenieZone hypervisor. +*/ +#ifndef __GZVM_H__ +#define __GZVM_H__ + +#include <linux/const.h> +#include <linux/types.h> +#include <linux/ioctl.h> + +#include <asm/gzvm_arch.h> + +/* GZVM ioctls */ +#define GZVM_IOC_MAGIC 0x92/* gz */ + +/* ioctls for /dev/gzvm fds */ +#define GZVM_CREATE_VM _IO(GZVM_IOC_MAGIC, 0x01)/* Returns a Geniezone VM fd */ + +/* +* Check if the given capability is supported or not. +* The argument is capability. Ex. GZVM_CAP_ARM_PROTECTED_VM or GZVM_CAP_ARM_VM_IPA_SIZE +* return is 0 (supported, no error) +* return is -EOPNOTSUPP (unsupported) +* return is -EFAULT (failed to get the argument from userspace) +*/ +#define GZVM_CHECK_EXTENSION _IO(GZVM_IOC_MAGIC, 0x03) + +/* ioctls for VM fds */ +/* for GZVM_SET_MEMORY_REGION */ +struct gzvm_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +__u64 memory_size;/* bytes */ +}; + +#define GZVM_SET_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x40, \ + struct gzvm_memory_region) + +/* for GZVM_SET_USER_MEMORY_REGION */ +struct gzvm_userspace_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +/* bytes */ +__u64 memory_size; +/* start of the userspace allocated memory */ +__u64 userspace_addr; +};
include/uapi/linux/gzvm.h line 67
Quoted 10 lines
include/uapi/linux/gzvm.h new file +10
-0+ +#define GZVM_SET_USER_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x46, \ + struct gzvm_userspace_memory_region) + +/* for GZVM_ENABLE_CAP */ +struct gzvm_enable_cap { +/* in */ +__u64 cap; +/** +* we have total 5 (8 - 3) registers can be used for
which can be used ?
include/uapi/linux/gzvm.h line 76
Quoted 9 lines
include/uapi/linux/gzvm.h new file +9
-0+* additional args +*/ + __u64 args[5]; +}; + +#define GZVM_ENABLE_CAP _IOW(GZVM_IOC_MAGIC, 0xa3, \ + struct gzvm_enable_cap) + +#endif /* __GZVM_H__ */
Regards,
Eugen
Re: [PATCH v5 03/12] virt: geniezone: Add GenieZone hypervisor support
Quoted 46 lines · Eugen Hristev
Hi Yi-De,
Quoted 30 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
GenieZone is MediaTek hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. This patch exports a set of ioctl
interfaces for userspace VMM (e.g., crosvm) to operate guest VMs lifecycle (creation and destroy) on GenieZone.Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>--- MAINTAINERS | 6 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/gzvm_arch_common.h | 68 ++++ arch/arm64/geniezone/vm.c | 212 +++++++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 20 ++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 10 + drivers/virt/geniezone/gzvm_main.c | 143 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 400 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 90 ++++++ include/uapi/asm-generic/Kbuild | 1 + include/uapi/asm-generic/gzvm_arch.h | 10 + include/uapi/linux/gzvm.h | 76 +++++ 15 files changed, 1064 insertions(+)Quoted 12 lines
create mode 100644
arch/arm64/geniezone/Makefilecreate mode 100644arch/arm64/geniezone/gzvm_arch_common.hcreate mode 100644arch/arm64/geniezone/vm.ccreate mode 100644arch/arm64/include/uapi/asm/gzvm_arch.hcreate mode 100644drivers/virt/geniezone/Kconfigcreate mode 100644drivers/virt/geniezone/Makefilecreate mode 100644drivers/virt/geniezone/gzvm_main.ccreate mode 100644drivers/virt/geniezone/gzvm_vm.ccreate mode 100644include/linux/gzvm_drv.hcreate mode 100644include/uapi/asm-generic/gzvm_arch.hcreate mode 100644include/uapi/linux/gzvm.h
Quoted 4 lines
I have a feeling this patch is a bit big, and could help review if it's
split into chunks of smaller size.
Sure, we would tear this patch apart into a couple of smaller patches according to their features.
Quoted 1,314 lines
Quoted 159 lines
MAINTAINERS +0
-0@@ -8747,6 +8747,12 @@ M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> F: Documentation/devicetree/bindings/hypervisor/mediatek,g
eniezone-hyp.yaml
F:Documentation/virt/geniezone/MAINTAINERS +6
-0+F: arch/arm64/geniezone/ +F: arch/arm64/include/uapi/asm/gzvm_arch.h +F: drivers/virt/geniezone/ +F: include/linux/gzvm_drv.h +F include/uapi/asm-generic/gzvm_arch.h +F: include/uapi/linux/gzvm.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>arch/arm64/Kbuild +1
-0@@ -4,6 +4,7 @@ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(subst m,y,$(CONFIG_HYPERV)) += hyperv/ obj-$(CONFIG_CRYPTO) += crypto/ +obj-$(CONFIG_MTK_GZVM) += geniezone/ # for cleaning subdir- += bootarch/arm64/geniezone/Makefile new file +3
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Main Makefile for gzvm, this one includes
drivers/virt/geniezone/Makefilearch/arm64/geniezone/Makefile new file +6
-0+# +include $(srctree)/drivers/virt/geniezone/Makefile + +gzvm-y += vm.o + +obj-$(CONFIG_MTK_GZVM) += gzvm.oarch/arm64/geniezone/gzvm_arch_common.h new file +29
-0@@ -0,0 +1,68 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_COMMON_H__ +#define __GZVM_ARCH_COMMON_H__ + +#include <linux/arm-smccc.h> + +enum { +GZVM_FUNC_CREATE_VM =0 , +GZVM_FUNC_DESTROY_VM =1 , +GZVM_FUNC_CREATE_VCPU =2 , +GZVM_FUNC_DESTROY_VCPU =3 , +GZVM_FUNC_SET_MEMREGION =4 , +GZVM_FUNC_RUN =5 , +GZVM_FUNC_GET_ONE_REG =8 , +GZVM_FUNC_SET_ONE_REG =9 , +GZVM_FUNC_IRQ_LINE =10 , +GZVM_FUNC_CREATE_DEVICE =11 , +GZVM_FUNC_PROBE =12 , +GZVM_FUNC_ENABLE_CAP =13 , +NR_GZVM_FUNC , +}; + +#define SMC_ENTITY_MTK 59 +#define GZVM_FUNCID_START (0x1000) +#define GZVM_HCALL_ID (func)\arch/arm64/geniezone/gzvm_arch_common.h new file +2
-0+ ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_32, \ + SMC_ENTITY_MTK, (GZVM_FUNCID_START +(func)))
arch/arm64/geniezone/gzvm_arch_common.h new file +2
-0+ +#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC
_CREATE_VM)
+#defineMT_HVC_GZVM_DESTROY_VMGZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM)
+#defineMT_HVC_GZVM_CREATE_VCPUGZVM_HCALL_ID(GZVM_FUNC_CREATE_VCPU)
+#defineMT_HVC_GZVM_DESTROY_VCPUGZVM_HCALL_ID(GZVM_FUNC_DESTROY_VCPU)
+#defineMT_HVC_GZVM_SET_MEMREGIONGZVM_HCALL_ID(GZVM_FUNC_SET_MEM
REGION)
+#defineMT_HVC_GZVM_RUNGZVM_HCALL_ID(GZVM_FUNC_RUN)
+#defineMT_HVC_GZVM_GET_ONE_REGGZVM_HCALL_ID(GZVM_FUNC_GET_ONE_REG)
+#defineMT_HVC_GZVM_SET_ONE_REGGZVM_HCALL_ID(GZVM_FUNC_SET_ONE_REG)
+#defineMT_HVC_GZVM_IRQ_LINEGZVM_HCALL_ID(GZVM_FUNC_IRQ_LINE)
+#defineMT_HVC_GZVM_CREATE_DEVICEGZVM_HCALL_ID(GZVM_FUNC_CREATE_
DEVICE)arch/arm64/geniezone/gzvm_arch_common.h new file +2
-0+#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE) +#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC
_ENABLE_CAP)arch/arm64/geniezone/gzvm_arch_common.h new file +7
-0+ +/** +* gzvm_hypcall_wrapper() - the wrapper for hvc calls +* @a0-a7: arguments passed in registers 0 to 7 +* @res: result values from registers 0 to 3 +* +* Return: The wrapper helps caller to convert geniezone errno to Linux errno.
+ */
+static inline int gzvm_hypcall_wrapper(unsigned long a0, unsigned long a1,arch/arm64/geniezone/gzvm_arch_common.h new file +1
-0+ unsigned long a2, unsigned longa3,
arch/arm64/geniezone/gzvm_arch_common.h new file +1
-0+ unsigned long a4, unsigned longa5,
arch/arm64/geniezone/gzvm_arch_common.h new file +1
-0+ unsigned long a6, unsigned longa7,
arch/arm64/geniezone/gzvm_arch_common.h new file +12
-0+ struct arm_smccc_res *res) +{ +arm_smccc_hvc (a0, a1, a2, a3, a4, a5, a6, a7, res); +return gzvm_err_to_errno (res->a0); +} + +static inline u16 get_vmid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple >>16 ); +} + +#endif /* __GZVM_ARCH_COMMON_H__ */ arch/arm64/geniezone/vm.c new file +13
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <asm/sysreg.h> +#include <linux/arm-smccc.h> +#include <linux/err.h> +#include <linux/uaccess.h> + +#include <linux/gzvm.h> +#include <linux/gzvm_drv.h> +#include "gzvm_arch_common.h" arch/arm64/geniezone/vm.c line 23
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ +#define PAR_PA47_MASK ((((1UL << 48) - 1) >> 12) << 12) + +int gzvm_arch_probe (void ) +{ +struct arm_smccc_res res; + +arm_smccc_hvc (MT_HVC_GZVM_PROBE ,0 ,0 ,0 ,0 ,0 ,0 ,0 , &res); +if (res.a0 ==0 ) +return 0 ;I would see the error path as a particular case here, e.g.
if (res.a0)
return -ENXIO;and on the usual path return success.
(as you already do below in some functions)...
Quoted 12 lines
arch/arm64/geniezone/vm.c new file +11
-0+ +return -ENXIO ; +} + +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region) +{ +struct arm_smccc_res res; + + return gzvm_hypcall_wrapper(MT_HVC_GZVM_SET_MEMREGION, vm_id, + buf_size, region, 0, 0, 0, 0,&res);
arch/arm64/geniezone/vm.c line 42
Quoted 8 lines
arch/arm64/geniezone/vm.c new file +8
-0+} + +static int gzvm_cap_arm_vm_ipa_size (void __user *argp) +{ +__u64 value =CONFIG_ARM64_PA_BITS ; + +if (copy_to_user (argp, &value,sizeof (__u64))) +return -EFAULT ;... e.g. here.
Quoted 14 lines
arch/arm64/geniezone/vm.c new file +5
-0+ +return 0 ; +} + +int gzvm_arch_check_extension(struct gzvm *gzvm, __u64 cap, void
__user*argp)arch/arm64/geniezone/vm.c new file +8
-0+{ +int ret = -EOPNOTSUPP ; + +switch (cap) { +case GZVM_CAP_ARM_PROTECTED_VM : { +__u64 success =1 ; + +if (copy_to_user (argp, &success,sizeof (__u64)))arch/arm64/geniezone/vm.c line 65
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+return -EFAULT ; + ret =0 ; +break ; + } +case GZVM_CAP_ARM_VM_IPA_SIZE : { + ret =gzvm_cap_arm_vm_ipa_size (argp); +break ; + } +default : + ret = -EOPNOTSUPP ;you already initialized ret to
-EOPNOTSUPP, why don't you initialize it
with 0, and just set it as error code here, and avoid setting it to 0 on
the success case above.Quoted 91 lines
arch/arm64/geniezone/vm.c new file +19
-0+ } + +return ret; +} + +/** +* gzvm_arch_create_vm() - create vm +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: +* * positive value - VM ID +* * -ENOMEM - Memory not enough for storing VM data +*/ +int gzvm_arch_create_vm (unsigned long vm_type) +{ +struct arm_smccc_res res; +int ret; + + ret = gzvm_hypcall_wrapper(MT_HVC_GZVM_CREATE_VM, vm_type, 0,0, 0, 0,
arch/arm64/geniezone/vm.c new file +13
-0+ 0, 0, &res); + +if (ret ==0 ) +return res.a1; +else +return ret; +} + +int gzvm_arch_destroy_vm (u16 vm_id) +{ +struct arm_smccc_res res; + + return gzvm_hypcall_wrapper(MT_HVC_GZVM_DESTROY_VM, vm_id, 0,0, 0, 0,
arch/arm64/geniezone/vm.c new file +8
-0+ 0, 0, &res); +} + +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +struct arm_smccc_res *res) +{ + return gzvm_hypcall_wrapper(MT_HVC_GZVM_ENABLE_CAP, gzvm-Quoted 1 line
vm_id,arch/arm64/geniezone/vm.c new file +1
-0+ cap->cap, cap->args[0], cap-Quoted 1 line
args[1],
arch/arm64/geniezone/vm.c new file +1
-0+ cap->args[2], cap->args[3], cap-Quoted 1 line
args[4],
arch/arm64/geniezone/vm.c new file +5
-0+ res); +} + +/** +* gzvm_vm_ioctl_get_pvmfw_size() - Get pvmfw size from hypervisor, return
+ * in x1, and return to userspace in
args
+ * @gzvm: Pointer to struct gzvm.
+ * @cap: Pointer to structgzvm_enable_cap.
+ * @argp: Pointer to structgzvm_enable_capin user space.
+ *
+ * Return:
+ * * 0 - Succeed
+ * *-EINVAL- Hypervisor return invalid results
+ * *-EFAULT- Fail to copy back to userspace buffer
+ */arch/arm64/geniezone/vm.c new file +18
-0+static int gzvm_vm_ioctl_get_pvmfw_size (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +struct arm_smccc_res res = {0 }; + +if (gzvm_vm_arch_enable_cap (gzvm, cap, &res) !=0 ) +return -EINVAL ; + + cap->args[1 ] = res.a1; +if (copy_to_user (argp, cap,sizeof (*cap))) +return -EFAULT ; + +return 0 ; +} + +/** +* gzvm_vm_ioctl_cap_pvm() - Proceed GZVM_CAP_ARM_PROTECTED_VM's subcommands
+ * @gzvm: Pointer to struct gzvm.
+ * @cap: Pointer to structgzvm_enable_cap.
+ * @argp: Pointer to structgzvm_enable_capin user space.
+ *
+ * Return:
+ * * 0 - Succeed
+ * *-EINVAL- Invalid subcommand or arguments
+ */arch/arm64/geniezone/vm.c line 153
Quoted 5 lines
arch/arm64/geniezone/vm.c new file +5
-0+static int gzvm_vm_ioctl_cap_pvm (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ;This initialization appears redundant as you always rewrite ret to a new
value belowQuoted 14 lines
arch/arm64/geniezone/vm.c new file +14
-0+struct arm_smccc_res res = {0 }; + +switch (cap->args[0 ]) { +case GZVM_CAP_ARM_PVM_SET_PVMFW_IPA : + fallthrough; +case GZVM_CAP_ARM_PVM_SET_PROTECTED_VM : + ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res); +break ; +case GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE : + ret =gzvm_vm_ioctl_get_pvmfw_size (gzvm, cap, argp); +break ; +default : + ret = -EINVAL ; +break ;arch/arm64/geniezone/vm.c line 177
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ } + +return ret; +} + +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ;same here
Quoted 15 lines
arch/arm64/geniezone/vm.c new file +15
-0+ +switch (cap->cap) { +case GZVM_CAP_ARM_PROTECTED_VM : + ret =gzvm_vm_ioctl_cap_pvm (gzvm, cap, argp); +break ; +default : + ret = -EINVAL ; +break ; + } + +return ret; +} + +/** +* gzvm_hva_to_pa_arch() - converts hva to pa with arch-specific Quoted 4 lines
way
+ * @hva: Host virtual address.
+ *
+ * Return: 0 if translation errorThis is a bit misleading, if you look at the code, you return 0 if the
bitSYS_PAR_EL1_Fis present, but also return 0 if bitPAR_PA47_MASKis
not present. Are those situations identical ?Also, it's a bit strange to return 0 for an error case.
Quoted 63 lines
+ */
arch/arm64/geniezone/vm.c new file +16
-0+u64 gzvm_hva_to_pa_arch (u64 hva) +{ +u64 par; +unsigned long flags; + +local_irq_save (flags); + asmvolatile ("at s1e1r, %0" ::"r" (hva)); +isb (); + par =read_sysreg_par (); +local_irq_restore (flags); + +if (par &SYS_PAR_EL1_F ) +return 0 ; + +return par &PAR_PA47_MASK ; +}arch/arm64/include/uapi/asm/gzvm_arch.h new file +17
-0@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_H__ +#define __GZVM_ARCH_H__ + +#include <linux/types.h> + +#define GZVM_CAP_ARM_VM_IPA_SIZE 165 +#define GZVM_CAP_ARM_PROTECTED_VM 0xffbadab1 + +/* sub-commands put in args[0] for GZVM_CAP_ARM_PROTECTED_VM */ +#define GZVM_CAP_ARM_PVM_SET_PVMFW_IPA 0 +#define GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE 1 +/* GZVM_CAP_ARM_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */
arch/arm64/include/uapi/asm/gzvm_arch.h new file +3
-0+#define GZVM_CAP_ARM_PVM_SET_PROTECTED_VM 2 + +#endif /* __GZVM_ARCH_H__ */ drivers/virt/Kconfig +2
-0@@ -54,4 +54,6 @@ source "drivers/virt/coco/sev-guest/Kconfig" source "drivers/virt/coco/tdx-guest/Kconfig" +source "drivers/virt/geniezone/Kconfig" + endifdrivers/virt/geniezone/Kconfig new file +0
-0drivers/virt/geniezone/Kconfig line 5
Quoted 5 lines
drivers/virt/geniezone/Kconfig new file +5
-0@@ -0,0 +1,16 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config MTK_GZVM + tristate "GenieZone Hypervisor driver for guest VM operation" + depends on ARM64if only mediatek SoC is supported, should it depend on it here ?
Quoted 85 lines
drivers/virt/geniezone/Kconfig new file +3
-0+ help + This driver, gzvm, enables to run guest VMs on MTK GenieZone + hypervisor. It exports kvm-like interfaces for VMM (e.g.,crosvm) in
drivers/virt/geniezone/Kconfig new file +8
-0+ order to operate guest VMs on GenieZone hypervisor. + + GenieZone hypervisor now only supports MediaTek SoC and arm64 + architecture. + + Select M if you want it be built as a module (gzvm.ko). + + If unsure, say N.drivers/virt/geniezone/Makefile new file +3
-0@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Makefile for GenieZone driver, this file should be include inarch's
drivers/virt/geniezone/Makefile new file +7
-0+# to avoid two ko being generated. +# + +GZVM_DIR ?= ../../../drivers/virt/geniezone + +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o +drivers/virt/geniezone/gzvm_main.c new file +18
-0@@ -0,0 +1,143 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/device.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/miscdevice.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> + +/** +* gzvm_err_to_errno() - Convert geniezone return value to standard errno
+ *
+ * @err: Return value from geniezone function return
+ *
+ * Return: Standard errno
+ */drivers/virt/geniezone/gzvm_main.c new file +24
-0+int gzvm_err_to_errno (unsigned long err) +{ +int gz_err = (int )err; + +switch (gz_err) { +case 0 : +return 0 ; +case ERR_NO_MEMORY : +return -ENOMEM ; +case ERR_NOT_SUPPORTED : +return -EOPNOTSUPP ; +case ERR_NOT_IMPLEMENTED : +return -EOPNOTSUPP ; +case ERR_FAULT : +return -EFAULT ; +default : +break ; + } + +return -EINVAL ; +} + +/** +* gzvm_dev_ioctl_check_extension() - Check if given capability is Quoted 8 lines
support
+ * or not
+ *
+ * @gzvm: Pointer to struct gzvm
+ * @args: Pointer in u64 from userspace
+ *
+ * Return:
+ * * 0 - Support, no errorSupported ?
Quoted 8 lines
+ * *
-EOPNOTSUPP- Not support
+ * *-EFAULT- Failed to get data from userspace
+ */
+longgzvm_dev_ioctl_check_extension(struct gzvm *gzvm, unsigned long args)drivers/virt/geniezone/gzvm_main.c new file +3
-0+{ +__u64 cap; +void __user *argp = (void __user *)args;drivers/virt/geniezone/gzvm_main.c line 71
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+ +if (copy_from_user (&cap, argp,sizeof (uint64_t ))) +return -EFAULT ; +return gzvm_arch_check_extension (gzvm, cap, argp); +} + +static long gzvm_dev_ioctl (struct file *filp,unsigned int cmd, +unsigned long user_args) +{ +long ret = -ENOTTY ;again redundant initializations
Quoted 28 lines
drivers/virt/geniezone/gzvm_main.c new file +28
-0+ +switch (cmd) { +case GZVM_CREATE_VM : + ret =gzvm_dev_ioctl_create_vm (user_args); +break ; +case GZVM_CHECK_EXTENSION : +if (!user_args) +return -EINVAL ; + ret =gzvm_dev_ioctl_check_extension (NULL , user_args); +break ; +default : + ret = -ENOTTY ; + } + +return ret; +} + +static const struct file_operations gzvm_chardev_ops = { + .unlocked_ioctl = gzvm_dev_ioctl, + .llseek = noop_llseek, +}; + +static struct miscdevice gzvm_dev = { + .minor =MISC_DYNAMIC_MINOR , + .name =KBUILD_MODNAME , + .fops = &gzvm_chardev_ops, +}; +drivers/virt/geniezone/gzvm_main.c line 109
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+static int gzvm_drv_probe (struct platform_device *pdev) +{ +int ret; + +if (gzvm_arch_probe () !=0 ) { +dev_err (&pdev->dev,"Not found available conduit\n" ); +return -ENODEV ; + } + + ret =misc_register (&gzvm_dev);return
misc_register(...)?Quoted 65 lines
drivers/virt/geniezone/gzvm_main.c new file +34
-0+if (ret) +return ret; + +return 0 ; +} + +static int gzvm_drv_remove (struct platform_device *pdev) +{ +gzvm_destroy_all_vms (); +misc_deregister (&gzvm_dev); +return 0 ; +} + +static const struct of_device_id gzvm_of_match[] = { + { .compatible ="mediatek,geniezone-hyp" , }, + {/* sentinel */ }, +}; + +static struct platform_driver gzvm_driver = { + .probe = gzvm_drv_probe, + .remove = gzvm_drv_remove, + .driver = { + .name =KBUILD_MODNAME , + .owner =THIS_MODULE , + .of_match_table = gzvm_of_match, + }, +}; + +module_platform_driver (gzvm_driver); + +MODULE_DEVICE_TABLE (of, gzvm_of_match); +MODULE_AUTHOR ("MediaTek" ); +MODULE_DESCRIPTION ("GenieZone interface for VMM" ); +MODULE_LICENSE ("GPL" );drivers/virt/geniezone/gzvm_vm.c new file +24
-0@@ -0,0 +1,400 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/mm.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> + +static DEFINE_MUTEX (gzvm_list_lock); +static LIST_HEAD (gzvm_list); + +/** +* hva_to_pa_fast() - converts hva to pa in generic fast way +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_fast (u64 hva)drivers/virt/geniezone/gzvm_vm.c line 34
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+{ +struct page *page[1 ]; + +u64 pfn; + +if (get_user_page_fast_only (hva,0 , page)) { + pfn =page_to_phys (page[0 ]); +put_page ((struct page *)page); +return pfn; + }else {you can remove the 'else' and just return 0 here as you return pfn in
the if(true) case.Quoted 204 lines
drivers/virt/geniezone/gzvm_vm.c new file +27
-0+return 0 ; + } +} + +/** +* hva_to_pa_slow() - note that this function may sleep +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_slow (u64 hva) +{ +struct page *page; +int npages; +u64 pfn; + + npages =get_user_pages_unlocked (hva,1 , &page,0 ); +if (npages !=1 ) +return 0 ; + + pfn =page_to_phys (page); +put_page (page); + +return pfn; +} + +static u64 gzvm_gfn_to_hva_memslot(struct gzvm_memslot *memslot,u64 gfn)
drivers/virt/geniezone/gzvm_vm.c new file +7
-0+{ +u64 offset = gfn - memslot->base_gfn; + +return memslot->userspace_addr + offset *PAGE_SIZE ; +} + +static u64 __gzvm_gfn_to_pfn_memslot(struct gzvm_memslot *memslot,u64 gfn)
drivers/virt/geniezone/gzvm_vm.c new file +22
-0+{ +u64 hva, pa; + + hva =gzvm_gfn_to_hva_memslot (memslot, gfn); + + pa =gzvm_hva_to_pa_arch (hva); +if (pa !=0 ) +return PHYS_PFN (pa); + + pa =hva_to_pa_fast (hva); +if (pa) +return PHYS_PFN (pa); + + pa =hva_to_pa_slow (hva); +if (pa) +return PHYS_PFN (pa); + +return 0 ; +} + +/** +* gzvm_gfn_to_pfn_memslot() - Translate gfn (guest ipa) to pfn (host pa),
+ * result is in @pfn
+ * @memslot: Pointer to structgzvm_memslot.
+ * @gfn: Guest frame number.
+ * @pfn: Host page frame number.
+ *
+ * Return:
+ * * 0 - Succeed
+ * *-EFAULT- Failed to convert
+ */
+static int gzvm_gfn_to_pfn_memslot(structgzvm_memslot*memslot, u64 gfn,drivers/virt/geniezone/gzvm_vm.c new file +31
-0+ u64 *pfn) +{ +u64 __pfn; + +if (!memslot) +return -EFAULT ; + + __pfn =__gzvm_gfn_to_pfn_memslot (memslot, gfn); +if (__pfn ==0 ) { + *pfn =0 ; +return -EFAULT ; + } + + *pfn = __pfn; + +return 0 ; +} + +/** +* fill_constituents() - Populate pa to buffer until full +* @consti: Pointer to struct mem_region_addr_range. +* @consti_cnt: Constituent count. +* @max_nr_consti: Maximum number of constituent count. +* @gfn: Guest frame number. +* @total_pages: Total page numbers. +* @slot: Pointer to struct gzvm_memslot. +* +* Return: how many pages we've fill in, negative if error +*/ +static int fill_constituents (struct mem_region_addr_range *consti, + int *consti_cnt, int max_nr_consti, u64gfn,
drivers/virt/geniezone/gzvm_vm.c new file +1
-0+ u32 total_pages, struct gzvm_memslot*slot)
drivers/virt/geniezone/gzvm_vm.c new file +43
-0+{ +u64 pfn, prev_pfn, gfn_end; +int nr_pages =1 ; +int i =0 ; + +if (unlikely (total_pages ==0 )) +return -EINVAL ; + gfn_end = gfn + total_pages; + +/* entry 0 */ +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; + consti[0 ].address =PFN_PHYS (pfn); + consti[0 ].pg_cnt =1 ; + gfn++; + prev_pfn = pfn; + +while (i < max_nr_consti && gfn < gfn_end) { +if (gzvm_gfn_to_pfn_memslot (slot, gfn, &pfn) !=0 ) +return -EFAULT ; +if (pfn == (prev_pfn +1 )) { + consti[i].pg_cnt++; + }else { + i++; +if (i >= max_nr_consti) +break ; + consti[i].address =PFN_PHYS (pfn); + consti[i].pg_cnt =1 ; + } + prev_pfn = pfn; + gfn++; + nr_pages++; + } +if (i != max_nr_consti) + i++; + *consti_cnt = i; + +return nr_pages; +} + +/* register_memslot_addr_range() - Register memory region to GZ */ +static int +register_memslot_addr_range(struct gzvm *gzvm, struct gzvm_memslot*memslot)
drivers/virt/geniezone/gzvm_vm.c new file +38
-0+{ +struct gzvm_memory_region_ranges *region; +u32 buf_size; +int max_nr_consti, remain_pages; +u64 gfn, gfn_end; + + buf_size =PAGE_SIZE *2 ; + region =alloc_pages_exact (buf_size,GFP_KERNEL ); +if (!region) +return -ENOMEM ; + max_nr_consti = (buf_size -sizeof (*region)) / +sizeof (struct mem_region_addr_range ); + + region->slot = memslot->slot_id; + remain_pages = memslot->npages; + gfn = memslot->base_gfn; + gfn_end = gfn + remain_pages; +while (gfn < gfn_end) { +int nr_pages; + + nr_pages =fill_constituents (region->constituents, + ®ion->constituent_cnt, + max_nr_consti, gfn, + remain_pages, memslot); +if (nr_pages <0 ) { +pr_err ("Failed to fill constituents\n" ); +free_pages_exact (region, buf_size); +return nr_pages; + } + region->gpa =PFN_PHYS (gfn); + region->total_pages = nr_pages; + + remain_pages -= nr_pages; + gfn += nr_pages; + +if (gzvm_arch_set_memregion (gzvm->vm_id, buf_size, +virt_to_phys (region))) { + pr_err("Failed to register memregion tohypervisor\n");
drivers/virt/geniezone/gzvm_vm.c new file +17
-0+free_pages_exact (region, buf_size); +return -EFAULT ; + } + } +free_pages_exact (region, buf_size); +return 0 ; +} + +/** +* gzvm_vm_ioctl_set_memory_region() - Set memory region of guest +* @gzvm: Pointer to struct gzvm. +* @mem: Input memory region from user. +* +* Return: +* * -EXIO - memslot is out-of-range +* * -EFAULT - Cannot find corresponding vma +* * -EINVAL - region size and vma size does not Quoted 1 line
match
I assume 0 for success ?
Quoted 35 lines
+ */
drivers/virt/geniezone/gzvm_vm.c new file +3
-0+static int +gzvm_vm_ioctl_set_memory_region (struct gzvm *gzvm, + struct gzvm_userspace_memory_region*mem)
drivers/virt/geniezone/gzvm_vm.c new file +30
-0+{ +struct vm_area_struct *vma; +struct gzvm_memslot *memslot; +unsigned long size; +__u32 slot; + + slot = mem->slot; +if (slot >=GZVM_MAX_MEM_REGION ) +return -ENXIO ; + memslot = &gzvm->memslot[slot]; + + vma =vma_lookup (gzvm->mm, mem->userspace_addr); +if (!vma) +return -EFAULT ; + + size = vma->vm_end - vma->vm_start; +if (size != mem->memory_size) +return -EINVAL ; + + memslot->base_gfn =__phys_to_pfn (mem->guest_phys_addr); + memslot->npages = size >>PAGE_SHIFT ; + memslot->userspace_addr = mem->userspace_addr; + memslot->vma = vma; + memslot->flags = mem->flags; + memslot->slot_id = mem->slot; +return register_memslot_addr_range (gzvm, memslot); +} + +static int gzvm_vm_ioctl_enable_cap(struct gzvm *gzvm, + struct gzvm_enable_cap *cap,drivers/virt/geniezone/gzvm_vm.c line 274
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+ void __user *argp) +{ +return gzvm_vm_ioctl_arch_enable_cap (gzvm, cap, argp); +} + +/* gzvm_vm_ioctl() - Ioctl handler of VM FD */ +static long gzvm_vm_ioctl (struct file *filp,unsigned int ioctl, +unsigned long arg) +{ +long ret = -ENOTTY ;appears to be redundant
Quoted 151 lines
drivers/virt/geniezone/gzvm_vm.c new file +12
-0+void __user *argp = (void __user *)arg; +struct gzvm *gzvm = filp->private_data; + +switch (ioctl) { +case GZVM_CHECK_EXTENSION : { + ret =gzvm_dev_ioctl_check_extension (gzvm, arg); +break ; + } +case GZVM_SET_USER_MEMORY_REGION : { +struct gzvm_userspace_memory_region userspace_mem; + + if (copy_from_user(&userspace_mem, argp,
sizeof(userspace_mem))) {drivers/virt/geniezone/gzvm_vm.c new file +4
-0+ ret = -EFAULT ; + goto out; + } + ret = gzvm_vm_ioctl_set_memory_region(gzvm,
&userspace_mem);drivers/virt/geniezone/gzvm_vm.c new file +110
-0+break ; + } +case GZVM_ENABLE_CAP : { +struct gzvm_enable_cap cap; + +if (copy_from_user (&cap, argp,sizeof (cap))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_vm_ioctl_enable_cap (gzvm, &cap, argp); +break ; + } +default : + ret = -ENOTTY ; + } +out: +return ret; +} + +static void gzvm_destroy_vm (struct gzvm *gzvm) +{ +pr_debug ("VM-%u is going to be destroyed\n" , gzvm->vm_id); + +mutex_lock (&gzvm->lock); + +gzvm_arch_destroy_vm (gzvm->vm_id); + +mutex_lock (&gzvm_list_lock); +list_del (&gzvm->vm_list); +mutex_unlock (&gzvm_list_lock); + +mutex_unlock (&gzvm->lock); + +kfree (gzvm); +} + +static int gzvm_vm_release (struct inode *inode,struct file *filp) +{ +struct gzvm *gzvm = filp->private_data; + +gzvm_destroy_vm (gzvm); +return 0 ; +} + +static const struct file_operations gzvm_vm_fops = { + .release = gzvm_vm_release, + .unlocked_ioctl = gzvm_vm_ioctl, + .llseek = noop_llseek, +}; + +static struct gzvm *gzvm_create_vm (unsigned long vm_type) +{ +int ret; +struct gzvm *gzvm; + + gzvm =kzalloc (sizeof (*gzvm),GFP_KERNEL ); +if (!gzvm) +return ERR_PTR (-ENOMEM ); + + ret =gzvm_arch_create_vm (vm_type); +if (ret <0 ) { +kfree (gzvm); +return ERR_PTR (ret); + } + + gzvm->vm_id = ret; + gzvm->mm = current->mm; +mutex_init (&gzvm->lock); + +mutex_lock (&gzvm_list_lock); +list_add (&gzvm->vm_list, &gzvm_list); +mutex_unlock (&gzvm_list_lock); + +pr_debug ("VM-%u is created\n" , gzvm->vm_id); + +return gzvm; +} + +/** +* gzvm_dev_ioctl_create_vm - Create vm fd +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: fd of vm, negative if error +*/ +int gzvm_dev_ioctl_create_vm (unsigned long vm_type) +{ +struct gzvm *gzvm; + + gzvm =gzvm_create_vm (vm_type); +if (IS_ERR (gzvm)) +return PTR_ERR (gzvm); + +return anon_inode_getfd ("gzvm-vm" , &gzvm_vm_fops, gzvm, +O_RDWR |O_CLOEXEC ); +} + +void gzvm_destroy_all_vms (void ) +{ +struct gzvm *gzvm, *tmp; + +mutex_lock (&gzvm_list_lock); +if (list_empty (&gzvm_list)) + goto out; + +list_for_each_entry_safe (gzvm, tmp, &gzvm_list, vm_list) +gzvm_destroy_vm (gzvm); + +out: +mutex_unlock (&gzvm_list_lock); +}include/linux/gzvm_drv.h new file +17
-0@@ -0,0 +1,90 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_DRV_H__ +#define __GZVM_DRV_H__ + +#include <linux/list.h> +#include <linux/mutex.h> +#include <linux/gzvm.h> + +#define GZVM_VCPU_MMAP_SIZE PAGE_SIZE +#define INVALID_VM_ID 0xffff + +/* +* These are the efinitions of APIs between GenieZone hypervisor Quoted 1 line
and driver,
typo: definitions
Quoted 2 lines
+ * there's no need to be visible to uapi. Furthermore, We need GenieZone
We doesn't have to be capital
Quoted 179 lines
+ * specific error code in order to map to Linux errno
+ */include/linux/gzvm_drv.h new file +8
-0+#define NO_ERROR (0) +#define ERR_NO_MEMORY (-5) +#define ERR_NOT_SUPPORTED (-24) +#define ERR_NOT_IMPLEMENTED (-27) +#define ERR_FAULT (-40) + +/* +* The following data structures are for data transferring between driver and
+ * hypervisor, and they're aligned with hypervisor definitions
+ */include/linux/gzvm_drv.h new file +4
-0+#define GZVM_MAX_VCPUS 8 +#define GZVM_MAX_MEM_REGION 10 + +/* struct mem_region_addr_range - Identical to ffa memory constituent */
include/linux/gzvm_drv.h new file +2
-0+struct mem_region_addr_range { +/* the base IPA of the constituent memory region, aligned to 4 kiB */
include/linux/gzvm_drv.h new file +2
-0+__u64 address; +/* the number of 4 kiB pages in the constituent memory region. */
include/linux/gzvm_drv.h new file +15
-0+__u32 pg_cnt; +__u32 reserved; +}; + +struct gzvm_memory_region_ranges { +__u32 slot; +__u32 constituent_cnt; +__u64 total_pages; +__u64 gpa; +struct mem_region_addr_range constituents[]; +}; + +/* struct gzvm_memslot - VM's memory slot descriptor */ +struct gzvm_memslot { +u64 base_gfn;/* begin of guest page frame */
include/linux/gzvm_drv.h new file +1
-0+unsigned long npages;/* number of pages this slot covers */
include/linux/gzvm_drv.h new file +1
-0+unsigned long userspace_addr;/* corresponding userspace va */
include/linux/gzvm_drv.h new file +1
-0+struct vm_area_struct *vma;/* vma related to this userspace addr */
include/linux/gzvm_drv.h new file +15
-0+u32 flags; +u32 slot_id; +}; + +struct gzvm { +/* userspace tied to this vm */ +struct mm_struct *mm; +struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ]; +/* lock for list_add*/ +struct mutex lock; +struct list_head vm_list; +u16 vm_id; +}; + +long gzvm_dev_ioctl_check_extension(struct gzvm *gzvm, unsignedlong args);
include/linux/gzvm_drv.h new file +11
-0+int gzvm_dev_ioctl_create_vm (unsigned long vm_type); + +int gzvm_err_to_errno (unsigned long err); + +void gzvm_destroy_all_vms (void ); + +/* arch-dependant functions */ +int gzvm_arch_probe (void ); +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region); +int gzvm_arch_check_extension(struct gzvm *gzvm, __u64 cap, void
__user*argp);include/linux/gzvm_drv.h new file +8
-0+int gzvm_arch_create_vm (unsigned long vm_type); +int gzvm_arch_destroy_vm (u16 vm_id); +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp); +u64 gzvm_hva_to_pa_arch (u64 hva); + +#endif /* __GZVM_DRV_H__ */ include/uapi/asm- renamed from include/uapi/asm-generic/Kbuild +0
-0generic/Kbuild
indexebb180aac74e..5af115a3c1a8100644include/uapi/asm-generic/Kbuild +1
-0@@ -34,3 +34,4 @@ mandatory-y += termbits.h mandatory-y += termios.h mandatory-y += types.h mandatory-y += unistd.h +mandatory-y += gzvm_arch.hinclude/uapi/asm-generic/gzvm_arch.h new file +10
-0@@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __ASM_GENERIC_GZVM_ARCH_H +#define __ASM_GENERIC_GZVM_ARCH_H +/* geniezone only supports aarch64 platform for now */ + +#endif /* __ASM_GENERIC_GZVM_ARCH_H */ include/uapi/linux/gzvm.h new file +9
-0@@ -0,0 +1,76 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +/** +* DOC: UAPI of GenieZone Hypervisor +* +* This file declares common data structure shared among user space,
+ * kernel space, and GenieZone hypervisor.
+ */include/uapi/linux/gzvm.h new file +14
-0+#ifndef __GZVM_H__ +#define __GZVM_H__ + +#include <linux/const.h> +#include <linux/types.h> +#include <linux/ioctl.h> + +#include <asm/gzvm_arch.h> + +/* GZVM ioctls */ +#define GZVM_IOC_MAGIC 0x92/* gz */ + +/* ioctls for /dev/gzvm fds */ +#define GZVM_CREATE_VM _IO(GZVM_IOC_MAGIC, 0x01)/* Returns a Geniezone VM fd */
include/uapi/linux/gzvm.h new file +4
-0+ +/* +* Check if the given capability is supported or not. +* The argument is capability. Ex. GZVM_CAP_ARM_PROTECTED_VM or
GZVM_CAP_ARM_VM_IPA_SIZE
+ * return is 0 (supported, no error)
+ * return is-EOPNOTSUPP(unsupported)
+ * return is-EFAULT(failed to get the argument from userspace)
+ */include/uapi/linux/gzvm.h new file +27
-0+#define GZVM_CHECK_EXTENSION _IO(GZVM_IOC_MAGIC, 0x03) + +/* ioctls for VM fds */ +/* for GZVM_SET_MEMORY_REGION */ +struct gzvm_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +__u64 memory_size;/* bytes */ +}; + +#define GZVM_SET_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x40, \ + struct gzvm_memory_region) + +/* for GZVM_SET_USER_MEMORY_REGION */ +struct gzvm_userspace_memory_region { +__u32 slot; +__u32 flags; +__u64 guest_phys_addr; +/* bytes */ +__u64 memory_size; +/* start of the userspace allocated memory */ +__u64 userspace_addr; +}; + +#define GZVM_SET_USER_MEMORY_REGION _IOW(GZVM_IOC_MAGIC, 0x46, \ + struct
gzvm_userspace_memory_region)include/uapi/linux/gzvm.h line 67
Quoted 7 lines
include/uapi/linux/gzvm.h new file +7
-0+ +/* for GZVM_ENABLE_CAP */ +struct gzvm_enable_cap { +/* in */ +__u64 cap; +/** +* we have total 5 (8 - 3) registers can be used for which can be used ?
include/uapi/linux/gzvm.h line 76
Quoted 9 lines
include/uapi/linux/gzvm.h new file +9
-0+* additional args +*/ + __u64 args[5]; +}; + +#define GZVM_ENABLE_CAP _IOW(GZVM_IOC_MAGIC, 0xa3, \ + struct gzvm_enable_cap) + +#endif /* __GZVM_H__ */ Regards,
Eugen
AngeloGioacchino Del Regno
maintainerRe: [PATCH v5 03/12] virt: geniezone: Add GenieZone hypervisor support
In reply to Yi-De WuIl 27/07/23 09:59, Yi-De Wu ha scritto:
Quoted 203 lines
From: "Yingshiuan Pan" <[email protected]>
GenieZone is MediaTek hypervisor solution, and it is running in EL2 stand alone as a type-I hypervisor. This patch exports a set of ioctl interfaces for userspace VMM (e.g., crosvm) to operate guest VMs lifecycle (creation and destroy) on GenieZone.
Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>--- MAINTAINERS | 6 + arch/arm64/Kbuild | 1 + arch/arm64/geniezone/Makefile | 9 + arch/arm64/geniezone/gzvm_arch_common.h | 68 ++++ arch/arm64/geniezone/vm.c | 212 +++++++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 20 ++ drivers/virt/Kconfig | 2 + drivers/virt/geniezone/Kconfig | 16 + drivers/virt/geniezone/Makefile | 10 + drivers/virt/geniezone/gzvm_main.c | 143 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 400 ++++++++++++++++++++++++ include/linux/gzvm_drv.h | 90 ++++++ include/uapi/asm-generic/Kbuild | 1 + include/uapi/asm-generic/gzvm_arch.h | 10 + include/uapi/linux/gzvm.h | 76 +++++ 15 files changed, 1064 insertions(+)create mode 100644
arch/arm64/geniezone/Makefilecreate mode 100644arch/arm64/geniezone/gzvm_arch_common.hcreate mode 100644arch/arm64/geniezone/vm.ccreate mode 100644arch/arm64/include/uapi/asm/gzvm_arch.hcreate mode 100644drivers/virt/geniezone/Kconfigcreate mode 100644drivers/virt/geniezone/Makefilecreate mode 100644drivers/virt/geniezone/gzvm_main.ccreate mode 100644drivers/virt/geniezone/gzvm_vm.ccreate mode 100644include/linux/gzvm_drv.hcreate mode 100644include/uapi/asm-generic/gzvm_arch.hcreate mode 100644include/uapi/linux/gzvm.hMAINTAINERS +6
-0@@ -8747,6 +8747,12 @@ M: Ze-Yu Wang <[email protected]> M: Yi-De Wu <[email protected]> F: Documentation/devicetree/bindings/hypervisor/mediatek,geniezone-hyp.yaml F: Documentation/virt/geniezone/ +F: arch/arm64/geniezone/ +F: arch/arm64/include/uapi/asm/gzvm_arch.h +F: drivers/virt/geniezone/ +F: include/linux/gzvm_drv.h +F include/uapi/asm-generic/gzvm_arch.h +F: include/uapi/linux/gzvm.h GENWQE (IBM Generic Workqueue Card) M: Frank Haverkamp <[email protected]>arch/arm64/Kbuild +1
-0@@ -4,6 +4,7 @@ obj-$(CONFIG_KVM) += kvm/ obj-$(CONFIG_XEN) += xen/ obj-$(subst m,y,$(CONFIG_HYPERV)) += hyperv/ obj-$(CONFIG_CRYPTO) += crypto/ +obj-$(CONFIG_MTK_GZVM) += geniezone/ # for cleaning subdir- += bootarch/arm64/geniezone/Makefile new file +9
-0@@ -0,0 +1,9 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Main Makefile for gzvm, this one includes drivers/virt/geniezone/Makefile +# +include $(srctree)/drivers/virt/geniezone/Makefile + +gzvm-y += vm.o + +obj-$(CONFIG_MTK_GZVM) += gzvm.oarch/arm64/geniezone/gzvm_arch_common.h new file +68
-0@@ -0,0 +1,68 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZVM_ARCH_COMMON_H__ +#define __GZVM_ARCH_COMMON_H__ + +#include <linux/arm-smccc.h> + +enum { +GZVM_FUNC_CREATE_VM =0 , +GZVM_FUNC_DESTROY_VM =1 , +GZVM_FUNC_CREATE_VCPU =2 , +GZVM_FUNC_DESTROY_VCPU =3 , +GZVM_FUNC_SET_MEMREGION =4 , +GZVM_FUNC_RUN =5 , +GZVM_FUNC_GET_ONE_REG =8 , +GZVM_FUNC_SET_ONE_REG =9 , +GZVM_FUNC_IRQ_LINE =10 , +GZVM_FUNC_CREATE_DEVICE =11 , +GZVM_FUNC_PROBE =12 , +GZVM_FUNC_ENABLE_CAP =13 , +NR_GZVM_FUNC , +}; + +#define SMC_ENTITY_MTK 59 +#define GZVM_FUNCID_START (0x1000) +#define GZVM_HCALL_ID (func) \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_32, \ + SMC_ENTITY_MTK, (GZVM_FUNCID_START + (func))) + +#define MT_HVC_GZVM_CREATE_VM GZVM_HCALL_ID(GZVM_FUNC_CREATE_VM) +#define MT_HVC_GZVM_DESTROY_VM GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VM) +#define MT_HVC_GZVM_CREATE_VCPU GZVM_HCALL_ID(GZVM_FUNC_CREATE_VCPU) +#define MT_HVC_GZVM_DESTROY_VCPU GZVM_HCALL_ID(GZVM_FUNC_DESTROY_VCPU) +#define MT_HVC_GZVM_SET_MEMREGION GZVM_HCALL_ID(GZVM_FUNC_SET_MEMREGION) +#define MT_HVC_GZVM_RUN GZVM_HCALL_ID(GZVM_FUNC_RUN) +#define MT_HVC_GZVM_GET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_GET_ONE_REG) +#define MT_HVC_GZVM_SET_ONE_REG GZVM_HCALL_ID(GZVM_FUNC_SET_ONE_REG) +#define MT_HVC_GZVM_IRQ_LINE GZVM_HCALL_ID(GZVM_FUNC_IRQ_LINE) +#define MT_HVC_GZVM_CREATE_DEVICE GZVM_HCALL_ID(GZVM_FUNC_CREATE_DEVICE) +#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE) +#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP) + +/** +* gzvm_hypcall_wrapper() - the wrapper for hvc calls +* @a0-a7: arguments passed in registers 0 to 7 +* @res: result values from registers 0 to 3 +* +* Return: The wrapper helps caller to convert geniezone errno to Linux errno. +*/ +static inline int gzvm_hypcall_wrapper (unsigned long a0,unsigned long a1, +unsigned long a2,unsigned long a3, +unsigned long a4,unsigned long a5, +unsigned long a6,unsigned long a7, +struct arm_smccc_res *res) +{ +arm_smccc_hvc (a0, a1, a2, a3, a4, a5, a6, a7, res); +return gzvm_err_to_errno (res->a0); +} + +static inline u16 get_vmid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple >>16 ); +} + +#endif /* __GZVM_ARCH_COMMON_H__ */ arch/arm64/geniezone/vm.c new file +39
-0@@ -0,0 +1,212 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <asm/sysreg.h> +#include <linux/arm-smccc.h> +#include <linux/err.h> +#include <linux/uaccess.h> + +#include <linux/gzvm.h> +#include <linux/gzvm_drv.h> +#include "gzvm_arch_common.h" + +#define PAR_PA47_MASK ((((1UL << 48) - 1) >> 12) << 12) + +int gzvm_arch_probe (void ) +{ +struct arm_smccc_res res; + +arm_smccc_hvc (MT_HVC_GZVM_PROBE ,0 ,0 ,0 ,0 ,0 ,0 ,0 , &res); +if (res.a0 ==0 ) +return 0 ; + +return -ENXIO ; +} + +int gzvm_arch_set_memregion (u16 vm_id,size_t buf_size, +phys_addr_t region) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_SET_MEMREGION , vm_id, + buf_size, region,0 ,0 ,0 ,0 , &res); +} + +static int gzvm_cap_arm_vm_ipa_size (void __user *argp) +{ +__u64 value =CONFIG_ARM64_PA_BITS ;
arch/arm64/geniezone/vm.c line 49
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+ +if (copy_to_user (argp, &value,sizeof (__u64))) +return -EFAULT ; + +return 0 ; +} + +int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp) +{ +int ret = -EOPNOTSUPP ;
int ret;
arch/arm64/geniezone/vm.c line 57
Quoted 8 lines
arch/arm64/geniezone/vm.c new file +8
-0+ +switch (cap) { +case GZVM_CAP_ARM_PROTECTED_VM : { +__u64 success =1 ; + +if (copy_to_user (argp, &success,sizeof (__u64))) +return -EFAULT ; + ret =0 ;
here, instead of ret = 0...
return 0;
arch/arm64/geniezone/vm.c line 61
Quoted 4 lines
arch/arm64/geniezone/vm.c new file +4
-0+break ; + } +case GZVM_CAP_ARM_VM_IPA_SIZE : { + ret =gzvm_cap_arm_vm_ipa_size (argp);
and here
return ret;
arch/arm64/geniezone/vm.c line 65
Quoted 4 lines
arch/arm64/geniezone/vm.c new file +4
-0+break ; + } +default : + ret = -EOPNOTSUPP ;
break;
arch/arm64/geniezone/vm.c line 67
Quoted 2 lines
arch/arm64/geniezone/vm.c new file +2
-0+ } +
return -EOPNOTSUPP;
Quoted 9 lines
arch/arm64/geniezone/vm.c new file +9
-0+return ret; +} + +/** +* gzvm_arch_create_vm() - create vm +* @vm_type: VM type. Only supports Linux VM now. +* +* Return: +* * positive value - VM ID
arch/arm64/geniezone/vm.c line 86
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+* * -ENOMEM - Memory not enough for storing VM data +*/ +int gzvm_arch_create_vm (unsigned long vm_type) +{ +struct arm_smccc_res res; +int ret; + + ret =gzvm_hypcall_wrapper (MT_HVC_GZVM_CREATE_VM , vm_type,0 ,0 ,0 ,0 , +0 ,0 , &res); +
return ret ? ret : res.a1;
Quoted 58 lines
arch/arm64/geniezone/vm.c new file +58
-0+if (ret ==0 ) +return res.a1; +else +return ret; +} + +int gzvm_arch_destroy_vm (u16 vm_id) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_DESTROY_VM , vm_id,0 ,0 ,0 ,0 , +0 ,0 , &res); +} + +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +struct arm_smccc_res *res) +{ +return gzvm_hypcall_wrapper (MT_HVC_GZVM_ENABLE_CAP , gzvm->vm_id, + cap->cap, cap->args[0 ], cap->args[1 ], + cap->args[2 ], cap->args[3 ], cap->args[4 ], + res); +} + +/** +* gzvm_vm_ioctl_get_pvmfw_size() - Get pvmfw size from hypervisor, return +* in x1, and return to userspace in args +* @gzvm: Pointer to struct gzvm. +* @cap: Pointer to struct gzvm_enable_cap. +* @argp: Pointer to struct gzvm_enable_cap in user space. +* +* Return: +* * 0 - Succeed +* * -EINVAL - Hypervisor return invalid results +* * -EFAULT - Fail to copy back to userspace buffer +*/ +static int gzvm_vm_ioctl_get_pvmfw_size (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +struct arm_smccc_res res = {0 }; + +if (gzvm_vm_arch_enable_cap (gzvm, cap, &res) !=0 ) +return -EINVAL ; + + cap->args[1 ] = res.a1; +if (copy_to_user (argp, cap,sizeof (*cap))) +return -EFAULT ; + +return 0 ; +} + +/** +* gzvm_vm_ioctl_cap_pvm() - Proceed GZVM_CAP_ARM_PROTECTED_VM's subcommands +* @gzvm: Pointer to struct gzvm. +* @cap: Pointer to struct gzvm_enable_cap. +* @argp: Pointer to struct gzvm_enable_cap in user space. +*
arch/arm64/geniezone/vm.c line 154
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+* Return: +* * 0 - Succeed +* * -EINVAL - Invalid subcommand or arguments +*/ +static int gzvm_vm_ioctl_cap_pvm (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ; +struct arm_smccc_res res = {0 };
Invert for readability; struct arm_smccc_res res first, ret last... also, you don't need to initialize ret to -EINVAL, because:
arch/arm64/geniezone/vm.c line 160
Quoted 6 lines
arch/arm64/geniezone/vm.c new file +6
-0+ +switch (cap->args[0 ]) { +case GZVM_CAP_ARM_PVM_SET_PVMFW_IPA : + fallthrough; +case GZVM_CAP_ARM_PVM_SET_PROTECTED_VM : + ret =gzvm_vm_arch_enable_cap (gzvm, cap, &res);
return ret;
arch/arm64/geniezone/vm.c line 163
Quoted 3 lines
arch/arm64/geniezone/vm.c new file +3
-0+break ; +case GZVM_CAP_ARM_PVM_GET_PVMFW_SIZE : + ret =gzvm_vm_ioctl_get_pvmfw_size (gzvm, cap, argp);
return ret;
arch/arm64/geniezone/vm.c line 165
Quoted 2 lines
arch/arm64/geniezone/vm.c new file +2
-0+break ; +default :
just break here
arch/arm64/geniezone/vm.c line 169
Quoted 4 lines
arch/arm64/geniezone/vm.c new file +4
-0+ ret = -EINVAL ; +break ; + } +
return -EINVAL;
arch/arm64/geniezone/vm.c line 177
Quoted 8 lines
arch/arm64/geniezone/vm.c new file +8
-0+return ret; +} + +int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm, +struct gzvm_enable_cap *cap, +void __user *argp) +{ +int ret = -EINVAL ;
same comments here
Quoted 13 lines
arch/arm64/geniezone/vm.c new file +13
-0+ +switch (cap->cap) { +case GZVM_CAP_ARM_PROTECTED_VM : + ret =gzvm_vm_ioctl_cap_pvm (gzvm, cap, argp); +break ; +default : + ret = -EINVAL ; +break ; + } + +return ret; +} +
arch/arm64/geniezone/vm.c line 200
Quoted 10 lines
arch/arm64/geniezone/vm.c new file +10
-0+/** +* gzvm_hva_to_pa_arch() - converts hva to pa with arch-specific way +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +u64 gzvm_hva_to_pa_arch (u64 hva) +{ +u64 par; +unsigned long flags;
unsigned long flags;
u64 par;
Quoted 12 lines
arch/arm64/geniezone/vm.c new file +12
-0+ +local_irq_save (flags); + asmvolatile ("at s1e1r, %0" ::"r" (hva)); +isb (); + par =read_sysreg_par (); +local_irq_restore (flags); + +if (par &SYS_PAR_EL1_F ) +return 0 ; + +return par &PAR_PA47_MASK ; +}
..snip..
Quoted 22 lines
drivers/virt/geniezone/gzvm_main.c new file +16
-0@@ -0,0 +1,143 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/device.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/miscdevice.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> +
..snip..
drivers/virt/geniezone/gzvm_main.c line 71
Quoted 5 lines
drivers/virt/geniezone/gzvm_main.c new file +5
-0+ +static long gzvm_dev_ioctl (struct file *filp,unsigned int cmd, +unsigned long user_args) +{ +long ret = -ENOTTY ;
long ret;
drivers/virt/geniezone/gzvm_main.c line 75
Quoted 4 lines
drivers/virt/geniezone/gzvm_main.c new file +4
-0+ +switch (cmd) { +case GZVM_CREATE_VM : + ret =gzvm_dev_ioctl_create_vm (user_args);
you may even do just
return gzvm_dev_ioctl_create_vm(user_args);
drivers/virt/geniezone/gzvm_main.c line 80
Quoted 5 lines
drivers/virt/geniezone/gzvm_main.c new file +5
-0+break ; +case GZVM_CHECK_EXTENSION : +if (!user_args) +return -EINVAL ; + ret =gzvm_dev_ioctl_check_extension (NULL , user_args);
return ....
drivers/virt/geniezone/gzvm_main.c
Quoted 2 lines
drivers/virt/geniezone/gzvm_main.c new file +2
-0+break ; +default :
break...
drivers/virt/geniezone/gzvm_main.c
Quoted 2 lines
drivers/virt/geniezone/gzvm_main.c new file +2
-0+ ret = -ENOTTY ; + }
...return
Quoted 30 lines
drivers/virt/geniezone/gzvm_main.c new file +30
-0+ +return ret; +} + +static const struct file_operations gzvm_chardev_ops = { + .unlocked_ioctl = gzvm_dev_ioctl, + .llseek = noop_llseek, +}; + +static struct miscdevice gzvm_dev = { + .minor =MISC_DYNAMIC_MINOR , + .name =KBUILD_MODNAME , + .fops = &gzvm_chardev_ops, +}; + +static int gzvm_drv_probe (struct platform_device *pdev) +{ +int ret; + +if (gzvm_arch_probe () !=0 ) { +dev_err (&pdev->dev,"Not found available conduit\n" ); +return -ENODEV ; + } + + ret =misc_register (&gzvm_dev); +if (ret) +return ret; + +return 0 ; +}
drivers/virt/geniezone/gzvm_main.c line 124
Quoted 10 lines
drivers/virt/geniezone/gzvm_main.c new file +10
-0+ +static int gzvm_drv_remove (struct platform_device *pdev) +{ +gzvm_destroy_all_vms (); +misc_deregister (&gzvm_dev); +return 0 ; +} + +static const struct of_device_id gzvm_of_match[] = { + { .compatible ="mediatek,geniezone-hyp" , },
Remove the comma after "mediatek,geniezone-hyp" as it's not needed.
Quoted 42 lines
drivers/virt/geniezone/gzvm_main.c new file +19
-0+ {/* sentinel */}, +}; + +static struct platform_driver gzvm_driver = { + .probe = gzvm_drv_probe, + .remove = gzvm_drv_remove, + .driver = { + .name =KBUILD_MODNAME , + .owner =THIS_MODULE , + .of_match_table = gzvm_of_match, + }, +}; + +module_platform_driver (gzvm_driver); + +MODULE_DEVICE_TABLE (of, gzvm_of_match); +MODULE_AUTHOR ("MediaTek" ); +MODULE_DESCRIPTION ("GenieZone interface for VMM" ); +MODULE_LICENSE ("GPL" );drivers/virt/geniezone/gzvm_vm.c new file +17
-0@@ -0,0 +1,400 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/anon_inodes.h> +#include <linux/file.h> +#include <linux/kdev_t.h> +#include <linux/mm.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/slab.h> +#include <linux/gzvm_drv.h> + +static DEFINE_MUTEX (gzvm_list_lock); +static LIST_HEAD (gzvm_list); +
drivers/virt/geniezone/gzvm_vm.c line 27
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+/** +* hva_to_pa_fast() - converts hva to pa in generic fast way +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_fast (u64 hva) +{ +struct page *page[1 ]; +
Remove extra blank line
drivers/virt/geniezone/gzvm_vm.c line 33
Quoted 6 lines
drivers/virt/geniezone/gzvm_vm.c new file +6
-0+u64 pfn; + +if (get_user_page_fast_only (hva,0 , page)) { + pfn =page_to_phys (page[0 ]); +put_page ((struct page *)page); +return pfn;
why the else branch? just do...
if (get_user_page_fast_only(.....)) {
do_something; return pfn;
}
return 0;
}drivers/virt/geniezone/gzvm_vm.c line 40
Quoted 7 lines
drivers/virt/geniezone/gzvm_vm.c new file +7
-0+ }else { +return 0 ; + } +} + +/** +* hva_to_pa_slow() - note that this function may sleep
/**
* hva_to_pa_slow() - converts hva to pa in a slow way
* @hva: Host virtual address
*
* This function converts HVA to PA in a slow way (because......) *
* Context: This function may sleep
* Return: PA or 0 for translation error
*/
Quoted 20 lines
drivers/virt/geniezone/gzvm_vm.c new file +20
-0+* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +static u64 hva_to_pa_slow (u64 hva) +{ +struct page *page; +int npages; +u64 pfn; + + npages =get_user_pages_unlocked (hva,1 , &page,0 ); +if (npages !=1 ) +return 0 ; + + pfn =page_to_phys (page); +put_page (page); + +return pfn; +} +
..snip..
drivers/virt/geniezone/gzvm_vm.c line 173
Quoted 2 lines
drivers/virt/geniezone/gzvm_vm.c new file +2
-0+ +/* register_memslot_addr_range() - Register memory region to GZ */
/**
* register_memslot_addr_range() - Register memory region to GenieZone
* @gzvm: xxxx
* @memslot: xxxx
*
* Return: something
*/
drivers/virt/geniezone/gzvm_vm.c line 178
Quoted 5 lines
drivers/virt/geniezone/gzvm_vm.c new file +5
-0+static int +register_memslot_addr_range (struct gzvm *gzvm,struct gzvm_memslot *memslot) +{ +struct gzvm_memory_region_ranges *region; +u32 buf_size;
u32 buf_size = PAGE_SIZE * 2;
Quoted 6 lines
drivers/virt/geniezone/gzvm_vm.c new file +6
-0+int max_nr_consti, remain_pages; +u64 gfn, gfn_end; + + buf_size =PAGE_SIZE *2 ; + region =alloc_pages_exact (buf_size,GFP_KERNEL ); +if (!region)
drivers/virt/geniezone/gzvm_vm.c line 194
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+return -ENOMEM ; + max_nr_consti = (buf_size -sizeof (*region)) / +sizeof (struct mem_region_addr_range ); + + region->slot = memslot->slot_id; + remain_pages = memslot->npages; + gfn = memslot->base_gfn; + gfn_end = gfn + remain_pages; +while (gfn < gfn_end) { +int nr_pages;
int nr_pages = fill_constituents(...)
Quoted 23 lines
drivers/virt/geniezone/gzvm_vm.c new file +23
-0+ + nr_pages =fill_constituents (region->constituents, + ®ion->constituent_cnt, + max_nr_consti, gfn, + remain_pages, memslot); +if (nr_pages <0 ) { +pr_err ("Failed to fill constituents\n" ); +free_pages_exact (region, buf_size); +return nr_pages; + } + region->gpa =PFN_PHYS (gfn); + region->total_pages = nr_pages; + + remain_pages -= nr_pages; + gfn += nr_pages; + +if (gzvm_arch_set_memregion (gzvm->vm_id, buf_size, +virt_to_phys (region))) { +pr_err ("Failed to register memregion to hypervisor\n" ); +free_pages_exact (region, buf_size); +return -EFAULT ; + } + }
drivers/virt/geniezone/gzvm_vm.c line 227
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+free_pages_exact (region, buf_size); +return 0 ; +} + +/** +* gzvm_vm_ioctl_set_memory_region() - Set memory region of guest +* @gzvm: Pointer to struct gzvm. +* @mem: Input memory region from user. +* +* Return:
* Return: 0 for success, negative number for error *
* -EXIO - The memslot is out-of-range * -EFAULT - Cannot find corresponding vma * -EINVAL - Region size and VMA size mismatch
*/
Quoted 25 lines
+ * *
-EXIO- memslot is out-of-range
+ * *-EFAULT- Cannot find corresponding vma
+ * *-EINVAL- region size and vma size does not match
+ */drivers/virt/geniezone/gzvm_vm.c new file +21
-0+static int +gzvm_vm_ioctl_set_memory_region (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem) +{ +struct vm_area_struct *vma; +struct gzvm_memslot *memslot; +unsigned long size; +__u32 slot; + + slot = mem->slot; +if (slot >=GZVM_MAX_MEM_REGION ) +return -ENXIO ; + memslot = &gzvm->memslot[slot]; + + vma =vma_lookup (gzvm->mm, mem->userspace_addr); +if (!vma) +return -EFAULT ; + + size = vma->vm_end - vma->vm_start; +if (size != mem->memory_size) +return -EINVAL ;
drivers/virt/geniezone/gzvm_vm.c line 262
Quoted 10 lines
drivers/virt/geniezone/gzvm_vm.c new file +10
-0+ + memslot->base_gfn =__phys_to_pfn (mem->guest_phys_addr); + memslot->npages = size >>PAGE_SHIFT ; + memslot->userspace_addr = mem->userspace_addr; + memslot->vma = vma; + memslot->flags = mem->flags; + memslot->slot_id = mem->slot; +return register_memslot_addr_range (gzvm, memslot); +} +
There are other instances of the same for all comments in this review, so fix accordingly everywhere else.
Regards,
Angelo
PATCH v5 4/12 virt: geniezone: Add vcpu support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and this fd will be for any vcpu operations, such as setting vcpu registers and accepts the most important ioctl GZVM_VCPU_RUN which requests GenieZone hypervisor to do context switch to execute VM's vcpu context.
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 20 ++ arch/arm64/geniezone/vcpu.c | 88 +++++++++ arch/arm64/geniezone/vm.c | 11 ++ arch/arm64/include/uapi/asm/gzvm_arch.h | 30 +++ drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_vcpu.c | 250 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vm.c | 5 + include/linux/gzvm_drv.h | 21 ++ include/uapi/linux/gzvm.h | 136 +++++++++++++ 10 files changed, 564 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o +gzvm-y += vm.o vcpu.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/gzvm_arch_common.h +20 -0
@@ -21,6 +21,7 @@ enum {GZVM_FUNC_CREATE_DEVICE =11 ,GZVM_FUNC_PROBE =12 ,GZVM_FUNC_ENABLE_CAP =13 , +GZVM_FUNC_INFORM_EXIT =14 , NR_GZVM_FUNC, };
@@ -42,6 +43,7 @@ enum {#define MT_HVC_GZVM_CREATE_DEVICE GZVM_HCALL_ID(GZVM_FUNC_CREATE_DEVICE)#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP) +#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls
@@ -65,4 +67,22 @@ static inline u16 get_vmid_from_tuple(unsigned int tuple) return (u16)(tuple >> 16); } +static inline u16 get_vcpuid_from_tuple (unsigned int tuple) +{ +return (u16)(tuple &0xffff ); +} + +static inline unsigned int +assemble_vm_vcpu_tuple (u16 vmid,u16 vcpuid) +{ +return ((unsigned int )vmid <<16 | vcpuid); +} + +static inline void +disassemble_vm_vcpu_tuple (unsigned int tuple,u16 *vmid,u16 *vcpuid) +{ + *vmid =get_vmid_from_tuple (tuple); + *vcpuid =get_vcpuid_from_tuple (tuple); +} +#endif /* __GZVM_ARCH_COMMON_H__ */
arch/arm64/geniezone/vcpu.c new file +88 -0
88 lines not on this page · raw message
arch/arm64/geniezone/vm.c +11 -0
@@ -14,6 +14,17 @@#define PAR_PA47_MASK ((((1UL << 48) - 1) >> 12) << 12) +int gzvm_arch_inform_exit (u16 vm_id) +{ +struct arm_smccc_res res; + +arm_smccc_hvc (MT_HVC_GZVM_INFORM_EXIT , vm_id,0 ,0 ,0 ,0 ,0 ,0 , &res); +if (res.a0 ==0 ) +return 0 ; + +return -ENXIO ; +} +int gzvm_arch_probe (void ) {struct arm_smccc_res res;
arch/arm64/include/uapi/asm/gzvm_arch.h +30 -0
@@ -17,4 +17,34 @@/* GZVM_CAP_ARM_PVM_SET_PROTECTED_VM only sets protected but not load pvmfw */ #define GZVM_CAP_ARM_PVM_SET_PROTECTED_VM 2 +/* +* Architecture specific registers are to be defined in arch headers and +* ORed with the arch identifier. +*/ +#define GZVM_REG_ARM 0x4000000000000000ULL +#define GZVM_REG_ARM64 0x6000000000000000ULL + +#define GZVM_REG_SIZE_SHIFT 52 +#define GZVM_REG_SIZE_MASK 0x00f0000000000000ULL +#define GZVM_REG_SIZE_U8 0x0000000000000000ULL +#define GZVM_REG_SIZE_U16 0x0010000000000000ULL +#define GZVM_REG_SIZE_U32 0x0020000000000000ULL +#define GZVM_REG_SIZE_U64 0x0030000000000000ULL +#define GZVM_REG_SIZE_U128 0x0040000000000000ULL +#define GZVM_REG_SIZE_U256 0x0050000000000000ULL +#define GZVM_REG_SIZE_U512 0x0060000000000000ULL +#define GZVM_REG_SIZE_U1024 0x0070000000000000ULL +#define GZVM_REG_SIZE_U2048 0x0080000000000000ULL + +#define GZVM_REG_ARCH_MASK 0xff00000000000000ULL + +/* If you need to interpret the index values, here is the key: */ +#define GZVM_REG_ARM_COPROC_MASK 0x000000000FFF0000 +#define GZVM_REG_ARM_COPROC_SHIFT 16 + +/* Normal registers are mapped as coprocessor 16. */ +#define GZVM_REG_ARM_CORE (0x0010 << GZVM_REG_ARM_COPROC_SHIFT) +#define GZVM_REG_ARM_CORE_REG (name) \ + (offsetof(struct gzvm_regs, name) / sizeof(__u32)) +#endif /* __GZVM_ARCH_H__ */
drivers/virt/geniezone/Makefile +2 -1
@@ -6,5 +6,6 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone -gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o +gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ + $(GZVM_DIR)/gzvm_vcpu.o
drivers/virt/geniezone/gzvm_vcpu.c new file +250 -0
250 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vm.c +5 -0
@@ -280,6 +280,10 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_dev_ioctl_check_extension (gzvm, arg);break ; } +case GZVM_CREATE_VCPU : { + ret =gzvm_vm_ioctl_create_vcpu (gzvm, arg); +break ; + }case GZVM_SET_USER_MEMORY_REGION : {struct gzvm_userspace_memory_region userspace_mem;
@@ -313,6 +317,7 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_lock (&gzvm->lock); +gzvm_destroy_vcpus (gzvm);gzvm_arch_destroy_vm (gzvm->vm_id);mutex_lock (&gzvm_list_lock);
include/linux/gzvm_drv.h +21 -0
@@ -31,6 +31,8 @@#define GZVM_MAX_VCPUS 8#define GZVM_MAX_MEM_REGION 10 +#define GZVM_VCPU_RUN_MAP_SIZE (PAGE_SIZE * 2) +/* struct mem_region_addr_range - Identical to ffa memory constituent */ struct mem_region_addr_range {/* the base IPA of the constituent memory region, aligned to 4 kiB */
@@ -58,7 +60,16 @@ struct gzvm_memslot {u32 slot_id; }; +struct gzvm_vcpu { +struct gzvm *gzvm; +int vcpuid; +/* lock of vcpu*/ +struct mutex lock; +struct gzvm_vcpu_run *run; +}; +struct gzvm { +struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */ struct mm_struct *mm;struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ];
@@ -75,6 +86,8 @@ int gzvm_err_to_errno(unsigned long err);void gzvm_destroy_all_vms (void ); +void gzvm_destroy_vcpus (struct gzvm *gzvm); +/* arch-dependant functions */ int gzvm_arch_probe (void ); int gzvm_arch_set_memregion(u16 vm_id, size_t buf_size,
@@ -85,6 +98,14 @@ int gzvm_arch_destroy_vm(u16 vm_id);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp); +u64 gzvm_hva_to_pa_arch (u64 hva); +int gzvm_vm_ioctl_create_vcpu (struct gzvm *gzvm,u32 cpuid); +int gzvm_arch_vcpu_update_one_reg (struct gzvm_vcpu *vcpu,__u64 reg_id, +bool is_write,__u64 *data); +int gzvm_arch_create_vcpu (u16 vm_id,int vcpuid,void *run); +int gzvm_arch_vcpu_run (struct gzvm_vcpu *vcpu,__u64 *exit_reason); +int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid); +int gzvm_arch_inform_exit (u16 vm_id);#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +136 -0
152 lines not on this page · raw message
Signature · 1 line
2.18.0
Rob Herring
maintainerRe: [PATCH v5 04/12] virt: geniezone: Add vcpu support
Quoted 11 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and this fd will be for any vcpu operations, such as setting vcpu registers and accepts the most important ioctl
GZVM_VCPU_RUNwhich requests GenieZone hypervisor to do context switch to execute VM's vcpu context.Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>
Quoted 6 lines
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 20 ++ arch/arm64/geniezone/vcpu.c | 88 +++++++++ arch/arm64/geniezone/vm.c | 11 ++ arch/arm64/include/uapi/asm/gzvm_arch.h | 30 +++
I'm almost certain that the arm64 maintainers will reject putting this here. What is the purpose of the split with drivers/virt/? Do you plan to support another arch in the near future?
Yes, there's KVM stuff in arch/arm64, but that is multi-arch.
Quoted 8 lines
drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_vcpu.c | 250 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vm.c | 5 + include/linux/gzvm_drv.h | 21 ++ include/uapi/linux/gzvm.h | 136 +++++++++++++ 10 files changed, 564 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c
Will Deacon
maintainerRe: [PATCH v5 04/12] virt: geniezone: Add vcpu support
Quoted 19 lines · Rob Herring
Quoted 11 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and this fd will be for any vcpu operations, such as setting vcpu registers and accepts the most important ioctl
GZVM_VCPU_RUNwhich requests GenieZone hypervisor to do context switch to execute VM's vcpu context.Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>Quoted 6 lines
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 20 ++ arch/arm64/geniezone/vcpu.c | 88 +++++++++ arch/arm64/geniezone/vm.c | 11 ++ arch/arm64/include/uapi/asm/gzvm_arch.h | 30 +++
Quoted 3 lines
I'm almost certain that the arm64 maintainers will reject putting this here. What is the purpose of the split with
drivers/virt/? Do you plan to support another arch in the near future?
Thanks, Rob. You're absolutely right that this doesn't belong in the architecture code.
Will
Re: [PATCH v5 04/12] virt: geniezone: Add vcpu support
In reply to Rob HerringQuoted 25 lines · Rob Herring
External email : Please do not click links or open attachments until you have verified the sender or the content.
Quoted 3 lines · Yi-De Wu
From: "Yingshiuan Pan" <[email protected]>
VMM use this interface to create vcpu instance which is a fd, and
this
Quoted 1 line
fd will be for any vcpu operations, such as setting vcpu registers
and
Quoted 1 line
accepts the most important ioctl
GZVM_VCPU_RUNwhich requestsGenieZone
Quoted 6 lines
hypervisor to do context switch to execute VM's vcpu context.
Signed-off-by Yingshiuan Pan <[email protected]>Signed-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>Quoted 6 lines
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/gzvm_arch_common.h | 20 ++ arch/arm64/geniezone/vcpu.c | 88 +++++++++ arch/arm64/geniezone/vm.c | 11 ++ arch/arm64/include/uapi/asm/gzvm_arch.h | 30 +++
Quoted 8 lines
I'm almost certain that the arm64 maintainers will reject putting this
here. What is the purpose of the split withdrivers/virt/? Do you plan
to support another arch in the near future?Yes, there's KVM stuff in
arch/arm64, but that is multi-arch.
hi Rob,
Thank you for the review, and the confirmation from Will was well received.
To be more specific, are you suggesting to
- remove the gzvm_arch.h
from UAPI or
- remove all the code under arch/arm64/geniezone to somewhere like drivers/virt/geniezone/arch, or
- both?
Regards,
Quoted 9 lines
Quoted 2 lines
drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_vcpu.c | 250++++++++++++++++++++++++
Quoted 6 lines
drivers/virt/geniezone/gzvm_vm.c | 5 + include/linux/gzvm_drv.h | 21 ++ include/uapi/linux/gzvm.h | 136 +++++++++++++ 10 files changed, 564 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/geniezone/vcpu.c create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c
PATCH v5 5/12 virt: geniezone: Add irqchip support for virtual interrupt injection
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Enable GenieZone to handle virtual interrupt injection request.
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/vgic.c | 108 ++++++++++++++++++++++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 4 + drivers/virt/geniezone/gzvm_common.h | 12 +++ drivers/virt/geniezone/gzvm_vm.c | 82 ++++++++++++++++++ include/linux/gzvm_drv.h | 4 + include/uapi/linux/gzvm.h | 66 +++++++++++++++ 7 files changed, 277 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/geniezone/vgic.c create mode 100644 drivers/virt/geniezone/gzvm_common.h
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o vcpu.o +gzvm-y += vm.o vcpu.o vgic.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/vgic.c new file +108 -0
108 lines not on this page · raw message
arch/arm64/include/uapi/asm/gzvm_arch.h +4 -0
@@ -47,4 +47,8 @@#define GZVM_REG_ARM_CORE_REG (name) \ (offsetof(struct gzvm_regs, name) / sizeof(__u32)) +#define GZVM_VGIC_NR_SGIS 16 +#define GZVM_VGIC_NR_PPIS 16 +#define GZVM_VGIC_NR_PRIVATE_IRQS (GZVM_VGIC_NR_SGIS + GZVM_VGIC_NR_PPIS) +#endif /* __GZVM_ARCH_H__ */
drivers/virt/geniezone/gzvm_common.h new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#ifndef __GZ_COMMON_H__ +#define __GZ_COMMON_H__ + +int gzvm_irqchip_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq_type,u32 irq,bool level); + +#endif /* __GZVM_COMMON_H__ */
drivers/virt/geniezone/gzvm_vm.c +82 -0
100 lines not on this page · raw message
include/linux/gzvm_drv.h +4 -0
@@ -108,4 +108,8 @@ int gzvm_arch_vcpu_run(struct gzvm_vcpu *vcpu, __u64 *exit_reason);int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid);int gzvm_arch_inform_exit (u16 vm_id); +int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); +int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq_type,u32 irq,bool level); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +66 -0
72 lines not on this page · raw message
Signature · 1 line
2.18.0
PATCH v5 6/12 virt: geniezone: Add irqfd support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
irqfd enables other threads than vcpu threads to inject virtual interrupt through irqfd asynchronously rather through ioctl interface. This interface is necessary for VMM which creates separated thread for IO handling or uses vhost devices.
--- arch/arm64/geniezone/gzvm_arch_common.h | 18 + drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_irqfd.c | 566 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 4 + drivers/virt/geniezone/gzvm_vcpu.c | 1 + drivers/virt/geniezone/gzvm_vm.c | 18 + include/linux/gzvm_drv.h | 26 ++ include/uapi/linux/gzvm.h | 26 ++ 8 files changed, 660 insertions(+), 2 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_irqfd.c
arch/arm64/geniezone/gzvm_arch_common.h +18 -0
@@ -45,6 +45,8 @@ enum {#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT) +#define GIC_V3_NR_LRS 16 +/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls * @a0-a7: arguments passed in registers 0 to 7
@@ -72,6 +74,22 @@ static inline u16 get_vcpuid_from_tuple(unsigned int tuple)return (u16)(tuple &0xffff ); } +/** +* struct gzvm_vcpu_hwstate: Sync architecture state back to host for handling +* @nr_lrs: The available LRs(list registers) in Soc. +* @__pad: add an explicit '__u32 __pad;' in the middle to make it clear +* what the actual layout is. +* @lr: The array of LRs(list registers). +* +* - Keep the same layout of hypervisor data struct. +* - Sync list registers back for acking virtual device interrupt status. +*/ +struct gzvm_vcpu_hwstate { +__le32 nr_lrs; +__le32 __pad; +__le64 lr[GIC_V3_NR_LRS ]; +}; +static inline unsigned int assemble_vm_vcpu_tuple (u16 vmid,u16 vcpuid) {
drivers/virt/geniezone/Makefile +1 -2
@@ -7,5 +7,4 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ - $(GZVM_DIR)/gzvm_vcpu.o - + $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o
drivers/virt/geniezone/gzvm_irqfd.c new file +566 -0
566 lines not on this page · raw message
drivers/virt/geniezone/gzvm_main.c +4 -0
@@ -110,11 +110,15 @@ static int gzvm_drv_probe(struct platform_device *pdev)if (ret)return ret; + ret =gzvm_drv_irqfd_init (); +if (ret) +return ret;return 0 ; }static int gzvm_drv_remove (struct platform_device *pdev) { +gzvm_drv_irqfd_exit ();gzvm_destroy_all_vms ();misc_deregister (&gzvm_dev);return 0 ;
drivers/virt/geniezone/gzvm_vcpu.c +1 -0
@@ -227,6 +227,7 @@ int gzvm_vm_ioctl_create_vcpu(struct gzvm *gzvm, u32 cpuid) ret = -ENOMEM ; goto free_vcpu; } + vcpu->hwstate = (void *)vcpu->run +PAGE_SIZE ; vcpu->vcpuid = cpuid; vcpu->gzvm = gzvm;mutex_init (&vcpu->lock);
drivers/virt/geniezone/gzvm_vm.c +18 -0
@@ -376,6 +376,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_vm_ioctl_create_device (gzvm, argp);break ; } +case GZVM_IRQFD : { +struct gzvm_irqfd data; + +if (copy_from_user (&data, argp,sizeof (data))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_irqfd (gzvm, &data); +break ; + }case GZVM_ENABLE_CAP : {struct gzvm_enable_cap cap;
@@ -399,6 +409,7 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_lock (&gzvm->lock); +gzvm_vm_irqfd_release (gzvm);gzvm_destroy_vcpus (gzvm);gzvm_arch_destroy_vm (gzvm->vm_id);
@@ -444,6 +455,13 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type) gzvm->mm = current->mm;mutex_init (&gzvm->lock); + ret =gzvm_vm_irqfd_init (gzvm); +if (ret) { +pr_err ("Failed to initialize irqfd\n" ); +kfree (gzvm); +return ERR_PTR (ret); + } +mutex_lock (&gzvm_list_lock);list_add (&gzvm->vm_list, &gzvm_list);mutex_unlock (&gzvm_list_lock);
include/linux/gzvm_drv.h +26 -0
@@ -9,6 +9,7 @@#include <linux/list.h> #include <linux/mutex.h> #include <linux/gzvm.h> +#include <linux/srcu.h> #define GZVM_VCPU_MMAP_SIZE PAGE_SIZE#define INVALID_VM_ID 0xffff
@@ -23,6 +24,8 @@#define ERR_NOT_SUPPORTED (-24)#define ERR_NOT_IMPLEMENTED (-27)#define ERR_FAULT (-40) +#define GZVM_USERSPACE_IRQ_SOURCE_ID 0 +#define GZVM_IRQFD_RESAMPLE_IRQ_SOURCE_ID 1/* * The following data structures are for data transferring between driver and
@@ -66,6 +69,7 @@ struct gzvm_vcpu {/* lock of vcpu*/ struct mutex lock;struct gzvm_vcpu_run *run; +struct gzvm_vcpu_hwstate *hwstate; };struct gzvm {
@@ -75,8 +79,23 @@ struct gzvm {struct gzvm_memslot memslot[GZVM_MAX_MEM_REGION ];/* lock for list_add*/ struct mutex lock; + +struct { +/* lock for irqfds list operation */ +spinlock_t lock; +struct list_head items; +struct list_head resampler_list; +/* lock for irqfds resampler */ +struct mutex resampler_lock; + } irqfds; +struct list_head vm_list;u16 vm_id; + +struct hlist_head irq_ack_notifier_list; +struct srcu_struct irq_srcu; +/* lock for irq injection */ +struct mutex irq_lock; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
@@ -112,4 +131,11 @@ int gzvm_arch_create_device(u16 vm_id, struct gzvm_create_device *gzvm_dev);int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx,u32 irq_type,u32 irq,bool level); +void gzvm_notify_acked_irq (struct gzvm *gzvm,unsigned int gsi); +int gzvm_irqfd (struct gzvm *gzvm,struct gzvm_irqfd *args); +int gzvm_drv_irqfd_init (void ); +void gzvm_drv_irqfd_exit (void ); +int gzvm_vm_irqfd_init (struct gzvm *gzvm); +void gzvm_vm_irqfd_release (struct gzvm *gzvm); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +26 -0
@@ -275,4 +275,30 @@ struct gzvm_one_reg {#define GZVM_REG_GENERIC 0x0000000000000000ULL +#define GZVM_IRQFD_FLAG_DEASSIGN BIT(0) +/* +* GZVM_IRQFD_FLAG_RESAMPLE indicates resamplefd is valid and specifies +* the irqfd to operate in resampling mode for level triggered interrupt +* emulation. +*/ +#define GZVM_IRQFD_FLAG_RESAMPLE BIT(1) + +/** +* struct gzvm_irqfd: gzvm irqfd descriptor +* @fd: File descriptor. +* @gsi: Used for level IRQ fast-path. +* @flags: FLAG_DEASSIGN or FLAG_RESAMPLE. +* @resamplefd: The file descriptor of the resampler. +* @pad: Reserved for future-proof. +*/ +struct gzvm_irqfd { +__u32 fd; +__u32 gsi; +__u32 flags; +__u32 resamplefd; +__u8 pad[16 ]; +}; + +#define GZVM_IRQFD _IOW(GZVM_IOC_MAGIC, 0x76, struct gzvm_irqfd) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v5 7/12 virt: geniezone: Add ioeventfd support
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
Ioeventfd leverages eventfd to provide asynchronous notification mechanism for VMM. VMM can register a mmio address and bind with an eventfd. Once a mmio trap occurs on this registered region, its corresponding eventfd will be notified.
--- drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_ioeventfd.c | 273 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 27 ++- drivers/virt/geniezone/gzvm_vm.c | 17 ++ include/linux/gzvm_drv.h | 12 ++ include/uapi/linux/gzvm.h | 25 +++ 6 files changed, 355 insertions(+), 2 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_ioeventfd.c
drivers/virt/geniezone/Makefile +2 -1
@@ -7,4 +7,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ - $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o + $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o \ + $(GZVM_DIR)/gzvm_ioeventfd.o
drivers/virt/geniezone/gzvm_ioeventfd.c new file +273 -0
273 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vcpu.c +26 -1
@@ -50,6 +50,30 @@ static long gzvm_vcpu_update_one_reg(struct gzvm_vcpu *vcpu,return 0 ; } +/** +* gzvm_vcpu_handle_mmio() - Handle mmio in kernel space. +* @vcpu: Pointer to vcpu. +* +* Return: +* * true - This mmio exit has been processed. +* * false - This mmio exit has not been processed, require userspace. +*/ +static bool gzvm_vcpu_handle_mmio (struct gzvm_vcpu *vcpu) +{ +__u64 addr; +__u32 len; +const void *val_ptr; + +/* So far, we don't have in-kernel mmio read handler */ +if (!vcpu->run->mmio.is_write) +return false; + addr = vcpu->run->mmio.phys_addr; + len = vcpu->run->mmio.size; + val_ptr = &vcpu->run->mmio.data; + +return gzvm_ioevent_write (vcpu, addr, len, val_ptr); +} +/** * gzvm_vcpu_run() - Handle vcpu run ioctl, entry point to guest and exit * point from guest
@@ -81,7 +105,8 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void * __user argp)switch (exit_reason) {case GZVM_EXIT_MMIO : - need_userspace = true; +if (!gzvm_vcpu_handle_mmio (vcpu)) + need_userspace = true;break ;/** * it's geniezone's responsibility to fill corresponding data
drivers/virt/geniezone/gzvm_vm.c +17 -0
@@ -386,6 +386,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_irqfd (gzvm, &data);break ; } +case GZVM_IOEVENTFD : { +struct gzvm_ioeventfd data; + +if (copy_from_user (&data, argp,sizeof (data))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_ioeventfd (gzvm, &data); +break ; + }case GZVM_ENABLE_CAP : {struct gzvm_enable_cap cap;
@@ -462,6 +472,13 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type)return ERR_PTR (ret); } + ret =gzvm_init_ioeventfd (gzvm); +if (ret) { +pr_err ("Failed to initialize ioeventfd\n" ); +kfree (gzvm); +return ERR_PTR (ret); + } +mutex_lock (&gzvm_list_lock);list_add (&gzvm->vm_list, &gzvm_list);mutex_unlock (&gzvm_list_lock);
include/linux/gzvm_drv.h +12 -0
@@ -6,6 +6,7 @@#ifndef __GZVM_DRV_H__#define __GZVM_DRV_H__ +#include <linux/eventfd.h> #include <linux/list.h> #include <linux/mutex.h> #include <linux/gzvm.h>
@@ -89,6 +90,8 @@ struct gzvm {struct mutex resampler_lock; } irqfds; +struct list_head ioevents; +struct list_head vm_list;u16 vm_id;
@@ -138,4 +141,13 @@ void gzvm_drv_irqfd_exit(void);int gzvm_vm_irqfd_init (struct gzvm *gzvm);void gzvm_vm_irqfd_release (struct gzvm *gzvm); +int gzvm_init_ioeventfd (struct gzvm *gzvm); +int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args); +bool gzvm_ioevent_write (struct gzvm_vcpu *vcpu,__u64 addr,int len, +const void *val); +void eventfd_ctx_do_read (struct eventfd_ctx *ctx,__u64 *cnt); +struct vm_area_struct *vma_lookup (struct mm_struct *mm,unsigned long addr); +void add_wait_queue_priority (struct wait_queue_head *wq_head, +struct wait_queue_entry *wq_entry); +#endif /* __GZVM_DRV_H__ */
include/uapi/linux/gzvm.h +25 -0
@@ -301,4 +301,29 @@ struct gzvm_irqfd {#define GZVM_IRQFD _IOW(GZVM_IOC_MAGIC, 0x76, struct gzvm_irqfd) +enum { + gzvm_ioeventfd_flag_nr_datamatch =0 , + gzvm_ioeventfd_flag_nr_pio =1 , + gzvm_ioeventfd_flag_nr_deassign =2 , + gzvm_ioeventfd_flag_nr_max, +}; + +#define GZVM_IOEVENTFD_FLAG_DATAMATCH (1 << gzvm_ioeventfd_flag_nr_datamatch) +#define GZVM_IOEVENTFD_FLAG_PIO (1 << gzvm_ioeventfd_flag_nr_pio) +#define GZVM_IOEVENTFD_FLAG_DEASSIGN (1 << gzvm_ioeventfd_flag_nr_deassign) +#define GZVM_IOEVENTFD_VALID_FLAG_MASK ((1 << gzvm_ioeventfd_flag_nr_max) - 1) + +struct gzvm_ioeventfd { +__u64 datamatch; +/* private: legal pio/mmio address */ +__u64 addr; +/* private: 1, 2, 4, or 8 bytes; or 0 to ignore length */ +__u32 len; +__s32 fd; +__u32 flags; +__u8 pad[36 ]; +}; + +#define GZVM_IOEVENTFD _IOW(GZVM_IOC_MAGIC, 0x79, struct gzvm_ioeventfd) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v5 8/12 virt: geniezone: Add memory region support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Hypervisor might need to know the precise purpose of each memory region, so that it can provide specific memory protection. We add a new uapi to pass address and size of a memory region and its purpose.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 ++ arch/arm64/geniezone/vm.c | 10 ++++++++++ drivers/virt/geniezone/gzvm_vm.c | 7 +++++++ include/linux/gzvm_drv.h | 3 +++ 4 files changed, 22 insertions(+)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -22,6 +22,7 @@ enum {GZVM_FUNC_PROBE =12 ,GZVM_FUNC_ENABLE_CAP =13 ,GZVM_FUNC_INFORM_EXIT =14 , +GZVM_FUNC_MEMREGION_PURPOSE =15 , NR_GZVM_FUNC, };
@@ -44,6 +45,7 @@ enum {#define MT_HVC_GZVM_PROBE GZVM_HCALL_ID(GZVM_FUNC_PROBE)#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT) +#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +10 -0
@@ -109,6 +109,16 @@ int gzvm_arch_destroy_vm(u16 vm_id) 0, 0, &res); } +int gzvm_arch_memregion_purpose (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_MEMREGION_PURPOSE , gzvm->vm_id, + mem->guest_phys_addr, mem->memory_size, + mem->flags,0 ,0 ,0 , &res); +} +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,struct arm_smccc_res *res)
drivers/virt/geniezone/gzvm_vm.c +7 -0
@@ -234,6 +234,7 @@ static int gzvm_vm_ioctl_set_memory_region(struct gzvm *gzvm, struct gzvm_userspace_memory_region *mem) { + int ret;struct vm_area_struct *vma;struct gzvm_memslot *memslot;unsigned long size;
@@ -258,6 +259,12 @@ gzvm_vm_ioctl_set_memory_region(struct gzvm *gzvm, memslot->vma = vma; memslot->flags = mem->flags; memslot->slot_id = mem->slot; + + ret =gzvm_arch_memregion_purpose (gzvm, mem); +if (ret) { +pr_err ("Failed to config memory region for the specified purpose\n" ); +return -EFAULT ; + }return register_memslot_addr_range (gzvm, memslot); }
include/linux/gzvm_drv.h +3 -0
@@ -141,6 +141,9 @@ void gzvm_drv_irqfd_exit(void);int gzvm_vm_irqfd_init (struct gzvm *gzvm);void gzvm_vm_irqfd_release (struct gzvm *gzvm); +int gzvm_arch_memregion_purpose (struct gzvm *gzvm, +struct gzvm_userspace_memory_region *mem); +int gzvm_init_ioeventfd (struct gzvm *gzvm);int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args); bool gzvm_ioevent_write(struct gzvm_vcpu *vcpu, __u64 addr, int len,
Signature · 1 line
2.18.0
PATCH v5 9/12 virt: geniezone: Add dtb config support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Hypervisor might need to know the accurate address and size of dtb passed from userspace. And then hypervisor would parse the dtb and get vm information.
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 ++ arch/arm64/geniezone/vm.c | 9 +++++++++ drivers/virt/geniezone/gzvm_vm.c | 10 ++++++++++ include/linux/gzvm_drv.h | 1 + include/uapi/linux/gzvm.h | 14 ++++++++++++++ 5 files changed, 36 insertions(+)
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -23,6 +23,7 @@ enum {GZVM_FUNC_ENABLE_CAP =13 ,GZVM_FUNC_INFORM_EXIT =14 ,GZVM_FUNC_MEMREGION_PURPOSE =15 , +GZVM_FUNC_SET_DTB_CONFIG =16 , NR_GZVM_FUNC, };
@@ -46,6 +47,7 @@ enum {#define MT_HVC_GZVM_ENABLE_CAP GZVM_HCALL_ID(GZVM_FUNC_ENABLE_CAP)#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE) +#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +9 -0
@@ -119,6 +119,15 @@ int gzvm_arch_memregion_purpose(struct gzvm *gzvm, mem->flags, 0, 0, 0, &res); } +int gzvm_arch_set_dtb_config (struct gzvm *gzvm,struct gzvm_dtb_config *cfg) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_SET_DTB_CONFIG , gzvm->vm_id, + cfg->dtb_addr, cfg->dtb_size,0 ,0 ,0 ,0 , + &res); +} +static int gzvm_vm_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,struct arm_smccc_res *res)
drivers/virt/geniezone/gzvm_vm.c +10 -0
@@ -413,6 +413,16 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl, ret =gzvm_vm_ioctl_enable_cap (gzvm, &cap, argp);break ; } +case GZVM_SET_DTB_CONFIG : { +struct gzvm_dtb_config cfg; + +if (copy_from_user (&cfg, argp,sizeof (cfg))) { + ret = -EFAULT ; + goto out; + } + ret =gzvm_arch_set_dtb_config (gzvm, &cfg); +break ; + }default : ret = -ENOTTY ; }
include/linux/gzvm_drv.h +1 -0
@@ -143,6 +143,7 @@ void gzvm_vm_irqfd_release(struct gzvm *gzvm);int gzvm_arch_memregion_purpose (struct gzvm *gzvm,struct gzvm_userspace_memory_region *mem); +int gzvm_arch_set_dtb_config (struct gzvm *gzvm,struct gzvm_dtb_config *args);int gzvm_init_ioeventfd (struct gzvm *gzvm);int gzvm_ioeventfd (struct gzvm *gzvm,struct gzvm_ioeventfd *args);
include/uapi/linux/gzvm.h +14 -0
@@ -326,4 +326,18 @@ struct gzvm_ioeventfd {#define GZVM_IOEVENTFD _IOW(GZVM_IOC_MAGIC, 0x79, struct gzvm_ioeventfd) +/** +* struct gzvm_dtb_config: store address and size of dtb passed from userspace +* +* @dtb_addr: dtb address set by VMM (guset memory) +* @dtb_size: dtb size +*/ +struct gzvm_dtb_config { +__u64 dtb_addr; +__u64 dtb_size; +}; + +#define GZVM_SET_DTB_CONFIG _IOW(GZVM_IOC_MAGIC, 0xff, \ + struct gzvm_dtb_config) +#endif /* __GZVM_H__ */
Signature · 1 line
2.18.0
PATCH v5 10/12 virt: geniezone: Add virtual timer support
In reply to Yi-De WuFrom: "Willix Yeh" <[email protected]>
Implement vtimer migration handler.
- Using hrtimer for guest vtimer migration
- Identify migrate flag to do register hrtimer
--- arch/arm64/geniezone/Makefile | 2 +- arch/arm64/geniezone/driver.c | 26 ++++++++ arch/arm64/geniezone/gzvm_arch_common.h | 18 ++++++ arch/arm64/geniezone/vcpu.c | 83 ++++++++++++++++++++++--- arch/arm64/geniezone/vgic.c | 16 +++++ drivers/virt/geniezone/gzvm_main.c | 5 ++ drivers/virt/geniezone/gzvm_vcpu.c | 4 +- include/linux/gzvm_drv.h | 8 ++- 8 files changed, 149 insertions(+), 13 deletions(-) create mode 100644 arch/arm64/geniezone/driver.c
arch/arm64/geniezone/Makefile +1 -1
@@ -4,6 +4,6 @@ # include $(srctree)/drivers/virt/geniezone/Makefile -gzvm-y += vm.o vcpu.o vgic.o +gzvm-y += vm.o vcpu.o vgic.o driver.o obj-$(CONFIG_MTK_GZVM) += gzvm.o
arch/arm64/geniezone/driver.c new file +26 -0
@@ -0,0 +1,26 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/clocksource.h> +#include <linux/gzvm_drv.h> +#include "gzvm_arch_common.h" + +struct timecycle clock_scale_factor; + +int gzvm_arch_drv_init (void ) +{ +/* clock_scale_factor init mult shift */ +clocks_calc_mult_shift (&clock_scale_factor.mult, + &clock_scale_factor.shift, +arch_timer_get_cntfrq (), +NSEC_PER_SEC , +10 ); + +return 0 ; +} + +void gzvm_arch_drv_exit (void ) +{ +}
arch/arm64/geniezone/gzvm_arch_common.h +18 -0
@@ -51,6 +51,13 @@ enum {#define GIC_V3_NR_LRS 16 +struct timecycle { +u32 mult; +u32 shift; +}; + +extern struct timecycle clock_scale_factor; +/** * gzvm_hypcall_wrapper() - the wrapper for hvc calls * @a0-a7: arguments passed in registers 0 to 7
@@ -84,14 +91,22 @@ static inline u16 get_vcpuid_from_tuple(unsigned int tuple)* @__pad: add an explicit '__u32 __pad;' in the middle to make it clear * what the actual layout is. * @lr: The array of LRs(list registers). +* @vtimer_delay: The remaining time until the next tick of guest VM. +* @vtimer_migrate: The switch flag used for guest VM to do vtimer migration or not. +* @vtimer_irq_num: vtimer irq number. * * - Keep the same layout of hypervisor data struct. * - Sync list registers back for acking virtual device interrupt status. +* - Sync timer registers back for migrating timer to host's hwtimer to keep +* timer working in background. */ struct gzvm_vcpu_hwstate {__le32 nr_lrs;__le32 __pad;__le64 lr[GIC_V3_NR_LRS ]; +__le64 vtimer_delay; +__le32 vtimer_migrate; +__le32 vtimer_irq_num; }; static inline unsigned int
@@ -107,4 +122,7 @@ disassemble_vm_vcpu_tuple(unsigned int tuple, u16 *vmid, u16 *vcpuid) *vcpuid = get_vcpuid_from_tuple(tuple); } +int gzvm_vgic_inject_ppi (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq,bool level); +#endif /* __GZVM_ARCH_COMMON_H__ */
arch/arm64/geniezone/vcpu.c +75 -8
126 lines not on this page · raw message
arch/arm64/geniezone/vgic.c +16 -0
@@ -91,6 +91,22 @@ static int gzvm_vgic_inject_spi(struct gzvm *gzvm, unsigned int vcpu_idx, level); } +/** +* gzvm_vgic_inject_ppi() - Inject virtual ppi interrupt +* @gzvm: Pointer to struct gzvm +* @vcpu_idx: vcpu index +* @irq: This is spi interrupt number (starts from 0 instead of 32) +* @level: 1 if true else 0 +* +* Return: +* * 0 if succeed else other negative values indicating each errors +*/ +int gzvm_vgic_inject_ppi (struct gzvm *gzvm,unsigned int vcpu_idx, +u32 irq,bool level) +{ +return gzvm_vgic_inject_irq (gzvm,0 ,GZVM_IRQ_TYPE_PPI , irq, level); +} +int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev) {struct arm_smccc_res res;
drivers/virt/geniezone/gzvm_main.c +5 -0
@@ -106,6 +106,10 @@ static int gzvm_drv_probe(struct platform_device *pdev)return -ENODEV ; } + ret =gzvm_arch_drv_init (); +if (ret) +return ret; + ret =misc_register (&gzvm_dev);if (ret)return ret;
@@ -121,6 +125,7 @@ static int gzvm_drv_remove(struct platform_device *pdev)gzvm_drv_irqfd_exit ();gzvm_destroy_all_vms ();misc_deregister (&gzvm_dev); +gzvm_arch_drv_exit ();return 0 ; }
drivers/virt/geniezone/gzvm_vcpu.c +2 -2
@@ -188,7 +188,7 @@ static void gzvm_destroy_vcpu(struct gzvm_vcpu *vcpu)if (!vcpu)return ; -gzvm_arch_destroy_vcpu (vcpu->gzvm->vm_id, vcpu->vcpuid); +gzvm_arch_destroy_vcpu (vcpu);/* clean guest's data */ memset (vcpu->run,0 ,GZVM_VCPU_RUN_MAP_SIZE );free_pages_exact (vcpu->run,GZVM_VCPU_RUN_MAP_SIZE );
@@ -257,7 +257,7 @@ int gzvm_vm_ioctl_create_vcpu(struct gzvm *gzvm, u32 cpuid) vcpu->gzvm = gzvm;mutex_init (&vcpu->lock); - ret =gzvm_arch_create_vcpu (gzvm->vm_id, vcpu->vcpuid, vcpu->run); + ret =gzvm_arch_create_vcpu (vcpu);if (ret <0 ) goto free_vcpu_run;
include/linux/gzvm_drv.h +6 -2
@@ -6,6 +6,7 @@#ifndef __GZVM_DRV_H__#define __GZVM_DRV_H__ +#include <asm/arch_timer.h> #include <linux/eventfd.h> #include <linux/list.h> #include <linux/mutex.h>
@@ -71,6 +72,7 @@ struct gzvm_vcpu {struct mutex lock;struct gzvm_vcpu_run *run;struct gzvm_vcpu_hwstate *hwstate; +struct hrtimer gzvm_mtimer; };struct gzvm {
@@ -125,10 +127,12 @@ u64 gzvm_hva_to_pa_arch(u64 hva);int gzvm_vm_ioctl_create_vcpu (struct gzvm *gzvm,u32 cpuid);int gzvm_arch_vcpu_update_one_reg (struct gzvm_vcpu *vcpu,__u64 reg_id,bool is_write,__u64 *data); -int gzvm_arch_create_vcpu (u16 vm_id,int vcpuid,void *run); +int gzvm_arch_create_vcpu (struct gzvm_vcpu *vcpu);int gzvm_arch_vcpu_run (struct gzvm_vcpu *vcpu,__u64 *exit_reason); -int gzvm_arch_destroy_vcpu (u16 vm_id,int vcpuid); +int gzvm_arch_destroy_vcpu (struct gzvm_vcpu *vcpu);int gzvm_arch_inform_exit (u16 vm_id); +int gzvm_arch_drv_init (void ); +void gzvm_arch_drv_exit (void );int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); int gzvm_arch_inject_irq(struct gzvm *gzvm, unsigned int vcpu_idx,
Signature · 1 line
2.18.0
PATCH v5 11/12 virt: geniezone: Add guest page fault handler
In reply to Yi-De WuFrom: "Yingshiuan Pan" <[email protected]>
This page fault handler helps GenieZone hypervisor to do demand paging. On a lower level translation fault, GenieZone hypervisor will first check the fault GPA (guest physical address or IPA in ARM) is valid e.g. within the registered memory region, then it will setup the vcpu_run->exit_reason with necessary information for returning to gzvm driver.
With the fault information, the gzvm driver looks up the physical address and call the MT_HVC_GZVM_MAP_GUEST to request the hypervisor maps the found PA to the fault GPA (IPA).
--- arch/arm64/geniezone/gzvm_arch_common.h | 2 + arch/arm64/geniezone/vm.c | 9 ++++ arch/arm64/include/uapi/asm/gzvm_arch.h | 4 ++ drivers/virt/geniezone/Makefile | 2 +- drivers/virt/geniezone/gzvm_exception.c | 66 +++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_main.c | 2 + drivers/virt/geniezone/gzvm_vcpu.c | 6 ++- drivers/virt/geniezone/gzvm_vm.c | 28 ++++++++++- include/linux/gzvm_drv.h | 7 +++ include/uapi/asm-generic/gzvm_arch.h | 3 ++ include/uapi/linux/gzvm.h | 14 ++++++ 11 files changed, 138 insertions(+), 5 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_exception.c
arch/arm64/geniezone/gzvm_arch_common.h +2 -0
@@ -24,6 +24,7 @@ enum {GZVM_FUNC_INFORM_EXIT =14 ,GZVM_FUNC_MEMREGION_PURPOSE =15 ,GZVM_FUNC_SET_DTB_CONFIG =16 , +GZVM_FUNC_MAP_GUEST =17 , NR_GZVM_FUNC, };
@@ -48,6 +49,7 @@ enum {#define MT_HVC_GZVM_INFORM_EXIT GZVM_HCALL_ID(GZVM_FUNC_INFORM_EXIT)#define MT_HVC_GZVM_MEMREGION_PURPOSE GZVM_HCALL_ID(GZVM_FUNC_MEMREGION_PURPOSE)#define MT_HVC_GZVM_SET_DTB_CONFIG GZVM_HCALL_ID(GZVM_FUNC_SET_DTB_CONFIG) +#define MT_HVC_GZVM_MAP_GUEST GZVM_HCALL_ID(GZVM_FUNC_MAP_GUEST)#define GIC_V3_NR_LRS 16
arch/arm64/geniezone/vm.c +9 -0
@@ -240,3 +240,12 @@ u64 gzvm_hva_to_pa_arch(u64 hva)return par &PAR_PA47_MASK ; } + +int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn, +u64 nr_pages) +{ +struct arm_smccc_res res; + +return gzvm_hypcall_wrapper (MT_HVC_GZVM_MAP_GUEST , vm_id, memslot_id, + pfn, gfn, nr_pages,0 ,0 , &res); +}
arch/arm64/include/uapi/asm/gzvm_arch.h +4 -0
@@ -51,4 +51,8 @@#define GZVM_VGIC_NR_PPIS 16#define GZVM_VGIC_NR_PRIVATE_IRQS (GZVM_VGIC_NR_SGIS + GZVM_VGIC_NR_PPIS) +struct gzvm_arch_exception { +__u64 esr_el2; +}; +#endif /* __GZVM_ARCH_H__ */
drivers/virt/geniezone/Makefile +1 -1
@@ -8,4 +8,4 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o \ - $(GZVM_DIR)/gzvm_ioeventfd.o + $(GZVM_DIR)/gzvm_ioeventfd.o $(GZVM_DIR)/gzvm_exception.o
drivers/virt/geniezone/gzvm_exception.c new file +66 -0
66 lines not on this page · raw message
drivers/virt/geniezone/gzvm_main.c +2 -0
@@ -30,6 +30,8 @@ int gzvm_err_to_errno(unsigned long err)return 0 ;case ERR_NO_MEMORY :return -ENOMEM ; +case ERR_INVALID_ARGS : +return -EINVAL ;case ERR_NOT_SUPPORTED :return -EOPNOTSUPP ;case ERR_NOT_IMPLEMENTED :
drivers/virt/geniezone/gzvm_vcpu.c +4 -2
@@ -112,9 +112,11 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void * __user argp)* it's geniezone's responsibility to fill corresponding data * structure */ -case GZVM_EXIT_HYPERCALL : - fallthrough;case GZVM_EXIT_EXCEPTION : +if (!gzvm_handle_guest_exception (vcpu)) + need_userspace = true; +break ; +case GZVM_EXIT_HYPERCALL : fallthrough;case GZVM_EXIT_DEBUG : fallthrough;
drivers/virt/geniezone/gzvm_vm.c +26 -2
@@ -98,8 +98,7 @@ static u64 __gzvm_gfn_to_pfn_memslot(struct gzvm_memslot *memslot, u64 gfn)* * 0 - Succeed * * -EFAULT - Failed to convert */ -static int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn, -u64 *pfn) +int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn) {u64 __pfn;
@@ -117,6 +116,31 @@ static int gzvm_gfn_to_pfn_memslot(struct gzvm_memslot *memslot, u64 gfn,return 0 ; } +/** +* gzvm_find_memslot() - Find memslot containing this @gpa +* @vm: Pointer to struct gzvm +* @gfn: Guest frame number +* +* Return: +* * >=0 - Index of memslot +* * -EFAULT - Not found +*/ +int gzvm_find_memslot (struct gzvm *vm,u64 gfn) +{ +int i; + +for (i =0 ; i <GZVM_MAX_MEM_REGION ; i++) { +if (vm->memslot[i].npages ==0 ) +continue ; + +if (gfn >= vm->memslot[i].base_gfn && + gfn < vm->memslot[i].base_gfn + vm->memslot[i].npages) +return i; + } + +return -EFAULT ; +} +/** * fill_constituents() - Populate pa to buffer until full * @consti: Pointer to struct mem_region_addr_range.
include/linux/gzvm_drv.h +7 -0
@@ -23,6 +23,7 @@*/ #define NO_ERROR (0)#define ERR_NO_MEMORY (-5) +#define ERR_INVALID_ARGS (-8)#define ERR_NOT_SUPPORTED (-24)#define ERR_NOT_IMPLEMENTED (-27)#define ERR_FAULT (-40)
@@ -119,6 +120,8 @@ int gzvm_arch_set_memregion(u16 vm_id, size_t buf_size,int gzvm_arch_check_extension (struct gzvm *gzvm,__u64 cap,void __user *argp);int gzvm_arch_create_vm (unsigned long vm_type);int gzvm_arch_destroy_vm (u16 vm_id); +int gzvm_arch_map_guest (u16 vm_id,int memslot_id,u64 pfn,u64 gfn, +u64 nr_pages);int gzvm_vm_ioctl_arch_enable_cap (struct gzvm *gzvm,struct gzvm_enable_cap *cap,void __user *argp);
@@ -134,6 +137,10 @@ int gzvm_arch_inform_exit(u16 vm_id);int gzvm_arch_drv_init (void );void gzvm_arch_drv_exit (void ); +int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn); +int gzvm_find_memslot (struct gzvm *vm,u64 gpa); +bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu); +int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev);int gzvm_arch_inject_irq (struct gzvm *gzvm,unsigned int vcpu_idx,u32 irq_type,u32 irq,bool level);
include/uapi/asm-generic/gzvm_arch.h +3 -0
@@ -5,6 +5,9 @@#ifndef __ASM_GENERIC_GZVM_ARCH_H#define __ASM_GENERIC_GZVM_ARCH_H +/* geniezone only supports aarch64 platform for now */ +struct gzvm_arch_exception { +};#endif /* __ASM_GENERIC_GZVM_ARCH_H */
include/uapi/linux/gzvm.h +14 -0
@@ -150,6 +150,12 @@ enum { GZVM_EXIT_GZ = 0x9292000a, }; +/* exception definitions of GZVM_EXIT_EXCEPTION */ +enum { +GZVM_EXCEPTION_UNKNOWN =0x0 , +GZVM_EXCEPTION_PAGE_FAULT =0x1 , +}; +/** * struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is * shared between userspace, kernel and
@@ -174,6 +180,11 @@ enum {* Handle exception occurred in VM * @exception: Which exception vector * @error_code: Exception error codes +* @fault_gpa: Fault GPA (guest physical address or IPA in ARM) +* @reserved: Future-proof reservation and should be zeroed, and this can also +* fix the offset of `gzvm_arch_exception` +* @arch: struct gzvm_arch_exception, architecture information for guest +* exception * @hypercall: The nested struct in anonymous union. * Some hypercalls issued from VM must be handled * @args: The hypercall's arguments
@@ -220,6 +231,9 @@ struct gzvm_vcpu_run {struct {__u32 exception;__u32 error_code; +__u64 fault_gpa; +__u64 reserved[6 ]; +struct gzvm_arch_exception arch; } exception;/* GZVM_EXIT_HYPERCALL */ struct {
Signature · 1 line
2.18.0
PATCH v5 12/12 virt: geniezone: Add memory pin/unpin support
In reply to Yi-De WuFrom: "Jerry Wang" <[email protected]>
Implement memory pin/unpin.
- use rb_tree to store pinned memory page
- pin page when handling page fault
- unpin page when handling relinquish or destroy
--- drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_exception.c | 32 ---- drivers/virt/geniezone/gzvm_hvc.c | 34 ++++ drivers/virt/geniezone/gzvm_mmu.c | 210 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 4 +- drivers/virt/geniezone/gzvm_vm.c | 113 +++---------- include/linux/gzvm_drv.h | 19 ++- include/uapi/linux/gzvm.h | 5 + 8 files changed, 291 insertions(+), 129 deletions(-) create mode 100644 drivers/virt/geniezone/gzvm_hvc.c create mode 100644 drivers/virt/geniezone/gzvm_mmu.c
drivers/virt/geniezone/Makefile +2 -1
@@ -8,4 +8,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o \ - $(GZVM_DIR)/gzvm_ioeventfd.o $(GZVM_DIR)/gzvm_exception.o + $(GZVM_DIR)/gzvm_ioeventfd.o $(GZVM_DIR)/gzvm_exception.o \ + $(GZVM_DIR)/gzvm_hvc.o $(GZVM_DIR)/gzvm_mmu.o
drivers/virt/geniezone/gzvm_exception.c +0 -32
@@ -6,38 +6,6 @@#include <linux/device.h> #include <linux/gzvm_drv.h> -/** -* gzvm_handle_page_fault() - Handle guest page fault, find corresponding page -* for the faulting gpa -* @vcpu: Pointer to struct gzvm_vcpu_run of the faulting vcpu -* -* Return: -* * 0 - Success to handle guest page fault -* * -EFAULT - Failed to map phys addr to guest's GPA -*/ -static int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu) -{ -struct gzvm *vm = vcpu->gzvm; -int memslot_id; -u64 pfn, gfn; -int ret; - - gfn =PHYS_PFN (vcpu->run->exception.fault_gpa); - memslot_id =gzvm_find_memslot (vm, gfn); -if (unlikely (memslot_id <0 )) -return -EFAULT ; - - ret =gzvm_gfn_to_pfn_memslot (&vm->memslot[memslot_id], gfn, &pfn); -if (unlikely (ret)) -return -EFAULT ; - - ret =gzvm_arch_map_guest (vm->vm_id, memslot_id, pfn, gfn,1 ); -if (unlikely (ret)) -return -EFAULT ; - -return 0 ; -} -/** * gzvm_handle_guest_exception() - Handle guest exception * @vcpu: Pointer to struct gzvm_vcpu_run in userspace
drivers/virt/geniezone/gzvm_hvc.c new file +34 -0
@@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/gzvm_drv.h> + +/** +* gzvm_handle_guest_hvc() - Handle guest hvc +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +* Return: +* * true - This hvc has been processed, no need to back to VMM. +* * false - This hvc has not been processed, require userspace. +*/ +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu) +{ +int ret; +unsigned long ipa; + +switch (vcpu->run->hypercall.args[0 ]) { +case GZVM_HVC_MEM_RELINQUISH : + ipa = vcpu->run->hypercall.args[1 ]; + ret =gzvm_handle_relinquish (vcpu, ipa); +break ; +default : + ret = false; +break ; + } + +if (!ret) +return true; +else +return false; +}
drivers/virt/geniezone/gzvm_mmu.c new file +210 -0
210 lines not on this page · raw message
drivers/virt/geniezone/gzvm_vcpu.c +3 -1
@@ -117,7 +117,9 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void * __user argp) need_userspace = true;break ;case GZVM_EXIT_HYPERCALL : - fallthrough; +if (!gzvm_handle_guest_hvc (vcpu)) + need_userspace = true; +break ;case GZVM_EXIT_DEBUG : fallthrough;case GZVM_EXIT_FAIL_ENTRY :
drivers/virt/geniezone/gzvm_vm.c +19 -94
143 lines not on this page · raw message
include/linux/gzvm_drv.h +18 -1
@@ -12,6 +12,8 @@#include <linux/mutex.h> #include <linux/gzvm.h> #include <linux/srcu.h> +#include <linux/rbtree.h> +#include <linux/mm.h> #define GZVM_VCPU_MMAP_SIZE PAGE_SIZE#define INVALID_VM_ID 0xffff
@@ -76,6 +78,12 @@ struct gzvm_vcpu {struct hrtimer gzvm_mtimer; }; +struct gzvm_pinned_page { +struct rb_node node; +struct page *page; +u64 ipa; +}; +struct gzvm {struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */
@@ -102,6 +110,9 @@ struct gzvm {struct srcu_struct irq_srcu;/* lock for irq injection */ struct mutex irq_lock; + +/* Use rb-tree to record pin/unpin page */ +struct rb_root pinned_pages; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);
@@ -137,9 +148,15 @@ int gzvm_arch_inform_exit(u16 vm_id);int gzvm_arch_drv_init (void );void gzvm_arch_drv_exit (void ); -int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn);int gzvm_find_memslot (struct gzvm *vm,u64 gpa); +int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn); +u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn); +u64 hva_to_pa_fast (u64 hva); +u64 hva_to_pa_slow (u64 hva); +int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu); +int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa);bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu); +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu);int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); int gzvm_arch_inject_irq(struct gzvm *gzvm, unsigned int vcpu_idx,
include/uapi/linux/gzvm.h +5 -0
@@ -156,6 +156,11 @@ enum { GZVM_EXCEPTION_PAGE_FAULT = 0x1, }; +/* hypercall definitions of GZVM_EXIT_HYPERCALL */ +enum { +GZVM_HVC_MEM_RELINQUISH =0xc6000009 , +}; +/** * struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is * shared between userspace, kernel and
Signature · 1 line
2.18.0
Re: [PATCH v5 12/12] virt: geniezone: Add memory pin/unpin support
Hi Jerry,
Quoted 246 lines · Yi-De Wu
From: "Jerry Wang" <[email protected]>
Implement memory pin/unpin.
- userb_treeto store pinned memory page
- pin page when handling page fault
- unpin page when handling relinquish or destroySigned-off-by Jerry Wang <[email protected]>Signed-off-by Liju Chen <[email protected]>Signed-off-by Yi-De Wu <[email protected]>--- drivers/virt/geniezone/Makefile | 3 +- drivers/virt/geniezone/gzvm_exception.c | 32 ---- drivers/virt/geniezone/gzvm_hvc.c | 34 ++++ drivers/virt/geniezone/gzvm_mmu.c | 210 ++++++++++++++++++++++++ drivers/virt/geniezone/gzvm_vcpu.c | 4 +- drivers/virt/geniezone/gzvm_vm.c | 113 +++---------- include/linux/gzvm_drv.h | 19 ++- include/uapi/linux/gzvm.h | 5 + 8 files changed, 291 insertions(+), 129 deletions(-)create mode 100644
drivers/virt/geniezone/gzvm_hvc.ccreate mode 100644drivers/virt/geniezone/gzvm_mmu.cdrivers/virt/geniezone/Makefile +2
-1@@ -8,4 +8,5 @@ GZVM_DIR ?= ../../../drivers/virt/geniezone gzvm-y := $(GZVM_DIR)/gzvm_main.o $(GZVM_DIR)/gzvm_vm.o \ $(GZVM_DIR)/gzvm_vcpu.o $(GZVM_DIR)/gzvm_irqfd.o \ - $(GZVM_DIR)/gzvm_ioeventfd.o $(GZVM_DIR)/gzvm_exception.o + $(GZVM_DIR)/gzvm_ioeventfd.o $(GZVM_DIR)/gzvm_exception.o \ + $(GZVM_DIR)/gzvm_hvc.o $(GZVM_DIR)/gzvm_mmu.odrivers/virt/geniezone/gzvm_exception.c +0
-32@@ -6,38 +6,6 @@#include <linux/device.h> #include <linux/gzvm_drv.h> -/** -* gzvm_handle_page_fault() - Handle guest page fault, find corresponding page -* for the faulting gpa -* @vcpu: Pointer to struct gzvm_vcpu_run of the faulting vcpu -* -* Return: -* * 0 - Success to handle guest page fault -* * -EFAULT - Failed to map phys addr to guest's GPA -*/ -static int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu) -{ -struct gzvm *vm = vcpu->gzvm; -int memslot_id; -u64 pfn, gfn; -int ret; - - gfn =PHYS_PFN (vcpu->run->exception.fault_gpa); - memslot_id =gzvm_find_memslot (vm, gfn); -if (unlikely (memslot_id <0 )) -return -EFAULT ; - - ret =gzvm_gfn_to_pfn_memslot (&vm->memslot[memslot_id], gfn, &pfn); -if (unlikely (ret)) -return -EFAULT ; - - ret =gzvm_arch_map_guest (vm->vm_id, memslot_id, pfn, gfn,1 ); -if (unlikely (ret)) -return -EFAULT ; - -return 0 ; -} -/** * gzvm_handle_guest_exception() - Handle guest exception * @vcpu: Pointer to struct gzvm_vcpu_run in userspace drivers/virt/geniezone/gzvm_hvc.c new file +34
-0@@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/gzvm_drv.h> + +/** +* gzvm_handle_guest_hvc() - Handle guest hvc +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +* Return: +* * true - This hvc has been processed, no need to back to VMM. +* * false - This hvc has not been processed, require userspace. +*/ +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu) +{ +int ret; +unsigned long ipa; + +switch (vcpu->run->hypercall.args[0 ]) { +case GZVM_HVC_MEM_RELINQUISH : + ipa = vcpu->run->hypercall.args[1 ]; + ret =gzvm_handle_relinquish (vcpu, ipa); +break ; +default : + ret = false; +break ; + } + +if (!ret) +return true; +else +return false; +}drivers/virt/geniezone/gzvm_mmu.c new file +123
-0@@ -0,0 +1,210 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (c) 2023 MediaTek Inc. +*/ + +#include <linux/gzvm_drv.h> + +/** +* hva_to_pa_fast() - converts hva to pa in generic fast way +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +u64 hva_to_pa_fast (u64 hva) +{ +struct page *page[1 ]; + +u64 pfn; + +if (get_user_page_fast_only (hva,0 , page)) { + pfn =page_to_phys (page[0 ]); +put_page ((struct page *)page); +return pfn; + }else { +return 0 ; + } +} + +/** +* hva_to_pa_slow() - note that this function may sleep +* @hva: Host virtual address. +* +* Return: 0 if translation error +*/ +u64 hva_to_pa_slow (u64 hva) +{ +struct page *page =NULL ; +u64 pfn =0 ; +int npages; + + npages =get_user_pages_unlocked (hva,1 , &page,0 ); +if (npages !=1 ) +return 0 ; + +if (page) { + pfn =page_to_phys (page); +put_page (page); + } + +return pfn; +} + +static u64 __gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn) +{ +u64 hva, pa; + + hva =gzvm_gfn_to_hva_memslot (memslot, gfn); + + pa =gzvm_hva_to_pa_arch (hva); +if (pa !=0 ) +return PHYS_PFN (pa); + + pa =hva_to_pa_fast (hva); +if (pa) +return PHYS_PFN (pa); + + pa =hva_to_pa_slow (hva); +if (pa) +return PHYS_PFN (pa); + +return 0 ; +} + +/** +* gzvm_gfn_to_pfn_memslot() - Translate gfn (guest ipa) to pfn (host pa), +* result is in @pfn +* @memslot: Pointer to struct gzvm_memslot. +* @gfn: Guest frame number. +* @pfn: Host page frame number. +* +* Return: +* * 0 - Succeed +* * -EFAULT - Failed to convert +*/ +int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn) +{ +u64 __pfn; + +if (!memslot) +return -EFAULT ; + + __pfn =__gzvm_gfn_to_pfn_memslot (memslot, gfn); +if (__pfn ==0 ) { + *pfn =0 ; +return -EFAULT ; + } + + *pfn = __pfn; + +return 0 ; +} + +static int cmp_ppages (struct rb_node *node,const struct rb_node *parent) +{ + struct gzvm_pinned_page *a = container_of(node, struct gzvm_pinned_page, node); + struct gzvm_pinned_page *b = container_of(parent, struct gzvm_pinned_page, node); + +if (a->ipa < b->ipa) +return -1 ; +if (a->ipa > b->ipa) +return 1 ; +return 0 ; +} + +static int rb_ppage_cmp (const void *key,const struct rb_node *node) +{ + struct gzvm_pinned_page *p = container_of(node, struct gzvm_pinned_page, node); +phys_addr_t ipa = (phys_addr_t )key; + +return (ipa < p->ipa) ?-1 : (ipa > p->ipa); +} + +static int gzvm_insert_ppage (struct gzvm *vm,struct gzvm_pinned_page *ppage)
drivers/virt/geniezone/gzvm_mmu.c line 133
Quoted 10 lines
drivers/virt/geniezone/gzvm_mmu.c new file +10
-0+{ +if (rb_find_add (&ppage->node, &vm->pinned_pages, cmp_ppages)) +return -EEXIST ; +return 0 ; +} + +static int pin_one_page (unsigned long hva,struct page **page) +{ +struct mm_struct *mm = current->mm; +unsigned int flags =FOLL_HWPOISON |FOLL_LONGTERM |FOLL_WRITE ;
Recently received this feedback you might also find helpful:
https://lore.kernel.org/all/20230714121321.GB5597@willie-the-truck/
Quoted 312 lines
drivers/virt/geniezone/gzvm_mmu.c new file +77
-0+ +mmap_read_lock (mm); +pin_user_pages (hva,1 , flags, page); +mmap_read_unlock (mm); + +return 0 ; +} + +/** +* gzvm_handle_relinquish() - Handle memory relinquish request from hypervisor +* +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +* @ipa: Start address(gpa) of a reclaimed page +*/ +int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa) +{ +struct gzvm_pinned_page *ppage; +struct rb_node *node; +struct gzvm *vm = vcpu->gzvm; + + node =rb_find ((void *)ipa, &vm->pinned_pages, rb_ppage_cmp); + +if (node) +rb_erase (node, &vm->pinned_pages); +else +return 0 ; + + ppage = container_of(node, struct gzvm_pinned_page, node); +unpin_user_pages_dirty_lock (&ppage->page,1 , true); +kfree (ppage); +return 0 ; +} + +/** +* gzvm_handle_page_fault() - Handle guest page fault, find corresponding page +* for the faulting gpa +* @vcpu: Pointer to struct gzvm_vcpu_run in userspace +*/ +int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu) +{ +struct gzvm *vm = vcpu->gzvm; +int memslot_id; +u64 pfn, gfn; +unsigned long hva; +struct gzvm_pinned_page *ppage =NULL ; +struct page *page =NULL ; +int ret; + + gfn =PHYS_PFN (vcpu->run->exception.fault_gpa); + memslot_id =gzvm_find_memslot (vm, gfn); +if (unlikely (memslot_id <0 )) +return -EFAULT ; + + ret =gzvm_gfn_to_pfn_memslot (&vm->memslot[memslot_id], gfn, &pfn); +if (unlikely (ret)) +return -EFAULT ; + + ret =gzvm_arch_map_guest (vm->vm_id, memslot_id, pfn, gfn,1 ); +if (unlikely (ret)) +return -EFAULT ; + + hva =gzvm_gfn_to_hva_memslot (&vm->memslot[memslot_id], gfn); +pin_one_page (hva, &page); + +if (!page) +return -EFAULT ; + + ppage =kmalloc (sizeof (*ppage),GFP_KERNEL_ACCOUNT ); +if (!ppage) +return -ENOMEM ; + + ppage->page = page; + ppage->ipa = vcpu->run->exception.fault_gpa; +gzvm_insert_ppage (vm, ppage); + +return 0 ; +}drivers/virt/geniezone/gzvm_vcpu.c +3
-1@@ -117,7 +117,9 @@ static long gzvm_vcpu_run(struct gzvm_vcpu *vcpu, void * __user argp) need_userspace = true;break ;case GZVM_EXIT_HYPERCALL : - fallthrough; +if (!gzvm_handle_guest_hvc (vcpu)) + need_userspace = true; +break ;case GZVM_EXIT_DEBUG : fallthrough;case GZVM_EXIT_FAIL_ENTRY :drivers/virt/geniezone/gzvm_vm.c +19
-94@@ -16,106 +16,13 @@static DEFINE_MUTEX (gzvm_list_lock);static LIST_HEAD (gzvm_list); -/** -* hva_to_pa_fast() - converts hva to pa in generic fast way -* @hva: Host virtual address. -* -* Return: 0 if translation error -*/ -static u64 hva_to_pa_fast (u64 hva) -{ -struct page *page[1 ]; - -u64 pfn; - -if (get_user_page_fast_only (hva,0 , page)) { - pfn =page_to_phys (page[0 ]); -put_page ((struct page *)page); -return pfn; - }else { -return 0 ; - } -} - -/** -* hva_to_pa_slow() - note that this function may sleep -* @hva: Host virtual address. -* -* Return: 0 if translation error -*/ -static u64 hva_to_pa_slow (u64 hva) -{ -struct page *page; -int npages; -u64 pfn; - - npages =get_user_pages_unlocked (hva,1 , &page,0 ); -if (npages !=1 ) -return 0 ; - - pfn =page_to_phys (page); -put_page (page); - -return pfn; -} - -static u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn) +u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn) {u64 offset = gfn - memslot->base_gfn;return memslot->userspace_addr + offset *PAGE_SIZE ; } -static u64 __gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn) -{ -u64 hva, pa; - - hva =gzvm_gfn_to_hva_memslot (memslot, gfn); - - pa =gzvm_hva_to_pa_arch (hva); -if (pa !=0 ) -return PHYS_PFN (pa); - - pa =hva_to_pa_fast (hva); -if (pa) -return PHYS_PFN (pa); - - pa =hva_to_pa_slow (hva); -if (pa) -return PHYS_PFN (pa); - -return 0 ; -} - -/** -* gzvm_gfn_to_pfn_memslot() - Translate gfn (guest ipa) to pfn (host pa), -* result is in @pfn -* @memslot: Pointer to struct gzvm_memslot. -* @gfn: Guest frame number. -* @pfn: Host page frame number. -* -* Return: -* * 0 - Succeed -* * -EFAULT - Failed to convert -*/ -int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn) -{ -u64 __pfn; - -if (!memslot) -return -EFAULT ; - - __pfn =__gzvm_gfn_to_pfn_memslot (memslot, gfn); -if (__pfn ==0 ) { - *pfn =0 ; -return -EFAULT ; - } - - *pfn = __pfn; - -return 0 ; -} -/** * gzvm_find_memslot() - Find memslot containing this @gpa * @vm: Pointer to struct gzvm @@ -454,6 +361,21 @@ static long gzvm_vm_ioctl(struct file *filp, unsigned int ioctl,return ret; } +static void gzvm_destroy_ppage (struct gzvm *gzvm) +{ +struct gzvm_pinned_page *ppage; +struct rb_node *node; + + node =rb_first (&gzvm->pinned_pages); +while (node) { + ppage = rb_entry(node, struct gzvm_pinned_page, node); +unpin_user_pages_dirty_lock (&ppage->page,1 , true); + node =rb_next (node); +rb_erase (&ppage->node, &gzvm->pinned_pages); +kfree (ppage); + } +} +static void gzvm_destroy_vm (struct gzvm *gzvm) {pr_debug ("VM-%u is going to be destroyed\n" , gzvm->vm_id);@@ -470,6 +392,8 @@ static void gzvm_destroy_vm(struct gzvm *gzvm)mutex_unlock (&gzvm->lock); +gzvm_destroy_ppage (gzvm); +kfree (gzvm); }@@ -505,6 +429,7 @@ static struct gzvm *gzvm_create_vm(unsigned long vm_type) gzvm->vm_id = ret; gzvm->mm = current->mm;mutex_init (&gzvm->lock); + gzvm->pinned_pages =RB_ROOT ; ret =gzvm_vm_irqfd_init (gzvm);if (ret) {include/linux/gzvm_drv.h +18
-1@@ -12,6 +12,8 @@#include <linux/mutex.h> #include <linux/gzvm.h> #include <linux/srcu.h> +#include <linux/rbtree.h> +#include <linux/mm.h> #define GZVM_VCPU_MMAP_SIZE PAGE_SIZE#define INVALID_VM_ID 0xffff@@ -76,6 +78,12 @@ struct gzvm_vcpu {struct hrtimer gzvm_mtimer; }; +struct gzvm_pinned_page { +struct rb_node node; +struct page *page; +u64 ipa; +}; +struct gzvm {struct gzvm_vcpu *vcpus[GZVM_MAX_VCPUS ];/* userspace tied to this vm */ @@ -102,6 +110,9 @@ struct gzvm {struct srcu_struct irq_srcu;/* lock for irq injection */ struct mutex irq_lock; + +/* Use rb-tree to record pin/unpin page */ +struct rb_root pinned_pages; };long gzvm_dev_ioctl_check_extension (struct gzvm *gzvm,unsigned long args);@@ -137,9 +148,15 @@ int gzvm_arch_inform_exit(u16 vm_id);int gzvm_arch_drv_init (void );void gzvm_arch_drv_exit (void ); -int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn);int gzvm_find_memslot (struct gzvm *vm,u64 gpa); +int gzvm_gfn_to_pfn_memslot (struct gzvm_memslot *memslot,u64 gfn,u64 *pfn); +u64 gzvm_gfn_to_hva_memslot (struct gzvm_memslot *memslot,u64 gfn); +u64 hva_to_pa_fast (u64 hva); +u64 hva_to_pa_slow (u64 hva); +int gzvm_handle_page_fault (struct gzvm_vcpu *vcpu); +int gzvm_handle_relinquish (struct gzvm_vcpu *vcpu,phys_addr_t ipa);bool gzvm_handle_guest_exception (struct gzvm_vcpu *vcpu); +bool gzvm_handle_guest_hvc (struct gzvm_vcpu *vcpu);int gzvm_arch_create_device (u16 vm_id,struct gzvm_create_device *gzvm_dev); int gzvm_arch_inject_irq(struct gzvm *gzvm, unsigned int vcpu_idx,include/uapi/linux/gzvm.h +5
-0@@ -156,6 +156,11 @@ enum { GZVM_EXCEPTION_PAGE_FAULT = 0x1, }; +/* hypercall definitions of GZVM_EXIT_HYPERCALL */ +enum { +GZVM_HVC_MEM_RELINQUISH =0xc6000009 , +}; +/** * struct gzvm_vcpu_run: Same purpose as kvm_run, this struct is * shared between userspace, kernel and
Rob Herring
maintainerQuoted 11 lines · Yi-De Wu
This series is based on linux-next, tag: next-20230726.
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports various virtual machine types and provides security features such as TEE-like scenarios and secure boot. It can create guest VMs for security use cases and has virtualization capabilities for both platform and interrupt. Although the hypervisor can be booted independently, it requires the assistance of GenieZone hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux kernel for vCPU scheduling, memory management, inter-VM communication and virtio backend support.
Quoted 2 lines
Changes in v5:
- Add dt solution back for device initialization
Why? It's a software interface that you define and control. Make that interface discoverable.
Rob
Quoted 21 lines · Rob Herring
External email : Please do not click links or open attachments until you have verified the sender or the content.
Quoted 3 lines · Yi-De Wu
This series is based on linux-next, tag: next-20230726.
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports
various virtual
Quoted 1 line
machine types and provides security features such as TEE-like
scenarios and
Quoted 2 lines
secure boot. It can create guest VMs for security use cases and has virtualization capabilities for both platform and interrupt.
Although the
Quoted 1 line
hypervisor can be booted independently, it requires the assistance
of GenieZone
Quoted 1 line
hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux
kernel for
Quoted 1 line
vCPU scheduling, memory management, inter-VM communication and
virtio backend
Quoted 2 lines
support.
Quoted 8 lines
Quoted 2 lines
Changes in v5:
- Add dt solution back for device initializationWhy? It's a software interface that you define and control. Make that
interface discoverable.Rob
hi Rob,
Let me recap a bit about this as you might not notice our previous response[1]. In order to discover our GenieZone hypervisor, there were 2 solutions being talked about, namely with dt or without dt.
The reasons we use dt now were listed in some previous mail thread[2]. I'll just copy the statements here for better sync-up.
- Although dt is for hardware, it's difficult to discover a specific hypervisor without probing on all subsystem and thus pollute all of other users as a consequence.
- The GenieZone hypervisor could be considered as a vendor model to assist platform virtualization whose implementation is independent from Linuxism.
In contrast to the solution with dt, what we were doing was probing via hypercall to see whether our hypervisor exists.
However, this could raise some concerns about "polluting all systems" even for those systems without GenieZone hypervisor embedded[3].
We're wondering if there's any specific implementation in mind from your side that we could initialize our device in a discoverable manners while not affecting other systems. We'll appreciate for the hint.
Regards,
Reference
1.
https://lore.kernel.org/all/[email protected]/
2.
https://lore.kernel.org/lkml/[email protected]/
3.
https://lore.kernel.org/all/[email protected]/
Regards,
Quoted 70 lines · Yi-De Wu
Quoted 31 lines · Rob Herring
External email : Please do not click links or open attachments until
you have verified the sender or the content.Quoted 3 lines · Yi-De Wu
This series is based on linux-next, tag: next-20230726.
GenieZone hypervisor(gzvm) is a type-1 hypervisor that supports
various virtual
Quoted 1 line
machine types and provides security features such as TEE-like
scenarios and
Quoted 3 lines
secure boot. It can create guest VMs for security use cases and has
virtualization capabilities for both platform and interrupt.Although the
Quoted 2 lines
hypervisor can be booted independently, it requires the assistance
of GenieZone
Quoted 2 lines
hypervisor kernel driver(gzvm-ko) to leverage the ability of Linux
kernel for
Quoted 1 line
vCPU scheduling, memory management, inter-VM communication and
virtio backend
Quoted 2 lines
support.
Quoted 8 lines
Quoted 2 lines
Changes in v5:
- Add dt solution back for device initializationWhy? It's a software interface that you define and control. Make that
interface discoverable.Rob
hi Rob,
Let me recap a bit about this as you might not notice our previous response[1]. In order to discover our GenieZone hypervisor, there were
2 solutions being talked about, namely with dt or without dt.The reasons we use dt now were listed in some previous mail thread[2].
I'll just copy the statements here for better sync-up.
- Although dt is for hardware, it's difficult to discover a specific hypervisor without probing on all subsystem and thus pollute all of other users as a consequence.
- The GenieZone hypervisor could be considered as a vendor model to assist platform virtualization whose implementation is independent from
Linuxism.In contrast to the solution with dt, what we were doing was probing via
hypercall to see whether our hypervisor exists.
However, this could raise some concerns about "polluting all systems" even for those systems without GenieZone hypervisor embedded[3].We're wondering if there's any specific implementation in mind from your side that we could initialize our device in a discoverable manners
while not affecting other systems. We'll appreciate for the hint.
Quoted 5 lines
Regards,
Reference
1.
https://lore.kernel.org/all/[email protected]/
Quoted 2 lines
2.
https://lore.kernel.org/lkml/[email protected]/
Quoted 2 lines
3.
https://lore.kernel.org/all/[email protected]/
Quoted 3 lines
Regards,
A gentle ping.
We suppose a simple dt would be a consise solution here to initialize the GenieZone hypervisor. We also found some other software pieces use dt as well[4]. Perhaps it could be brought into discussion that dt shall be suitable under our use case.
Reference
4. OP-TEE Trusted OS maintained by Linaro