Skip to contentSkip to conversation

drm/amd/pm: correct the pcie width for smu 13.0.0

PATCH In review Kenneth Feng 4 participants 4 messages Jul 27, 2023 – Jul 28, 2023

Subsystems (3)
lore
Share & tools
lore

Kenneth Feng

author maintainer
#0 lore raw

PATCH 1/1 drm/amd/pm: correct the pcie width for smu 13.0.0

correct the pcie width value in pp_dpm_pcie for smu 13.0.0

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +1 -2
index 232274423f9e..4bdbd3910e1f 100644
@@ -1140,7 +1140,6 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
 		(OverDriveTableExternal_t *)smu->smu_table.overdrive_table;
 	struct smu_13_0_dpm_table *single_dpm_table;
 	struct smu_13_0_pcie_table *pcie_table;
-	const int link_width[] = {0, 1, 2, 4, 8, 12, 16};
 	uint32_t gen_speed, lane_width;
 	int i, curr_freq, size = 0;
 	int32_t min_value, max_value;
@@ -1256,7 +1255,7 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
 					(pcie_table->pcie_lane[i] == 6) ? "x16" : "",
 					pcie_table->clk_freq[i],
 					(gen_speed == DECODE_GEN_SPEED(pcie_table->pcie_gen[i])) &&
-					(lane_width == DECODE_LANE_WIDTH(link_width[pcie_table->pcie_lane[i]])) ?
+					(lane_width == DECODE_LANE_WIDTH(pcie_table->pcie_lane[i])) ?
 					"*" : "");
 		break;
 
Signature · 1 line
2.34.1
maintainer Acked-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

________________________________
From: amd-gfx <[email protected]> on behalf of Kenneth Feng <[email protected]>
Sent: Thursday, July 27, 2023 7:41 AM
To: [email protected] <[email protected]>
Cc: Quan, Evan <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

correct the pcie width value in pp_dpm_pcie for smu 13.0.0

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +1 -2
index 232274423f9e..4bdbd3910e1f 100644
@@ -1140,7 +1140,6 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
                 (OverDriveTableExternal_t *)smu->smu_table.overdrive_table;
         struct smu_13_0_dpm_table *single_dpm_table;
         struct smu_13_0_pcie_table *pcie_table;
-       const int link_width[] = {0, 1, 2, 4, 8, 12, 16};
         uint32_t gen_speed, lane_width;
         int i, curr_freq, size = 0;
         int32_t min_value, max_value;
@@ -1256,7 +1255,7 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
                                         (pcie_table->pcie_lane[i] == 6) ? "x16" : "",
                                         pcie_table->clk_freq[i],
                                         (gen_speed == DECODE_GEN_SPEED(pcie_table->pcie_gen[i])) &&
-                                       (lane_width == DECODE_LANE_WIDTH(link_width[pcie_table->pcie_lane[i]])) ?
+                                       (lane_width == DECODE_LANE_WIDTH(pcie_table->pcie_lane[i])) ?
                                         "*" : "");
                 break;
 

--
2.34.1

Reviewed-by Acked-by Alex Deucher
#2 lore raw

[AMD Official Use Only - General]

From: amd-gfx <[email protected]> On Behalf Of Deucher, Alexander
Sent: Thursday, July 27, 2023 9:30 AM
To: Feng, Kenneth <[email protected]>; [email protected]
Cc: Quan, Evan <[email protected]>
Subject: Re: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

[AMD Official Use Only - General]

[AMD Official Use Only - General]

________________________________
From: amd-gfx <[email protected]<mailto:[email protected]>> on behalf of Kenneth Feng <[email protected]<mailto:[email protected]>>
Sent: Thursday, July 27, 2023 7:41 AM
To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>
Cc: Quan, Evan <[email protected]<mailto:[email protected]>>; Feng, Kenneth <[email protected]<mailto:[email protected]>>
Subject: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

correct the pcie width value in pp_dpm_pcie for smu 13.0.0

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +1 -2
index 232274423f9e..4bdbd3910e1f 100644
@@ -1140,7 +1140,6 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
                 (OverDriveTableExternal_t *)smu->smu_table.overdrive_table;
         struct smu_13_0_dpm_table *single_dpm_table;
         struct smu_13_0_pcie_table *pcie_table;
-       const int link_width[] = {0, 1, 2, 4, 8, 12, 16};
         uint32_t gen_speed, lane_width;
         int i, curr_freq, size = 0;
         int32_t min_value, max_value;
@@ -1256,7 +1255,7 @@ static int smu_v13_0_0_print_clk_levels(struct smu_context *smu,
                                         (pcie_table->pcie_lane[i] == 6) ? "x16" : "",
                                         pcie_table->clk_freq[i],
                                         (gen_speed == DECODE_GEN_SPEED(pcie_table->pcie_gen[i])) &&
-                                       (lane_width == DECODE_LANE_WIDTH(link_width[pcie_table->pcie_lane[i]])) ?
+                                       (lane_width == DECODE_LANE_WIDTH(pcie_table->pcie_lane[i])) ?
                                         "*" : "");
                 break;
 

--
2.34.1

Reviewed-by on v1 1/1
#3 lore raw
In reply to Kenneth Feng

[AMD Official Use Only - General]

Quoted 46 lines

-----Original Message-----
From: Kenneth Feng <[email protected]>
Sent: Thursday, July 27, 2023 7:41 PM
To: [email protected]
Cc: Quan, Evan <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

correct the pcie width value in pp_dpm_pcie for smu 13.0.0

---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +0 -1
index 232274423f9e..4bdbd3910e1f 100644
@@ -1140,7 +1140,6 @@ static int smu_v13_0_0_print_clk_levels(struct
 smu_context *smu,
              (OverDriveTableExternal_t *)smu-
 >smu_table.overdrive_table;
      struct smu_13_0_dpm_table *single_dpm_table;
      struct smu_13_0_pcie_table *pcie_table;
-     const int link_width[] = {0, 1, 2, 4, 8, 12, 16};
      uint32_t gen_speed, lane_width;
      int i, curr_freq, size = 0;
      int32_t min_value, max_value;
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +0 -0
@@ -1256,7 +1255,7 @@ static int smu_v13_0_0_print_clk_levels(struct
 smu_context *smu,
                                      (pcie_table->pcie_lane[i] == 6) ?
 "x16" : "",
                                      pcie_table->clk_freq[i],
                                      (gen_speed ==

DECODE_GEN_SPEED(pcie_table->pcie_gen[i])) &&
- (lane_width ==
DECODE_LANE_WIDTH(link_width[pcie_table->pcie_lane[i]])) ?
+ (lane_width ==
DECODE_LANE_WIDTH(pcie_table->pcie_lane[i])) ?

                                      "*" : "");
              break;

--
2.34.1