Skip to contentSkip to conversation

fstests: install soak_duration.awk

PATCH In review Theodore Ts'o 3 participants 5 messages Jul 27, 2023 – Jul 28, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fstests: install soak_duration.awk

Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a helper executable, soak_duration.awk, is which used by the check script if SOAK_DURATION is set. This script translates a "human-firendly" time duration specifier, such as 4m or 2d into an integer number of seconds. We need to make sure that this script is installed or the checks script will bomb out of SOAK_DURATION is set (and the fstests installation doesn't include a full set of fstests source, but just those files installed by "make install").

Fixes 3e85dd4fe423 ("misc: add duration for long soak tests")
Cc Darrick J. Wong <[email protected]>
---
 src/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/Makefile +2 -1
index 24cd47479..aff871d04 100644
@@ -36,7 +36,8 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
 	uuid_ioctl
 
 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
-	      btrfs_crc32c_forged_name.py popdir.pl popattr.py
+	      btrfs_crc32c_forged_name.py popdir.pl popattr.py \
+	      soak_duration.awk
 
 SUBDIRS = log-writes perf
 
Signature · 1 line
2.31.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Theodore Ts'o

Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a helper executable, soak_duration.awk, is which used by the check script if SOAK_DURATION is set. This script translates a "human-firendly" time duration specifier, such as 4m or 2d into an integer number of seconds. We need to make sure that this script is installed or the checks script will bomb out of SOAK_DURATION is set (and the fstests installation doesn't include a full set of fstests source, but just those files installed by "make install").

Quoted 3 lines
Fixes 3e85dd4fe423 ("misc: add duration for long soak tests")
Cc Darrick J. Wong <[email protected]>

Oooooops,

--D

Quoted 21 lines
---
 src/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/Makefile +2 -1
index 24cd47479..aff871d04 100644
@@ -36,7 +36,8 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
 	uuid_ioctl
 
 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
-	      btrfs_crc32c_forged_name.py popdir.pl popattr.py
+	      btrfs_crc32c_forged_name.py popdir.pl popattr.py \
+	      soak_duration.awk
 
 SUBDIRS = log-writes perf
 
Signature · 1 line
2.31.0
#2 lore raw
Quoted 1 line · Darrick J. Wong
Quoted 1 line

installed or the checks script will bomb out of SOAK_DURATION is set

One more typo fix: s/of/if/

I think I've gotten way too spoiled by automatic spell/grammar checking in GMail and Google Docs....

- Ted

#3 lore raw
In reply to Theodore Ts'o
Quoted 4 lines · Theodore Ts'o

Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a helper executable, soak_duration.awk, is which used by the check script if SOAK_DURATION is set. This script translates a "human-firendly" time duration specifier, such as 4m or 2d into an

s/firendly/friendly/

Quoted 2 lines

integer number of seconds. We need to make sure that this script is installed or the checks script will bomb out of SOAK_DURATION is set

s/checks/check/

Quoted 2 lines

(and the fstests installation doesn't include a full set of fstests source, but just those files installed by "make install").

s/and/and if/

Apologies for the typos in the commit description.

- Ted

#4 lore raw
Quoted 11 lines · Theodore Ts'o
Quoted 4 lines · Theodore Ts'o

Commit 3e85dd4fe423 ("misc: add duration for long soak tests") added a helper executable, soak_duration.awk, is which used by the check script if SOAK_DURATION is set. This script translates a "human-firendly" time duration specifier, such as 4m or 2d into an

s/firendly/friendly/

Quoted 2 lines

integer number of seconds. We need to make sure that this script is installed or the checks script will bomb out of SOAK_DURATION is set

Quoted 8 lines

s/checks/check/

Quoted 2 lines

(and the fstests installation doesn't include a full set of fstests source, but just those files installed by "make install").

s/and/and if/

Apologies for the typos in the commit description.

Thanks for this fix, I'll fix that when I merge it.

Thanks,
Zorro

Quoted 3 lines

- Ted