Skip to contentSkip to conversation

firmware: Fix an NULL vs IS_ERR() bug in probe

PATCH New Dinh Nguyen 1 participant 1 message Jul 27, 2023

Subsystems (2)
Stable branch Intel STRATIX10 firmware drivers
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 firmware: Fix an NULL vs IS_ERR() bug in probe

From: Wang Ming <[email protected]>

The devm_memremap() function returns error pointers. It never returns NULL. Fix the check.

Fixes 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Cc [email protected]
Signed-off-by Wang Ming <[email protected]>
Signed-off-by Dinh Nguyen <[email protected]>
---
 drivers/firmware/stratix10-svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/stratix10-svc.c +1 -1
index 260695a8a9e6..c693da60e9a9 100644
@@ -774,7 +774,7 @@ svc_create_memory_pool(struct platform_device *pdev,
 	paddr = begin;
 	size = end - begin;
 	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
-	if (!va) {
+	if (IS_ERR(va)) {
 		dev_err(dev, "fail to remap shared memory\n");
 		return ERR_PTR(-EINVAL);
 	}
Signature · 1 line
2.25.1