Skip to contentSkip to conversation

mfd: Explicitly include correct DT includes

PATCH Applied Rob Herring 3 participants 4 messages Jul 14, 2023 – Sep 11, 2023

Subsystems (19)
Arm Qualcomm mailing list Memory technology devices (MTD) Arm MediaTek Arm Samsung Exynos +15 more subsystems
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 mfd: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Signed-off-by Rob Herring <[email protected]>
---
 drivers/mfd/ab8500-core.c           | 1 -
 drivers/mfd/acer-ec-a500.c          | 2 +-
 drivers/mfd/act8945a.c              | 2 +-
 drivers/mfd/altera-sysmgr.c         | 3 +--
 drivers/mfd/arizona-core.c          | 1 -
 drivers/mfd/atc260x-core.c          | 1 -
 drivers/mfd/bcm590xx.c              | 1 -
 drivers/mfd/cros_ec_dev.c           | 2 +-
 drivers/mfd/da9052-i2c.c            | 5 +----
 drivers/mfd/da9055-i2c.c            | 1 -
 drivers/mfd/da9062-core.c           | 2 +-
 drivers/mfd/hi655x-pmic.c           | 4 ++--
 drivers/mfd/iqs62x.c                | 2 +-
 drivers/mfd/lp873x.c                | 2 +-
 drivers/mfd/madera-i2c.c            | 1 -
 drivers/mfd/madera-spi.c            | 1 -
 drivers/mfd/max77620.c              | 1 -
 drivers/mfd/max77686.c              | 1 -
 drivers/mfd/max77843.c              | 2 +-
 drivers/mfd/max8907.c               | 1 -
 drivers/mfd/max8925-core.c          | 1 -
 drivers/mfd/max8997.c               | 1 -
 drivers/mfd/max8998.c               | 1 -
 drivers/mfd/mt6358-irq.c            | 5 ++---
 drivers/mfd/mt6397-core.c           | 5 +++--
 drivers/mfd/mt6397-irq.c            | 5 ++---
 drivers/mfd/palmas.c                | 3 ++-
 drivers/mfd/qcom-pm8008.c           | 2 +-
 drivers/mfd/rave-sp.c               | 2 +-
 drivers/mfd/rk8xx-core.c            | 2 +-
 drivers/mfd/rohm-bd71828.c          | 2 +-
 drivers/mfd/rohm-bd718x7.c          | 2 +-
 drivers/mfd/rohm-bd9576.c           | 2 +-
 drivers/mfd/rt5033.c                | 2 +-
 drivers/mfd/rz-mtu3.c               | 4 +++-
 drivers/mfd/sec-core.c              | 2 --
 drivers/mfd/sprd-sc27xx-spi.c       | 2 +-
 drivers/mfd/ssbi.c                  | 6 +++---
 drivers/mfd/stm32-lptimer.c         | 1 +
 drivers/mfd/stm32-timers.c          | 1 +
 drivers/mfd/sun4i-gpadc.c           | 4 ++--
 drivers/mfd/ti-lmu.c                | 1 -
 drivers/mfd/ti_am335x_tscadc.c      | 2 +-
 drivers/mfd/tps6507x.c              | 1 -
 drivers/mfd/tps65090.c              | 1 -
 drivers/mfd/tps65217.c              | 1 -
 drivers/mfd/tps65218.c              | 1 -
 drivers/mfd/tps6594-core.c          | 2 +-
 drivers/mfd/twl6040.c               | 2 --
 drivers/mfd/wm831x-core.c           | 3 +--
 drivers/mtd/chips/cfi_cmdset_0002.c | 3 +--
 51 files changed, 42 insertions(+), 66 deletions(-)
drivers/mfd/ab8500-core.c +0 -1
index 9d9e9787d5e8..15c95828b09a 100644
@@ -21,7 +21,6 @@
 #include <linux/mfd/abx500/ab8500.h>
 #include <linux/mfd/dbx500-prcmu.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 /*
  * Interrupt register offsets
drivers/mfd/acer-ec-a500.c +1 -1
index feb757e90dc3..79405835ff8e 100644
@@ -9,7 +9,7 @@
 #include <linux/i2c.h>
 #include <linux/mfd/core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/reboot.h>
 #include <linux/regmap.h>
drivers/mfd/act8945a.c +1 -1
index 2406fcdff5f9..64876537f066 100644
@@ -10,7 +10,7 @@
 #include <linux/i2c.h>
 #include <linux/mfd/core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 
 static const struct mfd_cell act8945a_devs[] = {
drivers/mfd/altera-sysmgr.c +1 -2
index af205813b281..0e52bd2ebd74 100644
@@ -14,8 +14,7 @@
 #include <linux/mfd/syscon.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/arizona-core.c +0 -1
index c166fcd331f1..19a0adf8ce3d 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/core.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
drivers/mfd/atc260x-core.c +0 -1
index 7c5de3ae776e..67473b58b03d 100644
@@ -11,7 +11,6 @@
 #include <linux/mfd/core.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 
 #define ATC260X_CHIP_REV_MAX	31
drivers/mfd/bcm590xx.c +0 -1
index 9f39b46b87f4..92eede9a5e61 100644
@@ -14,7 +14,6 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/cros_ec_dev.c +1 -1
index 92f4dfccc3cc..79d393b602bf 100644
@@ -10,7 +10,7 @@
 #include <linux/mfd/core.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/platform_data/cros_ec_chardev.h>
 #include <linux/platform_data/cros_ec_commands.h>
drivers/mfd/da9052-i2c.c +1 -4
index 541e2d47677e..fd000a21bcba 100644
@@ -13,14 +13,11 @@
 #include <linux/mfd/core.h>
 #include <linux/i2c.h>
 #include <linux/err.h>
+#include <linux/of.h>
 
 #include <linux/mfd/da9052/da9052.h>
 #include <linux/mfd/da9052/reg.h>
 
-#ifdef CONFIG_OF
-#include <linux/of.h>
-#include <linux/of_device.h>
-#endif
 
 /* I2C safe register check */
 static inline bool i2c_safe_reg(unsigned char reg)
drivers/mfd/da9055-i2c.c +0 -1
index bbaf4f07f274..9a5f51b60bad 100644
@@ -11,7 +11,6 @@
 #include <linux/i2c.h>
 #include <linux/err.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 #include <linux/mfd/da9055/core.h>
drivers/mfd/da9062-core.c +1 -1
index 48f58b6f5629..45da007d3e70 100644
@@ -9,7 +9,7 @@
 #include <linux/init.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 #include <linux/irq.h>
 #include <linux/mfd/core.h>
drivers/mfd/hi655x-pmic.c +2 -2
index a58e42ddcd0c..e6c5bd50751e 100644
@@ -16,7 +16,7 @@
 #include <linux/mfd/hi655x-pmic.h>
 #include <linux/module.h>
 #include <linux/gpio/consumer.h>
-#include <linux/of_platform.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 

@@ -163,7 +163,7 @@ MODULE_DEVICE_TABLE(of, hi655x_pmic_match);
 static struct platform_driver hi655x_pmic_driver = {
 	.driver	= {
 		.name =	"hi655x-pmic",
-		.of_match_table = of_match_ptr(hi655x_pmic_match),
+		.of_match_table = hi655x_pmic_match,
 	},
 	.probe  = hi655x_pmic_probe,
 	.remove = hi655x_pmic_remove,
drivers/mfd/iqs62x.c +1 -1
index dfe9cb79e6a1..e03b4d38fbb0 100644
@@ -27,7 +27,7 @@
 #include <linux/mfd/iqs62x.h>
 #include <linux/module.h>
 #include <linux/notifier.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/lp873x.c +1 -1
index 6639f0fad4ea..de7ab7aed3c6 100644
@@ -7,8 +7,8 @@
 
 #include <linux/interrupt.h>
 #include <linux/mfd/core.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 
 #include <linux/mfd/lp873x.h>
drivers/mfd/madera-i2c.c +0 -1
index 0968aa9733ac..a404ea26bc79 100644
@@ -10,7 +10,6 @@
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 
 #include <linux/mfd/madera/core.h>
drivers/mfd/madera-spi.c +0 -1
index da84eb50e53a..ad07ebe29e59 100644
@@ -9,7 +9,6 @@
 #include <linux/err.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 #include <linux/spi/spi.h>
drivers/mfd/max77620.c +0 -1
index 5811ed8f4840..e63e8e47d908 100644
@@ -30,7 +30,6 @@
 #include <linux/mfd/max77620.h>
 #include <linux/init.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/max77686.c +0 -1
index 01833086ca7d..91c286c4571c 100644
@@ -20,7 +20,6 @@
 #include <linux/mfd/max77686-private.h>
 #include <linux/err.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 static const struct mfd_cell max77686_devs[] = {
 	{ .name = "max77686-pmic", },
drivers/mfd/max77843.c +1 -1
index b3689c13a14d..fcff0c498c0f 100644
@@ -13,7 +13,7 @@
 #include <linux/mfd/core.h>
 #include <linux/mfd/max77693-common.h>
 #include <linux/mfd/max77843-private.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 static const struct mfd_cell max77843_devs[] = {
drivers/mfd/max8907.c +0 -1
index 78b5ee688dec..8bbe7979db91 100644
@@ -15,7 +15,6 @@
 #include <linux/mfd/max8907.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/max8925-core.c +0 -1
index 0246bbe80354..105d79b91493 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/core.h>
 #include <linux/mfd/max8925.h>
 #include <linux/of.h>
-#include <linux/of_platform.h>
 
 static const struct resource bk_resources[] = {
 	{ 0x84, 0x84, "mode control", IORESOURCE_REG, },
drivers/mfd/max8997.c +0 -1
index 94c09a5eab32..110bef71f208 100644
@@ -11,7 +11,6 @@
 #include <linux/slab.h>
 #include <linux/i2c.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/interrupt.h>
 #include <linux/pm_runtime.h>
drivers/mfd/max8998.c +0 -1
index 33a3ec5464fb..4cc426a6c767 100644
@@ -12,7 +12,6 @@
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/pm_runtime.h>
 #include <linux/mutex.h>
drivers/mfd/mt6358-irq.c +2 -3
index 389756436af6..49830b526ee8 100644
@@ -3,6 +3,8 @@
 // Copyright (c) 2020 MediaTek Inc.
 
 #include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/irqdomain.h>
 #include <linux/mfd/mt6357/core.h>
 #include <linux/mfd/mt6357/registers.h>
 #include <linux/mfd/mt6358/core.h>

@@ -11,9 +13,6 @@
 #include <linux/mfd/mt6359/registers.h>
 #include <linux/mfd/mt6397/core.h>
 #include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
-#include <linux/of_irq.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
drivers/mfd/mt6397-core.c +3 -2
index f6c1f80f94a4..4449dde05021 100644
@@ -6,9 +6,10 @@
 
 #include <linux/interrupt.h>
 #include <linux/ioport.h>
+#include <linux/irqdomain.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
-#include <linux/of_irq.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/mt6323/core.h>
drivers/mfd/mt6397-irq.c +2 -3
index 72f923e47752..886745b5b607 100644
@@ -3,10 +3,9 @@
 // Copyright (c) 2019 MediaTek Inc.
 
 #include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/irqdomain.h>
 #include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
-#include <linux/of_irq.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/suspend.h>
drivers/mfd/palmas.c +2 -1
index a36f12402987..6e562bab62e4 100644
@@ -18,7 +18,8 @@
 #include <linux/err.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/palmas.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
 
 static const struct regmap_config palmas_regmap_config[PALMAS_NUM_CLIENTS] = {
 	{
drivers/mfd/qcom-pm8008.c +1 -1
index 94a8cca1d955..3ac3742f438b 100644
@@ -9,7 +9,7 @@
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/pinctrl/consumer.h>
 #include <linux/regmap.h>
drivers/mfd/rave-sp.c +1 -1
index 545196c85b5c..da50eba10014 100644
@@ -18,7 +18,7 @@
 #include <linux/mfd/rave-sp.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/sched.h>
 #include <linux/serdev.h>
 #include <asm/unaligned.h>
drivers/mfd/rk8xx-core.c +1 -1
index e8fc9e2ab1d0..11a831e92da8 100644
@@ -14,7 +14,7 @@
 #include <linux/mfd/rk808.h>
 #include <linux/mfd/core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/reboot.h>
drivers/mfd/rohm-bd71828.c +1 -1
index 93d80a79b901..594718f7e8e1 100644
@@ -15,7 +15,7 @@
 #include <linux/mfd/rohm-bd71828.h>
 #include <linux/mfd/rohm-generic.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 #include <linux/types.h>
drivers/mfd/rohm-bd718x7.c +1 -1
index 0b58ecc78334..4798bdf27afb 100644
@@ -14,7 +14,7 @@
 #include <linux/mfd/rohm-bd718x7.h>
 #include <linux/mfd/core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 #include <linux/types.h>
drivers/mfd/rohm-bd9576.c +1 -1
index 645673322ec0..bceac7016740 100644
@@ -13,7 +13,7 @@
 #include <linux/mfd/rohm-bd957x.h>
 #include <linux/mfd/rohm-generic.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 #include <linux/types.h>
drivers/mfd/rt5033.c +1 -1
index 67b0a228db24..7e23ab3d5842 100644
@@ -10,9 +10,9 @@
  */
 
 #include <linux/err.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>
-#include <linux/of_device.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/rt5033.h>
 #include <linux/mfd/rt5033-private.h>
drivers/mfd/rz-mtu3.c +3 -1
index 04006f4aa702..47bf4469d093 100644
@@ -11,7 +11,9 @@
 #include <linux/irq.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/rz-mtu3.h>
-#include <linux/of_platform.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
 #include <linux/reset.h>
 #include <linux/spinlock.h>
drivers/mfd/sec-core.c +0 -2
index d2f631901886..a6b0d7300b2d 100644
@@ -10,8 +10,6 @@
 #include <linux/slab.h>
 #include <linux/i2c.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
-#include <linux/of_irq.h>
 #include <linux/interrupt.h>
 #include <linux/pm_runtime.h>
 #include <linux/mutex.h>
drivers/mfd/sprd-sc27xx-spi.c +1 -1
index d21f32cc784d..81e517cdfb27 100644
@@ -8,7 +8,7 @@
 #include <linux/module.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/sc27xx-pmic.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/regmap.h>
 #include <linux/spi/spi.h>
drivers/mfd/ssbi.c +3 -3
index dee89db3471d..b0b0be483dbf 100644
@@ -14,12 +14,12 @@
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/ssbi.h>
-#include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
 
 /* SSBI 2.0 controller registers */
 #define SSBI2_CMD			0x0008
drivers/mfd/stm32-lptimer.c +1 -0
index fa322f4412c8..b2704a9809c7 100644
@@ -9,6 +9,7 @@
 #include <linux/mfd/stm32-lptimer.h>
 #include <linux/module.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #define STM32_LPTIM_MAX_REGISTER	0x3fc
drivers/mfd/stm32-timers.c +1 -0
index 44ed2fce0319..5937c16b9fcf 100644
@@ -8,6 +8,7 @@
 #include <linux/mfd/stm32-timers.h>
 #include <linux/module.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/reset.h>
 
 #define STM32_TIMERS_MAX_REGISTERS	0x3fc
drivers/mfd/sun4i-gpadc.c +2 -2
index d1cbea27b136..3029d48e982c 100644
@@ -8,8 +8,8 @@
 #include <linux/kernel.h>
 #include <linux/mfd/core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
-#include <linux/of_irq.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 
 #include <linux/mfd/sun4i-gpadc.h>
drivers/mfd/ti-lmu.c +0 -1
index 4f06adad7b5e..cfc9f88b9842 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/ti-lmu-register.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/slab.h>
 
 struct ti_lmu_data {
drivers/mfd/ti_am335x_tscadc.c +1 -1
index 07825cfd8aa8..8762732bc691 100644
@@ -14,7 +14,7 @@
 #include <linux/mfd/core.h>
 #include <linux/pm_runtime.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/platform_device.h>
 #include <linux/sched.h>
 
 #include <linux/mfd/ti_am335x_tscadc.h>
drivers/mfd/tps6507x.c +0 -1
index 9716bf703c7a..95dafb0e9f00 100644
@@ -20,7 +20,6 @@
 #include <linux/slab.h>
 #include <linux/i2c.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/mfd/core.h>
 #include <linux/mfd/tps6507x.h>
drivers/mfd/tps65090.c +0 -1
index a35ad70755fb..9245e11219f3 100644
@@ -17,7 +17,6 @@
 #include <linux/mfd/core.h>
 #include <linux/mfd/tps65090.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/err.h>
 
 #define NUM_INT_REG 2
drivers/mfd/tps65217.c +0 -1
index 60599291b315..029ecc32f078 100644
@@ -17,7 +17,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
drivers/mfd/tps65218.c +0 -1
index 619bf7adb20c..11e4e52b56be 100644
@@ -15,7 +15,6 @@
 #include <linux/regmap.h>
 #include <linux/err.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/mutex.h>
drivers/mfd/tps6594-core.c +1 -1
index 15f314833207..0fb9c5cf213a 100644
@@ -9,7 +9,7 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 
 #include <linux/mfd/core.h>
 #include <linux/mfd/tps6594.h>
drivers/mfd/twl6040.c +0 -2
index d85675a4d9a8..9ce34dfd99b3 100644
@@ -16,8 +16,6 @@
 #include <linux/err.h>
 #include <linux/platform_device.h>
 #include <linux/of.h>
-#include <linux/of_irq.h>
-#include <linux/of_platform.h>
 #include <linux/gpio/consumer.h>
 #include <linux/delay.h>
 #include <linux/i2c.h>
drivers/mfd/wm831x-core.c +1 -2
index e86b6a4896a6..e7e68929275e 100644
@@ -15,8 +15,7 @@
 #include <linux/mfd/core.h>
 #include <linux/slab.h>
 #include <linux/err.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 
 #include <linux/mfd/wm831x/core.h>
 #include <linux/mfd/wm831x/pdata.h>
drivers/mtd/chips/cfi_cmdset_0002.c +1 -2
index 153fb8d0008e..df589d9b4d70 100644
@@ -32,7 +32,6 @@
 #include <linux/interrupt.h>
 #include <linux/reboot.h>
 #include <linux/of.h>
-#include <linux/of_platform.h>
 #include <linux/mtd/map.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/cfi.h>

@@ -650,7 +649,7 @@ struct mtd_info *cfi_cmdset_0002(struct map_info *map, int primary)
 
 			/*
 			 * Valid primary extension versions are: 1.0, 1.1, 1.2, 1.3, 1.4, 1.5
-			 * see: http://cs.ozerki.net/zap/pub/axim-x5/docs/cfi_r20.pdf, page 19 
+			 * see: http://cs.ozerki.net/zap/pub/axim-x5/docs/cfi_r20.pdf, page 19
 			 *      http://www.spansion.com/Support/AppNotes/cfi_100_20011201.pdf
 			 *      http://www.spansion.com/Support/Datasheets/s29ws-p_00_a12_e.pdf
 			 *      http://www.spansion.com/Support/Datasheets/S29GL_128S_01GS_00_02_e.pdf
Signature · 1 line
2.40.1
maintainer Applied
#1 lore raw
Quoted 55 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Signed-off-by Rob Herring <[email protected]>
---
 drivers/mfd/ab8500-core.c           | 1 -
 drivers/mfd/acer-ec-a500.c          | 2 +-
 drivers/mfd/act8945a.c              | 2 +-
 drivers/mfd/altera-sysmgr.c         | 3 +--
 drivers/mfd/arizona-core.c          | 1 -
 drivers/mfd/atc260x-core.c          | 1 -
 drivers/mfd/bcm590xx.c              | 1 -
 drivers/mfd/cros_ec_dev.c           | 2 +-
 drivers/mfd/da9052-i2c.c            | 5 +----
 drivers/mfd/da9055-i2c.c            | 1 -
 drivers/mfd/da9062-core.c           | 2 +-
 drivers/mfd/hi655x-pmic.c           | 4 ++--
 drivers/mfd/iqs62x.c                | 2 +-
 drivers/mfd/lp873x.c                | 2 +-
 drivers/mfd/madera-i2c.c            | 1 -
 drivers/mfd/madera-spi.c            | 1 -
 drivers/mfd/max77620.c              | 1 -
 drivers/mfd/max77686.c              | 1 -
 drivers/mfd/max77843.c              | 2 +-
 drivers/mfd/max8907.c               | 1 -
 drivers/mfd/max8925-core.c          | 1 -
 drivers/mfd/max8997.c               | 1 -
 drivers/mfd/max8998.c               | 1 -
 drivers/mfd/mt6358-irq.c            | 5 ++---
 drivers/mfd/mt6397-core.c           | 5 +++--
 drivers/mfd/mt6397-irq.c            | 5 ++---
 drivers/mfd/palmas.c                | 3 ++-
 drivers/mfd/qcom-pm8008.c           | 2 +-
 drivers/mfd/rave-sp.c               | 2 +-
 drivers/mfd/rk8xx-core.c            | 2 +-
 drivers/mfd/rohm-bd71828.c          | 2 +-
 drivers/mfd/rohm-bd718x7.c          | 2 +-
 drivers/mfd/rohm-bd9576.c           | 2 +-
 drivers/mfd/rt5033.c                | 2 +-
 drivers/mfd/rz-mtu3.c               | 4 +++-
 drivers/mfd/sec-core.c              | 2 --
 drivers/mfd/sprd-sc27xx-spi.c       | 2 +-
 drivers/mfd/ssbi.c                  | 6 +++---
 drivers/mfd/stm32-lptimer.c         | 1 +
 drivers/mfd/stm32-timers.c          | 1 +
 drivers/mfd/sun4i-gpadc.c           | 4 ++--
 drivers/mfd/ti-lmu.c                | 1 -
 drivers/mfd/ti_am335x_tscadc.c      | 2 +-
 drivers/mfd/tps6507x.c              | 1 -
Quoted 8 lines
 drivers/mfd/tps65090.c              | 1 -
 drivers/mfd/tps65217.c              | 1 -
 drivers/mfd/tps65218.c              | 1 -
 drivers/mfd/tps6594-core.c          | 2 +-
 drivers/mfd/twl6040.c               | 2 --
 drivers/mfd/wm831x-core.c           | 3 +--
 drivers/mtd/chips/cfi_cmdset_0002.c | 3 +--
 51 files changed, 42 insertions(+), 66 deletions(-)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]
CI Applied
#2 lore raw
In reply to Rob Herring
This patch was applied to chrome-platform/linux.git (for-kernelci) by Lee Jones <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Lee Jones <[email protected]>:

Quoted 10 lines · On Fri, 14 Jul 2023 11:47:27 -0600 you wrote:

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

[...]

Here is the summary with links:
- mfd: Explicitly include correct DT includes

    https://git.kernel.org/chrome-platform/c/dc0c386e09a7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
CI Applied
#3 lore raw
In reply to Rob Herring
This patch was applied to chrome-platform/linux.git (for-next) by Lee Jones <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Lee Jones <[email protected]>:

Quoted 10 lines · On Fri, 14 Jul 2023 11:47:27 -0600 you wrote:

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

[...]

Here is the summary with links:
- mfd: Explicitly include correct DT includes

    https://git.kernel.org/chrome-platform/c/dc0c386e09a7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html