Skip to contentSkip to conversation

s390/certstore: select CRYPTO_LIB_SHA256

PATCH Applied Sven Schnelle 3 participants 3 messages Jul 28, 2023 – Aug 1, 2023

Subsystems (2)
lore
Share & tools
lore

Sven Schnelle

author reviewer
#0 lore raw

PATCH 1/1 s390/certstore: select CRYPTO_LIB_SHA256

A build failure was reported when sha256() is not present:

gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'

Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.

Fixes 8cf57d7217c3 ("s390: add support for user-defined certificates")
---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/s390/Kconfig +1 -0
index d9d50a7a2016..18bf754e1fad 100644
@@ -516,6 +516,7 @@ config KEXEC_SIG
 config CERT_STORE
 	bool "Get user certificates via DIAG320"
 	depends on KEYS
+	select CRYPTO_LIB_SHA256
 	help
 	  Enable this option if you want to access user-provided secure boot
 	  certificates via DIAG 0x320.
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 7 lines · Sven Schnelle

A build failure was reported when sha256() is not present:

gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'

Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.

Quoted 7 lines
Fixes 8cf57d7217c3 ("s390: add support for user-defined certificates")
---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks!

Tested-by Acked-by on v1 1/1
#2 lore raw
In reply to Sven Schnelle
Quoted 11 lines · Sven Schnelle

A build failure was reported when sha256() is not present:

gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'

Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.

Fixes 8cf57d7217c3 ("s390: add support for user-defined certificates")

Sorry for the delay.

Thanks.

Quoted 16 lines
---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/s390/Kconfig +1 -0
index d9d50a7a2016..18bf754e1fad 100644
@@ -516,6 +516,7 @@ config KEXEC_SIG
 config CERT_STORE
 	bool "Get user certificates via DIAG320"
 	depends on KEYS
+	select CRYPTO_LIB_SHA256
 	help
 	  Enable this option if you want to access user-provided secure boot
 	  certificates via DIAG 0x320.
Signature · 1 line
~Randy