Skip to contentSkip to conversation

MAINTAINERS: add documentation to PSI section

PATCH Applied Ramazan Safiullin 6 participants 9 messages Jul 28, 2023 – Aug 9, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: add documentation to PSI section

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index a5c16bb92fe2..2da6643b9488 100644
@@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <[email protected]>
 M:	Suren Baghdasaryan <[email protected]>
 S:	Maintained
+F:	Documentation/accounting/psi.rst
 F:	include/linux/psi*
 F:	kernel/sched/psi.c
 
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ramazan Safiullin

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

Quoted 19 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index a5c16bb92fe2..2da6643b9488 100644
@@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
 M:     Johannes Weiner <[email protected]>
 M:     Suren Baghdasaryan <[email protected]>
 S:     Maintained
+F:     Documentation/accounting/psi.rst
 F:     include/linux/psi*
 F:     kernel/sched/psi.c
 
--

2.25.1

#2 lore raw
Quoted 4 lines · Suren Baghdasaryan
Quoted 1 line · Ramazan Safiullin
Quoted 8 lines
Quoted 6 lines

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

CC'ing Peter to pick up into his tree.

Quoted 20 lines
Quoted 20 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index a5c16bb92fe2..2da6643b9488 100644
@@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
 M:     Johannes Weiner <[email protected]>
 M:     Suren Baghdasaryan <[email protected]>
 S:     Maintained
+F:     Documentation/accounting/psi.rst
 F:     include/linux/psi*
 F:     kernel/sched/psi.c
 
--

2.25.1

#3 lore raw
Quoted 8 lines · Suren Baghdasaryan
Quoted 7 lines · Suren Baghdasaryan
Quoted 4 lines · Ramazan Safiullin

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Add entry for psi documentation.

CC'ing Peter to pick up into his tree.

Well, I'd need the actual patch email, otherwise I can't apply. Either bounce the thread or have it be resent.

Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -1
index a5c16bb92fe2..2da6643b9488 100644
@@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
 M:     Johannes Weiner <[email protected]>
 M:     Suren Baghdasaryan <[email protected]>
 S:     Maintained
+F:     Documentation/accounting/psi.rst
 F:     include/linux/psi*
 F:     kernel/sched/psi.c
 
--

2.25.1

#4 lore raw
Quoted 12 lines · Peter Zijlstra
Quoted 10 lines · Suren Baghdasaryan
Quoted 9 lines · Suren Baghdasaryan
Quoted 6 lines · Ramazan Safiullin

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

CC'ing Peter to pick up into his tree.

Well, I'd need the actual patch email, otherwise I can't apply. Either bounce the thread or have it be resent.

Speaking on behalf of Ramazan, who I am working with:

Suren, Peter, should we actually better just add you, Peter, as a reviewer to PSI in MAINTAINERS, so that you get all the patches to psi stuff in your mailbox and you just need to wait for an Ack from Suren or Johannes?

Then, we could fix this up in the PSI section and just send out a v2 with the current Ack from Suren and Peter in CC.

And we will fix the typo in the commit message above:
s/MAINTENERS/MAINTAINERS/

Lukas

#5 lore raw
Quoted 23 lines · Lukas Bulwahn
Quoted 12 lines · Peter Zijlstra
Quoted 10 lines · Suren Baghdasaryan
Quoted 9 lines · Suren Baghdasaryan
Quoted 6 lines · Ramazan Safiullin

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

CC'ing Peter to pick up into his tree.

Well, I'd need the actual patch email, otherwise I can't apply. Either bounce the thread or have it be resent.

Quoted 6 lines

Speaking on behalf of Ramazan, who I am working with:

Suren, Peter, should we actually better just add you, Peter, as a reviewer to PSI in MAINTAINERS, so that you get all the patches to psi stuff in your mailbox and you just need to wait for an Ack from Suren or Johannes?

Well, mostly psi patches touch kernel/sched/psi.c and then I should get it anyway (throught the kernel/sched/ glob). But sure, one more copy of my email address in that file isn't going to hurt..

#6 lore raw
Quoted 26 lines · Peter Zijlstra
Quoted 25 lines · Lukas Bulwahn
Quoted 12 lines · Peter Zijlstra
Quoted 10 lines · Suren Baghdasaryan
Quoted 9 lines · Suren Baghdasaryan
Quoted 6 lines · Ramazan Safiullin

While creating a patch for the psi documentation I noticed that MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

CC'ing Peter to pick up into his tree.

Well, I'd need the actual patch email, otherwise I can't apply. Either bounce the thread or have it be resent.

Speaking on behalf of Ramazan, who I am working with:

Quoted 8 lines
Quoted 4 lines

Suren, Peter, should we actually better just add you, Peter, as a reviewer to PSI in MAINTAINERS, so that you get all the patches to psi stuff in your mailbox and you just need to wait for an Ack from Suren or Johannes?

Well, mostly psi patches touch kernel/sched/psi.c and then I should get it anyway (throught the kernel/sched/ glob). But sure, one more copy of my email address in that file isn't going to hurt..

From f00cd5986718e7ff435444523305d480b54e34e8 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 1 Aug 2023 09:18:21 -0400
Subject: [PATCH] MAINTAINERS: add Peter explicitly to the psi section

Peter is kind enough to route the low-volume psi patches through the scheduler tree, but he is frequently not CC'd on them.

While he is matched through the SCHEDULER maintainers and reviewers on kern/sched/*, that list is long, and mostly not applicable to psi code. Thus, patch submitters often just CC the explicit PSI entries.

Add him to that section, to make sure he gets those patches.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 3be1bdfe8ecc..b68f3ab368c1 100644
@@ -17037,6 +17037,7 @@ F:	drivers/net/ppp/pptp.c
 PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <[email protected]>
 M:	Suren Baghdasaryan <[email protected]>
+R:	Peter Ziljstra <[email protected]>
 S:	Maintained
 F:	include/linux/psi*
 F:	kernel/sched/psi.c
Signature · 1 line
2.41.0
#7 lore raw
Quoted 8 lines · Johannes Weiner

From f00cd5986718e7ff435444523305d480b54e34e8 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <[email protected]>
Date: Tue, 1 Aug 2023 09:18:21 -0400
Subject: [PATCH] MAINTAINERS: add Peter explicitly to the psi section

Peter is kind enough to route the low-volume psi patches through the scheduler tree, but he is frequently not CC'd on them.

Quoted 7 lines

While he is matched through the SCHEDULER maintainers and reviewers on kern/sched/*, that list is long, and mostly not applicable to psi code. Thus, patch submitters often just CC the explicit PSI entries.

Add him to that section, to make sure he gets those patches.

Thanks!

Quoted 18 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 3be1bdfe8ecc..b68f3ab368c1 100644
@@ -17037,6 +17037,7 @@ F:	drivers/net/ppp/pptp.c
 PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <[email protected]>
 M:	Suren Baghdasaryan <[email protected]>
+R:	Peter Ziljstra <[email protected]>
 S:	Maintained
 F:	include/linux/psi*
 F:	kernel/sched/psi.c
Signature · 1 line
2.41.0
#8 lore raw

[tip: sched/core] MAINTAINERS: Add Peter explicitly to the psi section

In reply to Johannes Weiner
The following commit has been merged into the sched/core branch of tip:

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     113d0a6b3954b57907d1a6e3209f4174f504e0ae
Gitweb:        https://git.kernel.org/tip/113d0a6b3954b57907d1a6e3209f4174f504e0ae
Author:        Johannes Weiner <[email protected]>
AuthorDate:    Tue, 01 Aug 2023 09:18:21 -04:00
Committer:     Peter Zijlstra <[email protected]>
CommitterDate: Wed, 02 Aug 2023 16:19:25 +02:00

MAINTAINERS: Add Peter explicitly to the psi section

Peter is kind enough to route the low-volume psi patches through the scheduler tree, but he is frequently not CC'd on them.

While he is matched through the SCHEDULER maintainers and reviewers on kern/sched/*, that list is long, and mostly not applicable to psi code. Thus, patch submitters often just CC the explicit PSI entries.

Add him to that section, to make sure he gets those patches.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index aee3406..f017dc6 100644
@@ -17047,6 +17047,7 @@ F:	drivers/net/ppp/pptp.c
 PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <[email protected]>
 M:	Suren Baghdasaryan <[email protected]>
+R:	Peter Ziljstra <[email protected]>
 S:	Maintained
 F:	include/linux/psi*
 F:	kernel/sched/psi.c