Skip to contentSkip to conversation

gpio: rc5t583: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Jul 28, 2023 – Aug 1, 2023 GPIO

lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH 1/1 gpio: rc5t583: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-rc5t583.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-rc5t583.c +0 -2
index 4fae3ebea790..c34dcadaee36 100644
@@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
 	if (pdata && pdata->gpio_base)
 		rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
 
-	platform_set_drvdata(pdev, rc5t583_gpio);
-
 	return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
 				      rc5t583_gpio);
 }
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 26 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-rc5t583.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-rc5t583.c +0 -3
index 4fae3ebea790..c34dcadaee36 100644
@@ -121,8 +121,6 @@ static int rc5t583_gpio_probe(struct platform_device *pdev)
        if (pdata && pdata->gpio_base)
                rc5t583_gpio->gpio_chip.base = pdata->gpio_base;
 
-       platform_set_drvdata(pdev, rc5t583_gpio);
-
        return devm_gpiochip_add_data(&pdev->dev, &rc5t583_gpio->gpio_chip,
                                      rc5t583_gpio);
 }
--
Quoted 2 lines

2.34.1

Applied, thanks!

Bartosz