Skip to contentSkip to conversation

phy: realtek: usb: phy-rtk-usb2 and phy-rtk-usb3 needs USB_COMMON

PATCH New Stanley Chang 1 participant 1 message Jul 29, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: realtek: usb: phy-rtk-usb2 and phy-rtk-usb3 needs USB_COMMON

When USB_COMMON are not enabled, phy-rtk-usb2 and phy-rtk-usb3 suffers a build error due to a missing usb_debug_root that is provided by CONFIG_USB_COMMON, so make the driver select USB_COMMON.

or1k-linux-ld: drivers/phy/realtek/phy-rtk-usb2.o: in function `create_phy_debug_root':

Quoted 2 lines
Quoted 2 lines

drivers/phy/realtek/phy-rtk-usb2.c:715: undefined reference to `usb_debug_root'
or1k-linux-ld: drivers/phy/realtek/phy-rtk-usb2.c:715: undefined reference to `usb_debug_root'

or1k-linux-ld: drivers/phy/realtek/phy-rtk-usb3.o: in function `create_phy_debug_root':

Quoted 2 lines
Quoted 2 lines

drivers/phy/realtek/phy-rtk-usb3.c:349: undefined reference to `usb_debug_root'
or1k-linux-ld: drivers/phy/realtek/phy-rtk-usb3.c:349: undefined reference to `usb_debug_root'

Fixes 134e6d25f6bd ("phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY")

Fixed: adda6e82a7de ("phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY")

---
 drivers/phy/realtek/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/phy/realtek/Kconfig +2 -0
index a5a5a71edc9c..650e20ed69af 100644
@@ -7,6 +7,7 @@ config PHY_RTK_RTD_USB2PHY
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_PHY
+	select USB_COMMON
 	help
 	  Enable this to support Realtek SoC USB2 phy transceiver.
 	  The DHC (digital home center) RTD series SoCs used the Synopsys
@@ -18,6 +19,7 @@ config PHY_RTK_RTD_USB3PHY
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_PHY
+	select USB_COMMON
 	help
 	  Enable this to support Realtek SoC USB3 phy transceiver.
 	  The DHC (digital home center) RTD series SoCs used the Synopsys
Signature · 1 line
2.34.1