Skip to contentSkip to conversation

kni: remove deprecated kernel network interface

PATCH Superseded Stephen Hemminger 3 participants 10 messages Jul 29, 2023 – Aug 1, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kni: remove deprecated kernel network interface

Deprecation and removal was announced in 22.11.
Make it so.

---
 MAINTAINERS                                   |  10 -
 app/test/meson.build                          |   2 -
 app/test/test_kni.c                           | 740 ---------------
 doc/api/doxy-api-index.md                     |   2 -
 doc/api/doxy-api.conf.in                      |   1 -
 doc/guides/contributing/documentation.rst     |   2 +-
 doc/guides/howto/flow_bifurcation.rst         |   3 +-
 doc/guides/nics/index.rst                     |   1 -
 doc/guides/nics/kni.rst                       | 170 ----
 doc/guides/nics/virtio.rst                    |  92 +-
 .../prog_guide/env_abstraction_layer.rst      |   2 -
 doc/guides/prog_guide/glossary.rst            |   3 -
 doc/guides/prog_guide/index.rst               |   1 -
 .../prog_guide/kernel_nic_interface.rst       | 423 ---------
 doc/guides/prog_guide/packet_framework.rst    |   9 +-
 doc/guides/rel_notes/deprecation.rst          |   9 +-
 doc/guides/rel_notes/release_23_11.rst        |  16 +
 doc/guides/sample_app_ug/ip_pipeline.rst      |  22 -
 drivers/net/cnxk/cnxk_ethdev.c                |   2 +-
 drivers/net/kni/meson.build                   |  11 -
 drivers/net/kni/rte_eth_kni.c                 | 524 -----------
 drivers/net/meson.build                       |   1 -
 examples/ip_pipeline/Makefile                 |   1 -
 examples/ip_pipeline/cli.c                    |  95 --
 examples/ip_pipeline/examples/kni.cli         |  69 --
 examples/ip_pipeline/kni.c                    | 168 ----
 examples/ip_pipeline/kni.h                    |  46 -
 examples/ip_pipeline/main.c                   |  10 -
 examples/ip_pipeline/meson.build              |   1 -
 examples/ip_pipeline/pipeline.c               |  57 --
 examples/ip_pipeline/pipeline.h               |   2 -
 kernel/linux/kni/Kbuild                       |   6 -
 kernel/linux/kni/compat.h                     | 157 ----
 kernel/linux/kni/kni_dev.h                    | 137 ---
 kernel/linux/kni/kni_fifo.h                   |  87 --
 kernel/linux/kni/kni_misc.c                   | 719 --------------
 kernel/linux/kni/kni_net.c                    | 878 ------------------
 kernel/linux/kni/meson.build                  |  41 -
 kernel/linux/meson.build                      | 103 --
 lib/eal/common/eal_common_log.c               |   1 -
 lib/eal/include/rte_log.h                     |   2 +-
 lib/eal/linux/eal.c                           |  19 -
 lib/kni/meson.build                           |  21 -
 lib/kni/rte_kni.c                             | 843 -----------------
 lib/kni/rte_kni.h                             | 269 ------
 lib/kni/rte_kni_common.h                      | 147 ---
 lib/kni/rte_kni_fifo.h                        | 117 ---
 lib/kni/version.map                           |  24 -
 lib/meson.build                               |   3 -
 lib/port/meson.build                          |   6 -
 lib/port/rte_port_kni.c                       | 515 ----------
 lib/port/rte_port_kni.h                       |  63 --
 lib/port/version.map                          |   3 -
 meson_options.txt                             |   2 +-
 54 files changed, 26 insertions(+), 6632 deletions(-)
 delete mode 100644 app/test/test_kni.c
 delete mode 100644 doc/guides/nics/kni.rst
 delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst
 create mode 100644 doc/guides/rel_notes/release_23_11.rst
 delete mode 100644 drivers/net/kni/meson.build
 delete mode 100644 drivers/net/kni/rte_eth_kni.c
 delete mode 100644 examples/ip_pipeline/examples/kni.cli
 delete mode 100644 examples/ip_pipeline/kni.c
 delete mode 100644 examples/ip_pipeline/kni.h
 delete mode 100644 kernel/linux/kni/Kbuild
 delete mode 100644 kernel/linux/kni/compat.h
 delete mode 100644 kernel/linux/kni/kni_dev.h
 delete mode 100644 kernel/linux/kni/kni_fifo.h
 delete mode 100644 kernel/linux/kni/kni_misc.c
 delete mode 100644 kernel/linux/kni/kni_net.c
 delete mode 100644 kernel/linux/kni/meson.build
 delete mode 100644 kernel/linux/meson.build
 delete mode 100644 lib/kni/meson.build
 delete mode 100644 lib/kni/rte_kni.c
 delete mode 100644 lib/kni/rte_kni.h
 delete mode 100644 lib/kni/rte_kni_common.h
 delete mode 100644 lib/kni/rte_kni_fifo.h
 delete mode 100644 lib/kni/version.map
 delete mode 100644 lib/port/rte_port_kni.c
 delete mode 100644 lib/port/rte_port_kni.h
MAINTAINERS +0 -10
index 18bc05fccd0d..6ad45569bcd2 100644
@@ -617,12 +617,6 @@ F: doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
 F: app/test/test_link_bonding*
 F: examples/bond/
 
-Linux KNI
-F: kernel/linux/kni/
-F: lib/kni/
-F: doc/guides/prog_guide/kernel_nic_interface.rst
-F: app/test/test_kni.c
-
 Linux AF_PACKET
 M: John W. Linville <[email protected]>
 F: drivers/net/af_packet/
@@ -1027,10 +1021,6 @@ F: drivers/net/tap/
 F: doc/guides/nics/tap.rst
 F: doc/guides/nics/features/tap.ini
 
-KNI PMD
-F: drivers/net/kni/
-F: doc/guides/nics/kni.rst
-
 Ring PMD
 M: Bruce Richardson <[email protected]>
 F: drivers/net/ring/
app/test/meson.build +0 -2
index b89cf0368fb5..de895cc8fc52 100644
@@ -72,7 +72,6 @@ test_sources = files(
         'test_ipsec.c',
         'test_ipsec_sad.c',
         'test_ipsec_perf.c',
-        'test_kni.c',
         'test_kvargs.c',
         'test_lcores.c',
         'test_logs.c',
@@ -237,7 +236,6 @@ fast_tests = [
         ['fbarray_autotest', true, true],
         ['hash_readwrite_func_autotest', false, true],
         ['ipsec_autotest', true, true],
-        ['kni_autotest', false, true],
         ['kvargs_autotest', true, true],
         ['member_autotest', true, true],
         ['power_cpufreq_autotest', false, true],
app/test/test_kni.c deleted +0 -740

740 lines not on this page · raw message

doc/api/doxy-api-index.md +0 -2
index 3bc8778981f6..7bba67d58586 100644
@@ -43,7 +43,6 @@ The public API headers are grouped by topics:
   [bond](@ref rte_eth_bond.h),
   [vhost](@ref rte_vhost.h),
   [vdpa](@ref rte_vdpa.h),
-  [KNI](@ref rte_kni.h),
   [ixgbe](@ref rte_pmd_ixgbe.h),
   [i40e](@ref rte_pmd_i40e.h),
   [iavf](@ref rte_pmd_iavf.h),
@@ -178,7 +177,6 @@ The public API headers are grouped by topics:
     [frag](@ref rte_port_frag.h),
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
-    [kni](@ref rte_port_kni.h),
     [src/sink](@ref rte_port_source_sink.h)
   * [table](@ref rte_table.h):
     [lpm IPv4](@ref rte_table_lpm.h),
doc/api/doxy-api.conf.in +0 -1
index 1a4210b948a8..90dcf232dffd 100644
@@ -49,7 +49,6 @@ INPUT                   = @TOPDIR@/doc/api/doxy-api-index.md \
                           @TOPDIR@/lib/ip_frag \
                           @TOPDIR@/lib/ipsec \
                           @TOPDIR@/lib/jobstats \
-                          @TOPDIR@/lib/kni \
                           @TOPDIR@/lib/kvargs \
                           @TOPDIR@/lib/latencystats \
                           @TOPDIR@/lib/lpm \
doc/guides/contributing/documentation.rst +1 -1
index 7fcbb7fc43b2..f16c94e9768b 100644
@@ -95,7 +95,7 @@ added to by the developer.
 * **The Programmers Guide**
 
   The Programmers Guide explains how the API components of DPDK such as the EAL, Memzone, Rings and the Hash Library work.
-  It also explains how some higher level functionality such as Packet Distributor, Packet Framework and KNI work.
+  It also explains how some higher level functionality such as Packet Distributor and Packet Framework.
   It also shows the build system and explains how to add applications.
 
   The Programmers Guide should be expanded when new functionality is added to DPDK.
doc/guides/howto/flow_bifurcation.rst +1 -2
index 838eb2a4cc89..554dd24c32c5 100644
@@ -7,8 +7,7 @@ Flow Bifurcation How-to Guide
 Flow Bifurcation is a mechanism which uses hardware capable Ethernet devices
 to split traffic between Linux user space and kernel space. Since it is a
 hardware assisted feature this approach can provide line rate processing
-capability. Other than :ref:`KNI <kni>`, the software is just required to
-enable device configuration, there is no need to take care of the packet
+capability. There is no need to take care of the packet
 movement during the traffic split. This can yield better performance with
 less CPU overhead.
 
doc/guides/nics/index.rst +0 -1
index 31296822e5ec..7bfcac880f44 100644
@@ -43,7 +43,6 @@ Network Interface Controller Drivers
     ionic
     ipn3ke
     ixgbe
-    kni
     mana
     memif
     mlx4
doc/guides/nics/kni.rst deleted +0 -170

170 lines not on this page · raw message

doc/guides/nics/virtio.rst +1 -91

109 lines not on this page · raw message

doc/guides/prog_guide/env_abstraction_layer.rst +0 -2
index 93c8a031be56..5d382fdd9032 100644
@@ -610,8 +610,6 @@ devices would fail anyway.
     ``RTE_PCI_DRV_NEED_IOVA_AS_VA`` flag is used to dictate that this PCI
     driver can only work in RTE_IOVA_VA mode.
 
-    When the KNI kernel module is detected, RTE_IOVA_PA mode is preferred as a
-    performance penalty is expected in RTE_IOVA_VA mode.
 
 IOVA Mode Configuration
 ~~~~~~~~~~~~~~~~~~~~~~~
doc/guides/prog_guide/glossary.rst +0 -3
index fb0910ba5b3f..8d6349701e43 100644
@@ -103,9 +103,6 @@ lcore
    A logical execution unit of the processor, sometimes called a *hardware
    thread*.
 
-KNI
-   Kernel Network Interface
-
 L1
    Layer 1
 
doc/guides/prog_guide/index.rst +0 -1
index d89cd3edb63c..1be6a3d6d9b6 100644
@@ -54,7 +54,6 @@ Programmer's Guide
     pcapng_lib
     pdump_lib
     multi_proc_support
-    kernel_nic_interface
     thread_safety_dpdk_functions
     eventdev
     event_ethernet_rx_adapter
doc/guides/prog_guide/kernel_nic_interface.rst deleted +0 -423

423 lines not on this page · raw message

doc/guides/prog_guide/packet_framework.rst +3 -6
index 3d4e3b66cc5c..ebc69d8c3e75 100644
@@ -87,18 +87,15 @@ Port Types
    |   |                  | management and hierarchical scheduling according to pre-defined SLAs.                 |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 6 | KNI              | Send/receive packets to/from Linux kernel space.                                      |
-   |   |                  |                                                                                       |
-   +---+------------------+---------------------------------------------------------------------------------------+
-   | 7 | Source           | Input port used as packet generator. Similar to Linux kernel /dev/zero character      |
+   | 6 | Source           | Input port used as packet generator. Similar to Linux kernel /dev/zero character      |
    |   |                  | device.                                                                               |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 8 | Sink             | Output port used to drop all input packets. Similar to Linux kernel /dev/null         |
+   | 7 | Sink             | Output port used to drop all input packets. Similar to Linux kernel /dev/null         |
    |   |                  | character device.                                                                     |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 9 | Sym_crypto       | Output port used to extract DPDK Cryptodev operations from a fixed offset of the      |
+   | 8 | Sym_crypto       | Output port used to extract DPDK Cryptodev operations from a fixed offset of the      |
    |   |                  | packet and then enqueue to the Cryptodev PMD. Input port used to dequeue the          |
    |   |                  | Cryptodev operations from the Cryptodev PMD and then retrieve the packets from them.  |
    +---+------------------+---------------------------------------------------------------------------------------+
doc/guides/rel_notes/deprecation.rst +1 -8
index 494b401cda4b..fa619514fd64 100644
@@ -35,7 +35,7 @@ Deprecation Notices
     which also added support for standard atomics
     (Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html)
 
-* build: Enabling deprecated libraries (``flow_classify``, ``kni``)
+* build: Enabling deprecated libraries (``flow_classify``)
   won't be possible anymore through the use of the ``disable_libs`` build option.
   A new build option for deprecated libraries will be introduced instead.
 
@@ -78,13 +78,6 @@ Deprecation Notices
   ``__atomic_thread_fence`` must be used for patches that need to be merged in
   20.08 onwards. This change will not introduce any performance degradation.
 
-* kni: The KNI kernel module and library are not recommended for use by new
-  applications - other technologies such as virtio-user are recommended instead.
-  Following the DPDK technical board
-  `decision <https://mails.dpdk.org/archives/dev/2021-January/197077.html>`_
-  and `refinement <https://mails.dpdk.org/archives/dev/2022-June/243596.html>`_,
-  the KNI kernel module, library and PMD will be removed from the DPDK 23.11 release.
-
 * lib: will fix extending some enum/define breaking the ABI. There are multiple
   samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is
   used by iterators, and arrays holding these values are sized with this
doc/guides/rel_notes/release_23_11.rst new file +16 -0
new file mode 100644
index 000000000000..e2158934751f
@@ -0,0 +1,16 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2022 The DPDK contributors
+
+.. include:: <isonum.txt>
+
+DPDK Release 23.11
+==================
+
+New Features
+------------
+
+
+Removed Items
+-------------
+
+* kni: Remove deprecated Kernel Network Interface driver, libraries and examples
doc/guides/sample_app_ug/ip_pipeline.rst +0 -22
index b521d3b8be20..f30ac5e19db7 100644
@@ -164,15 +164,6 @@ Examples
    |                       |                      |                | 8. Pipeline table rule add default |
    |                       |                      |                | 9. Pipeline table rule add         |
    +-----------------------+----------------------+----------------+------------------------------------+
-   | KNI                   | Stub                 | Forward        | 1. Mempool create                  |
-   |                       |                      |                | 2. Link create                     |
-   |                       |                      |                | 3. Pipeline create                 |
-   |                       |                      |                | 4. Pipeline port in/out            |
-   |                       |                      |                | 5. Pipeline table                  |
-   |                       |                      |                | 6. Pipeline port in table          |
-   |                       |                      |                | 7. Pipeline enable                 |
-   |                       |                      |                | 8. Pipeline table rule add         |
-   +-----------------------+----------------------+----------------+------------------------------------+
    | Firewall              | ACL                  | Allow/Drop     | 1. Mempool create                  |
    |                       |                      |                | 2. Link create                     |
    |                       | * Key = n-tuple      |                | 3. Pipeline create                 |
@@ -297,17 +288,6 @@ Tap
   tap <name>
 
 
-Kni
-~~~
-
-  Create kni port ::
-
-   kni <kni_name>
-    link <link_name>
-    mempool <mempool_name>
-    [thread <thread_id>]
-
-
 Cryptodev
 ~~~~~~~~~
 
@@ -366,7 +346,6 @@ Create pipeline input port ::
    | swq <swq_name>
    | tmgr <tmgr_name>
    | tap <tap_name> mempool <mempool_name> mtu <mtu>
-   | kni <kni_name>
    | source mempool <mempool_name> file <file_name> bpp <n_bytes_per_pkt>
    [action <port_in_action_profile_name>]
    [disabled]
@@ -379,7 +358,6 @@ Create pipeline output port ::
    | swq <swq_name>
    | tmgr <tmgr_name>
    | tap <tap_name>
-   | kni <kni_name>
    | sink [file <file_name> pkts <max_n_pkts>]
 
 Create pipeline table ::
drivers/net/cnxk/cnxk_ethdev.c +1 -1
index 4b98faa72980..01b707b6c4ac 100644
@@ -1130,7 +1130,7 @@ nix_set_nop_rxtx_function(struct rte_eth_dev *eth_dev)
 {
 	/* These dummy functions are required for supporting
 	 * some applications which reconfigure queues without
-	 * stopping tx burst and rx burst threads(eg kni app)
+	 * stopping tx burst and rx burst threads.
 	 * When the queues context is saved, txq/rxqs are released
 	 * which caused app crash since rx/tx burst is still
 	 * on different lcores
drivers/net/kni/meson.build deleted +0 -11
deleted file mode 100644
index 2acc98969426..000000000000
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2018 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-deps += 'kni'
-sources = files('rte_eth_kni.c')
drivers/net/kni/rte_eth_kni.c deleted +0 -524

524 lines not on this page · raw message

drivers/net/meson.build +0 -1
index f68bbc27a784..bd38b533c573 100644
@@ -35,7 +35,6 @@ drivers = [
         'ionic',
         'ipn3ke',
         'ixgbe',
-        'kni',
         'mana',
         'memif',
         'mlx4',
examples/ip_pipeline/Makefile +0 -1
index 785c7ee38ce5..bc5e0a9f1800 100644
@@ -8,7 +8,6 @@ APP = ip_pipeline
 SRCS-y := action.c
 SRCS-y += cli.c
 SRCS-y += conn.c
-SRCS-y += kni.c
 SRCS-y += link.c
 SRCS-y += main.c
 SRCS-y += mempool.c
examples/ip_pipeline/cli.c +0 -95

149 lines not on this page · raw message

examples/ip_pipeline/examples/kni.cli deleted +0 -69

69 lines not on this page · raw message

examples/ip_pipeline/kni.c deleted +0 -168

168 lines not on this page · raw message

examples/ip_pipeline/kni.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/main.c +0 -10
index e35d9bce3984..663f538f024a 100644
@@ -14,7 +14,6 @@
 
 #include "cli.h"
 #include "conn.h"
-#include "kni.h"
 #include "cryptodev.h"
 #include "link.h"
 #include "mempool.h"
@@ -205,13 +204,6 @@ main(int argc, char **argv)
 		return status;
 	}
 
-	/* KNI */
-	status = kni_init();
-	if (status) {
-		printf("Error: KNI initialization failed (%d)\n", status);
-		return status;
-	}
-
 	/* Sym Crypto */
 	status = cryptodev_init();
 	if (status) {
@@ -264,7 +256,5 @@ main(int argc, char **argv)
 		conn_poll_for_conn(conn);
 
 		conn_poll_for_msg(conn);
-
-		kni_handle_request();
 	}
 }
examples/ip_pipeline/meson.build +0 -1
index 57f522c24cf9..68049157e429 100644
@@ -18,7 +18,6 @@ sources = files(
         'cli.c',
         'conn.c',
         'cryptodev.c',
-        'kni.c',
         'link.c',
         'main.c',
         'mempool.c',
examples/ip_pipeline/pipeline.c +0 -57

99 lines not on this page · raw message

examples/ip_pipeline/pipeline.h +0 -2
index 4d2ee29a54c7..083d5e852421 100644
@@ -25,7 +25,6 @@ enum port_in_type {
 	PORT_IN_SWQ,
 	PORT_IN_TMGR,
 	PORT_IN_TAP,
-	PORT_IN_KNI,
 	PORT_IN_SOURCE,
 	PORT_IN_CRYPTODEV,
 };
@@ -67,7 +66,6 @@ enum port_out_type {
 	PORT_OUT_SWQ,
 	PORT_OUT_TMGR,
 	PORT_OUT_TAP,
-	PORT_OUT_KNI,
 	PORT_OUT_SINK,
 	PORT_OUT_CRYPTODEV,
 };
kernel/linux/kni/Kbuild deleted +0 -6
deleted file mode 100644
index e5452d6c00db..000000000000
@@ -1,6 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2018 Luca Boccassi <[email protected]>
-
-ccflags-y := $(MODULE_CFLAGS)
-obj-m := rte_kni.o
-rte_kni-y := $(patsubst $(src)/%.c,%.o,$(wildcard $(src)/*.c))
kernel/linux/kni/compat.h deleted +0 -157

157 lines not on this page · raw message

kernel/linux/kni/kni_dev.h deleted +0 -137

50 lines not on this page · raw message

kernel/linux/kni/kni_fifo.h deleted +0 -87

87 lines not on this page · raw message

kernel/linux/kni/kni_misc.c deleted +0 -719

719 lines not on this page · raw message

kernel/linux/kni/kni_net.c deleted +0 -878

878 lines not on this page · raw message

kernel/linux/kni/meson.build deleted +0 -41

41 lines not on this page · raw message

kernel/linux/meson.build deleted +0 -103

103 lines not on this page · raw message

lib/eal/common/eal_common_log.c +0 -1
index bd7b188ceb4a..0a1d219d6924 100644

Lines of this file are not shown. View the raw message.

lib/eal/include/rte_log.h +1 -1
index 6d2b0856a565..bdefff2a5933 100644

Lines of this file are not shown. View the raw message.

lib/eal/linux/eal.c +0 -19
index c6efd920145c..a1fefcd9d83a 100644

Lines of this file are not shown. View the raw message.

lib/kni/meson.build deleted +0 -21
deleted file mode 100644
index 5ce410f7f2d2..000000000000

Lines of this file are not shown. View the raw message.

lib/kni/rte_kni.c deleted +0 -843

843 lines not on this page · raw message

lib/kni/rte_kni.h deleted +0 -269

269 lines not on this page · raw message

lib/kni/rte_kni_common.h deleted +0 -147

147 lines not on this page · raw message

lib/kni/rte_kni_fifo.h deleted +0 -117

117 lines not on this page · raw message

lib/kni/version.map deleted +0 -24
deleted file mode 100644
index 83bbbe880f43..000000000000

Lines of this file are not shown. View the raw message.

lib/meson.build +0 -3
index fac2f52cad4f..06df4f57ad6e 100644

Lines of this file are not shown. View the raw message.

lib/port/meson.build +0 -6
index 3ab37e2cb4b7..b0af2b185b39 100644

Lines of this file are not shown. View the raw message.

lib/port/rte_port_kni.c deleted +0 -515

515 lines not on this page · raw message

lib/port/rte_port_kni.h deleted +0 -63

63 lines not on this page · raw message

lib/port/version.map +0 -3
index af6cf696fd54..d67a03650d8b 100644

Lines of this file are not shown. View the raw message.

meson_options.txt +1 -1
index 82c8297065f0..7b67e0203f8f 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.39.2

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH v2 1/1 kni: remove deprecated kernel network interface

Deprecation and removal was announced in 22.11.
Make it so.

Leave kernel/linux with empty directory because CI is trying to directly build it. At some later date, kernel/linux can be removed.

---
v2 - fix doc and CI build

 MAINTAINERS                                   |  10 -
 app/test/meson.build                          |   2 -
 app/test/test_kni.c                           | 740 ---------------
 doc/api/doxy-api-index.md                     |   2 -
 doc/api/doxy-api.conf.in                      |   1 -
 doc/guides/contributing/documentation.rst     |   2 +-
 doc/guides/howto/flow_bifurcation.rst         |   3 +-
 doc/guides/nics/index.rst                     |   1 -
 doc/guides/nics/kni.rst                       | 170 ----
 doc/guides/nics/virtio.rst                    |  92 +-
 .../prog_guide/env_abstraction_layer.rst      |   2 -
 doc/guides/prog_guide/glossary.rst            |   3 -
 doc/guides/prog_guide/index.rst               |   1 -
 .../prog_guide/kernel_nic_interface.rst       | 423 ---------
 doc/guides/prog_guide/packet_framework.rst    |   9 +-
 doc/guides/rel_notes/deprecation.rst          |   9 +-
 doc/guides/rel_notes/index.rst                |   1 +
 doc/guides/rel_notes/release_23_11.rst        |  16 +
 doc/guides/sample_app_ug/ip_pipeline.rst      |  22 -
 drivers/net/cnxk/cnxk_ethdev.c                |   2 +-
 drivers/net/kni/meson.build                   |  11 -
 drivers/net/kni/rte_eth_kni.c                 | 524 -----------
 drivers/net/meson.build                       |   1 -
 examples/ip_pipeline/Makefile                 |   1 -
 examples/ip_pipeline/cli.c                    |  95 --
 examples/ip_pipeline/examples/kni.cli         |  69 --
 examples/ip_pipeline/kni.c                    | 168 ----
 examples/ip_pipeline/kni.h                    |  46 -
 examples/ip_pipeline/main.c                   |  10 -
 examples/ip_pipeline/meson.build              |   1 -
 examples/ip_pipeline/pipeline.c               |  57 --
 examples/ip_pipeline/pipeline.h               |   2 -
 kernel/linux/kni/Kbuild                       |   6 -
 kernel/linux/kni/compat.h                     | 157 ----
 kernel/linux/kni/kni_dev.h                    | 137 ---
 kernel/linux/kni/kni_fifo.h                   |  87 --
 kernel/linux/kni/kni_misc.c                   | 719 --------------
 kernel/linux/kni/kni_net.c                    | 878 ------------------
 kernel/linux/kni/meson.build                  |  41 -
 kernel/linux/meson.build                      |   2 +-
 lib/eal/common/eal_common_log.c               |   1 -
 lib/eal/include/rte_log.h                     |   2 +-
 lib/eal/linux/eal.c                           |  19 -
 lib/kni/meson.build                           |  21 -
 lib/kni/rte_kni.c                             | 843 -----------------
 lib/kni/rte_kni.h                             | 269 ------
 lib/kni/rte_kni_common.h                      | 147 ---
 lib/kni/rte_kni_fifo.h                        | 117 ---
 lib/kni/version.map                           |  24 -
 lib/meson.build                               |   3 -
 lib/port/meson.build                          |   6 -
 lib/port/rte_port_kni.c                       | 515 ----------
 lib/port/rte_port_kni.h                       |  63 --
 lib/port/version.map                          |   3 -
 meson_options.txt                             |   2 +-
 55 files changed, 28 insertions(+), 6530 deletions(-)
 delete mode 100644 app/test/test_kni.c
 delete mode 100644 doc/guides/nics/kni.rst
 delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst
 create mode 100644 doc/guides/rel_notes/release_23_11.rst
 delete mode 100644 drivers/net/kni/meson.build
 delete mode 100644 drivers/net/kni/rte_eth_kni.c
 delete mode 100644 examples/ip_pipeline/examples/kni.cli
 delete mode 100644 examples/ip_pipeline/kni.c
 delete mode 100644 examples/ip_pipeline/kni.h
 delete mode 100644 kernel/linux/kni/Kbuild
 delete mode 100644 kernel/linux/kni/compat.h
 delete mode 100644 kernel/linux/kni/kni_dev.h
 delete mode 100644 kernel/linux/kni/kni_fifo.h
 delete mode 100644 kernel/linux/kni/kni_misc.c
 delete mode 100644 kernel/linux/kni/kni_net.c
 delete mode 100644 kernel/linux/kni/meson.build
 delete mode 100644 lib/kni/meson.build
 delete mode 100644 lib/kni/rte_kni.c
 delete mode 100644 lib/kni/rte_kni.h
 delete mode 100644 lib/kni/rte_kni_common.h
 delete mode 100644 lib/kni/rte_kni_fifo.h
 delete mode 100644 lib/kni/version.map
 delete mode 100644 lib/port/rte_port_kni.c
 delete mode 100644 lib/port/rte_port_kni.h
MAINTAINERS +0 -10
index 18bc05fccd0d..6ad45569bcd2 100644
@@ -617,12 +617,6 @@ F: doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
 F: app/test/test_link_bonding*
 F: examples/bond/
 
-Linux KNI
-F: kernel/linux/kni/
-F: lib/kni/
-F: doc/guides/prog_guide/kernel_nic_interface.rst
-F: app/test/test_kni.c
-
 Linux AF_PACKET
 M: John W. Linville <[email protected]>
 F: drivers/net/af_packet/
@@ -1027,10 +1021,6 @@ F: drivers/net/tap/
 F: doc/guides/nics/tap.rst
 F: doc/guides/nics/features/tap.ini
 
-KNI PMD
-F: drivers/net/kni/
-F: doc/guides/nics/kni.rst
-
 Ring PMD
 M: Bruce Richardson <[email protected]>
 F: drivers/net/ring/
app/test/meson.build +0 -2
index b89cf0368fb5..de895cc8fc52 100644
@@ -72,7 +72,6 @@ test_sources = files(
         'test_ipsec.c',
         'test_ipsec_sad.c',
         'test_ipsec_perf.c',
-        'test_kni.c',
         'test_kvargs.c',
         'test_lcores.c',
         'test_logs.c',
@@ -237,7 +236,6 @@ fast_tests = [
         ['fbarray_autotest', true, true],
         ['hash_readwrite_func_autotest', false, true],
         ['ipsec_autotest', true, true],
-        ['kni_autotest', false, true],
         ['kvargs_autotest', true, true],
         ['member_autotest', true, true],
         ['power_cpufreq_autotest', false, true],
app/test/test_kni.c deleted +0 -740

740 lines not on this page · raw message

doc/api/doxy-api-index.md +0 -2
index 3bc8778981f6..7bba67d58586 100644
@@ -43,7 +43,6 @@ The public API headers are grouped by topics:
   [bond](@ref rte_eth_bond.h),
   [vhost](@ref rte_vhost.h),
   [vdpa](@ref rte_vdpa.h),
-  [KNI](@ref rte_kni.h),
   [ixgbe](@ref rte_pmd_ixgbe.h),
   [i40e](@ref rte_pmd_i40e.h),
   [iavf](@ref rte_pmd_iavf.h),
@@ -178,7 +177,6 @@ The public API headers are grouped by topics:
     [frag](@ref rte_port_frag.h),
     [reass](@ref rte_port_ras.h),
     [sched](@ref rte_port_sched.h),
-    [kni](@ref rte_port_kni.h),
     [src/sink](@ref rte_port_source_sink.h)
   * [table](@ref rte_table.h):
     [lpm IPv4](@ref rte_table_lpm.h),
doc/api/doxy-api.conf.in +0 -1
index 1a4210b948a8..90dcf232dffd 100644
@@ -49,7 +49,6 @@ INPUT                   = @TOPDIR@/doc/api/doxy-api-index.md \
                           @TOPDIR@/lib/ip_frag \
                           @TOPDIR@/lib/ipsec \
                           @TOPDIR@/lib/jobstats \
-                          @TOPDIR@/lib/kni \
                           @TOPDIR@/lib/kvargs \
                           @TOPDIR@/lib/latencystats \
                           @TOPDIR@/lib/lpm \
doc/guides/contributing/documentation.rst +1 -1
index 7fcbb7fc43b2..f16c94e9768b 100644
@@ -95,7 +95,7 @@ added to by the developer.
 * **The Programmers Guide**
 
   The Programmers Guide explains how the API components of DPDK such as the EAL, Memzone, Rings and the Hash Library work.
-  It also explains how some higher level functionality such as Packet Distributor, Packet Framework and KNI work.
+  It also explains how some higher level functionality such as Packet Distributor and Packet Framework.
   It also shows the build system and explains how to add applications.
 
   The Programmers Guide should be expanded when new functionality is added to DPDK.
doc/guides/howto/flow_bifurcation.rst +1 -2
index 838eb2a4cc89..554dd24c32c5 100644
@@ -7,8 +7,7 @@ Flow Bifurcation How-to Guide
 Flow Bifurcation is a mechanism which uses hardware capable Ethernet devices
 to split traffic between Linux user space and kernel space. Since it is a
 hardware assisted feature this approach can provide line rate processing
-capability. Other than :ref:`KNI <kni>`, the software is just required to
-enable device configuration, there is no need to take care of the packet
+capability. There is no need to take care of the packet
 movement during the traffic split. This can yield better performance with
 less CPU overhead.
 
doc/guides/nics/index.rst +0 -1
index 31296822e5ec..7bfcac880f44 100644
@@ -43,7 +43,6 @@ Network Interface Controller Drivers
     ionic
     ipn3ke
     ixgbe
-    kni
     mana
     memif
     mlx4
doc/guides/nics/kni.rst deleted +0 -170

170 lines not on this page · raw message

doc/guides/nics/virtio.rst +1 -91

109 lines not on this page · raw message

doc/guides/prog_guide/env_abstraction_layer.rst +0 -2
index 93c8a031be56..5d382fdd9032 100644
@@ -610,8 +610,6 @@ devices would fail anyway.
     ``RTE_PCI_DRV_NEED_IOVA_AS_VA`` flag is used to dictate that this PCI
     driver can only work in RTE_IOVA_VA mode.
 
-    When the KNI kernel module is detected, RTE_IOVA_PA mode is preferred as a
-    performance penalty is expected in RTE_IOVA_VA mode.
 
 IOVA Mode Configuration
 ~~~~~~~~~~~~~~~~~~~~~~~
doc/guides/prog_guide/glossary.rst +0 -3
index fb0910ba5b3f..8d6349701e43 100644
@@ -103,9 +103,6 @@ lcore
    A logical execution unit of the processor, sometimes called a *hardware
    thread*.
 
-KNI
-   Kernel Network Interface
-
 L1
    Layer 1
 
doc/guides/prog_guide/index.rst +0 -1
index d89cd3edb63c..1be6a3d6d9b6 100644
@@ -54,7 +54,6 @@ Programmer's Guide
     pcapng_lib
     pdump_lib
     multi_proc_support
-    kernel_nic_interface
     thread_safety_dpdk_functions
     eventdev
     event_ethernet_rx_adapter
doc/guides/prog_guide/kernel_nic_interface.rst deleted +0 -423

423 lines not on this page · raw message

doc/guides/prog_guide/packet_framework.rst +3 -6
index 3d4e3b66cc5c..ebc69d8c3e75 100644
@@ -87,18 +87,15 @@ Port Types
    |   |                  | management and hierarchical scheduling according to pre-defined SLAs.                 |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 6 | KNI              | Send/receive packets to/from Linux kernel space.                                      |
-   |   |                  |                                                                                       |
-   +---+------------------+---------------------------------------------------------------------------------------+
-   | 7 | Source           | Input port used as packet generator. Similar to Linux kernel /dev/zero character      |
+   | 6 | Source           | Input port used as packet generator. Similar to Linux kernel /dev/zero character      |
    |   |                  | device.                                                                               |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 8 | Sink             | Output port used to drop all input packets. Similar to Linux kernel /dev/null         |
+   | 7 | Sink             | Output port used to drop all input packets. Similar to Linux kernel /dev/null         |
    |   |                  | character device.                                                                     |
    |   |                  |                                                                                       |
    +---+------------------+---------------------------------------------------------------------------------------+
-   | 9 | Sym_crypto       | Output port used to extract DPDK Cryptodev operations from a fixed offset of the      |
+   | 8 | Sym_crypto       | Output port used to extract DPDK Cryptodev operations from a fixed offset of the      |
    |   |                  | packet and then enqueue to the Cryptodev PMD. Input port used to dequeue the          |
    |   |                  | Cryptodev operations from the Cryptodev PMD and then retrieve the packets from them.  |
    +---+------------------+---------------------------------------------------------------------------------------+
doc/guides/rel_notes/deprecation.rst +1 -8
index 494b401cda4b..fa619514fd64 100644
@@ -35,7 +35,7 @@ Deprecation Notices
     which also added support for standard atomics
     (Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html)
 
-* build: Enabling deprecated libraries (``flow_classify``, ``kni``)
+* build: Enabling deprecated libraries (``flow_classify``)
   won't be possible anymore through the use of the ``disable_libs`` build option.
   A new build option for deprecated libraries will be introduced instead.
 
@@ -78,13 +78,6 @@ Deprecation Notices
   ``__atomic_thread_fence`` must be used for patches that need to be merged in
   20.08 onwards. This change will not introduce any performance degradation.
 
-* kni: The KNI kernel module and library are not recommended for use by new
-  applications - other technologies such as virtio-user are recommended instead.
-  Following the DPDK technical board
-  `decision <https://mails.dpdk.org/archives/dev/2021-January/197077.html>`_
-  and `refinement <https://mails.dpdk.org/archives/dev/2022-June/243596.html>`_,
-  the KNI kernel module, library and PMD will be removed from the DPDK 23.11 release.
-
 * lib: will fix extending some enum/define breaking the ABI. There are multiple
   samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is
   used by iterators, and arrays holding these values are sized with this
doc/guides/rel_notes/index.rst +1 -0
index d8dfa621ecf2..d07281527991 100644
@@ -8,6 +8,7 @@ Release Notes
     :maxdepth: 1
     :numbered:
 
+    release_23_11
     release_23_07
     release_23_03
     release_22_11
doc/guides/rel_notes/release_23_11.rst new file +16 -0
new file mode 100644
index 000000000000..e2158934751f
@@ -0,0 +1,16 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2022 The DPDK contributors
+
+.. include:: <isonum.txt>
+
+DPDK Release 23.11
+==================
+
+New Features
+------------
+
+
+Removed Items
+-------------
+
+* kni: Remove deprecated Kernel Network Interface driver, libraries and examples
doc/guides/sample_app_ug/ip_pipeline.rst +0 -22
index b521d3b8be20..f30ac5e19db7 100644
@@ -164,15 +164,6 @@ Examples
    |                       |                      |                | 8. Pipeline table rule add default |
    |                       |                      |                | 9. Pipeline table rule add         |
    +-----------------------+----------------------+----------------+------------------------------------+
-   | KNI                   | Stub                 | Forward        | 1. Mempool create                  |
-   |                       |                      |                | 2. Link create                     |
-   |                       |                      |                | 3. Pipeline create                 |
-   |                       |                      |                | 4. Pipeline port in/out            |
-   |                       |                      |                | 5. Pipeline table                  |
-   |                       |                      |                | 6. Pipeline port in table          |
-   |                       |                      |                | 7. Pipeline enable                 |
-   |                       |                      |                | 8. Pipeline table rule add         |
-   +-----------------------+----------------------+----------------+------------------------------------+
    | Firewall              | ACL                  | Allow/Drop     | 1. Mempool create                  |
    |                       |                      |                | 2. Link create                     |
    |                       | * Key = n-tuple      |                | 3. Pipeline create                 |
@@ -297,17 +288,6 @@ Tap
   tap <name>
 
 
-Kni
-~~~
-
-  Create kni port ::
-
-   kni <kni_name>
-    link <link_name>
-    mempool <mempool_name>
-    [thread <thread_id>]
-
-
 Cryptodev
 ~~~~~~~~~
 
@@ -366,7 +346,6 @@ Create pipeline input port ::
    | swq <swq_name>
    | tmgr <tmgr_name>
    | tap <tap_name> mempool <mempool_name> mtu <mtu>
-   | kni <kni_name>
    | source mempool <mempool_name> file <file_name> bpp <n_bytes_per_pkt>
    [action <port_in_action_profile_name>]
    [disabled]
@@ -379,7 +358,6 @@ Create pipeline output port ::
    | swq <swq_name>
    | tmgr <tmgr_name>
    | tap <tap_name>
-   | kni <kni_name>
    | sink [file <file_name> pkts <max_n_pkts>]
 
 Create pipeline table ::
drivers/net/cnxk/cnxk_ethdev.c +1 -1
index 4b98faa72980..01b707b6c4ac 100644
@@ -1130,7 +1130,7 @@ nix_set_nop_rxtx_function(struct rte_eth_dev *eth_dev)
 {
 	/* These dummy functions are required for supporting
 	 * some applications which reconfigure queues without
-	 * stopping tx burst and rx burst threads(eg kni app)
+	 * stopping tx burst and rx burst threads.
 	 * When the queues context is saved, txq/rxqs are released
 	 * which caused app crash since rx/tx burst is still
 	 * on different lcores
drivers/net/kni/meson.build deleted +0 -11
deleted file mode 100644
index 2acc98969426..000000000000
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2018 Intel Corporation
-
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-    subdir_done()
-endif
-
-deps += 'kni'
-sources = files('rte_eth_kni.c')
drivers/net/kni/rte_eth_kni.c deleted +0 -524

524 lines not on this page · raw message

drivers/net/meson.build +0 -1
index f68bbc27a784..bd38b533c573 100644
@@ -35,7 +35,6 @@ drivers = [
         'ionic',
         'ipn3ke',
         'ixgbe',
-        'kni',
         'mana',
         'memif',
         'mlx4',
examples/ip_pipeline/Makefile +0 -1
index 785c7ee38ce5..bc5e0a9f1800 100644
@@ -8,7 +8,6 @@ APP = ip_pipeline
 SRCS-y := action.c
 SRCS-y += cli.c
 SRCS-y += conn.c
-SRCS-y += kni.c
 SRCS-y += link.c
 SRCS-y += main.c
 SRCS-y += mempool.c
examples/ip_pipeline/cli.c +0 -95

149 lines not on this page · raw message

examples/ip_pipeline/examples/kni.cli deleted +0 -69

69 lines not on this page · raw message

examples/ip_pipeline/kni.c deleted +0 -168

168 lines not on this page · raw message

examples/ip_pipeline/kni.h deleted +0 -46

46 lines not on this page · raw message

examples/ip_pipeline/main.c +0 -10
index e35d9bce3984..663f538f024a 100644
@@ -14,7 +14,6 @@
 
 #include "cli.h"
 #include "conn.h"
-#include "kni.h"
 #include "cryptodev.h"
 #include "link.h"
 #include "mempool.h"
@@ -205,13 +204,6 @@ main(int argc, char **argv)
 		return status;
 	}
 
-	/* KNI */
-	status = kni_init();
-	if (status) {
-		printf("Error: KNI initialization failed (%d)\n", status);
-		return status;
-	}
-
 	/* Sym Crypto */
 	status = cryptodev_init();
 	if (status) {
@@ -264,7 +256,5 @@ main(int argc, char **argv)
 		conn_poll_for_conn(conn);
 
 		conn_poll_for_msg(conn);
-
-		kni_handle_request();
 	}
 }
examples/ip_pipeline/meson.build +0 -1
index 57f522c24cf9..68049157e429 100644
@@ -18,7 +18,6 @@ sources = files(
         'cli.c',
         'conn.c',
         'cryptodev.c',
-        'kni.c',
         'link.c',
         'main.c',
         'mempool.c',
examples/ip_pipeline/pipeline.c +0 -57

99 lines not on this page · raw message

examples/ip_pipeline/pipeline.h +0 -2
index 4d2ee29a54c7..083d5e852421 100644
@@ -25,7 +25,6 @@ enum port_in_type {
 	PORT_IN_SWQ,
 	PORT_IN_TMGR,
 	PORT_IN_TAP,
-	PORT_IN_KNI,
 	PORT_IN_SOURCE,
 	PORT_IN_CRYPTODEV,
 };
@@ -67,7 +66,6 @@ enum port_out_type {
 	PORT_OUT_SWQ,
 	PORT_OUT_TMGR,
 	PORT_OUT_TAP,
-	PORT_OUT_KNI,
 	PORT_OUT_SINK,
 	PORT_OUT_CRYPTODEV,
 };
kernel/linux/kni/Kbuild deleted +0 -6
deleted file mode 100644
index e5452d6c00db..000000000000
@@ -1,6 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2018 Luca Boccassi <[email protected]>
-
-ccflags-y := $(MODULE_CFLAGS)
-obj-m := rte_kni.o
-rte_kni-y := $(patsubst $(src)/%.c,%.o,$(wildcard $(src)/*.c))
kernel/linux/kni/compat.h deleted +0 -157

157 lines not on this page · raw message

kernel/linux/kni/kni_dev.h deleted +0 -137

43 lines not on this page · raw message

kernel/linux/kni/kni_fifo.h deleted +0 -87

87 lines not on this page · raw message

kernel/linux/kni/kni_misc.c deleted +0 -719

719 lines not on this page · raw message

kernel/linux/kni/kni_net.c deleted +0 -878

878 lines not on this page · raw message

kernel/linux/kni/meson.build deleted +0 -41

41 lines not on this page · raw message

kernel/linux/meson.build +1 -1
index 16a094899446..8d47074621f7 100644

Lines of this file are not shown. View the raw message.

lib/eal/common/eal_common_log.c +0 -1
index bd7b188ceb4a..0a1d219d6924 100644

Lines of this file are not shown. View the raw message.

lib/eal/include/rte_log.h +1 -1
index 6d2b0856a565..bdefff2a5933 100644

Lines of this file are not shown. View the raw message.

lib/eal/linux/eal.c +0 -19
index c6efd920145c..a1fefcd9d83a 100644

Lines of this file are not shown. View the raw message.

lib/kni/meson.build deleted +0 -21
deleted file mode 100644
index 5ce410f7f2d2..000000000000

Lines of this file are not shown. View the raw message.

lib/kni/rte_kni.c deleted +0 -843

843 lines not on this page · raw message

lib/kni/rte_kni.h deleted +0 -269

269 lines not on this page · raw message

lib/kni/rte_kni_common.h deleted +0 -147

147 lines not on this page · raw message

lib/kni/rte_kni_fifo.h deleted +0 -117

117 lines not on this page · raw message

lib/kni/version.map deleted +0 -24
deleted file mode 100644
index 83bbbe880f43..000000000000

Lines of this file are not shown. View the raw message.

lib/meson.build +0 -3
index fac2f52cad4f..06df4f57ad6e 100644

Lines of this file are not shown. View the raw message.

lib/port/meson.build +0 -6
index 3ab37e2cb4b7..b0af2b185b39 100644

Lines of this file are not shown. View the raw message.

lib/port/rte_port_kni.c deleted +0 -515

515 lines not on this page · raw message

lib/port/rte_port_kni.h deleted +0 -63

63 lines not on this page · raw message

lib/port/version.map +0 -3
index af6cf696fd54..d67a03650d8b 100644

Lines of this file are not shown. View the raw message.

meson_options.txt +1 -1
index 82c8297065f0..7b67e0203f8f 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.39.2

Part of the diff is not shown here. View the raw message.

#2 lore raw
Quoted 9 lines · On Sat, 29 Jul 2023 19:12:05 -0700 Stephen Hemminger…

Deprecation and removal was announced in 22.11.
Make it so.

Leave kernel/linux with empty directory because CI is trying to directly build it. At some later date, kernel/linux can be removed.

---

Want suggestions on this.
1. The release notes gets coding style warning because checkpatch is checking that release note matches current release, and release number hasn't change yet. Should I just wait?

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

#3 lore raw

30/07/2023 19:12, Stephen Hemminger:

Quoted 5 lines
Quoted 2 lines · On Sat, 29 Jul 2023 19:12:05 -0700 Stephen Hemminger…

Deprecation and removal was announced in 22.11.
Make it so.

Would be good to summarize the reason here,
and name replacements.

Also it should not be completely removed.
I think we were supposed to move KNI into the kmod repository?

Quoted 11 lines
Quoted 6 lines

Leave kernel/linux with empty directory because CI is trying to directly build it. At some later date, kernel/linux can be removed.

---

Want suggestions on this.
1. The release notes gets coding style warning because checkpatch is checking that release note matches current release, and release number hasn't change yet. Should I just wait?

Yes the release notes file for 23.11 should be created today.

Quoted 3 lines

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

No we must support it until it is removed.
You should either disable or remove KNI from the port library.

#4 lore raw
Quoted 4 lines · On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon <[email protected]> wrote:

30/07/2023 19:12, Stephen Hemminger:

Quoted 3 lines

On Sat, 29 Jul 2023 19:12:05 -0700
Stephen Hemminger <[email protected]> wrote:

Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

Deprecation and removal was announced in 22.11.
Make it so.

Would be good to summarize the reason here,
and name replacements.

Also it should not be completely removed.
I think we were supposed to move KNI into the kmod repository?

The decision I remember was to remove it completely. KNI has several issues which make it unstable and even a potential security problem. Moving it doesn't stop usage.

Quoted 15 lines
Quoted 11 lines
Quoted 6 lines

Leave kernel/linux with empty directory because CI is trying to directly build it. At some later date, kernel/linux can be removed.

---

Want suggestions on this.
1. The release notes gets coding style warning because checkpatch is checking that release note matches current release, and release number hasn't change yet. Should I just wait?

Yes the release notes file for 23.11 should be created today.

Quoted 6 lines
Quoted 3 lines

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

No we must support it until it is removed.
You should either disable or remove KNI from the port library.

The patch removed from port library and it builds but the ABI robot was looking for symbols.

Will just remove port library first.

#5 lore raw
Quoted 9 lines · Stephen Hemminger
Quoted 6 lines
Quoted 3 lines

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

No we must support it until it is removed.
You should either disable or remove KNI from the port library.

The patch removed from port library and it builds but the ABI robot was looking for symbols.

The ABI check was still active by the time you submitted this series. Please resend it now that the ABI check is disabled with rc0 merged.

Signature · 1 line
David Marchand
#6 lore raw
In reply to Stephen Hemminger

31/07/2023 17:13, Stephen Hemminger:

Quoted 13 lines
Quoted 10 lines · On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon <[email protected]> wrote:

30/07/2023 19:12, Stephen Hemminger:

Quoted 5 lines
Quoted 2 lines · On Sat, 29 Jul 2023 19:12:05 -0700 Stephen Hemminger…

Deprecation and removal was announced in 22.11.
Make it so.

Would be good to summarize the reason here,
and name replacements.

Quoted 6 lines
Quoted 2 lines

Also it should not be completely removed.
I think we were supposed to move KNI into the kmod repository?

The decision I remember was to remove it completely. KNI has several issues which make it unstable and even a potential security problem. Moving it doesn't stop usage.

The latest decision I've found was "remove lib + kmod from main repo for 23.11"
http://mails.dpdk.org/archives/dev/2022-June/243596.html

igb_uio was moved in dpdk-kmods/linux which looks as a cemetery. Should we make a grave for KNI?

#7 lore raw
In reply to Thomas Monjalon
Quoted 6 lines · On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon <[email protected]> wrote:
Quoted 3 lines

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

No we must support it until it is removed.
You should either disable or remove KNI from the port library.

I just removed those calls from port library.

One reason that KNI can't be isolated into a separate kmod repo is that it has components such as lib/kni that were being shared in several places like port, examples, and tests.

#8 lore raw

31/07/2023 23:12, Stephen Hemminger:

Quoted 7 lines
Quoted 4 lines · On Mon, 31 Jul 2023 10:40:35 +0200 Thomas Monjalon <[email protected]> wrote:
Quoted 3 lines

2. The OVSrobot is looking into the port library to see the kni symbols. But port is marked as deprecated already.
Perhaps we should just pull out port first?

Quoted 8 lines
Quoted 2 lines

No we must support it until it is removed.
You should either disable or remove KNI from the port library.

I just removed those calls from port library.

One reason that KNI can't be isolated into a separate kmod repo is that it has components such as lib/kni that were being shared in several places like port, examples, and tests.

Yes you're right.

#9 lore raw
In reply to Stephen Hemminger

Hello Stephen,

While rebasing, please also fix those nits:

doc/guides/contributing/documentation.rst added to by the developer. · line 98

Quoted 10 lines · Stephen Hemminger
doc/guides/contributing/documentation.rst +1 -1
index 7fcbb7fc43b2..f16c94e9768b 100644
@@ -95,7 +95,7 @@ added to by the developer.
 * **The Programmers Guide**
 
   The Programmers Guide explains how the API components of DPDK such as the EAL, Memzone, Rings and the Hash Library work.
-  It also explains how some higher level functionality such as Packet Distributor, Packet Framework and KNI work.
+  It also explains how some higher level functionality such as Packet Distributor and Packet Framework.

s/how some higher level functionality/how some higher level functionality work/

Quoted 3 lines
doc/guides/contributing/documentation.rst +0 -0
   It also shows the build system and explains how to add applications.
 
   The Programmers Guide should be expanded when new functionality is added to DPDK.

[snip]

Quoted 12 lines
doc/guides/rel_notes/release_23_11.rst new file +6 -0
new file mode 100644
index 000000000000..e2158934751f
@@ -0,0 +1,16 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2022 The DPDK contributors
+
+.. include:: <isonum.txt>
+
+DPDK Release 23.11

doc/guides/rel_notes/release_23_11.rst line 16

Quoted 10 lines
doc/guides/rel_notes/release_23_11.rst new file +10 -0
+==================
+
+New Features
+------------
+
+
+Removed Items
+-------------
+
+* kni: Remove deprecated Kernel Network Interface driver, libraries and examples

s/Remove/Removed/
s/$/./

Thanks.

Signature · 1 line
David Marchand