Skip to contentSkip to conversation

ARM: dts: imx6sx: Remove LDB endpoint

PATCH Applied Fabio Estevam 2 participants 8 messages Jul 12, 2023 – Aug 15, 2023

Subsystems (5)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v3 1/3 ARM: dts: imx6sx: Remove LDB endpoint

From: Fabio Estevam <[email protected]>

Remove the LDB endpoint description from the common imx6sx.dtsi as it causes regression for boards that has the LCDIF connected directly to a parallel display.

Let the LDB endpoint be described in the board devicetree file instead.

Fixes b74edf626c4f ("ARM: dts: imx6sx: Add LDB support")

---
Changes since v2:
- Rebased against 6.5-rc1.

 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi +2 -6
index 3a4308666552..41c900929758 100644
@@ -863,7 +863,6 @@ port@0 {
 							reg = <0>;
 
 							ldb_from_lcdif1: endpoint {
-								remote-endpoint = <&lcdif1_to_ldb>;
 							};
 						};
 
@@ -1309,11 +1308,8 @@ lcdif1: lcdif@2220000 {
 					power-domains = <&pd_disp>;
 					status = "disabled";
 
-					ports {
-						port {
-							lcdif1_to_ldb: endpoint {
-								remote-endpoint = <&ldb_from_lcdif1>;
-							};
+					port {
+						lcdif1_to_ldb: endpoint {
 						};
 					};
 				};
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH v3 2/3 ARM: dts: imx6sx: Describe the default LCDIF1 parent

From: Fabio Estevam <[email protected]>

A suitable default for the LCDIF parent is the PLL5 clock, so describe it in the device tree.

The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but in preparation for removing such hardcoding, describe the parent relationship via devicetree.

There are some boards that may want to use a different parent for the LCDIF due to EMI reasons, for example.

With this approch, the user can change the LCDIF parent in the board devicetree if needed.

---
Changes since v2:
- Rebased against 6.5-rc1.

 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi +4 -0
index 41c900929758..0d549e1f3ced 100644
@@ -1305,6 +1305,10 @@ lcdif1: lcdif@2220000 {
 						 <&clks IMX6SX_CLK_LCDIF_APB>,
 						 <&clks IMX6SX_CLK_DISPLAY_AXI>;
 					clock-names = "pix", "axi", "disp_axi";
+					assigned-clocks = <&clks IMX6SX_CLK_LCDIF1_PRE_SEL>,
+							  <&clks IMX6SX_CLK_LCDIF1_SEL>;
+					assigned-clock-parents = <&clks IMX6SX_CLK_PLL5_VIDEO_DIV>,
+								 <&clks IMX6SX_CLK_LCDIF1_PODF>;
 					power-domains = <&pd_disp>;
 					status = "disabled";
 
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#2 lore raw

Re: [PATCH v3 2/3] ARM: dts: imx6sx: Describe the default LCDIF1 parent

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

A suitable default for the LCDIF parent is the PLL5 clock, so describe it in the device tree.

The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but in preparation for removing such hardcoding, describe the parent relationship via devicetree.

Quoted 7 lines

There are some boards that may want to use a different parent for the LCDIF due to EMI reasons, for example.

With this approch, the user can change the LCDIF parent in the board devicetree if needed.

Applied, thanks!

author reviewer
#3 lore raw

PATCH v3 3/3 clk: imx: imx6sx: Remove hardcoded LCDIF1 parent

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

It is not a good idea to hardcode the LCDIF1 parent inside the clock driver because some users may want to use a different clock parent for LCDIF1. One of the reasons could be related to EMI tests.

Remove the harcoded LCDIF1 parent as this is better described via devicetree.

---
Changes since v2:
- Rebased against 6.5-rc1.

 drivers/clk/imx/clk-imx6sx.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/clk/imx/clk-imx6sx.c +0 -4
index 3f1502933e59..b110258b9036 100644
@@ -498,10 +498,6 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
 	clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk);
 	clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000);
 
-	/* set parent clock for LCDIF1 pixel clock */
-	clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk);
-	clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk);
-
 	/* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */
 	if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk))
 		pr_err("Failed to set pcie bus parent clk.\n");
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#4 lore raw

Re: [PATCH v3 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent

Hi Abel,

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

It is not a good idea to hardcode the LCDIF1 parent inside the clock driver because some users may want to use a different clock parent for LCDIF1. One of the reasons could be related to EMI tests.

Quoted 7 lines

Remove the harcoded LCDIF1 parent as this is better described via devicetree.

---
Changes since v2:
- Rebased against 6.5-rc1.

Shawn has already applied patches 1/3 and 2/3.

Could this one go via your tree, please?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author reviewer
#5 lore raw

Re: [PATCH v3 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent

Quoted 14 lines · Fabio Estevam

Hi Abel,

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

It is not a good idea to hardcode the LCDIF1 parent inside the clock driver because some users may want to use a different clock parent for LCDIF1. One of the reasons could be related to EMI tests.

Remove the harcoded LCDIF1 parent as this is better described via devicetree.

Quoted 8 lines
Quoted 4 lines

---
Changes since v2:
- Rebased against 6.5-rc1.

Shawn has already applied patches 1/3 and 2/3.

Could this one go via your tree, please?

Actually, please discard this one. I missed adding the following suggestion from Stephen:

"Do you need to check for the DT property and skip these clk_set_parent() calls if they're present? How does this work if the DT isn't updated at the same time?"

I will revisit this after 6.6-rc1 is out.

Thanks

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author reviewer
#6 lore raw
In reply to Fabio Estevam

Hi Shawn,

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Remove the LDB endpoint description from the common imx6sx.dtsi as it causes regression for boards that has the LCDIF connected directly to a parallel display.

Let the LDB endpoint be described in the board devicetree file instead.

Quoted 6 lines
Fixes b74edf626c4f ("ARM: dts: imx6sx: Add LDB support")

---
Changes since v2:
- Rebased against 6.5-rc1.

Please consider applying this one as it fixes a regression, thanks.

Applied
#7 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Remove the LDB endpoint description from the common imx6sx.dtsi as it causes regression for boards that has the LCDIF connected directly to a parallel display.

Quoted 6 lines

Let the LDB endpoint be described in the board devicetree file instead.

Fixes b74edf626c4f ("ARM: dts: imx6sx: Add LDB support")

Applied, thanks!