Skip to contentSkip to conversation

ARM: dts: imx: Pass #sound-dai-cells to sgtl5000

PATCH Applied Fabio Estevam 2 participants 3 messages Jul 30, 2023 – Aug 6, 2023

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 ARM: dts: imx: Pass #sound-dai-cells to sgtl5000

From: Fabio Estevam <[email protected]>

As per sgtl5000.yaml, '#sound-dai-cells' is a required property.

Pass it to fix the following schema warnings:

imx53-mba53.dtb: sgtl5000@a: '#sound-dai-cells' is a required property

---
 arch/arm/boot/dts/nxp/imx/imx53-mba53.dts             | 1 +
 arch/arm/boot/dts/nxp/imx/imx6dl-riotboard.dts        | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-bx50v3.dtsi           | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts          | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts          | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-h100.dts              | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-pistachio.dts         | 1 +
 arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts           | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-apf6dev.dtsi        | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-gw52xx.dtsi         | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-gw53xx.dtsi         | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-gw54xx.dtsi         | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-nit6xlite.dtsi      | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_max.dtsi  | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_som2.dtsi | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6x.dtsi     | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-rex.dtsi            | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi      | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-ts7970.dtsi         | 1 +
 arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi      | 1 +
 arch/arm/boot/dts/nxp/imx/imx6sx-nitrogen6sx.dts      | 1 +
 arch/arm/boot/dts/nxp/imx/imx6ul-pico-dwarf.dts       | 1 +
 arch/arm/boot/dts/nxp/imx/imx6ul-pico-hobbit.dts      | 1 +
 arch/arm/boot/dts/nxp/imx/imx6ul-pico-pi.dts          | 1 +
 arch/arm/boot/dts/nxp/imx/imx7d-pico-dwarf.dts        | 1 +
 arch/arm/boot/dts/nxp/imx/imx7d-pico-nymph.dts        | 1 +
 26 files changed, 26 insertions(+)
arch/arm/boot/dts/nxp/imx/imx53-mba53.dts +1 -0
index 73369f752297..6a37616cef1c 100644
@@ -161,6 +161,7 @@ &i2c2 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>;
 		VDDA-supply = <&reg_3p2v>;
 		VDDIO-supply = <&reg_3p2v>;
arch/arm/boot/dts/nxp/imx/imx6dl-riotboard.dts +1 -0
index 0366d1037ef4..114739d10447 100644
@@ -172,6 +172,7 @@ &i2c1 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6q-bx50v3.dtsi +1 -0
index ead83091e193..99f4f6ac71d4 100644
@@ -228,6 +228,7 @@ mux1_i2c4: i2c@3 {
 			sgtl5000: codec@a {
 				compatible = "fsl,sgtl5000";
 				reg = <0x0a>;
+				#sound-dai-cells = <0>;
 				clocks = <&mclk>;
 				VDDA-supply = <&reg_1p8v>;
 				VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6q-dms-ba16.dts +1 -0
index 137db38f0d27..d2d0a82ea178 100644
@@ -96,6 +96,7 @@ &i2c1 {
 	sgtl5000: codec@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		lrclk-strength = <0x3>;
 		VDDA-supply = <&reg_1p8v>;
arch/arm/boot/dts/nxp/imx/imx6q-gw5400-a.dts +1 -0
index a9648d0c6c1f..c5c144879fa6 100644
@@ -310,6 +310,7 @@ accelerometer: mma8450@1c {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&sw4_reg>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6q-h100.dts +1 -0
index 3fe4591e21f5..a603562ea49a 100644
@@ -179,6 +179,7 @@ rtc: pcf8523@68 {
 	sgtl5000: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_h100_sgtl5000>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
arch/arm/boot/dts/nxp/imx/imx6q-pistachio.dts +1 -0
index 109b46a22b5e..fb9f320103c6 100644
@@ -196,6 +196,7 @@ codec: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_i2c1_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_1p8v>;
 		VDDIO-supply = <&reg_1p8v>;
arch/arm/boot/dts/nxp/imx/imx6q-tbs2910.dts +1 -0
index 2f576e2ce73f..7c298d9aa21e 100644
@@ -141,6 +141,7 @@ sgtl5000: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
 	};
arch/arm/boot/dts/nxp/imx/imx6qdl-apf6dev.dtsi +1 -0
index 2577eb4f535a..338d292553ad 100644
@@ -181,6 +181,7 @@ &i2c2 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-gw52xx.dtsi +1 -0
index 47d9a8d08197..535679c27d6f 100644
@@ -455,6 +455,7 @@ &i2c3 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_1p8v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-gw53xx.dtsi +1 -0
index fb1d29abe099..3e1c572af582 100644
@@ -452,6 +452,7 @@ &i2c3 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_1p8v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-gw54xx.dtsi +1 -0
index 24cab2a1571a..0ffa0357a6fa 100644
@@ -499,6 +499,7 @@ &i2c3 {
 	sgtl5000: audio-codec@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&sw4_reg>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-nit6xlite.dtsi +1 -0
index 384d942f0e70..f2542d725ce7 100644
@@ -226,6 +226,7 @@ codec: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_max.dtsi +1 -0
index 724aac0050f4..763831dc0e24 100644
@@ -365,6 +365,7 @@ codec: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_som2.dtsi +1 -0
index 000e9dc97b1a..414196b75991 100644
@@ -286,6 +286,7 @@ codec: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6x.dtsi +1 -0
index f88f84b56611..f278b14911ce 100644
@@ -297,6 +297,7 @@ &i2c1 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-rex.dtsi +1 -0
index c65649390e85..eba698d04243 100644
@@ -111,6 +111,7 @@ &i2c1 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-sabrelite.dtsi +1 -0
index 9c271394f960..84c8a9531e18 100644
@@ -320,6 +320,7 @@ &i2c1 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-ts7970.dtsi +1 -0
index 1e0a041e9f60..e2db875b61c4 100644
@@ -235,6 +235,7 @@ sgtl5000: codec@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_3p3v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi +1 -0
index e4f63423d8ee..38abb6b50f6c 100644
@@ -119,6 +119,7 @@ codec: sgtl5000@a {
 		pinctrl-0 = <&pinctrl_mclk>;
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6sx-nitrogen6sx.dts +1 -0
index a2c79bcf9a11..8a5d705debbe 100644
@@ -196,6 +196,7 @@ codec: sgtl5000@a {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_sgtl5000>;
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		clocks = <&clks IMX6SX_CLK_CKO2>;
 		VDDA-supply = <&reg_1p8v>;
 		VDDIO-supply = <&reg_1p8v>;
arch/arm/boot/dts/nxp/imx/imx6ul-pico-dwarf.dts +1 -0
index 5a74c7f68eb6..fb206c1d8aca 100644
@@ -40,6 +40,7 @@ &i2c2 {
 	sgtl5000: audio-codec@a {
 		reg = <0x0a>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6ul-pico-hobbit.dts +1 -0
index 09f7ffa9ad8c..bf7dbb4f1f3e 100644
@@ -51,6 +51,7 @@ &i2c2 {
 	sgtl5000: codec@a {
 		reg = <0x0a>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx6ul-pico-pi.dts +1 -0
index 6cd7d5877d20..6cfc943a8fa3 100644
@@ -51,6 +51,7 @@ &i2c2 {
 	sgtl5000: codec@a {
 		reg = <0x0a>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx7d-pico-dwarf.dts +1 -0
index fdc10563f147..12361fcbe24a 100644
@@ -40,6 +40,7 @@ &i2c1 {
 	sgtl5000: audio-codec@a {
 		reg = <0x0a>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
arch/arm/boot/dts/nxp/imx/imx7d-pico-nymph.dts +1 -0
index 5afb1674e012..af26284297a2 100644
@@ -51,6 +51,7 @@ &i2c1 {
 	sgtl5000: audio-codec@a {
 		reg = <0x0a>;
 		compatible = "fsl,sgtl5000";
+		#sound-dai-cells = <0>;
 		clocks = <&sys_mclk>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/2 ARM: dts: imx: Remove 'compatible' from the pfuze nodes

From: Fabio Estevam <[email protected]>

Passing the 'compatible' property inside the pfuze100 regulator nodes is not allowed per pfuze100.yaml and results in the following warning:

imx6q-bosch-acc.dtb: pmic@8: regulators:sw3a: Unevaluated properties are not allowed ('compatible' was unexpected)

Remove it.

---
 arch/arm/boot/dts/nxp/imx/imx6q-bosch-acc.dts     | 2 --
 arch/arm/boot/dts/nxp/imx/imx6ul-ccimx6ulsom.dtsi | 1 -
 2 files changed, 3 deletions(-)
arch/arm/boot/dts/nxp/imx/imx6q-bosch-acc.dts +0 -2
index 8263bfef9bf8..02648806c275 100644
@@ -314,7 +314,6 @@ sw2_reg: sw2 {
 			};
 
 			sw3a_reg: sw3a {
-				compatible = "regulator-fixed";
 				regulator-name = "DDR_1V5a";
 				regulator-boot-on;
 				regulator-always-on;
@@ -322,7 +321,6 @@ sw3a_reg: sw3a {
 			};
 
 			sw3b_reg: sw3b {
-				compatible = "regulator-fixed";
 				regulator-name = "DDR_1V5b";
 				regulator-boot-on;
 				regulator-always-on;
arch/arm/boot/dts/nxp/imx/imx6ul-ccimx6ulsom.dtsi +0 -1
index 7d1a391431bd..4a03ea6d24dc 100644
@@ -114,7 +114,6 @@ vrefddr: vrefddr {
 			};
 
 			vdda_adc_3v3: vldo1 {
-				compatible = "regulator-fixed";
 				regulator-name = "vref-adc-3v3";
 				regulator-min-microvolt = <3300000>;
 				regulator-max-microvolt = <3300000>;
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

As per sgtl5000.yaml, '#sound-dai-cells' is a required property.

Pass it to fix the following schema warnings:

imx53-mba53.dtb: sgtl5000@a: '#sound-dai-cells' is a required property

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel