Skip to contentSkip to conversation

f2fs: doc: fix description of max_small_discards

PATCH Applied Chao Yu 3 participants 5 messages Jul 30, 2023 – Aug 21, 2023 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/2 f2fs: doc: fix description of max_small_discards

The description of max_small_discards is out-of-update in below two aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint

---
 Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/ABI/testing/sysfs-fs-f2fs +3 -3
index ad3d76d37c8b..36c3cb547901 100644
@@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
 Date:		November 2013
 Contact:	"Jaegeuk Kim" <[email protected]>
 Description:	Controls the issue rate of discard commands that consist of small
-		blocks less than 2MB. The candidates to be discarded are cached until
-		checkpoint is triggered, and issued during the checkpoint.
-		By default, it is disabled with 0.
+		blocks less than 2MB. The candidates to be discarded are cached during
+		checkpoint, and issued by issue_discard thread after checkpoint.
+		It is enabled by default.
 
 What:		/sys/fs/f2fs/<disk>/max_ordered_discard
 Date:		October 2022
Signature · 1 line
2.40.1
author maintainer
#1 lore raw

PATCH 2/2 Revert "f2fs: do not issue small discard commands during checkpoint"

Previously, we have two mechanisms to cache & submit small discards:

a) set max small discard number in /sys/fs/f2fs/vdb/max_small_discards, and checkpoint will cache small discard candidates w/ configured maximum number.

b) call FITRIM ioctl, also, checkpoint in f2fs_trim_fs() will cache small discard candidates w/ configured discard granularity, but w/o limitation of number. FSTRIM interface is asynchronized, so it won't submit discard directly.

Finally, discard thread will submit them in background periodically.

However, after commit 9ac00e7cef10 ("f2fs: do not issue small discard commands during checkpoint"), the mechanism a) is broken, since no matter how we configure the sysfs entry /sys/fs/f2fs/vdb/max_small_discards, checkpoint will not cache small discard candidates any more.

echo 0 > /sys/fs/f2fs/vdb/max_small_discards xfs_io -f /mnt/f2fs/file -c "pwrite 0 2m" -c "fsync" xfs_io /mnt/f2fs/file -c "fpunch 0 4k"
sync
cat /proc/fs/f2fs/vdb/discard_plist_info |head -2

echo 100 > /sys/fs/f2fs/vdb/max_small_discards rm /mnt/f2fs/file
xfs_io -f /mnt/f2fs/file -c "pwrite 0 2m" -c "fsync" xfs_io /mnt/f2fs/file -c "fpunch 0 4k"
sync
cat /proc/fs/f2fs/vdb/discard_plist_info |head -2

Before the patch:
Discard pend list(Show diacrd_cmd count on each entry, .:not exist):
0 . . . . . . . .
Discard pend list(Show diacrd_cmd count on each entry, .:not exist):
0 3 1 . . . . . .

After the patch:
Discard pend list(Show diacrd_cmd count on each entry, .:not exist):
0 . . . . . . . .
Discard pend list(Show diacrd_cmd count on each entry, .:not exist):
0 . . . . . . . .

This patch reverts commit 9ac00e7cef10 ("f2fs: do not issue small discard commands during checkpoint") in order to fix this issue.

Fixes 9ac00e7cef10 ("f2fs: do not issue small discard commands during checkpoint")
---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/segment.c +1 -1
index 6e5d1039ca76..1f0a25011687 100644
@@ -2195,7 +2195,7 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi,
 			len = next_pos - cur_pos;
 
 			if (f2fs_sb_has_blkzoned(sbi) ||
-					!force || len < cpc->trim_minlen)
+			    (force && len < cpc->trim_minlen))
 				goto skip;
 
 			f2fs_issue_discard(sbi, entry->start_blkaddr + cur_pos,
Signature · 1 line
2.40.1
author maintainer
#2 lore raw
In reply to Chao Yu

Ping,

Quoted 17 lines · Chao Yu

The description of max_small_discards is out-of-update in below two aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint

---
  Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/ABI/testing/sysfs-fs-f2fs +0 -0
index ad3d76d37c8b..36c3cb547901 100644
@@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
  Date:		November 2013
  Contact:	"Jaegeuk Kim" <[email protected]>

Documentation/ABI/testing/sysfs-fs-f2fs What: /sys/fs/f2fs/<disk>/max_small_discards · line 110

Quoted 10 lines
Documentation/ABI/testing/sysfs-fs-f2fs +3 -3
  Description:	Controls the issue rate of discard commands that consist of small
-		blocks less than 2MB. The candidates to be discarded are cached until
-		checkpoint is triggered, and issued during the checkpoint.
-		By default, it is disabled with 0.
+		blocks less than 2MB. The candidates to be discarded are cached during
+		checkpoint, and issued by issue_discard thread after checkpoint.
+		It is enabled by default.
 
  What:		/sys/fs/f2fs/<disk>/max_ordered_discard
  Date:		October 2022

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

maintainer
#3 lore raw

Let me apply this and see what'll happen later, since no luck to reproduce.

Quoted 13 lines · Chao Yu

Ping,

Quoted 10 lines · Chao Yu

The description of max_small_discards is out-of-update in below two aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint

---
  Documentation/ABI/testing/sysfs-fs-f2fs | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 16 lines
Quoted 6 lines
Documentation/ABI/testing/sysfs-fs-f2fs +0 -0
index ad3d76d37c8b..36c3cb547901 100644
@@ -102,9 +102,9 @@ What:		/sys/fs/f2fs/<disk>/max_small_discards
  Date:		November 2013

Documentation/ABI/testing/sysfs-fs-f2fs What: /sys/fs/f2fs/<disk>/max_small_discards · line 109

Quoted 10 lines
Documentation/ABI/testing/sysfs-fs-f2fs +3 -3
  Contact:	"Jaegeuk Kim" <[email protected]>
  Description:	Controls the issue rate of discard commands that consist of small
-		blocks less than 2MB. The candidates to be discarded are cached until
-		checkpoint is triggered, and issued during the checkpoint.
-		By default, it is disabled with 0.
+		blocks less than 2MB. The candidates to be discarded are cached during
+		checkpoint, and issued by issue_discard thread after checkpoint.
+		It is enabled by default.
  What:		/sys/fs/f2fs/<disk>/max_ordered_discard
  Date:		October 2022

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

#4 lore raw
In reply to Chao Yu
This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:

Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

Quoted 8 lines · On Sun, 30 Jul 2023 22:25:51 +0800 you wrote:

The description of max_small_discards is out-of-update in below two aspects, fix it.
- it is disabled by default
- small discards will be issued during checkpoint

[...]

Here is the summary with links:
- [f2fs-dev,1/2] f2fs: doc: fix description of max_small_discards

    https://git.kernel.org/jaegeuk/f2fs/c/726865e69aa3
  - [f2fs-dev,2/2] Revert "f2fs: do not issue small discard commands during checkpoint"
    https://git.kernel.org/jaegeuk/f2fs/c/005abf9e5e0d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html