Skip to contentSkip to conversation

dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

PATCH In review David Heidelberg 6 participants 7 messages Jul 30, 2023 – Aug 17, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +9 -2
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
+      then:
+        required:
+          - power-domains
 
 examples:
   - |
Signature · 1 line
2.40.1
#1 lore raw

Hi,

Quoted 19 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0 -1
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 140

Quoted 10 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +9 -1
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
+      then:
+        required:
+          - power-domains

We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm?

Cheers,
-- Guido

Quoted 6 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +0 -0
 examples:
   - |
Signature · 1 line
2.40.1
#2 lore raw
Quoted 28 lines · Guido Günther

Hi,

Quoted 26 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6 -2
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
Quoted 8 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 140

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+      then:
+        required:
+          - power-domains

We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm?

I'm happy to Ack this, but I've been sitting on it waiting to see if Marek or Liu popped up..

maintainer Reviewed-by
#3 lore raw
Quoted 38 lines · Conor Dooley
Quoted 28 lines · Guido Günther

Hi,

Quoted 26 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
  .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6 -2
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
                - fsl,imx8mp-lcdif
                - fsl,imx93-lcdif
      then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
Quoted 8 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 140

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+      then:
+        required:
+          - power-domains

We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm?

Quoted 2 lines

I'm happy to Ack this, but I've been sitting on it waiting to see if Marek or Liu popped up..

I don't see anything which would resemble power domains like on MX8MM/N/P on the MQ MXSFB, there are such domains for the VPU and DCSS, but not MXSFB. So

Reviewed-by
#4 lore raw
In reply to Conor Dooley
Quoted 41 lines · Conor Dooley
Quoted 6 lines · Guido Günther

Hi,

Quoted 4 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document

i.MX8M/i.MX6SX/i.MX6SL power-domains property")

Quoted 7 lines

Review

Quoted 7 lines
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml

Quoted 15 lines
Quoted 15 lines

index fc11ab5fc465..2d868276b0f9 100644

Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6 -2
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
Quoted 8 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 140

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+      then:
+        required:
+          - power-domains

We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm?

Quoted 2 lines

I'm happy to Ack this, but I've been sitting on it waiting to see if Marek or Liu popped up..

I see DCSS and HDMI controller/PHY sit in displaymix in a system bus diagram(internal only), but LCDIF and MIPI DSI controller/PHY are not in that mix. So, it seems that the "gpc_disp" power domain defined in imx8mq.dtsi supplies power for DCSS and HDMI controller/PHY only, though nxp,imx8mq-dcss.yaml doesn't even allow a "power-domains" property...

Assuming that system bus diagram is correct and "gpc_disp" power domain does supply power for everything in displaymix only:

P.s., there are still a few warnings from dtbs-check, see build log[1]. Hope they can be addressed...

[1] https://gitlab.com/robherring/dt-review-ci/-/jobs/4767324570/artifacts/raw/build-dtbs-1814673.log

Liu Ying

Acked-by
#5 lore raw
In reply to Conor Dooley
Quoted 38 lines · Conor Dooley
Quoted 28 lines · Guido Günther

Hi,

Quoted 26 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +6 -2
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
Quoted 8 lines

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 140

Quoted 3 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
+      then:
+        required:
+          - power-domains

We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm?

Quoted 2 lines

I'm happy to Ack this, but I've been sitting on it waiting to see if Marek or Liu popped up..

Well, I got two positive responses, so

Thanks,
Conor.

Acked-by on v1 1/1
#6 lore raw
In reply to David Heidelberg

Hi,

Quoted 35 lines · David Heidelberg

i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers requirement of power-domains, thou it's not required.

Fixes f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
---
 .../devicetree/bindings/display/fsl,lcdif.yaml        | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +9 -2
index fc11ab5fc465..2d868276b0f9 100644
@@ -129,8 +129,15 @@ allOf:
               - fsl,imx8mp-lcdif
               - fsl,imx93-lcdif
     then:
-      required:
-        - power-domains
+      if:
+        properties:
+          compatible:
+            not:
+              contains:
+                const: fsl,imx8mq-lcdif
+      then:
+        required:
+          - power-domains
 
 examples:
   - |
Signature · 1 line
2.40.1

Thanks a lot to Marek and Liu for confirming!

Cheers,
-- Guido