Skip to contentSkip to conversation

dt-bindings: pinctrl: Update pinctrl-single to use yaml

PATCH In review Tony Lindgren 3 participants 5 messages Jul 21, 2023 – Aug 7, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 dt-bindings: pinctrl: Update pinctrl-single to use yaml

Update binding for yaml and remove the old related txt bindings. Note that we are also adding the undocumented pinctrl-single,slew-rate property. And we only use the first example from the old binding.

As we are mostly using a generic compatible across various SoCs, let's not start adding matches for random pin group node naming. Let's standardize on pin group node name ending in -pins with an optional instance number suffix.

As a pin group may have additional pins added to it later on, let's always use -pins rather than -pin for the gropu name.

Most of the dts files have been updated already for the pin group node names with a few changes still pending.

Cc Nishanth Menon <[email protected]>
Cc Vignesh Raghavendra <[email protected]>

---

Changes since v6:
- Avoid adding lots of matches and only accept nodes ending in -pins with an optional suffix for instance number

- Update title to drop driver related stuff as noted by Krzysztof

Changes since v5:
- Fix issues noted by Krzysztof

Changes since v4:
- Removed legacy matching for pin group node names, let's fix the dts files instead to use "pins" naming with dashes. This also fixed the new warnings introduced for "not of type 'object'" for anything named pin

Changes since v3:
- Fix issues noted by Rob for v2 version that I had missed

- Categorize patternProperties a bit to make fixing dts files easier

Changes since v2:

- Drop old ti,omap-pinctrl.txt in addition to old pinctrl-single.txt

- Replace reference to pinctrl-single.txt to point to the yaml in ctrl.txt

Changes since v1:

- The v1 version was a WIP patch posted as an example in thread "dt binding check error with hash and comma"

---
 .../devicetree/bindings/arm/omap/ctrl.txt     |   2 +-
 .../bindings/pinctrl/pinctrl-single.txt       | 262 ------------------
 .../bindings/pinctrl/pinctrl-single.yaml      | 206 ++++++++++++++
 .../bindings/pinctrl/ti,omap-pinctrl.txt      |  13 -
 4 files changed, 207 insertions(+), 276 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
Documentation/devicetree/bindings/arm/omap/ctrl.txt +1 -1
@@ -8,7 +8,7 @@ control module driver itself.
 
 See [2] for documentation about clock/clockdomain nodes.
 
-[1] Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
+[1] Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
 [2] Documentation/devicetree/bindings/clock/ti/*
 
 Required properties:
Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt deleted +0 -262

262 lines not on this page · raw message

Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml new file +206 -0

206 lines not on this page · raw message

Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt deleted +0 -13
deleted file mode 100644
@@ -1,13 +0,0 @@
-OMAP Pinctrl definitions
-
-Required properties:
-- compatible : Should be one of:
-  "ti,omap2420-padconf" - OMAP2420 compatible pinctrl
-  "ti,omap2430-padconf" - OMAP2430 compatible pinctrl
-  "ti,omap3-padconf" - OMAP3 compatible pinctrl
-  "ti,omap4-padconf" - OMAP4 compatible pinctrl
-  "ti,omap5-padconf" - OMAP5 compatible pinctrl
-  "ti,dra7-padconf" - DRA7 compatible pinctrl
-  "ti,am437-padconf" - AM437x compatible pinctrl
-
-See Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt for further details.
Signature · 1 line
2.41.0
maintainer Reviewed-by on v7 1/1
#1 lore raw
Quoted 51 lines · Tony Lindgren

Update binding for yaml and remove the old related txt bindings. Note that we are also adding the undocumented pinctrl-single,slew-rate property. And we only use the first example from the old binding.

As we are mostly using a generic compatible across various SoCs, let's not start adding matches for random pin group node naming. Let's standardize on pin group node name ending in -pins with an optional instance number suffix.

As a pin group may have additional pins added to it later on, let's always use -pins rather than -pin for the gropu name.

Most of the dts files have been updated already for the pin group node names with a few changes still pending.

Cc Nishanth Menon <[email protected]>
Cc Vignesh Raghavendra <[email protected]>

---

Changes since v6:
- Avoid adding lots of matches and only accept nodes ending in -pins with an optional suffix for instance number

- Update title to drop driver related stuff as noted by Krzysztof

Changes since v5:
- Fix issues noted by Krzysztof

Changes since v4:
- Removed legacy matching for pin group node names, let's fix the dts files instead to use "pins" naming with dashes. This also fixed the new warnings introduced for "not of type 'object'" for anything named pin

Changes since v3:
- Fix issues noted by Rob for v2 version that I had missed

- Categorize patternProperties a bit to make fixing dts files easier

Changes since v2:

- Drop old ti,omap-pinctrl.txt in addition to old pinctrl-single.txt

- Replace reference to pinctrl-single.txt to point to the yaml in ctrl.txt

Changes since v1:

- The v1 version was a WIP patch posted as an example in thread "dt binding check error with hash and comma"

Quoted 10 lines
---
 .../devicetree/bindings/arm/omap/ctrl.txt     |   2 +-
 .../bindings/pinctrl/pinctrl-single.txt       | 262 ------------------
 .../bindings/pinctrl/pinctrl-single.yaml      | 206 ++++++++++++++
 .../bindings/pinctrl/ti,omap-pinctrl.txt      |  13 -
 4 files changed, 207 insertions(+), 276 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
#2 lore raw
Quoted 4 lines · Rob Herring
Quoted 3 lines · Tony Lindgren

Update binding for yaml and remove the old related txt bindings. Note that we are also adding the undocumented pinctrl-single,slew-rate property. And we only use the first example from the old binding.

...

Quoted 1 line

Krzysztof, does this look OK to you now?

Regards,

Tony

#3 lore raw
In reply to Tony Lindgren
Quoted 15 lines · Tony Lindgren

Update binding for yaml and remove the old related txt bindings. Note that we are also adding the undocumented pinctrl-single,slew-rate property. And we only use the first example from the old binding.

As we are mostly using a generic compatible across various SoCs, let's not start adding matches for random pin group node naming. Let's standardize on pin group node name ending in -pins with an optional instance number suffix.

As a pin group may have additional pins added to it later on, let's always use -pins rather than -pin for the gropu name.

Most of the dts files have been updated already for the pin group node names with a few changes still pending.

Quoted 6 lines
Cc Nishanth Menon <[email protected]>
Cc Vignesh Raghavendra <[email protected]>

---

Changes since v6:

Phew!

Patch applied. Any remaining issues can certainly be fixed in tree.

Yours,
Linus Walleij

#4 lore raw
Quoted 17 lines · Linus Walleij
Quoted 15 lines · Tony Lindgren

Update binding for yaml and remove the old related txt bindings. Note that we are also adding the undocumented pinctrl-single,slew-rate property. And we only use the first example from the old binding.

As we are mostly using a generic compatible across various SoCs, let's not start adding matches for random pin group node naming. Let's standardize on pin group node name ending in -pins with an optional instance number suffix.

As a pin group may have additional pins added to it later on, let's always use -pins rather than -pin for the gropu name.

Most of the dts files have been updated already for the pin group node names with a few changes still pending.

Quoted 8 lines
Quoted 6 lines
Cc Nishanth Menon <[email protected]>
Cc Vignesh Raghavendra <[email protected]>

---

Changes since v6:

Phew!

Whee!

Quoted 1 line

Patch applied. Any remaining issues can certainly be fixed in tree.

Yes there should be only few more warnings remaining. Having the binding in place will enable some nice warning checks to prevent new inventions for pin group name variants :)

Regards,

Tony