hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS_WORD
PATCH v2 1/1 hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS_WORD
From: Patrick Rudolph <[email protected]>
MP2973 & MP2971 returns PGOOD instead of PB_STATUS_POWER_GOOD_N. Fix that in the read_word_data hook.
MP2975 might be affected but needs verification.
--- drivers/hwmon/pmbus/mp2975.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/hwmon/pmbus/mp2975.c +5 -0
@@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client *client, int page,int ret;switch (reg) { +case PMBUS_STATUS_WORD : +/* MP2973 & MP2971 returns PGOOD instead of PB_STATUS_POWER_GOOD_N. */ + ret =pmbus_read_word_data (client, page, phase, reg); + ret ^=PB_STATUS_POWER_GOOD_N ; +break ;case PMBUS_OT_FAULT_LIMIT : ret =mp2975_read_word_helper (client, page, phase, reg,GENMASK (7 ,0 ));
base-commit: cb7022b8976e3c4d12cea2e7bb820a2944e2fd7b
Signature · 1 line
2.41.0
Quoted 13 lines
-----Original Message-----
From: Naresh Solanki <[email protected]>
Sent: Monday, 31 July 2023 12:22
To: Guenter Roeck <[email protected]>; Jean Delvare <[email protected]>
Cc: Vadim Pasternak <[email protected]>; Patrick Rudolph <[email protected]>; Naresh Solanki <[email protected]>; [email protected]; linux- [email protected]
Subject: [PATCH v2] hwmon: (pmbus/mp2975) Fix PGOOD inREAD_STATUS_WORD
Quoted 5 lines
From: Patrick Rudolph <[email protected]>
MP2973 & MP2971 returns PGOOD instead of
PB_STATUS_POWER_GOOD_N. Fix that in theread_word_datahook.
MP2975 might be affected but needs verification.
Hi,
According to MP2975 regmap datasheet for STATUS_WORD, bit 11 reports:
11 POWER_GOOD_N 1’b0: PG is active.
1’b1: PG not active has occurred
Is it the same what stays MP2971 and MP2973 docs?
Thanks,
Vadim.
Quoted 30 lines
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- drivers/hwmon/pmbus/mp2975.c | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/drivers/hwmon/pmbus/mp2975.cindex28f33f4618fa..27bb39370662100644drivers/hwmon/pmbus/mp2975.c +2
-0@@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client *client, int page, int ret;switch (reg) { +case PMBUS_STATUS_WORD : +/* MP2973 & MP2971 returns PGOOD instead of
PB_STATUS_POWER_GOOD_N. */drivers/hwmon/pmbus/mp2975.c +3
-0+ ret =pmbus_read_word_data (client, page, phase, reg); + ret ^=PB_STATUS_POWER_GOOD_N ; +break ;case PMBUS_OT_FAULT_LIMIT : ret =mp2975_read_word_helper (client, page, phase, reg,GENMASK (7 ,0 ));base-commit:
cb7022b8976e3c4d12cea2e7bb820a2944e2fd7b--
2.41.0
Guenter Roeck
maintainerQuoted 19 lines · Vadim Pasternak
Quoted 13 lines
-----Original Message-----
From: Naresh Solanki <[email protected]>
Sent: Monday, 31 July 2023 12:22
To: Guenter Roeck <[email protected]>; Jean Delvare <[email protected]>
Cc: Vadim Pasternak <[email protected]>; Patrick Rudolph <[email protected]>; Naresh Solanki <[email protected]>; [email protected]; linux- [email protected]
Subject: [PATCH v2] hwmon: (pmbus/mp2975) Fix PGOOD inREAD_STATUS_WORDQuoted 5 lines
From: Patrick Rudolph <[email protected]>
MP2973 & MP2971 returns PGOOD instead of
PB_STATUS_POWER_GOOD_N. Fix that in theread_word_datahook.
MP2975 might be affected but needs verification.
Quoted 7 lines
Hi,
According to MP2975 regmap datasheet for
STATUS_WORD, bit 11 reports:
11POWER_GOOD_N1’b0: PG is active.
1’b1: PG not active has occurred
Is it the same what stays MP2971 and MP2973 docs?
I don't have a datasheet for any of the chips, so I can not confirm either way. The above looks like the standard definition, suggesting that MP2975 would not be affected.
If that is the case, the commit should say that MP2975 is not affected according to the datasheet, but that this has not been confirmed on real hardware (unless you can confirm it).
Thanks,
Guenter
Quoted 34 lines
Thanks,
Vadim.Quoted 30 lines
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- drivers/hwmon/pmbus/mp2975.c | 5 +++++ 1 file changed, 5 insertions(+)(quoted diff) +0
-0
b/drivers/hwmon/pmbus/mp2975.cindex28f33f4618fa..27bb39370662100644drivers/hwmon/pmbus/mp2975.c +2
-0@@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client *client, int page, int ret;switch (reg) { +case PMBUS_STATUS_WORD : +/* MP2973 & MP2971 returns PGOOD instead of
PB_STATUS_POWER_GOOD_N. */drivers/hwmon/pmbus/mp2975.c +3
-0+ ret =pmbus_read_word_data (client, page, phase, reg); + ret ^=PB_STATUS_POWER_GOOD_N ; +break ;case PMBUS_OT_FAULT_LIMIT : ret =mp2975_read_word_helper (client, page, phase, reg,GENMASK (7 ,0 ));base-commit:
cb7022b8976e3c4d12cea2e7bb820a2944e2fd7b--
2.41.0
Quoted 8 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
MP2973 & MP2971 returns PGOOD instead of
PB_STATUS_POWER_GOOD_N. Fix that in theread_word_datahook.
MP2975 might be affected but needs verification.Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>
Applied, after rephrasing description to indicate that MP2975 is likely not affected. Also added Fixes: tags.
Guenter
Quoted 23 lines
--- drivers/hwmon/pmbus/mp2975.c | 5 +++++ 1 file changed, 5 insertions(+)base-commit:
cb7022b8976e3c4d12cea2e7bb820a2944e2fd7bdrivers/hwmon/pmbus/mp2975.c +5
-0@@ -297,6 +297,11 @@ static int mp2973_read_word_data(struct i2c_client *client, int page,int ret;switch (reg) { +case PMBUS_STATUS_WORD : +/* MP2973 & MP2971 returns PGOOD instead of PB_STATUS_POWER_GOOD_N. */ + ret =pmbus_read_word_data (client, page, phase, reg); + ret ^=PB_STATUS_POWER_GOOD_N ; +break ;case PMBUS_OT_FAULT_LIMIT : ret =mp2975_read_word_helper (client, page, phase, reg,GENMASK (7 ,0 ));