Skip to contentSkip to conversation

drm/tve200: remove redundant of_match_ptr

PATCH In review Zhu Wang 2 participants 2 messages Jul 31, 2023 – Aug 7, 2023

Subsystems (3)
lore
Share & tools
lore

Zhu Wang

author
#0 lore raw

PATCH 1/1 drm/tve200: remove redundant of_match_ptr

The driver depends on CONFIG_OF, so it is not necessary to use of_match_ptr here.

Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with and without it. Hence we remove of_match_ptr.

---
 drivers/gpu/drm/tve200/tve200_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tve200/tve200_drv.c +1 -1
index 984aa8f0a542..0bb56d063536 100644
@@ -259,7 +259,7 @@ static const struct of_device_id tve200_of_match[] = {
 static struct platform_driver tve200_driver = {
 	.driver = {
 		.name           = "tve200",
-		.of_match_table = of_match_ptr(tve200_of_match),
+		.of_match_table = tve200_of_match,
 	},
 	.probe = tve200_probe,
 	.remove_new = tve200_remove,
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Zhu Wang

The driver depends on CONFIG_OF, so it is not necessary to use of_match_ptr here.

Even for drivers that do not depend on CONFIG_OF, it's almost always better to leave out the of_match_ptr(), since the only thing it can possibly do is to save a few bytes of .text if a driver can be used both with and without it. Hence we remove of_match_ptr.

Patch applied!

Yours,
Linus Walleij