nvme-auth: unlock mutex in one place only
Subsystems (2)
PATCH v2 1/2 nvme-auth: unlock mutex in one place only
--- drivers/nvme/host/auth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/nvme/host/auth.c +1 -2
@@ -758,12 +758,11 @@ static void nvme_queue_auth_work(struct work_struct *work) __func__, chap->qid);mutex_lock (&ctrl->dhchap_auth_mutex); ret =nvme_auth_dhchap_setup_host_response (ctrl, chap); +mutex_unlock (&ctrl->dhchap_auth_mutex);if (ret) { -mutex_unlock (&ctrl->dhchap_auth_mutex); chap->error = ret; goto fail2; } -mutex_unlock (&ctrl->dhchap_auth_mutex);/* DH-HMAC-CHAP Step 3: send reply */ dev_dbg(ctrl->device, "%s: qid %d send reply\n",
Signature · 1 line
2.39.2
PATCH v2 2/2 nvme-auth: set explanation code for failure2 msgs
Some error cases were not setting an auth-failure-reason-code-explanation. This means an AUTH_Failure2 message will be sent with an explanation value of 0 which is a reserved value.
---v1->v2: Set failure explanation in a single place if the error handling code has not already done so.
drivers/nvme/host/auth.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/nvme/host/auth.c +2 -0
@@ -839,6 +839,8 @@ static void nvme_queue_auth_work(struct work_struct *work) } fail2: +if (chap->status ==0 ) + chap->status =NVME_AUTH_DHCHAP_FAILURE_FAILED ;dev_dbg (ctrl->device,"%s: qid %d send failure2, status %x\n" , __func__, chap->qid, chap->status); tl =nvme_auth_set_dhchap_failure2_data (ctrl, chap);
Signature · 1 line
2.39.2
Re: [PATCH v2 2/2] nvme-auth: set explanation code for failure2 msgs
Quoted 17 lines · Mark O'Donovan
Some error cases were not setting an auth-failure-reason-code-explanation. This means an
AUTH_Failure2message will be sent with an explanation value of 0 which is a reserved value.Signed-off-by Mark O'Donovan <[email protected]>---
v1->v2: Set failure explanation in a single place if the error handling code has not already done so.drivers/nvme/host/auth.c | 2 ++ 1 file changed, 2 insertions(+)drivers/nvme/host/auth.c +0
-0
drivers/nvme/host/auth.c static void nvme_queue_auth_work(struct work_struct *work) · line 846
Quoted 8 lines
drivers/nvme/host/auth.c +2
-0@@ -839,6 +839,8 @@ static void nvme_queue_auth_work(struct work_struct *work) } fail2: +if (chap->status ==0 ) + chap->status =NVME_AUTH_DHCHAP_FAILURE_FAILED ;dev_dbg (ctrl->device,"%s: qid %d send failure2, status %x\n" , __func__, chap->qid, chap->status); tl =nvme_auth_set_dhchap_failure2_data (ctrl, chap);
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
Quoted 15 lines · Mark O'Donovan
Signed-off-by Mark O'Donovan <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by Sagi Grimberg <[email protected]>--- drivers/nvme/host/auth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/nvme/host/auth.c +0
-0@@ -758,12 +758,11 @@ static void nvme_queue_auth_work(struct work_struct *work) __func__, chap->qid);mutex_lock (&ctrl->dhchap_auth_mutex); ret =nvme_auth_dhchap_setup_host_response (ctrl, chap);
drivers/nvme/host/auth.c static void nvme_queue_auth_work(struct work_struct *work) · line 768
Quoted 10 lines
drivers/nvme/host/auth.c +1
-2+mutex_unlock (&ctrl->dhchap_auth_mutex);if (ret) { -mutex_unlock (&ctrl->dhchap_auth_mutex); chap->error = ret; goto fail2; } -mutex_unlock (&ctrl->dhchap_auth_mutex);/* DH-HMAC-CHAP Step 3: send reply */ dev_dbg(ctrl->device, "%s: qid %d send reply\n",
If you insist.
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman