fbdev/ps3fb: Build without kernel device
Subsystems (4)
PATCH 1/1 fbdev/ps3fb: Build without kernel device
Use fb_info() to print status message at the end of the probe function, which avoids decoding the devices. fb_info() works with or without an fbdev kernel device. Fixes the following error:
../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':../drivers/video/fbdev/ps3fb.c:1172:40: error: 'struct fb_info' has no member named 'dev'
1172 | dev_driver_string(info->dev), dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
| ^~~~~~~~../drivers/video/fbdev/ps3fb.c:1172:61: error: 'struct fb_info' has no member named 'dev'
1172 | dev_driver_string(info->dev), dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'
1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n",
| ^~~~~~~~--- drivers/video/fbdev/ps3fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/fbdev/ps3fb.c +1 -3
@@ -1168,9 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)ps3_system_bus_set_drvdata (dev, info); -dev_info (info->device,"%s %s, using %u KiB of video memory\n" , -dev_driver_string (info->dev),dev_name (info->dev), - info->fix.smem_len >>10 ); +fb_info (info,"using %u KiB of video memory\n" , info->fix.smem_len >>10 ); task =kthread_run (ps3fbd, info,DEVICE_NAME );if (IS_ERR (task)) {
Signature · 1 line
2.41.0
Quoted 24 lines · Thomas Zimmermann
Use
fb_info()to print status message at the end of the probe function, which avoids decoding the devices.fb_info()works with or without an fbdev kernel device. Fixes the following error:
../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':../drivers/video/fbdev/ps3fb.c:1172:40: error: 'structfb_info' has no member named 'dev'
1172 |dev_driver_string(info->dev),dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 |_p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~
../drivers/video/fbdev/ps3fb.c:1172:61: error: 'structfb_info' has no member named 'dev'
1172 |dev_driver_string(info->dev),dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 |_p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~
Quoted 14 lines
Reported-by Randy Dunlap <[email protected]>Signed-off-by Thomas Zimmermann <[email protected]>Fixes 701d2054fa31 ("fbdev: Make support for userspace interfaces configurable")Cc Michael Ellerman <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Helge Deller <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Randy Dunlap <[email protected]>Cc Bagas Sanjaya <[email protected]>Cc Thorsten Leemhuis <[email protected]>
Quoted 21 lines
--- drivers/video/fbdev/ps3fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/video/fbdev/ps3fb.c +1
-3@@ -1168,9 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)ps3_system_bus_set_drvdata (dev, info); -dev_info (info->device,"%s %s, using %u KiB of video memory\n" , -dev_driver_string (info->dev),dev_name (info->dev), - info->fix.smem_len >>10 ); +fb_info (info,"using %u KiB of video memory\n" , info->fix.smem_len >>10 ); task =kthread_run (ps3fbd, info,DEVICE_NAME );if (IS_ERR (task)) {Signature · 1 line
2.41.0
Quoted 24 lines · Thomas Zimmermann
Use
fb_info()to print status message at the end of the probe function, which avoids decoding the devices.fb_info()works with or without an fbdev kernel device. Fixes the following error:
../drivers/video/fbdev/ps3fb.c: In function 'ps3fb_probe':../drivers/video/fbdev/ps3fb.c:1172:40: error: 'structfb_info' has no member named 'dev'
1172 |dev_driver_string(info->dev),dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 |_p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~
../drivers/video/fbdev/ps3fb.c:1172:61: error: 'structfb_info' has no member named 'dev'
1172 |dev_driver_string(info->dev),dev_name(info->dev),
| ^~../include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 |_p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~../drivers/video/fbdev/ps3fb.c:1171:9: note: in expansion of macro 'dev_info'1171 | dev_info(info->device, "%s %s, using %u KiB of video memory\n", | ^~~~~~~~
Quoted 14 lines
Reported-by Randy Dunlap <[email protected]>Signed-off-by Thomas Zimmermann <[email protected]>Fixes 701d2054fa31 ("fbdev: Make support for userspace interfaces configurable")Cc Michael Ellerman <[email protected]>Cc Sam Ravnborg <[email protected]>Cc Helge Deller <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Randy Dunlap <[email protected]>Cc Bagas Sanjaya <[email protected]>Cc Thorsten Leemhuis <[email protected]>
Thanks.
Quoted 19 lines
--- drivers/video/fbdev/ps3fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/video/fbdev/ps3fb.c +1
-3@@ -1168,9 +1168,7 @@ static int ps3fb_probe(struct ps3_system_bus_device *dev)ps3_system_bus_set_drvdata (dev, info); -dev_info (info->device,"%s %s, using %u KiB of video memory\n" , -dev_driver_string (info->dev),dev_name (info->dev), - info->fix.smem_len >>10 ); +fb_info (info,"using %u KiB of video memory\n" , info->fix.smem_len >>10 ); task =kthread_run (ps3fbd, info,DEVICE_NAME );if (IS_ERR (task)) {
Signature · 1 line
~Randy