target/nios2: Pass semihosting arg to exit
PATCH 1/1 target/nios2: Pass semihosting arg to exit
Instead of using the function number (which is always zero), fetch the application-provided exit code argument and pass that to the two exit functions.
--- target/nios2/nios2-semi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
target/nios2/nios2-semi.c +3 -2
@@ -133,8 +133,9 @@ void do_nios2_semihosting(CPUNios2State *env) args = env->regs[R_ARG1 ];switch (nr) {case HOSTED_EXIT : -gdb_exit (env->regs[R_ARG0 ]); -exit (env->regs[R_ARG0 ]); +GET_ARG (0 ); +gdb_exit (arg0); +exit (arg0);case HOSTED_OPEN :GET_ARG (0 );
Signature · 1 line
2.40.1
Quoted 15 lines · Keith Packard via
Instead of using the function number (which is always zero), fetch the application-provided exit code argument and pass that to the two exit functions.
Signed-off-by Keith Packard <[email protected]>--- target/nios2/nios2-semi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)target/nios2/nios2-semi.c +0
-0
target/nios2/nios2-semi.c void do_nios2_semihosting(CPUNios2State *env) · line 138
Quoted 8 lines
target/nios2/nios2-semi.c +3
-2@@ -133,8 +133,9 @@ void do_nios2_semihosting(CPUNios2State *env) args = env->regs[R_ARG1 ];switch (nr) {case HOSTED_EXIT : -gdb_exit (env->regs[R_ARG0 ]); -exit (env->regs[R_ARG0 ]); +GET_ARG (0 ); +gdb_exit (arg0); +exit (arg0);
says that for HOSTED_EXIT the exit code is in r5, not in a parameter block pointed to by r5. That would imply that the correct change is to use R_ARG1 rather than R_ARG0 here.
thanks
-- PMM
Quoted 5 lines
says that for
HOSTED_EXITthe exit code is in r5, not in a parameter block pointed to by r5. That would imply that the correct change is to useR_ARG1rather thanR_ARG0here.
Ah, thanks -- I hadn't managed to find the actual standard yet. I'll resubmit with that fixed.
Signature · 1 line
-keith
Quoted 8 lines · Keith Packard
Quoted 6 lines
says that for
HOSTED_EXITthe exit code is in r5, not in a parameter block pointed to by r5. That would imply that the correct change is to useR_ARG1rather thanR_ARG0here.Ah, thanks -- I hadn't managed to find the actual standard yet.
Yeah, the closest to a "standard" we have for nios2 is that I asked the Codesourcery folks to document it in the libgloss sources and put the URL to it in a comment at the top of nios2-semi.c, given that there's no official spec and the original and main guest-side user is libgloss.
m68k is in a similar position only without the URL in our source file :-)
-- PMM
Quoted 8 lines
Yeah, the closest to a "standard" we have for nios2 is that I asked the Codesourcery folks to document it in the libgloss sources and put the URL to it in a comment at the top of
nios2-semi.c, given that there's no official spec and the original and main guest-side user is libgloss.
m68k is in a similar position only without the URL in our source file :-)
Yeah, we had the same ask when getting risc-v semihosting merged. For that, I actually pushed through an "official" risc-v standard. I kinda wish I'd used the m68k model instead of the arm model as that provides simple POSIX semantics...
https://github.com/riscv-software-src/riscv-semihosting/blob/main/riscv-semihosting-spec.adoc
Signature · 1 line
-keith
Quoted 10 lines · Keith Packard
Quoted 9 lines
Yeah, the closest to a "standard" we have for nios2 is that I asked the Codesourcery folks to document it in the libgloss sources and put the URL to it in a comment at the top of
nios2-semi.c, given that there's no official spec and the original and main guest-side user is libgloss.
m68k is in a similar position only without the URL in our source file :-)
Quoted 4 lines
Yeah, we had the same ask when getting risc-v semihosting merged. For that, I actually pushed through an "official" risc-v standard. I kinda wish I'd used the m68k model instead of the arm model as that provides simple POSIX semantics...
Yeah, there's a lot of stuff in the Arm semihosting API that I wouldn't put in there for a from-new version that didn't need to handle legacy guests. Notably the "errno" concept is badly underspecified and/or broken. On an architecture with a decent number of registers it would probably also make sense to use them rather than having every single call put its args in memory.
thanks
-- PMM