Skip to contentSkip to conversation

package/systemd: select kdb

PATCH In review James Hilliard 3 participants 7 messages Jul 31, 2023 – Aug 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/systemd: select kdb

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

Fixes:
systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

---
 package/systemd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/systemd/Config.in +1 -0
index bea717a456..f3e561e661 100644
@@ -563,6 +563,7 @@ config BR2_PACKAGE_SYSTEMD_UTMP
 config BR2_PACKAGE_SYSTEMD_VCONSOLE
 	bool "enable vconsole tool"
 	default y
+	select BR2_PACKAGE_KBD
 	help
 	  systemd-vconsole-setup is an early boot service that
 	  configures the virtual console font and console keymap.
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello James,

Quoted 6 lines · On Mon, 31 Jul 2023 15:45:59 -0600 James Hilliard <[email protected]>…

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

Fixes:
systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

Same question as always: since when is this needed? I suppose since commit 36d275f695936b7a54738c0354572944c1f08d87 ("package/systemd: bump to version 254"), but I don't know, and Peter will have an even harder time figuring this out when he will try to figure out which commits in master need to be backported to the stable branch.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 11 lines · Thomas Petazzoni

Hello James,

Quoted 5 lines · On Mon, 31 Jul 2023 15:45:59 -0600 James Hilliard <[email protected]>…

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

Fixes:
systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

Quoted 7 lines
Quoted 1 line

Same question as always: since when is this needed? I suppose since commit 36d275f695936b7a54738c0354572944c1f08d87 ("package/systemd: bump to version 254"), but I don't know, and Peter will have an even harder time figuring this out when he will try to figure out which commits in master need to be backported to the stable branch.

It looks like it should be backported, I looked at the code and found no obvious reason why it should have worked previously without kdb.

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training
https://bootlin.com

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 8 lines · On Mon, 31 Jul 2023 16:07:33 -0600 James Hilliard <[email protected]>…
Quoted 5 lines

Same question as always: since when is this needed? I suppose since commit 36d275f695936b7a54738c0354572944c1f08d87 ("package/systemd: bump to version 254"), but I don't know, and Peter will have an even harder time figuring this out when he will try to figure out which commits in master need to be backported to the stable branch.

It looks like it should be backported, I looked at the code and found no obvious reason why it should have worked previously without kdb.

But test cases were working I believe, so there must be some other explanation.

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw
In reply to James Hilliard

James, All,

On 2023-07-31 15:45 -0600, James Hilliard spake thusly:

Quoted 15 lines

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

Fixes:
systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

---
 package/systemd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/systemd/Config.in +0 -0
index bea717a456..f3e561e661 100644

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_UTMP · line 566

Quoted 4 lines
package/systemd/Config.in +1 -0
@@ -563,6 +563,7 @@ config BR2_PACKAGE_SYSTEMD_UTMP
 config BR2_PACKAGE_SYSTEMD_VCONSOLE
 	bool "enable vconsole tool"
 	default y
+	select BR2_PACKAGE_KBD

This is trivial to explain, indeed, but what is not trivial to explan but most interesting, and as I did ask in my preview mail, is to explain why:

- in systemd 252, loadkeys was already needed and called from systemd-vconsole-setup (check the code, it was already there in 252 and most probably even long before that...)

- with systemd 252, our test cases were not failing, even though loadkeys was needed

- with systemd 254, the same test case now fails.

This we need to understand.

That way, we know if our test was broken, or if the new dependency should be backported to previous maintenance branches...

(and now I see that Thomas had the same questions).

Quoted 6 lines
package/systemd/Config.in +0 -0
 	help
 	  systemd-vconsole-setup is an early boot service that
 	  configures the virtual console font and console keymap.
Signature · 1 line
2.34.1
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
Quoted 32 lines · Yann E. MORIN

James, All,

On 2023-07-31 15:45 -0600, James Hilliard spake thusly:

Quoted 15 lines

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

Fixes:
systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

---
 package/systemd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/systemd/Config.in +0 -0
index bea717a456..f3e561e661 100644

package/systemd/Config.in config BR2_PACKAGE_SYSTEMD_UTMP · line 566

Quoted 4 lines
package/systemd/Config.in +1 -0
@@ -563,6 +563,7 @@ config BR2_PACKAGE_SYSTEMD_UTMP
 config BR2_PACKAGE_SYSTEMD_VCONSOLE
      bool "enable vconsole tool"
      default y
+     select BR2_PACKAGE_KBD

This is trivial to explain, indeed, but what is not trivial to explan but most interesting, and as I did ask in my preview mail, is to explain why:

- in systemd 252, loadkeys was already needed and called from systemd-vconsole-setup (check the code, it was already there in 252 and most probably even long before that...)

Quoted 6 lines

- with systemd 252, our test cases were not failing, even though loadkeys was needed

- with systemd 254, the same test case now fails.

This we need to understand.

Yeah, I tried to figure that out, but I couldn't find any reason for the test not
failing previously.

Quoted 13 lines

That way, we know if our test was broken, or if the new dependency should be backported to previous maintenance branches...

(and now I see that Thomas had the same questions).

Quoted 6 lines
package/systemd/Config.in +0 -1
      help
        systemd-vconsole-setup is an early boot service that
        configures the virtual console font and console keymap.
--

2.34.1

Quoted 7 lines

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#6 lore raw

James, All,

On 2023-08-01 15:09 -0600, James Hilliard spake thusly:

Quoted 9 lines · Yann E. MORIN
Quoted 5 lines

On 2023-07-31 15:45 -0600, James Hilliard spake thusly:

Quoted 1 line

We need to select BR2_PACKAGE_KBD when building systemd with vconsole.

This is trivial to explain, indeed, but what is not trivial to explan but most interesting, and as I did ask in my preview mail, is to explain why:

Yeah, I tried to figure that out, but I couldn't find any reason for the test not
failing previously.

In the meantime, Romain has sent a patch that explains the issue, and adds the appropriate option to solve it.

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot