Skip to contentSkip to conversation

arm32: Avoid using solaris syntax for .section directive

PATCH In review Khem Raj 2 participants 3 messages Aug 1, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 arm32: Avoid using solaris syntax for .section directive

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr
Switch to using ELF syntax

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

---
 xen/arch/arm/arm32/proc-v7.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
xen/arch/arm/arm32/proc-v7.S +3 -3
index c90a31d80f..6d3d19b873 100644
@@ -29,7 +29,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca15mp_proc_info, #object
 __v7_ca15mp_proc_info:
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca7mp_proc_info, #object
 __v7_ca7mp_proc_info:
         .long 0x410FC070             /* Cortex-A7 */
@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_brahma15mp_proc_info, #object
 __v7_brahma15mp_proc_info:
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · Khem Raj

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr
Switch to using ELF syntax

You mean GNU, not ELF (ELF is describing the object format, not the syntax used). Feels almost like a regression (I'll mention that to Alan), which likely went unnoticed so far because Linux had changed to GNU syntax already in 5.5, to allow building with Clang's integrated assembler. This aspect may be worth mentioning here as well.

Quoted 5 lines

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

Out of curiosity - why were there four instances of the patch? They all look largely identical; if there are differences, I haven't spotted them.

Jan

author
#2 lore raw
Quoted 9 lines · Jan Beulich
Quoted 6 lines · Khem Raj

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr
Switch to using ELF syntax

Quoted 6 lines

You mean GNU, not ELF (ELF is describing the object format, not the syntax used). Feels almost like a regression (I'll mention that to Alan), which likely went unnoticed so far because Linux had changed to GNU syntax already in 5.5, to allow building with Clang's integrated assembler. This aspect may be worth mentioning here as well.

OK will send v2

Quoted 10 lines
Quoted 6 lines

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

Out of curiosity - why were there four instances of the patch? They all look largely identical; if there are differences, I haven't spotted them.

there should not have been
I was a not a subscriber to mailing list, did not realize why it was not appearing on ml :)

Quoted 2 lines

Jan