Skip to contentSkip to conversation

xen: Fix build with gas/2.41

PATCH In review Khem Raj 2 participants 3 messages Aug 1, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 xen: Fix build with gas/2.41

Cc Alexandre Belloni <[email protected]>
---
 ...g-solaris-syntax-for-.section-direct.patch | 62 +++++++++++++++++++
 recipes-extended/xen/xen_4.17.bb              |  4 ++
 2 files changed, 66 insertions(+)
 create mode 100644 recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch new file +62 -0
new file mode 100644
index 0000000..c73bb27
@@ -0,0 +1,62 @@
+From 9add6f9aced42a76f6a2c124754bef6fde56fa05 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+To: [email protected]
+Cc: Stefano Stabellini <[email protected]>
+Cc: Julien Grall <[email protected]>
+Cc: Bertrand Marquis <[email protected]>
+Cc: Volodymyr Babchuk <[email protected]>
+Date: Mon, 31 Jul 2023 17:01:32 -0700
+Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive
+
+Assembler from binutils 2.41 rejects this syntax
+
+.section "name"[, flags...]
+
+where flags could be #alloc, #write, #execstr
+Switch to using ELF syntax
+
+.section name[, "flags"[, @type]]
+
+[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
+
+Upstream-Status: Submitted [by email to [email protected] and maintainers]
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ xen/arch/arm/arm32/proc-v7.S | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
+index c90a31d80f..6d3d19b873 100644
+--- a/xen/arch/arm/arm32/proc-v7.S
++++ b/xen/arch/arm/arm32/proc-v7.S
+@@ -29,7 +29,7 @@ brahma15mp_init:
+         mcr   CP32(r0, ACTLR)
+         mov   pc, lr
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca15mp_proc_info, #object
+ __v7_ca15mp_proc_info:
+         .long 0x410FC0F0             /* Cortex-A15 */
+@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca7mp_proc_info, #object
+ __v7_ca7mp_proc_info:
+         .long 0x410FC070             /* Cortex-A7 */
+@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_brahma15mp_proc_info, #object
+ __v7_brahma15mp_proc_info:
+         .long 0x420F00F0             /* Broadcom Brahma-B15 */
+-- 
+2.41.0
+
recipes-extended/xen/xen_4.17.bb +4 -0
index 9da1b19..bd8f55b 100644
@@ -7,6 +7,7 @@ XEN_BRANCH ?= "stable-${XEN_REL}"
 SRC_URI = " \
     git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
     file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
+    file://0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch \
     "
 
 LIC_FILES_CHKSUM ?= "file://COPYING;md5=d1a1e216f80b6d8da95fec897d0dbec9"
@@ -17,3 +18,6 @@ S = "${WORKDIR}/git"
 
 require xen.inc
 require xen-hypervisor.inc
+
+TOOLCHAIN = "gcc"
+LDFLAGS:remove = "-fuse-ld=lld"
Signature · 1 line
2.41.0
#1 lore raw

merged.

Bruce

In message: [meta-virtualization][PATCH] xen: Fix build with gas/2.41

Quoted 108 lines · on 31/07/2023 Khem Raj wrote:
Cc Alexandre Belloni <[email protected]>
---
 ...g-solaris-syntax-for-.section-direct.patch | 62 +++++++++++++++++++
 recipes-extended/xen/xen_4.17.bb              |  4 ++
 2 files changed, 66 insertions(+)
 create mode 100644 recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch new file +62 -0
new file mode 100644
index 0000000..c73bb27
@@ -0,0 +1,62 @@
+From 9add6f9aced42a76f6a2c124754bef6fde56fa05 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+To: [email protected]
+Cc: Stefano Stabellini <[email protected]>
+Cc: Julien Grall <[email protected]>
+Cc: Bertrand Marquis <[email protected]>
+Cc: Volodymyr Babchuk <[email protected]>
+Date: Mon, 31 Jul 2023 17:01:32 -0700
+Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive
+
+Assembler from binutils 2.41 rejects this syntax
+
+.section "name"[, flags...]
+
+where flags could be #alloc, #write, #execstr
+Switch to using ELF syntax
+
+.section name[, "flags"[, @type]]
+
+[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
+
+Upstream-Status: Submitted [by email to [email protected] and maintainers]
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ xen/arch/arm/arm32/proc-v7.S | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
+index c90a31d80f..6d3d19b873 100644
+--- a/xen/arch/arm/arm32/proc-v7.S
++++ b/xen/arch/arm/arm32/proc-v7.S
+@@ -29,7 +29,7 @@ brahma15mp_init:
+         mcr   CP32(r0, ACTLR)
+         mov   pc, lr
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca15mp_proc_info, #object
+ __v7_ca15mp_proc_info:
+         .long 0x410FC0F0             /* Cortex-A15 */
+@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca7mp_proc_info, #object
+ __v7_ca7mp_proc_info:
+         .long 0x410FC070             /* Cortex-A7 */
+@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
+ 
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_brahma15mp_proc_info, #object
+ __v7_brahma15mp_proc_info:
+         .long 0x420F00F0             /* Broadcom Brahma-B15 */
+-- 
+2.41.0
+
recipes-extended/xen/xen_4.17.bb +4 -0
index 9da1b19..bd8f55b 100644
@@ -7,6 +7,7 @@ XEN_BRANCH ?= "stable-${XEN_REL}"
 SRC_URI = " \
     git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
     file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
+    file://0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch \
     "
 
 LIC_FILES_CHKSUM ?= "file://COPYING;md5=d1a1e216f80b6d8da95fec897d0dbec9"
@@ -17,3 +18,6 @@ S = "${WORKDIR}/git"
 
 require xen.inc
 require xen-hypervisor.inc
+
+TOOLCHAIN = "gcc"
+LDFLAGS:remove = "-fuse-ld=lld"
Signature · 11 lines
2.41.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8154): https://lists.yoctoproject.org/g/meta-virtualization/message/8154
Mute This Topic: https://lists.yoctoproject.org/mt/100474396/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
author
#2 lore raw
Quoted 2 lines · Bruce Ashfield

merged.

Thanks, I will send a followup to get the v2 of patch, since most likely that will get merged upstream.

Quoted 115 lines

Bruce

In message: [meta-virtualization][PATCH] xen: Fix build with gas/2.41

Quoted 108 lines · on 31/07/2023 Khem Raj wrote:
Cc Alexandre Belloni <[email protected]>
---
 ...g-solaris-syntax-for-.section-direct.patch | 62 +++++++++++++++++++
 recipes-extended/xen/xen_4.17.bb              |  4 ++
 2 files changed, 66 insertions(+)
 create mode 100644 recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch
recipes-extended/xen/files/0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch new file +62 -0
new file mode 100644
index 0000000..c73bb27
@@ -0,0 +1,62 @@
+From 9add6f9aced42a76f6a2c124754bef6fde56fa05 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+To: [email protected]
+Cc: Stefano Stabellini <[email protected]>
+Cc: Julien Grall <[email protected]>
+Cc: Bertrand Marquis <[email protected]>
+Cc: Volodymyr Babchuk <[email protected]>
+Date: Mon, 31 Jul 2023 17:01:32 -0700
+Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive
+
+Assembler from binutils 2.41 rejects this syntax
+
+.section "name"[, flags...]
+
+where flags could be #alloc, #write, #execstr
+Switch to using ELF syntax
+
+.section name[, "flags"[, @type]]
+
+[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
+
+Upstream-Status: Submitted [by email to [email protected] and maintainers]
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ xen/arch/arm/arm32/proc-v7.S | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
+index c90a31d80f..6d3d19b873 100644
+--- a/xen/arch/arm/arm32/proc-v7.S
++++ b/xen/arch/arm/arm32/proc-v7.S
+@@ -29,7 +29,7 @@ brahma15mp_init:
+         mcr   CP32(r0, ACTLR)
+         mov   pc, lr
+
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca15mp_proc_info, #object
+ __v7_ca15mp_proc_info:
+         .long 0x410FC0F0             /* Cortex-A15 */
+@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
+
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_ca7mp_proc_info, #object
+ __v7_ca7mp_proc_info:
+         .long 0x410FC070             /* Cortex-A7 */
+@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
+         .long caxx_processor
+         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
+
+-        .section ".proc.info", #alloc
++        .section .proc.info, "a"
+         .type __v7_brahma15mp_proc_info, #object
+ __v7_brahma15mp_proc_info:
+         .long 0x420F00F0             /* Broadcom Brahma-B15 */
+--
+2.41.0
+
recipes-extended/xen/xen_4.17.bb +4 -1
index 9da1b19..bd8f55b 100644
@@ -7,6 +7,7 @@ XEN_BRANCH ?= "stable-${XEN_REL}"
 SRC_URI = " \
     git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
     file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
+    file://0001-arm32-Avoid-using-solaris-syntax-for-.section-direct.patch \
     "
 
 LIC_FILES_CHKSUM ?= "file://COPYING;md5=d1a1e216f80b6d8da95fec897d0dbec9"
@@ -17,3 +18,6 @@ S = "${WORKDIR}/git"
 
 require xen.inc
 require xen-hypervisor.inc
+
+TOOLCHAIN = "gcc"
+LDFLAGS:remove = "-fuse-ld=lld"
--

2.41.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#8154): https://lists.yoctoproject.org/g/meta-virtualization/message/8154
Mute This Topic: https://lists.yoctoproject.org/mt/100474396/1050810
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-