usb: dwc3: gadget: Let pm runtime get/put paired
Subsystems (2)
PATCH v2 1/1 usb: dwc3: gadget: Let pm runtime get/put paired
Pm_runtime_get is called when setting pending_events to true. Pm_runtime_put is needed for pairing with pm_runtime_get.
---
V2: add Fixes tag, fix Fixes tag
--- drivers/usb/dwc3/gadget.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/dwc3/gadget.c +1 -0
@@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)dwc3_interrupt (dwc->irq_gadget, dwc->ev_buf); dwc->pending_events = false;enable_irq (dwc->irq_gadget); +pm_runtime_put (dwc->dev); } }
Signature · 1 line
2.17.1
Quoted 17 lines · Surong Pang
Pm_runtime_getis called when settingpending_eventsto true.Pm_runtime_putis needed for pairing withpm_runtime_get.Fixes fc8bb91bc83e ("usb: dwc3: implement runtime PM")Signed-off-by Surong Pang <[email protected]>---
V2: add Fixes tag, fix Fixes tag--- drivers/usb/dwc3/gadget.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/dwc3/gadget.c +0
-0
drivers/usb/dwc3/gadget.c void dwc3_gadget_process_pending_events(struct dwc3 *dwc) · line 4725
Quoted 6 lines
drivers/usb/dwc3/gadget.c +1
-0@@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)dwc3_interrupt (dwc->irq_gadget, dwc->ev_buf); dwc->pending_events = false;enable_irq (dwc->irq_gadget); +pm_runtime_put (dwc->dev); } }
I am already handling this change as part of below series. Will be uploading a separate patch based on the feedback from Roger.
https://lore.kernel.org/all/[email protected]/
Thanks
Elson
Greg KH
maintainerQuoted 30 lines · Elson Serrao
Quoted 17 lines · Surong Pang
Pm_runtime_getis called when settingpending_eventsto true.Pm_runtime_putis needed for pairing withpm_runtime_get.Fixes fc8bb91bc83e ("usb: dwc3: implement runtime PM")Signed-off-by Surong Pang <[email protected]>---
V2: add Fixes tag, fix Fixes tag--- drivers/usb/dwc3/gadget.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/dwc3/gadget.c +0
-0drivers/usb/dwc3/gadget.c void dwc3_gadget_process_pending_events(struct dwc3 *dwc) · line 4725
Quoted 6 lines
drivers/usb/dwc3/gadget.c +1
-0@@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)dwc3_interrupt (dwc->irq_gadget, dwc->ev_buf); dwc->pending_events = false;enable_irq (dwc->irq_gadget); +pm_runtime_put (dwc->dev); } }I am already handling this change as part of below series. Will be uploading a separate patch based on the feedback from Roger.
Quoted 1 line
But this should be fixed now, and properly backported to stable kernels. There's no need to wait for a different patch series if this one is correct, right?
thanks,
greg k-h
Quoted 31 lines · Greg KH
Quoted 30 lines · Elson Serrao
Quoted 17 lines · Surong Pang
Pm_runtime_getis called when settingpending_eventsto true.Pm_runtime_putis needed for pairing withpm_runtime_get.Fixes fc8bb91bc83e ("usb: dwc3: implement runtime PM")Signed-off-by Surong Pang <[email protected]>---
V2: add Fixes tag, fix Fixes tag--- drivers/usb/dwc3/gadget.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/dwc3/gadget.c +0
-0drivers/usb/dwc3/gadget.c void dwc3_gadget_process_pending_events(struct dwc3 *dwc) · line 4725
Quoted 6 lines
drivers/usb/dwc3/gadget.c +1
-0@@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)dwc3_interrupt (dwc->irq_gadget, dwc->ev_buf); dwc->pending_events = false;enable_irq (dwc->irq_gadget); +pm_runtime_put (dwc->dev); } }I am already handling this change as part of below series. Will be uploading a separate patch based on the feedback from Roger.
Quoted 6 lines
Quoted 1 line
But this should be fixed now, and properly backported to stable kernels. There's no need to wait for a different patch series if this one is correct, right?
Hi Greg
I have separated this change from the series and have uploaded below change as an independent fix. Based on the earlier feedback and discussion, few additional modifications are needed to properly handle pending events
https://lore.kernel.org/all/[email protected]/
Thanks
Elson