Skip to contentSkip to conversation

drm/amd/pm: Clean up errors in vega10_hwmgr.c

PATCH In review Ran Sun 2 participants 2 messages Aug 1, 2023 – Aug 7, 2023

Subsystems (3)
lore
Share & tools
lore

Ran Sun

author
#0 lore raw

PATCH 1/1 drm/amd/pm: Clean up errors in vega10_hwmgr.c

Fix the following errors reported by checkpatch:

ERROR: trailing statements should be on next line
ERROR: space required before the open brace '{'
ERROR: space required before the open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)

---
 .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c  | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +12 -6
index 08518bc1cbbe..ba7294daddfe 100644
@@ -670,17 +670,23 @@ static int vega10_patch_voltage_dependency_tables_with_lookup_table(
 	for (i = 0; i < 6; i++) {
 		struct phm_ppt_v1_clock_voltage_dependency_table *vdt;
 		switch (i) {
-		case 0: vdt = table_info->vdd_dep_on_socclk;
+		case 0:
+			vdt = table_info->vdd_dep_on_socclk;
 			break;
-		case 1: vdt = table_info->vdd_dep_on_sclk;
+		case 1:
+			vdt = table_info->vdd_dep_on_sclk;
 			break;
-		case 2: vdt = table_info->vdd_dep_on_dcefclk;
+		case 2:
+			vdt = table_info->vdd_dep_on_dcefclk;
 			break;
-		case 3: vdt = table_info->vdd_dep_on_pixclk;
+		case 3:
+			vdt = table_info->vdd_dep_on_pixclk;
 			break;
-		case 4: vdt = table_info->vdd_dep_on_dispclk;
+		case 4:
+			vdt = table_info->vdd_dep_on_dispclk;
 			break;
-		case 5: vdt = table_info->vdd_dep_on_phyclk;
+		case 5:
+			vdt = table_info->vdd_dep_on_phyclk;
 			break;
 		}
 
Signature · 1 line
2.17.1
#1 lore raw

This one doesn't apply due to whitespace differences.

Alex

Quoted 50 lines · Ran Sun

Fix the following errors reported by checkpatch:

ERROR: trailing statements should be on next line
ERROR: space required before the open brace '{'
ERROR: space required before the open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)

---
 .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c  | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +12 -7
index 08518bc1cbbe..ba7294daddfe 100644
@@ -670,17 +670,23 @@ static int vega10_patch_voltage_dependency_tables_with_lookup_table(
        for (i = 0; i < 6; i++) {
                struct phm_ppt_v1_clock_voltage_dependency_table *vdt;
                switch (i) {
-               case 0: vdt = table_info->vdd_dep_on_socclk;
+               case 0:
+                       vdt = table_info->vdd_dep_on_socclk;
                        break;
-               case 1: vdt = table_info->vdd_dep_on_sclk;
+               case 1:
+                       vdt = table_info->vdd_dep_on_sclk;
                        break;
-               case 2: vdt = table_info->vdd_dep_on_dcefclk;
+               case 2:
+                       vdt = table_info->vdd_dep_on_dcefclk;
                        break;
-               case 3: vdt = table_info->vdd_dep_on_pixclk;
+               case 3:
+                       vdt = table_info->vdd_dep_on_pixclk;
                        break;
-               case 4: vdt = table_info->vdd_dep_on_dispclk;
+               case 4:
+                       vdt = table_info->vdd_dep_on_dispclk;
                        break;
-               case 5: vdt = table_info->vdd_dep_on_phyclk;
+               case 5:
+                       vdt = table_info->vdd_dep_on_phyclk;
                        break;
                }
 
--

2.17.1