Skip to contentSkip to conversation

drm/panfrost: Sync IRQ by job's timeout handler

PATCH Superseded Dmitry Osipenko 2 participants 2 messages Aug 1, 2023

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/panfrost: Sync IRQ by job's timeout handler

Panfrost IRQ handler may stuck for a long time, for example this happens when there is a bad HDMI connection and HDMI handler takes a long time to finish processing, holding Panfrost. Make Panfrost's job timeout handler to sync IRQ before checking fence signal status in order to prevent spurious job timeouts due to a slow IRQ processing.

---

Changelog:

v3: - Added comment to the code as was suggested by Boris

- Added r-b/t-b from Steven and Angelo

v2: - Moved synchronize_irq() after first signal-check to avoid unnecessary
blocking on syncing.

- Added warn message about high interrupt latency.

 drivers/gpu/drm/panfrost/panfrost_job.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/gpu/drm/panfrost/panfrost_job.c +15 -0
index dbc597ab46fb..ea1149354f9d 100644
@@ -720,6 +720,21 @@ static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job
 	if (dma_fence_is_signaled(job->done_fence))
 		return DRM_GPU_SCHED_STAT_NOMINAL;
 
+	/*
+	 * Panfrost IRQ handler may take long time to process if there is
+	 * another IRQ handler hogging the processing. For example, HDMI
+	 * may stuck in IRQ handler for a significant time in a case of bad
+	 * cable connection. In order to catch such cases and not report
+	 * spurious Panfrost job timeouts, synchronize the IRQ handler and
+	 * re-check the fence status.
+	 */
+	synchronize_irq(pfdev->js->irq);
+
+	if (dma_fence_is_signaled(job->done_fence)) {
+		dev_warn(pfdev->dev, "unexpectedly high interrupt latency\n");
+		return DRM_GPU_SCHED_STAT_NOMINAL;
+	}
+
 	dev_err(pfdev->dev, "gpu sched timeout, js=%d, config=0x%x, status=0x%x, head=0x%x, tail=0x%x, sched_job=%p",
 		js,
 		job_read(pfdev, JS_CONFIG(js)),
Signature · 1 line
2.41.0
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 10 lines · On Tue, 1 Aug 2023 03:14:27 +0300 Dmitry Osipenko…

Panfrost IRQ handler may stuck for a long time, for example this happens when there is a bad HDMI connection and HDMI handler takes a long time to finish processing, holding Panfrost. Make Panfrost's job timeout handler to sync IRQ before checking fence signal status in order to prevent spurious job timeouts due to a slow IRQ processing.

Just a couple nits below.

Quoted 21 lines

---

Changelog:

v3: - Added comment to the code as was suggested by Boris

- Added r-b/t-b from Steven and Angelo

v2: - Moved synchronize_irq() after first signal-check to avoid unnecessary
blocking on syncing.

- Added warn message about high interrupt latency.

 drivers/gpu/drm/panfrost/panfrost_job.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
drivers/gpu/drm/panfrost/panfrost_job.c +0 -0
index dbc597ab46fb..ea1149354f9d 100644

drivers/gpu/drm/panfrost/panfrost_job.c static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job · line 724

Quoted 5 lines
drivers/gpu/drm/panfrost/panfrost_job.c +2 -0
@@ -720,6 +720,21 @@ static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job
 	if (dma_fence_is_signaled(job->done_fence))
 		return DRM_GPU_SCHED_STAT_NOMINAL;
 
+	/*
+	 * Panfrost IRQ handler may take long time to process if there is

^ may take a long time to process an
interrupt if there is ...

drivers/gpu/drm/panfrost/panfrost_job.c static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job · line 726

Quoted 2 lines
drivers/gpu/drm/panfrost/panfrost_job.c +2 -0
+	 * another IRQ handler hogging the processing. For example, HDMI
+	 * may stuck in IRQ handler for a significant time in a case of bad
	For example, the HDMI encoder driver might be stuck in the IRQ
	handler ...
Quoted 17 lines
drivers/gpu/drm/panfrost/panfrost_job.c +11 -0
+	 * cable connection. In order to catch such cases and not report
+	 * spurious Panfrost job timeouts, synchronize the IRQ handler and
+	 * re-check the fence status.
+	 */
 
 
 
+	synchronize_irq(pfdev->js->irq);
+
+	if (dma_fence_is_signaled(job->done_fence)) {
+		dev_warn(pfdev->dev, "unexpectedly high interrupt latency\n");
+		return DRM_GPU_SCHED_STAT_NOMINAL;
+	}
+
drivers/gpu/drm/panfrost/panfrost_job.c +0 -0
 	dev_err(pfdev->dev, "gpu sched timeout, js=%d, config=0x%x, status=0x%x, head=0x%x, tail=0x%x, sched_job=%p",
 		js,
 		job_read(pfdev, JS_CONFIG(js)),