clk: qcom: fix some Kconfig corner cases
Subsystems (3)
PATCH 1/1 clk: qcom: fix some Kconfig corner cases
From: Arnd Bergmann <[email protected]>
The SM_GCC_8550 symbol and others can only be built for ARM64 or when compile testing, but it gets selected by other drivers that can also be built for 32-bit ARCH_QCOM when not compile testing, which results in a Kconfig warning:
WARNING: unmet direct dependencies detected for SM_GCC_8550
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n]) Selected by [m]:
- SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
- SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
Add further 'depends on' statements to tighten this in a way that avoids the missing dependencies.
--- drivers/clk/qcom/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)
drivers/clk/qcom/Kconfig +4 -0
@@ -995,6 +995,7 @@ config SM_GPUCC_8450 config SM_GPUCC_8550 tristate "SM8550 Graphics Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8550 help Support for the graphics clock controller on SM8550 devices.
@@ -1031,6 +1032,7 @@ config SM_VIDEOCC_8250 config SM_VIDEOCC_8350 tristate "SM8350 Video Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8350 select QCOM_GDSC help
@@ -1040,6 +1042,7 @@ config SM_VIDEOCC_8350 config SM_VIDEOCC_8550 tristate "SM8550 Video Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8550 select QCOM_GDSC help
@@ -1088,6 +1091,7 @@ config CLK_GFM_LPASS_SM8250 config SM_VIDEOCC_8450 tristate "SM8450 Video Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8450 select QCOM_GDSC help
Signature · 1 line
2.39.2
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The
SM_GCC_8550symbol and others can only be built for ARM64 or when compile testing, but it gets selected by other drivers that can also be built for 32-bitARCH_QCOMwhen not compile testing, which results in aKconfigwarning:WARNING: unmet direct dependencies detected for
SM_GCC_8550
Depends on [n]:COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m] && (ARM64 ||COMPILE_TEST[=n]) Selected by [m]:
-SM_GPUCC_8550[=m] &&COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m]
-SM_VIDEOCC_8550[=m] &&COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m]
Quoted 8 lines
Add further 'depends on' statements to tighten this in a way that avoids the missing dependencies.
Fixes fd0b5b106fcab ("clk: qcom: Introduce SM8350 VIDEOCC")Fixes 441fe711be384 ("clk: qcom: videocc-sm8450: Add video clock controller driver for SM8450")Fixes f53153a37969c ("clk: qcom: videocc-sm8550: Add video clock controller driver for SM8550")Signed-off-by Arnd Bergmann <[email protected]>---
Konrad
Quoted 5 lines · Arnd Bergmann
The
SM_GCC_8550symbol and others can only be built for ARM64 or when compile testing, but it gets selected by other drivers that can also be built for 32-bitARCH_QCOMwhen not compile testing, which results in aKconfigwarning:
Quoted 7 lines
WARNING: unmet direct dependencies detected for
SM_GCC_8550
Depends on [n]:COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m] && (ARM64 ||COMPILE_TEST[=n]) Selected by [m]:
-SM_GPUCC_8550[=m] &&COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m]
-SM_VIDEOCC_8550[=m] &&COMMON_CLK[=y] &&COMMON_CLK_QCOM[=m][...]
Applied, thanks!
[1/1] clk: qcom: fix some Kconfig corner cases
commit: b6bcd1c0c27e1f210228346e6d23a2ec0c263e8c
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>