crypto: af_alg - Decrement struct key.usage in alg_set_by_key_serial()
Subsystems (2)
PATCH 1/1 crypto: af_alg - Decrement struct key.usage in alg_set_by_key_serial()
Calls to lookup_user_key() require a corresponding key_put() to decrement the usage counter. Once it reaches zero, we schedule key GC. Therefore decrement struct key.usage in alg_set_by_key_serial().
Fixes 7984ceb134bf ("crypto: af_alg - Support symmetric encryption via keyring keys")
Cc <[email protected]>
Signed-off-by Frederick Lawler <[email protected]>
---
This is rebased ontop of Linus's 6.5-rc1. Original patch was introduced in 6.2.
--- crypto/af_alg.c | 3 +++ 1 file changed, 3 insertions(+)
crypto/af_alg.c +3 -0
@@ -320,18 +320,21 @@ static int alg_setkey_by_key_serial(struct alg_sock *ask, sockptr_t optval,if (IS_ERR (ret)) {up_read (&key->sem); +key_put (key);return PTR_ERR (ret); } key_data =sock_kmalloc (&ask->sk, key_datalen,GFP_KERNEL );if (!key_data) {up_read (&key->sem); +key_put (key);return -ENOMEM ; }memcpy (key_data, ret, key_datalen);up_read (&key->sem); +key_put (key); err = type->setkey (ask->private, key_data, key_datalen);
Signature · 1 line
2.34.1
Herbert Xu
maintainerQuoted 4 lines · Frederick Lawler
Calls to
lookup_user_key()require a correspondingkey_put()to decrement the usage counter. Once it reaches zero, we schedule key GC. Therefore decrement struct key.usage inalg_set_by_key_serial().
Quoted 8 lines
Fixes 7984ceb134bf ("crypto: af_alg - Support symmetric encryption via keyring keys")Cc <[email protected]>Signed-off-by Frederick Lawler <[email protected]>---
This is rebased ontop of Linus's 6.5-rc1. Original patch was introduced in 6.2.--- crypto/af_alg.c | 3 +++ 1 file changed, 3 insertions(+)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt