Skip to contentSkip to conversation

libtracefs: fix cscope makefile rule

PATCH New Ross Zwisler 1 participant 1 message Aug 1, 2023 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtracefs: fix cscope makefile rule

From: Ross Zwisler <[email protected]>

The current 'make cscope' rule does not actually pass the filenames gathered by 'find' to cscope. cscope expects them either to be passed on the command line, as this patch does with xargs, or via a
'cscope.files' intermediate file. It doesn't read them from stdin.

As long as the file count is low, as it is in this library, the command line version works fine. Larger projects like the kernel need to use the intermediate file.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 9f377e9..80076aa 100644
@@ -256,7 +256,7 @@ $(EMACS_TAGS): force
 
 $(CSCOPE_TAGS): force
 	$(RM) $(obj)/cscope*
-	$(call find_tag_files) | cscope -b -q
+	$(call find_tag_files) | xargs cscope -b -q
 
 tags: $(VIM_TAGS)
 TAGS: $(EMACS_TAGS)
Signature · 1 line
2.41.0.585.gd2178a4bd4-goog