Skip to contentSkip to conversation

gpio: tqmx86: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 1, 2023 – Aug 3, 2023

Subsystems (2)
GPIO TQ systems board & driver support
lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH 1/1 gpio: tqmx86: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-tqmx86.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-tqmx86.c +0 -2
index 6f8bd1155db7..3a28c1f273c3 100644
@@ -277,8 +277,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
 
 	tqmx86_gpio_write(gpio, (u8)~TQMX86_DIR_INPUT_MASK, TQMX86_GPIODD);
 
-	platform_set_drvdata(pdev, gpio);
-
 	chip = &gpio->chip;
 	chip->label = "gpio-tqmx86";
 	chip->owner = THIS_MODULE;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 26 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Reviewed-by Alexandru Ardelean <[email protected]>
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/gpio/gpio-tqmx86.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpio/gpio-tqmx86.c +0 -3
index 6f8bd1155db7..3a28c1f273c3 100644
@@ -277,8 +277,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
 
        tqmx86_gpio_write(gpio, (u8)~TQMX86_DIR_INPUT_MASK, TQMX86_GPIODD);
 
-       platform_set_drvdata(pdev, gpio);
-
        chip = &gpio->chip;
        chip->label = "gpio-tqmx86";
        chip->owner = THIS_MODULE;
--
Quoted 2 lines

2.34.1

Applied, thanks!

Bart