Skip to contentSkip to conversation

dt-bindings: arm: bcm: add bindings for ASUS RT-AC3100

PATCH Applied Arınç ÜNAL 4 participants 7 messages Aug 3, 2023 – Aug 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: arm: bcm: add bindings for ASUS RT-AC3100

Add ASUS RT-AC3100 under BCM47094 based boards.

---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml +1 -0
index 5c3ac97e8728..4cc4e6754681 100644
@@ -66,6 +66,7 @@ properties:
       - description: BCM47094 based boards
         items:
           - enum:
+              - asus,rt-ac3100
               - asus,rt-ac88u
               - dlink,dir-885l
               - dlink,dir-890l
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 ARM: dts: BCM5301X: Add DT for ASUS RT-AC3100

ASUS RT-AC3100 is ASUS RT-AC88U without the external switch. Move the shared bindings to bcm47094-asus-rt-ac3100.dtsi.

Remove the fixed-link node on port@7 as commit ba4aebce23b2 ("ARM: dts:
BCM5301X: Describe switch ports in the main DTS") states it's not necessary.

Replace the copyright notice with an author notice.

Rename the model name from Asus to ASUS on bcm47094-asus-rt-ac88u.dts.

---
 arch/arm/boot/dts/broadcom/Makefile           |   1 +
 .../dts/broadcom/bcm47094-asus-rt-ac3100.dts  |  23 +++
 .../dts/broadcom/bcm47094-asus-rt-ac3100.dtsi | 163 ++++++++++++++++++
 .../dts/broadcom/bcm47094-asus-rt-ac88u.dts   | 155 +----------------
 4 files changed, 190 insertions(+), 152 deletions(-)
 create mode 100644 arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts
 create mode 100644 arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dtsi
arch/arm/boot/dts/broadcom/Makefile +1 -0
index 95b0ef2a4215..7099d9560033 100644
@@ -70,6 +70,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm4709-netgear-r7000.dtb \
 	bcm4709-netgear-r8000.dtb \
 	bcm4709-tplink-archer-c9-v1.dtb \
+	bcm47094-asus-rt-ac3100.dtb \
 	bcm47094-asus-rt-ac88u.dtb \
 	bcm47094-dlink-dir-885l.dtb \
 	bcm47094-dlink-dir-890l.dtb \
arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dts new file +23 -0
new file mode 100644
index 000000000000..5f089307cd8c
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Author: Arınç ÜNAL <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "bcm47094-asus-rt-ac3100.dtsi"
+
+/ {
+	compatible = "asus,rt-ac3100", "brcm,bcm47094", "brcm,bcm4708";
+	model = "ASUS RT-AC3100";
+
+	nvram@1c080000 {
+		et0macaddr: et0macaddr {
+		};
+	};
+};
+
+&gmac0 {
+	nvmem-cells = <&et0macaddr>;
+	nvmem-cell-names = "mac-address";
+};
arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac3100.dtsi new file +163 -0

163 lines not on this page · raw message

arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac88u.dts +3 -152

191 lines not on this page · raw message

Signature · 1 line
2.39.2
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3100

Quoted 7 lines · Arınç ÜNAL

ASUS RT-AC3100 is ASUS RT-AC88U without the external switch. Move the shared bindings to bcm47094-asus-rt-ac3100.dtsi.

Remove the fixed-link node on port@7 as commit ba4aebce23b2 ("ARM: dts:
BCM5301X: Describe switch ports in the main DTS") states it's not necessary.

Quoted 5 lines

Replace the copyright notice with an author notice.

Rename the model name from Asus to ASUS on bcm47094-asus-rt-ac88u.dts.

LGTM!

Yours,
Linus Walleij

maintainer Applied
#3 lore raw

Re: [PATCH 2/2] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3100

In reply to Arınç ÜNAL

From: Florian Fainelli <[email protected]>

Quoted 7 lines · Arınç ÜNAL

ASUS RT-AC3100 is ASUS RT-AC88U without the external switch. Move the shared bindings to bcm47094-asus-rt-ac3100.dtsi.

Remove the fixed-link node on port@7 as commit ba4aebce23b2 ("ARM: dts:
BCM5301X: Describe switch ports in the main DTS") states it's not necessary.

Quoted 6 lines

Replace the copyright notice with an author notice.

Rename the model name from Asus to ASUS on bcm47094-asus-rt-ac88u.dts.

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian

Acked-by on v1 1/2
#5 lore raw
In reply to Arınç ÜNAL
Quoted 3 lines · Arınç ÜNAL

Add ASUS RT-AC3100 under BCM47094 based boards.

Thanks,
Conor.

Quoted 19 lines
---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml +1 -0
index 5c3ac97e8728..4cc4e6754681 100644
@@ -66,6 +66,7 @@ properties:
       - description: BCM47094 based boards
         items:
           - enum:
+              - asus,rt-ac3100
               - asus,rt-ac88u
               - dlink,dir-885l
               - dlink,dir-890l
Signature · 1 line
2.39.2