lib: test_scanf: Add explicit type cast to result initialization in test_number_prefix()
PATCH 1/1 lib: test_scanf: Add explicit type cast to result initialization in test_number_prefix()
A recent change in clang allows it to consider more expressions as compile time constants, which causes it to point out an implicit conversion in the scanf tests:
lib/test_scanf.c:661:2: warning: implicit conversion from 'int' to 'unsigned char' changes value from -168 to 88 [-Wconstant-conversion]
661 | test_number_prefix(unsigned char, "0xA7", "%2hhx%hhx", 0, 0xa7, 2, check_uchar);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/test_scanf.c:609:29: note: expanded from macro 'test_number_prefix'
609 | T result[2] = {~expect[0], ~expect[1]}; \
| ~ ^~~~~~~~~~
1 warning generated.The result of the bitwise negation is the type of the operand after going through the integer promotion rules, so this truncation is expected but harmless, as the initial values in the result array get overwritten by _test() anyways. Add an explicit cast to the expected type in test_number_prefix() to silence the warning. There is no functional change, as all the tests still pass with GCC 13.1.0 and clang 18.0.0.
--- lib/test_scanf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/test_scanf.c +1 -1
@@ -606,7 +606,7 @@ static void __init numbers_slice(void)#define test_number_prefix (T , str, scan_fmt, expect0, expect1, n_args, fn) \ do { \ const T expect[2] = { expect0, expect1 }; \ - T result[2] = {~expect[0], ~expect[1]}; \ + T result[2] = {(T)~expect[0], (T)~expect[1]}; \ \ _test(fn, &expect, str, scan_fmt, n_args, &result[0], &result[1]); \ } while (0)
---
base-commit: 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
change-id: 20230803-test_scanf-wconstant-conversion-d97efbf3bb5d
Best regards,
Signature · 1 line
Nathan Chancellor <[email protected]>
Quoted 21 lines · Nathan Chancellor
A recent change in clang allows it to consider more expressions as compile time constants, which causes it to point out an implicit conversion in the scanf tests:
lib/test_scanf.c:661:2: warning: implicit conversion from 'int' to 'unsigned char' changes value from -168 to 88 [-Wconstant-conversion] 661 | test_number_prefix(unsigned char, "0xA7", "%2hhx%hhx", 0, 0xa7, 2, check_uchar); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/test_scanf.c:609:29: note: expanded from macro 'test_number_prefix' 609 | T result[2] = {~expect[0], ~expect[1]}; \ | ~ ^~~~~~~~~~ 1 warning generated.The result of the bitwise negation is the type of the operand after going through the integer promotion rules, so this truncation is expected but harmless, as the initial values in the result array get overwritten by
_test()anyways. Add an explicit cast to the expected type intest_number_prefix()to silence the warning. There is no functional change, as all the tests still pass with GCC 13.1.0 and clang 18.0.0.do { \
lib/test_scanf.c static void __init numbers_slice(void) · line 609
Quoted 3 lines
lib/test_scanf.c +1
-1const T expect[2 ] = { expect0, expect1 }; \ -T result[2 ] = {~expect[0 ], ~expect[1 ]}; \ +T result[2 ] = {(T )~expect[0 ], (T )~expect[1 ]}; \
Can we add spaces as above, while at it?
T result[2] = { (T)~expect[0], (T)~expect[1] }; \Quoted 2 lines
_test(fn, &expect, str, scan_fmt, n_args, &result[0], &result[1]); \
} while (0)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 21 lines · Andy Shevchenko
Quoted 19 lines · Nathan Chancellor
A recent change in clang allows it to consider more expressions as compile time constants, which causes it to point out an implicit conversion in the scanf tests:
lib/test_scanf.c:661:2: warning: implicit conversion from 'int' to 'unsigned char' changes value from -168 to 88 [-Wconstant-conversion] 661 | test_number_prefix(unsigned char, "0xA7", "%2hhx%hhx", 0, 0xa7, 2, check_uchar); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/test_scanf.c:609:29: note: expanded from macro 'test_number_prefix' 609 | T result[2] = {~expect[0], ~expect[1]}; \ | ~ ^~~~~~~~~~ 1 warning generated.The result of the bitwise negation is the type of the operand after going through the integer promotion rules, so this truncation is expected but harmless, as the initial values in the result array get overwritten by
_test()anyways. Add an explicit cast to the expected type intest_number_prefix()to silence the warning. There is no functional change, as all the tests still pass with GCC 13.1.0 and clang 18.0.0.
Quoted 8 lines
lib/test_scanf.c static void __init numbers_slice(void) · line 609
Quoted 4 lines
do { \
lib/test_scanf.c +1
-1const T expect[2 ] = { expect0, expect1 }; \ -T result[2 ] = {~expect[0 ], ~expect[1 ]}; \ +T result[2 ] = {(T )~expect[0 ], (T )~expect[1 ]}; \Can we add spaces as above, while at it?
T result[2] = { (T)~expect[0], (T)~expect[1] }; \
Sure. I can send a v2 on Monday to give folks a chance to chime in with other comments.
Quoted 8 lines
Quoted 2 lines
_test(fn, &expect, str, scan_fmt, n_args, &result[0], &result[1]); \
} while (0)Signature · 2 lines
With Best Regards, Andy Shevchenko