nvmem: core: Rework layouts to become platform devices
kernel test robot
build botBCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: Miquel Raynal <[email protected]>
TO: Srinivas Kandagatla <[email protected]>
CC: "Greg Kroah-Hartman" <[email protected]>
CC: Thomas Petazzoni <[email protected]>
CC: Robert Marko <[email protected]>
CC: Luka Perkov <[email protected]>
CC: Michael Walle <[email protected]>
CC: [email protected]
CC: Randy Dunlap <[email protected]>
CC: "Chen-Yu Tsai" <[email protected]>
CC: Daniel Golle <[email protected]>
CC: "Rafał Miłecki" <[email protected]>
CC: Miquel Raynal <[email protected]>
Hi Miquel,
kernel test robot noticed the following build warnings:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.5-rc4 next-20230802] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Miquel-Raynal/nvmem-core-Create-all-cells-before-adding-the-nvmem-device/20230802-022331 base: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20230801182132.1058707-6-miquel.raynal%40bootlin.com patch subject: [PATCH v7 5/7] nvmem: core: Rework layouts to become platform devices
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
config: x86_64-randconfig-m001-20230730 (https://download.01.org/0day-ci/archive/20230803/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230803/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
New smatch warnings:drivers/nvmem/core.c:1003 nvmem_register() warn: 'layout_np' is an error pointer or valid drivers/nvmem/core.c:2130 nvmem_try_loading_layout_driver() warn: 'layout_np' is an error pointer or valid
Old smatch warnings:drivers/nvmem/core.c:761 nvmem_add_cells_from_fixed_layout() warn: 'layout_np' is an error pointer or valid drivers/nvmem/core.c:802 nvmem_layout_get() warn: 'layout_np' is an error pointer or valid
vim +/layout_np +1003 drivers/nvmem/core.c
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 964
bd1244561fa2a4 Gaosheng Cui 2022-09-16 965 if (nvmem->nkeepout) {
bd1244561fa2a4 Gaosheng Cui 2022-09-16 966 rval = nvmem_validate_keepouts(nvmem);
bd1244561fa2a4 Gaosheng Cui 2022-09-16 967 if (rval)
ab3428cfd9aa2f Russell King (Oracle 2023-01-27 968) goto err_put_device;
bd1244561fa2a4 Gaosheng Cui 2022-09-16 969 }
bd1244561fa2a4 Gaosheng Cui 2022-09-16 970
b6c217ab9be689 Andrew Lunn 2016-02-26 971 if (config->compat) {
ae0c2d725512f3 Srinivas Kandagatla 2019-04-16 972 rval = nvmem_sysfs_setup_compat(nvmem, config);
b6c217ab9be689 Andrew Lunn 2016-02-26 973 if (rval)
ab3428cfd9aa2f Russell King (Oracle 2023-01-27 974) goto err_put_device;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 975 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 976
fa72d847d68d78 Bartosz Golaszewski 2018-09-21 977 if (config->cells) {
fa72d847d68d78 Bartosz Golaszewski 2018-09-21 978 rval = nvmem_add_cells(nvmem, config->cells, config->ncells);
fa72d847d68d78 Bartosz Golaszewski 2018-09-21 979 if (rval)
db3546d58b5a0f Michael Walle 2023-01-27 980 goto err_remove_cells;
fa72d847d68d78 Bartosz Golaszewski 2018-09-21 981 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 982
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 983 rval = nvmem_add_cells_from_table(nvmem);
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 984 if (rval)
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 985 goto err_remove_cells;
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 986
27f699e578b1a7 Rafał Miłecki 2023-06-11 987 rval = nvmem_add_cells_from_legacy_of(nvmem);
e888d445ac33a5 Bartosz Golaszewski 2018-09-21 988 if (rval)
e888d445ac33a5 Bartosz Golaszewski 2018-09-21 989 goto err_remove_cells;
e888d445ac33a5 Bartosz Golaszewski 2018-09-21 990
571c19069d5f4b Miquel Raynal 2023-08-01 991 rval = nvmem_add_cells_from_fixed_layout(nvmem);
ab3428cfd9aa2f Russell King (Oracle 2023-01-27 992) if (rval)
ab3428cfd9aa2f Russell King (Oracle 2023-01-27 993) goto err_remove_cells;
ab3428cfd9aa2f Russell King (Oracle 2023-01-27 994)
571c19069d5f4b Miquel Raynal 2023-08-01 995 dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", config->name);
571c19069d5f4b Miquel Raynal 2023-08-01 996
571c19069d5f4b Miquel Raynal 2023-08-01 997 rval = device_add(&nvmem->dev);
266570f496b90d Michael Walle 2023-04-04 998 if (rval)
266570f496b90d Michael Walle 2023-04-04 999 goto err_remove_cells;
266570f496b90d Michael Walle 2023-04-04 1000
00d059fd6702f0 Miquel Raynal 2023-08-01 1001 /* Populate layouts as devices */
00d059fd6702f0 Miquel Raynal 2023-08-01 1002 layout_np = of_nvmem_layout_get_container(nvmem);
00d059fd6702f0 Miquel Raynal 2023-08-01 @1003 if (layout_np) {
00d059fd6702f0 Miquel Raynal 2023-08-01 1004 rval = of_platform_populate(nvmem->dev.of_node, NULL, NULL, NULL);
00d059fd6702f0 Miquel Raynal 2023-08-01 1005 if (rval)
00d059fd6702f0 Miquel Raynal 2023-08-01 1006 goto err_remove_cells;
00d059fd6702f0 Miquel Raynal 2023-08-01 1007 of_node_put(layout_np);
00d059fd6702f0 Miquel Raynal 2023-08-01 1008 }
00d059fd6702f0 Miquel Raynal 2023-08-01 1009
25c9b5d3aa24a0 Miquel Raynal 2023-08-01 1010 mutex_lock(&nvmem_devices_mutex);
25c9b5d3aa24a0 Miquel Raynal 2023-08-01 1011 list_add_tail(&nvmem->node, &nvmem_devices_list);
25c9b5d3aa24a0 Miquel Raynal 2023-08-01 1012 mutex_unlock(&nvmem_devices_mutex);
25c9b5d3aa24a0 Miquel Raynal 2023-08-01 1013
f4853e1c321edb Bartosz Golaszewski 2019-02-15 1014 blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
bee1138bea15a6 Bartosz Golaszewski 2018-09-21 1015
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 1016 return nvmem;
3360acdf839170 Johan Hovold 2017-06-09 1017
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 1018 err_remove_cells:
b985f4cba6dbb3 Bartosz Golaszewski 2018-09-21 1019 nvmem_device_remove_all_cells(nvmem);
fa72d847d68d78 Bartosz Golaszewski 2018-09-21 1020 if (config->compat)
ae0c2d725512f3 Srinivas Kandagatla 2019-04-16 1021 nvmem_sysfs_remove_compat(nvmem, config);
3360acdf839170 Johan Hovold 2017-06-09 1022 err_put_device:
3360acdf839170 Johan Hovold 2017-06-09 1023 put_device(&nvmem->dev);
3360acdf839170 Johan Hovold 2017-06-09 1024
b6c217ab9be689 Andrew Lunn 2016-02-26 1025 return ERR_PTR(rval);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 1026 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 1027 EXPORT_SYMBOL_GPL(nvmem_register);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 1028 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki