net: vlan: update wrong comments
Subsystems (2)
PATCH 1/1 net: vlan: update wrong comments
vlan_insert_tag() and friends do not allocate a new skb. However they might allocate a new skb->head. Update their comments to better describe their behavior.
Signed-off-by Eric Dumazet <[email protected]>
--- include/linux/if_vlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
include/linux/if_vlan.h +3 -3
@@ -408,7 +408,7 @@ static inline int __vlan_insert_tag(struct sk_buff *skb,* @mac_len: MAC header length including outer vlan headers * * Inserts the VLAN tag into @skb as part of the payload at offset mac_len -* Returns a VLAN tagged skb. If a new skb is created, @skb is freed. +* Returns a VLAN tagged skb. This might change skb->head. * * Following the skb_unshare() example, in case of error, the calling function * doesn't have to worry about freeing the original skb.
@@ -437,7 +437,7 @@ static inline struct sk_buff *vlan_insert_inner_tag(struct sk_buff *skb,* @vlan_tci: VLAN TCI to insert * * Inserts the VLAN tag into @skb as part of the payload -* Returns a VLAN tagged skb. If a new skb is created, @skb is freed. +* Returns a VLAN tagged skb. This might change skb->head. * * Following the skb_unshare() example, in case of error, the calling function * doesn't have to worry about freeing the original skb.
@@ -457,7 +457,7 @@ static inline struct sk_buff *vlan_insert_tag(struct sk_buff *skb,* @vlan_tci: VLAN TCI to insert * * Inserts the VLAN tag into @skb as part of the payload -* Returns a VLAN tagged skb. If a new skb is created, @skb is freed. +* Returns a VLAN tagged skb. This might change skb->head. * * Following the skb_unshare() example, in case of error, the calling function * doesn't have to worry about freeing the original skb.
Signature · 1 line
2.41.0.640.ga95def55d0-goog
Quoted 5 lines · Eric Dumazet
vlan_insert_tag()and friends do not allocate a new skb. However they might allocate a newskb->head. Update their comments to better describe their behavior.Signed-off-by Eric Dumazet <[email protected]>
Reviewed-by Simon Horman <[email protected]>
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 8 lines · On Thu, 3 Aug 2023 07:14:26 +0000 you wrote:
vlan_insert_tag()and friends do not allocate a new skb. However they might allocate a newskb->head. Update their comments to better describe their behavior.Signed-off-by Eric Dumazet <[email protected]>--- include/linux/if_vlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] net: vlan: update wrong comments
https://git.kernel.org/netdev/net-next/c/7740bb882fde
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html