Skip to contentSkip to conversation

rcu: include torture_sched_setaffinity() declaration

PATCH Applied Arnd Bergmann 3 participants 3 messages Aug 3, 2023 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: include torture_sched_setaffinity() declaration

From: Arnd Bergmann <[email protected]>

The prototype for torture_sched_setaffinity() moved to a different header, which needs to be included from update.c to avoid this W=1 warning:

kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)

Fixes 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
---
 kernel/rcu/update.c | 1 +
 1 file changed, 1 insertion(+)
kernel/rcu/update.c +1 -0
index 0533b510f0a8..c534d6806d3d 100644
@@ -25,6 +25,7 @@
 #include <linux/interrupt.h>
 #include <linux/sched/signal.h>
 #include <linux/sched/debug.h>
+#include <linux/torture.h>
 #include <linux/atomic.h>
 #include <linux/bitops.h>
 #include <linux/percpu.h>
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The prototype for torture_sched_setaffinity() moved to a different header, which needs to be included from update.c to avoid this W=1 warning:

Quoted 5 lines

kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)

Fixes 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")

thanks,

- Joel

Quoted 19 lines
---
 kernel/rcu/update.c | 1 +
 1 file changed, 1 insertion(+)
kernel/rcu/update.c +1 -1
index 0533b510f0a8..c534d6806d3d 100644
@@ -25,6 +25,7 @@
 #include <linux/interrupt.h>
 #include <linux/sched/signal.h>
 #include <linux/sched/debug.h>
+#include <linux/torture.h>
 #include <linux/atomic.h>
 #include <linux/bitops.h>
 #include <linux/percpu.h>
--

2.39.2

maintainer Applied
#2 lore raw
Quoted 8 lines · Joel Fernandes
Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The prototype for torture_sched_setaffinity() moved to a different header, which needs to be included from update.c to avoid this W=1 warning:

Quoted 7 lines
Quoted 5 lines

kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)

Fixes 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")

Queued (likely for the v6.7 merge window), thank you both!

Thanx, Paul

Quoted 24 lines

thanks,

- Joel

Quoted 19 lines
---
 kernel/rcu/update.c | 1 +
 1 file changed, 1 insertion(+)
kernel/rcu/update.c +1 -1
index 0533b510f0a8..c534d6806d3d 100644
@@ -25,6 +25,7 @@
 #include <linux/interrupt.h>
 #include <linux/sched/signal.h>
 #include <linux/sched/debug.h>
+#include <linux/torture.h>
 #include <linux/atomic.h>
 #include <linux/bitops.h>
 #include <linux/percpu.h>
--

2.39.2