Skip to contentSkip to conversation

hwmon: (pmbus/bel-pfe) Enable PMBUS_SKIP_STATUS_CHECK for pfe1100

PATCH Superseded [email protected] 2 participants 3 messages Aug 3, 2023 – Aug 4, 2023 Hardware monitoring

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (pmbus/bel-pfe) Enable PMBUS_SKIP_STATUS_CHECK for pfe1100

From: Tao Ren <[email protected]>

Enable PMBUS_SKIP_STATUS_CHECK flag for both pfe1100 and pfe3000 because the similar communication error is observed on pfe1100 devices.

---
 drivers/hwmon/pmbus/bel-pfe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/pmbus/bel-pfe.c +3 -3
index fa5070ae26bc..8280d274da3f 100644
@@ -17,12 +17,12 @@
 enum chips {pfe1100, pfe3000};
 
 /*
- * Disable status check for pfe3000 devices, because some devices report
+ * Disable status check for pfexxxx devices, because some devices report
  * communication error (invalid command) for VOUT_MODE command (0x20)
  * although correct VOUT_MODE (0x16) is returned: it leads to incorrect
  * exponent in linear mode.
  */
-static struct pmbus_platform_data pfe3000_plat_data = {
+static struct pmbus_platform_data pfe_plat_data = {
 	.flags = PMBUS_SKIP_STATUS_CHECK,
 };
 
@@ -94,6 +94,7 @@ static int pfe_pmbus_probe(struct i2c_client *client)
 	int model;
 
 	model = (int)i2c_match_id(pfe_device_id, client)->driver_data;
+	client->dev.platform_data = &pfe_plat_data;
 
 	/*
 	 * PFE3000-12-069RA devices may not stay in page 0 during device
@@ -101,7 +102,6 @@ static int pfe_pmbus_probe(struct i2c_client *client)
 	 * So let's set the device to page 0 at the beginning.
 	 */
 	if (model == pfe3000) {
-		client->dev.platform_data = &pfe3000_plat_data;
 		i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);
 	}
 
Signature · 1 line
2.40.1
maintainer
#1 lore raw
Quoted 15 lines · On 8/3/23 16:55, [email protected] wrote:

From: Tao Ren <[email protected]>

Enable PMBUS_SKIP_STATUS_CHECK flag for both pfe1100 and pfe3000 because the similar communication error is observed on pfe1100 devices.

---
  drivers/hwmon/pmbus/bel-pfe.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/pmbus/bel-pfe.c +0 -0
index fa5070ae26bc..8280d274da3f 100644

drivers/hwmon/pmbus/bel-pfe.c line 24

Quoted 9 lines
drivers/hwmon/pmbus/bel-pfe.c +1 -1
@@ -17,12 +17,12 @@
  enum chips {pfe1100, pfe3000};
 
  /*
- * Disable status check for pfe3000 devices, because some devices report
+ * Disable status check for pfexxxx devices, because some devices report
   * communication error (invalid command) for VOUT_MODE command (0x20)
   * although correct VOUT_MODE (0x16) is returned: it leads to incorrect
   * exponent in linear mode.
   */

Rephrase to something like

Disable status check because some devices ... linear mode. This affects both pfe3000 and pfe1100.

We don't know if other pfe devices will be supported by the driver in the future, and we don't know if those will be affected, so we should not make any claims about such devices.

Quoted 14 lines
drivers/hwmon/pmbus/bel-pfe.c +2 -1
-static struct pmbus_platform_data pfe3000_plat_data = {
+static struct pmbus_platform_data pfe_plat_data = {
  	.flags = PMBUS_SKIP_STATUS_CHECK,
  };
 
@@ -94,6 +94,7 @@ static int pfe_pmbus_probe(struct i2c_client *client)
  	int model;
 
  	model = (int)i2c_match_id(pfe_device_id, client)->driver_data;
+	client->dev.platform_data = &pfe_plat_data;
 
  	/*
  	 * PFE3000-12-069RA devices may not stay in page 0 during device

drivers/hwmon/pmbus/bel-pfe.c static int pfe_pmbus_probe(struct i2c_client *client) · line 107

Quoted 7 lines
drivers/hwmon/pmbus/bel-pfe.c +0 -1
@@ -101,7 +102,6 @@ static int pfe_pmbus_probe(struct i2c_client *client)
  	 * So let's set the device to page 0 at the beginning.
  	 */
  	if (model == pfe3000) {
-		client->dev.platform_data = &pfe3000_plat_data;
  		i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);
  	}
 

{ } is no longer needed.

Thanks,
Guenter

author
#2 lore raw

Hi Guenter,

Thank you for the quick review, and I've addressed your comments in v2.

Cheers,
Tao

Quoted 57 lines · Guenter Roeck
Quoted 15 lines · On 8/3/23 16:55, [email protected] wrote:

From: Tao Ren <[email protected]>

Enable PMBUS_SKIP_STATUS_CHECK flag for both pfe1100 and pfe3000 because the similar communication error is observed on pfe1100 devices.

---
  drivers/hwmon/pmbus/bel-pfe.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hwmon/pmbus/bel-pfe.c +0 -0
index fa5070ae26bc..8280d274da3f 100644

drivers/hwmon/pmbus/bel-pfe.c line 23

Quoted 8 lines
drivers/hwmon/pmbus/bel-pfe.c +1 -1
@@ -17,12 +17,12 @@
  enum chips {pfe1100, pfe3000};
  /*
- * Disable status check for pfe3000 devices, because some devices report
+ * Disable status check for pfexxxx devices, because some devices report
   * communication error (invalid command) for VOUT_MODE command (0x20)
   * although correct VOUT_MODE (0x16) is returned: it leads to incorrect
   * exponent in linear mode.
   */

Rephrase to something like

Disable status check because some devices ... linear mode. This affects both pfe3000 and pfe1100.

We don't know if other pfe devices will be supported by the driver in the future, and we don't know if those will be affected, so we should not make any claims about such devices.

Quoted 11 lines
drivers/hwmon/pmbus/bel-pfe.c +2 -1
-static struct pmbus_platform_data pfe3000_plat_data = {
+static struct pmbus_platform_data pfe_plat_data = {
  	.flags = PMBUS_SKIP_STATUS_CHECK,
  };
@@ -94,6 +94,7 @@ static int pfe_pmbus_probe(struct i2c_client *client)
  	int model;
  	model = (int)i2c_match_id(pfe_device_id, client)->driver_data;
+	client->dev.platform_data = &pfe_plat_data;
  	/*
  	 * PFE3000-12-069RA devices may not stay in page 0 during device

drivers/hwmon/pmbus/bel-pfe.c static int pfe_pmbus_probe(struct i2c_client *client) · line 106

Quoted 6 lines
drivers/hwmon/pmbus/bel-pfe.c +0 -1
@@ -101,7 +102,6 @@ static int pfe_pmbus_probe(struct i2c_client *client)
  	 * So let's set the device to page 0 at the beginning.
  	 */
  	if (model == pfe3000) {
-		client->dev.platform_data = &pfe3000_plat_data;
  		i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);
  	}

{ } is no longer needed.

Thanks,
Guenter