serial: 8250: Reinit port_id when adding back serial8250_isa_devs
PATCH 1/1 serial: 8250: Reinit port_id when adding back serial8250_isa_devs
After fixing the serial core port device to use port->port_id instead of port->line, unloading a hardware specific 8250 port driver started producing an error for "sysfs: cannot create duplicate filename".
This is happening as we are wrongly initializing port->port_id to zero when adding back serial8250_isa_devs instances, and the serial8250:0.0 sysfs entry may already exist. For serial8250 devices, we typically have multiple devices mapped to a single driver instance. For the serial8250_isa_devs instances, the port->port_id is the same as port->line.
Let's fix the issue by re-initializing port_id when adding back the serial8250_isa_devs instances in serial8250_unregister_port().
--- drivers/tty/serial/8250/8250_core.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/serial/8250/8250_core.c +1 -0
@@ -1204,6 +1204,7 @@ void serial8250_unregister_port(int line) uart->port.flags &= ~UPF_BOOT_AUTOCONF ; uart->port.type =PORT_UNKNOWN ; uart->port.dev = &serial8250_isa_devs->dev; + uart->port.port_id = line; uart->capabilities =0 ;serial8250_init_port (uart);serial8250_apply_quirks (uart);
Signature · 1 line
2.41.0
Quoted 4 lines · Tony Lindgren
After fixing the serial core port device to use
port->port_idinstead ofport->line, unloading a hardware specific 8250 port driver started producing an error for "sysfs: cannot create duplicate filename".
Quoted 8 lines
This is happening as we are wrongly initializing
port->port_idto zero when adding backserial8250_isa_devsinstances, and the serial8250:0.0 sysfs entry may already exist. For serial8250 devices, we typically have multiple devices mapped to a single driver instance. For theserial8250_isa_devsinstances, theport->port_idis the same asport->line.Let's fix the issue by re-initializing
port_idwhen adding back theserial8250_isa_devsinstances inserial8250_unregister_port().
Good catch and fix, thank you!
Signature · 2 lines
With Best Regards, Andy Shevchenko