Skip to contentSkip to conversation

perf/x86/intel/uncore: Fix uninitialized variable in skx_upi_topology_cb()

PATCH New [email protected] 1 participant 1 message Aug 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf/x86/intel/uncore: Fix uninitialized variable in skx_upi_topology_cb()

From: Alexander Antonov <[email protected]>

Fix a potential return of an uninitialized 'ret' variable in skx_upi_topology_cb() function.

Fixes c1c1942b49ea ("perf/x86/intel/uncore: Enable UPI topology discovery for Skylake Server")
---
 arch/x86/events/intel/uncore_snbep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/intel/uncore_snbep.c +1 -1
index d49e90dc04a4..d857fc00511b 100644
@@ -4330,7 +4330,7 @@ static int upi_fill_topology(struct pci_dev *dev, struct intel_uncore_topology *
 static int skx_upi_topology_cb(struct intel_uncore_type *type, int segment,
 				int die, u64 cpu_bus_msr)
 {
-	int idx, ret;
+	int idx, ret = -ENODEV;
 	struct intel_uncore_topology *upi;
 	unsigned int devfn;
 	struct pci_dev *dev = NULL;

base-commit: c1a515d3c0270628df8ae5f5118ba859b85464a2

Signature · 1 line
2.25.1