Skip to contentSkip to conversation

kconfig: Alias mconfig to menuconfig, qconfig to xconfig

PATCH In review Jesse Taube 3 participants 4 messages Aug 5, 2023 – Aug 6, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kconfig: Alias mconfig to menuconfig, qconfig to xconfig

All the other menu-based config tools have a one-letter prefix, and are named the same as their respective file,
except for mconfig and qconfig. This commit adds an alias for mconfig to menuconfig and qconfig to xconfig.

---
 scripts/kconfig/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
scripts/kconfig/Makefile +5 -1
index af1c96198f49..319cd623acb9 100644
@@ -32,9 +32,11 @@ unexport CONFIG_
 
 config-prog	:= conf
 menuconfig-prog	:= mconf
+mconfig-prog	:= mconf
 nconfig-prog	:= nconf
 gconfig-prog	:= gconf
 xconfig-prog	:= qconf
+qconfig-prog	:= qconf
 
 define config_rule
 PHONY += $(1)
@@ -45,7 +47,7 @@ PHONY += build_$(1)
 build_$(1): $(obj)/$($(1)-prog)
 endef
 
-$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c))))
+$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c))))
 
 PHONY += localmodconfig localyesconfig
 localyesconfig localmodconfig: $(obj)/conf
@@ -118,7 +120,9 @@ help:
 	@echo  '  config	  - Update current config utilising a line-oriented program'
 	@echo  '  nconfig         - Update current config utilising a ncurses menu based program'
 	@echo  '  menuconfig	  - Update current config utilising a menu based program'
+	@echo  '  mconfig	  - Alias to menuconfig'
 	@echo  '  xconfig	  - Update current config utilising a Qt based front-end'
+	@echo  '  qconfig         - Alias to xconfig
 	@echo  '  gconfig	  - Update current config utilising a GTK+ based front-end'
 	@echo  '  oldconfig	  - Update current config utilising a provided .config as base'
 	@echo  '  localmodconfig  - Update current config disabling modules not loaded'
Signature · 1 line
2.40.0
#1 lore raw

Hi,

Quoted 25 lines · Jesse Taube

All the other menu-based config tools have a one-letter prefix, and are named the same as their respective file,
except for mconfig and qconfig. This commit adds an alias for mconfig to menuconfig and qconfig to xconfig.

---
 scripts/kconfig/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
scripts/kconfig/Makefile +1 -1
index af1c96198f49..319cd623acb9 100644
@@ -45,7 +47,7 @@ PHONY += build_$(1)
 build_$(1): $(obj)/$($(1)-prog)
 endef
 
-$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c))))
+$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c))))
 
 PHONY += localmodconfig localyesconfig
 localyesconfig localmodconfig: $(obj)/conf

scripts/kconfig/Makefile help: · line 125

Quoted 6 lines
scripts/kconfig/Makefile +2 -0
@@ -118,7 +120,9 @@ help:
 	@echo  '  config	  - Update current config utilising a line-oriented program'
 	@echo  '  nconfig         - Update current config utilising a ncurses menu based program'
 	@echo  '  menuconfig	  - Update current config utilising a menu based program'
+	@echo  '  mconfig	  - Alias to menuconfig'
 	@echo  '  xconfig	  - Update current config utilising a Qt based front-end'
+	@echo  '  qconfig         - Alias to xconfig

Seems to be missing an ending ' mark above... if we need this.

Quoted 3 lines
scripts/kconfig/Makefile +0 -0
 	@echo  '  gconfig	  - Update current config utilising a GTK+ based front-end'
 	@echo  '  oldconfig	  - Update current config utilising a provided .config as base'
 	@echo  '  localmodconfig  - Update current config disabling modules not loaded'
Signature · 1 line
~Randy
author
#2 lore raw
Quoted 26 lines · Randy Dunlap

Hi,

Quoted 22 lines · Jesse Taube

All the other menu-based config tools have a one-letter prefix, and are named the same as their respective file,
except for mconfig and qconfig. This commit adds an alias for mconfig to menuconfig and qconfig to xconfig.

---
 scripts/kconfig/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
scripts/kconfig/Makefile +1 -1
index af1c96198f49..319cd623acb9 100644
@@ -45,7 +47,7 @@ PHONY += build_$(1)
 build_$(1): $(obj)/$($(1)-prog)
 endef
 
-$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c))))
+$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c))))
 
Quoted 9 lines

scripts/kconfig/Makefile help: · line 125

Quoted 9 lines
scripts/kconfig/Makefile +2 -0
 PHONY += localmodconfig localyesconfig
 localyesconfig localmodconfig: $(obj)/conf
@@ -118,7 +120,9 @@ help:
      @echo  '  config          - Update current config utilising a line-oriented program'
      @echo  '  nconfig         - Update current config utilising a ncurses menu based program'
      @echo  '  menuconfig      - Update current config utilising a menu based program'
+     @echo  '  mconfig         - Alias to menuconfig'
      @echo  '  xconfig         - Update current config utilising a Qt based front-end'
+     @echo  '  qconfig         - Alias to xconfig'

Crap how did I miss this.
@Masahiro, can you add that when applying?
I'll take a reviewed-by as a yes otherwise I will submit V2 tomorrow.

Quoted 9 lines

Seems to be missing an ending ' mark above... if we need this.

scripts/kconfig/Makefile help: · line 128

Quoted 3 lines
scripts/kconfig/Makefile +0 -0
      @echo  '  gconfig         - Update current config utilising a GTK+ based front-end'
      @echo  '  oldconfig       - Update current config utilising a provided .config as base'
      @echo  '  localmodconfig  - Update current config disabling modules not loaded'

--
~Randy

#3 lore raw
Quoted 28 lines · Jesse T
Quoted 26 lines · Randy Dunlap

Hi,

Quoted 22 lines · Jesse Taube

All the other menu-based config tools have a one-letter prefix, and are named the same as their respective file,
except for mconfig and qconfig. This commit adds an alias for mconfig to menuconfig and qconfig to xconfig.

---
 scripts/kconfig/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
scripts/kconfig/Makefile +1 -1
index af1c96198f49..319cd623acb9 100644
@@ -45,7 +47,7 @@ PHONY += build_$(1)
 build_$(1): $(obj)/$($(1)-prog)
 endef
 
-$(foreach c, config menuconfig nconfig gconfig xconfig, $(eval $(call config_rule,$(c))))
+$(foreach c, config menuconfig mconfig nconfig gconfig xconfig qconfig, $(eval $(call config_rule,$(c))))
 
Quoted 12 lines
Quoted 9 lines

scripts/kconfig/Makefile help: · line 125

Quoted 9 lines
scripts/kconfig/Makefile +2 -0
 PHONY += localmodconfig localyesconfig
 localyesconfig localmodconfig: $(obj)/conf
@@ -118,7 +120,9 @@ help:
      @echo  '  config          - Update current config utilising a line-oriented program'
      @echo  '  nconfig         - Update current config utilising a ncurses menu based program'
      @echo  '  menuconfig      - Update current config utilising a menu based program'
+     @echo  '  mconfig         - Alias to menuconfig'
      @echo  '  xconfig         - Update current config utilising a Qt based front-end'
+     @echo  '  qconfig         - Alias to xconfig'

Crap how did I miss this.
@Masahiro, can you add that when applying?

I am not applying this.

I do not understand why it is useful.

Quoted 11 lines

I'll take a reviewed-by as a yes otherwise I will submit V2 tomorrow.

Quoted 9 lines

Seems to be missing an ending ' mark above... if we need this.

scripts/kconfig/Makefile help: · line 128

Quoted 3 lines
scripts/kconfig/Makefile +0 -0
      @echo  '  gconfig         - Update current config utilising a GTK+ based front-end'
      @echo  '  oldconfig       - Update current config utilising a provided .config as base'
      @echo  '  localmodconfig  - Update current config disabling modules not loaded'

--
~Randy

--
Best Regards
Masahiro Yamada