Skip to contentSkip to conversation

Fix scripts/checkpatch.py style failures.

PATCH Applied Nathan Egge 3 participants 4 messages Aug 5, 2023 – Aug 7, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix scripts/checkpatch.py style failures.

From: "Nathan Egge" <[email protected]>

---
 linux-user/syscall.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
linux-user/syscall.c +4 -4
index 95727a816a..38ab2201e2 100644
@@ -863,8 +863,8 @@ abi_long do_brk(abi_ulong brk_val)
     if (new_host_brk_page > brk_page) {
         new_alloc_size = new_host_brk_page - brk_page;
         mapped_addr = get_errno(target_mmap(brk_page, new_alloc_size,
-                                        PROT_READ|PROT_WRITE,
-                                        MAP_ANON|MAP_PRIVATE, 0, 0));
+                                        PROT_READ | PROT_WRITE,
+                                        MAP_ANON | MAP_PRIVATE, 0, 0));
     } else {
         new_alloc_size = 0;
         mapped_addr = brk_page;
@@ -6128,8 +6128,8 @@ static abi_long write_ldt(CPUX86State *env,
     if (!ldt_table) {
         env->ldt.base = target_mmap(0,
                                     TARGET_LDT_ENTRIES * TARGET_LDT_ENTRY_SIZE,
-                                    PROT_READ|PROT_WRITE,
-                                    MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
+                                    PROT_READ | PROT_WRITE,
+                                    MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
         if (env->ldt.base == -1)
             return -TARGET_ENOMEM;
         memset(g2h_untagged(env->ldt.base), 0,
Signature · 1 line
2.35.1
#2 lore raw
In reply to Nathan Egge

05.08.2023 15:51, Nathan Egge пишет:

Quoted 3 lines

From: "Nathan Egge" <[email protected]>

This needs at least some meaningful subject prefix. With the subject like it is now, it feels like the patch is about fixing checkpatch.py script itself.

Something like:

linux-user/syscall.c: fix coding-style issue (space-around-or)

I think one of the two places should be fixed in a patch which touches this place in tcg-next series instead of separately.

/mjt

#3 lore raw
Quoted 10 lines · Michael Tokarev

05.08.2023 15:51, Nathan Egge пишет:

Quoted 3 lines

From: "Nathan Egge" <[email protected]>

This needs at least some meaningful subject prefix. With the subject like it is now, it feels like the patch is about fixing checkpatch.py script itself.

Quoted 7 lines

Something like:

linux-user/syscall.c: fix coding-style issue (space-around-or)

I think one of the two places should be fixed in a patch which touches this place in tcg-next series instead of separately.

Also, this specific area of code (brk handling) is currently being worked on quite heavily. I'm pretty sure there's a patchset on list which touches these specific lines of code (and might well have fixed the style issue in passing). So we should hold off on the purely coding-style fixes here until after the dust has settled on those changes.

thanks
-- PMM