Skip to contentSkip to conversation

iio: trigger: stm32-lptimer-trigger: remove unneeded platform_set_drvdata()

PATCH In review Andrei Coardos 2 participants 4 messages Aug 2, 2023 – Aug 6, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iio: trigger: stm32-lptimer-trigger: remove unneeded platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---

Changelog V1->V2:

* https://lore.kernel.org/linux-iio/CAH3L5QpuoDYU6qvWH7_z5Yx0cW2qPMbCA8AFEYAPsiEkSzCiwQ@mail.gmail.com/T/#t
* Adjusted the returning values of the function

 drivers/iio/trigger/stm32-lptimer-trigger.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/iio/trigger/stm32-lptimer-trigger.c +1 -5
index df2416e33375..ab1cc6a05f26 100644
@@ -88,11 +88,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 	priv->trg = stm32_lptim_triggers[index];
 
-	ret = stm32_lptim_setup_trig(priv);
-	if (ret)
-		return ret;
-
-	return 0;
+	return stm32_lptim_setup_trig(priv);
 }
 
 static const struct of_device_id stm32_lptim_trig_of_match[] = {
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 7 lines · On Wed, 2 Aug 2023 16:35:09 +0300 Andrei Coardos <[email protected]>…

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Oops. Missed there was a v2. Ah well, end result the same ;)

Thanks,

Jonathan

Quoted 28 lines

---

Changelog V1->V2:

* https://lore.kernel.org/linux-iio/CAH3L5QpuoDYU6qvWH7_z5Yx0cW2qPMbCA8AFEYAPsiEkSzCiwQ@mail.gmail.com/T/#t
* Adjusted the returning values of the function

 drivers/iio/trigger/stm32-lptimer-trigger.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/iio/trigger/stm32-lptimer-trigger.c +1 -5
index df2416e33375..ab1cc6a05f26 100644
@@ -88,11 +88,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 	priv->trg = stm32_lptim_triggers[index];
 
-	ret = stm32_lptim_setup_trig(priv);
-	if (ret)
-		return ret;
-
-	return 0;
+	return stm32_lptim_setup_trig(priv);
 }
 
 static const struct of_device_id stm32_lptim_trig_of_match[] = {
maintainer
#2 lore raw
In reply to Andrei Coardos
Quoted 23 lines · On Wed, 2 Aug 2023 16:35:09 +0300 Andrei Coardos <[email protected]>…

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---

Changelog V1->V2:

* https://lore.kernel.org/linux-iio/CAH3L5QpuoDYU6qvWH7_z5Yx0cW2qPMbCA8AFEYAPsiEkSzCiwQ@mail.gmail.com/T/#t
* Adjusted the returning values of the function

 drivers/iio/trigger/stm32-lptimer-trigger.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/iio/trigger/stm32-lptimer-trigger.c +0 -0
index df2416e33375..ab1cc6a05f26 100644

drivers/iio/trigger/stm32-lptimer-trigger.c static int stm32_lptim_trigger_probe(struct platform_device *pdev) · line 91

Quoted 9 lines
drivers/iio/trigger/stm32-lptimer-trigger.c +1 -5
@@ -88,11 +88,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 	priv->trg = stm32_lptim_triggers[index];
 
-	ret = stm32_lptim_setup_trig(priv);
-	if (ret)
-		return ret;
-
-	return 0;
+	return stm32_lptim_setup_trig(priv);

Both of us failed to notice ret isn't used any more. Anyhow, I cleaned that up after spotting the build warning.

Jonathan

Quoted 3 lines
drivers/iio/trigger/stm32-lptimer-trigger.c +0 -0
 }
 
 static const struct of_device_id stm32_lptim_trig_of_match[] = {
#3 lore raw

Thank you very much!

Quoted 45 lines · Jonathan Cameron
Quoted 23 lines · On Wed, 2 Aug 2023 16:35:09 +0300 Andrei Coardos <[email protected]>…

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---

Changelog V1->V2:

* https://lore.kernel.org/linux-iio/CAH3L5QpuoDYU6qvWH7_z5Yx0cW2qPMbCA8AFEYAPsiEkSzCiwQ@mail.gmail.com/T/#t
* Adjusted the returning values of the function

 drivers/iio/trigger/stm32-lptimer-trigger.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/iio/trigger/stm32-lptimer-trigger.c +0 -0
index df2416e33375..ab1cc6a05f26 100644

drivers/iio/trigger/stm32-lptimer-trigger.c static int stm32_lptim_trigger_probe(struct platform_device *pdev) · line 91

Quoted 9 lines
drivers/iio/trigger/stm32-lptimer-trigger.c +1 -5
@@ -88,11 +88,7 @@ static int stm32_lptim_trigger_probe(struct platform_device *pdev)
      priv->dev = &pdev->dev;
      priv->trg = stm32_lptim_triggers[index];
 
-     ret = stm32_lptim_setup_trig(priv);
-     if (ret)
-             return ret;
-
-     return 0;
+     return stm32_lptim_setup_trig(priv);

Both of us failed to notice ret isn't used any more. Anyhow, I cleaned that up after spotting the build warning.

Jonathan

Quoted 3 lines
drivers/iio/trigger/stm32-lptimer-trigger.c +0 -0
 }
 
 static const struct of_device_id stm32_lptim_trig_of_match[] = {