ksmbd: fix wrong next length validation of ea buffer in smb2_set_ea()
Subsystems (2)
Namjae Jeon
maintainerPATCH 1/1 ksmbd: fix wrong next length validation of ea buffer in smb2_set_ea()
There are multiple smb2_ea_info buffers in FILE_FULL_EA_INFORMATION request from client. ksmbd find next smb2_ea_info using ->NextEntryOffset of current smb2_ea_info. ksmbd need to validate buffer length Before accessing the next ea. ksmbd should check buffer length using buf_len, not next variable. next is the start offset of current ea that got from previous ea.
Reported-by [email protected] # ZDI-CAN-21598
Signed-off-by Namjae Jeon <[email protected]>
--- fs/smb/server/smb2pdu.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
fs/smb/server/smb2pdu.c +8 -1
@@ -2324,9 +2324,16 @@ static int smb2_set_ea(struct smb2_ea_info *eabuf, unsigned int buf_len,break ; buf_len -= next; eabuf = (struct smb2_ea_info *)((char *)eabuf + next); -if (next < (u32 )eabuf->EaNameLength +le16_to_cpu (eabuf->EaValueLength)) +if (buf_len <sizeof (struct smb2_ea_info )) { + rc = -EINVAL ;break ; + } +if (buf_len <sizeof (struct smb2_ea_info ) + eabuf->EaNameLength + +le16_to_cpu (eabuf->EaValueLength)) { + rc = -EINVAL ; +break ; + } }while (next !=0 );kfree (attr_name);
Signature · 1 line
2.25.1