spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
PATCH v3 1/1 spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
From: Rajeshwar R Shinde <[email protected]>
In struct mpc512x_psc_spi, the variable 'irq' is declared as an unsigned int. The comparison of variable 'irq' with signed int operand is incorrect. Also, the return value from the call to platform_get_irq(pdev,0) is int and it is assigned to an unsigned int variable 'irq', thus redeclaring the type of variable 'irq' to signed int.
This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0
--- drivers/spi/spi-mpc512x-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-mpc512x-psc.c +1 -1
@@ -53,7 +53,7 @@ struct mpc512x_psc_spi {int type;void __iomem *psc;struct mpc512x_psc_fifo __iomem *fifo; -unsigned int irq; +int irq;u8 bits_per_word;u32 mclk_rate;
Signature · 1 line
2.25.1
PATCH v3 1/1 spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
From: Rajeshwar R Shinde <[email protected]>
In struct mpc52xx_psc_spi, the variable 'irq' is declared as an unsigned int. The comparison of variable 'irq' with signed int operand is incorrect. Also, the return value from the call to platform_get_irq(pdev,0) is int and it is assigned to an unsigned int variable 'irq', thus redeclaring the type of variable 'irq' to signed int.
This fixes warning such as:
drivers/spi/spi-mpc52xx-psc.c:332:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0
--- drivers/spi/spi-mpc52xx-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-mpc52xx-psc.c +1 -1
@@ -29,7 +29,7 @@ struct mpc52xx_psc_spi {/* driver internal data */ struct mpc52xx_psc __iomem *psc;struct mpc52xx_psc_fifo __iomem *fifo; -unsigned int irq; +int irq;u8 bits_per_word;struct completion done;
Signature · 6 lines
2.25.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Mark Brown
maintainerRe: [PATCH v3] spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
Quoted 10 lines · On Sun, 06 Aug 2023 14:07:34 +0530, [email protected] wrote:
In struct
mpc52xx_psc_spi, the variable 'irq' is declared as an unsigned int. The comparison of variable 'irq' with signed int operand is incorrect. Also, the return value from the call toplatform_get_irq(pdev,0)is int and it is assigned to an unsigned int variable 'irq', thus redeclaring the type of variable 'irq' to signed int.This fixes warning such as:
drivers/spi/spi-mpc52xx-psc.c:332:5-13:[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
commit: 4f5177458ba97734149897c5d4d44f85b8fe0348
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 36 lines · On Sun, Aug 06, 2023 at 02:07:33PM +0530, [email protected] wrote:
From: Rajeshwar R Shinde <[email protected]>
In struct
mpc512x_psc_spi, the variable 'irq' is declared as an unsigned int. The comparison of variable 'irq' with signed int operand is incorrect. Also, the return value from the call toplatform_get_irq(pdev,0)is int and it is assigned to an unsigned int variable 'irq', thus redeclaring the type of variable 'irq' to signed int.This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0--- drivers/spi/spi-mpc512x-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/spi/spi-mpc512x-psc.c +1
-1@@ -53,7 +53,7 @@ struct mpc512x_psc_spi {int type;void __iomem *psc;struct mpc512x_psc_fifo __iomem *fifo; -unsigned int irq; +int irq;u8 bits_per_word;u32 mclk_rate;Signature · 6 lines
2.25.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot