Skip to contentSkip to conversation

board: ten64: add missing error checks for retimer power on

PATCH In review Mathew McBride 2 participants 2 messages Aug 7, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: ten64: add missing error checks for retimer power on

The retimer reset/power on logic was changed in a recent commit, however, it neglected to check if the commands sent to the board microcontroller (to control power to the retimer chip) actually completed.

Add return checks for these operations so any failures will be reported to the user.

Fixes 7a041fea2 ("board: traverse: ten64: ensure retimer reset

is done on new board revisions")

---
 board/traverse/ten64/ten64.c | 5 +++++
 1 file changed, 5 insertions(+)
board/traverse/ten64/ten64.c +5 -0
index 52daae6e24..df9f0afe1a 100644
@@ -383,10 +383,15 @@ static int board_cycle_retimer(struct udevice **retim_dev)
 			puts("(retimer on, resetting...) ");
 
 			ret = misc_call(uc_dev, TEN64_CNTRL_10G_OFF, NULL, 0, NULL, 0);
+			if (ret)
+				return ret;
 			mdelay(1000);
 		}
 
+		/* Turn on the retimer */
 		ret = misc_call(uc_dev, TEN64_CNTRL_10G_ON, NULL, 0, NULL, 0);
+		if (ret)
+			return ret;
 	}
 
 	// Wait for retimer to come back
Signature · 1 line
2.30.1
#1 lore raw
Quoted 11 lines · Mathew McBride

The retimer reset/power on logic was changed in a recent commit, however, it neglected to check if the commands sent to the board microcontroller (to control power to the retimer chip) actually completed.

Add return checks for these operations so any failures will be reported to the user.

Fixes 7a041fea2 ("board: traverse: ten64: ensure retimer reset

is done on new board revisions")

Applied to u-boot/master, thanks!

Signature · 1 line
Tom