Skip to contentSkip to conversation

media: ivsc: Improve Kconfig help text

PATCH In review Sakari Ailus 2 participants 3 messages Aug 7, 2023

Subsystems (2)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH v2 1/1 media: ivsc: Improve Kconfig help text

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
since v1:

- Reworded most of the help text.

 drivers/media/pci/intel/ivsc/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +9 -3
index 9535ac10f4f7..ec4ade92f583 100644
@@ -7,6 +7,12 @@ config INTEL_VSC
 	help
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
-	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing
-	  Unit(IPU) driver of Intel.
+	  The IVSC support is split into two devices, ACE (Algorithm
+	  Context Engine) and CSI (Camera Serial Interface), each of which
+	  have their own drivers. The ACE is used to select the ownership
+	  of the sensor between the IVSC and the host CPU while the CSI is
+	  used to both select the routing destination for the data the
+	  sensor transmits over the CSI-2 bus between the IVSC and the
+	  host CPU and to configure the CSI-2 bus itself.
+
+	  The modules will be called ivsc-ace and ivsc-csi.
Signature · 1 line
2.39.2
Reviewed-by on v2 1/1
#1 lore raw

Hi Sakari,

Thank you for the patch.

Quoted 23 lines · Sakari Ailus

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
since v1:

- Reworded most of the help text.

 drivers/media/pci/intel/ivsc/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +0 -2
index 9535ac10f4f7..ec4ade92f583 100644
@@ -7,6 +7,12 @@ config INTEL_VSC
 	help
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
-	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 18

Quoted 10 lines
drivers/media/pci/intel/ivsc/Kconfig +9 -1
-	  Unit(IPU) driver of Intel.
+	  The IVSC support is split into two devices, ACE (Algorithm
+	  Context Engine) and CSI (Camera Serial Interface), each of which
+	  have their own drivers. The ACE is used to select the ownership
+	  of the sensor between the IVSC and the host CPU while the CSI is
+	  used to both select the routing destination for the data the
+	  sensor transmits over the CSI-2 bus between the IVSC and the
+	  host CPU and to configure the CSI-2 bus itself.
+
+	  The modules will be called ivsc-ace and ivsc-csi.

Side question though: as those two modules are always used together, could they be squashed into a single module ?

Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#2 lore raw

Hi Laurent,

Quoted 41 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 23 lines · Sakari Ailus

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
since v1:

- Reworded most of the help text.

 drivers/media/pci/intel/ivsc/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +0 -2
index 9535ac10f4f7..ec4ade92f583 100644
@@ -7,6 +7,12 @@ config INTEL_VSC
 	help
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
-	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 18

Quoted 10 lines
drivers/media/pci/intel/ivsc/Kconfig +9 -1
-	  Unit(IPU) driver of Intel.
+	  The IVSC support is split into two devices, ACE (Algorithm
+	  Context Engine) and CSI (Camera Serial Interface), each of which
+	  have their own drivers. The ACE is used to select the ownership
+	  of the sensor between the IVSC and the host CPU while the CSI is
+	  used to both select the routing destination for the data the
+	  sensor transmits over the CSI-2 bus between the IVSC and the
+	  host CPU and to configure the CSI-2 bus itself.
+
+	  The modules will be called ivsc-ace and ivsc-csi.
Quoted 2 lines

Side question though: as those two modules are always used together, could they be squashed into a single module ?

It's uncommon to have multiple drivers in a single module. I'd keep them separate, even if you wouldn't use one without the other.

Signature · 3 lines
Kind regards,

Sakari Ailus