Skip to contentSkip to conversation

reset: npcm: remove unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 2 participants 2 messages Aug 7, 2023 – Aug 8, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: npcm: remove unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/reset/reset-npcm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/reset/reset-npcm.c +0 -2
index f2333506b0a6..f6c4f854f2be 100644
@@ -394,8 +394,6 @@ static int npcm_rc_probe(struct platform_device *pdev)
 	rc->rcdev.of_reset_n_cells = 2;
 	rc->rcdev.of_xlate = npcm_reset_xlate;
 
-	platform_set_drvdata(pdev, rc);
-
 	ret = devm_reset_controller_register(&pdev->dev, &rc->rcdev);
 	if (ret) {
 		dev_err(&pdev->dev, "unable to register device\n");
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Thank you, applied to reset/next.

regards
Philipp