reset: uniphier-glue: remove unneeded call to platform_set_drvdata()
Subsystems (2)
PATCH 1/1 reset: uniphier-glue: remove unneeded call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/reset/reset-uniphier-glue.c | 2 -- 1 file changed, 2 deletions(-)
drivers/reset/reset-uniphier-glue.c +0 -2
@@ -99,8 +99,6 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev) priv->rdata.rcdev.of_node = dev->of_node; priv->rdata.active_low = true; -platform_set_drvdata (pdev, priv); -return devm_reset_controller_register (dev, &priv->rdata.rcdev); }
Signature · 1 line
2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
Quoted 21 lines
Signed-off-by Andrei Coardos <[email protected]>--- drivers/reset/reset-uniphier-glue.c | 2 -- 1 file changed, 2 deletions(-)drivers/reset/reset-uniphier-glue.c +0
-3@@ -99,8 +99,6 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev) priv->rdata.rcdev.of_node = dev->of_node; priv->rdata.active_low = true; -platform_set_drvdata (pdev, priv); -return devm_reset_controller_register (dev, &priv->rdata.rcdev); } --2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>
Thank you, applied to reset/next.
regards
Philipp
Signature · 6 lines
Philipp Zabel <[email protected]> _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel